Skip to contentSkip to conversation

target/core: Remove a set-but-not-used member variable from the XCOPY implementation

PATCH In review Bart Van Assche 1 participant 1 message Apr 2, 2019 SCSI target

lore
Share & tools
lore
#0 lore raw

PATCH 4/11 target/core: Remove a set-but-not-used member variable from the XCOPY implementation

This patch does not change any functionality.

Cc Mike Christie <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Nicholas Bellinger <[email protected]>
---
 drivers/target/target_core_xcopy.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/target/target_core_xcopy.c +2 -7
index 9be1418e919f..d97be766e4ac 100644
@@ -389,7 +389,6 @@ static int target_xcopy_parse_segment_descriptors(struct se_cmd *se_cmd,
  */
 
 struct xcopy_pt_cmd {
-	bool remote_port;
 	struct se_cmd se_cmd;
 	struct completion xpt_passthrough_sem;
 	unsigned char sense_buffer[TRANSPORT_SENSE_BUFFER];
@@ -520,9 +519,7 @@ static void target_xcopy_setup_pt_port(
 		 * when CDB is received on local source port, and READs blocks to
 		 * WRITE on remote destination port.
 		 */
-		if (remote_port) {
-			xpt_cmd->remote_port = remote_port;
-		} else {
+		if (!remote_port) {
 			pt_cmd->se_lun = ec_cmd->se_lun;
 			pt_cmd->se_dev = ec_cmd->se_dev;
 
@@ -539,9 +536,7 @@ static void target_xcopy_setup_pt_port(
 		 * blocks from the remote source port to WRITE on local
 		 * destination port.
 		 */
-		if (remote_port) {
-			xpt_cmd->remote_port = remote_port;
-		} else {
+		if (!remote_port) {
 			pt_cmd->se_lun = ec_cmd->se_lun;
 			pt_cmd->se_dev = ec_cmd->se_dev;
 
Signature · 1 line
2.21.0.196.g041f5ea1cf98