package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
PATCH 1/1 package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
Don't build and intall i18n if BR2_SYSTEM_ENABLE_NLS is not set otherwise build will fail with host-gettext-tiny on:
msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
fopen: No such file or directory
Fixes:
- http://autobuild.buildroot.org/results/0c230e49b6e9bf27163f751e6912ee85c6eb62e3
--- package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk +7 -2
@@ -12,6 +12,11 @@ VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr VDR_PLUGIN_VNSISERVER_CXXFLAGS = CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11 -fPIC" +VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS = install-lib +ifeq ($(BR2_SYSTEM_ENABLE_NLS),y) +VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS += install-i18n +endif + define VDR_PLUGIN_VNSISERVER_BUILD_CMDS $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \ $(VDR_PLUGIN_VNSISERVER_CXXFLAGS)
@@ -19,8 +24,8 @@ endef define VDR_PLUGIN_VNSISERVER_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \ - install DESTDIR=$(TARGET_DIR) LIBDIR=/usr/lib/vdr \ - LOCDIR=/usr/share/locale + $(VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS) DESTDIR=$(TARGET_DIR) \ + LIBDIR=/usr/lib/vdr LOCDIR=/usr/share/locale endef $(eval $(generic-package))
Signature · 1 line
2.14.1
PATCH 1/1 package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
Hello,
+Giulio and Vadim in Cc.
Quoted 5 lines · On Tue, 2 Apr 2019 22:32:37 +0200 Fabrice Fontaine…
Don't build and intall i18n if
BR2_SYSTEM_ENABLE_NLSis not set otherwise build will fail with host-gettext-tiny on:msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
fopen: No such file or directory
This looked a lot like the msgfmt issue that was causing build issues with rygel, and that got fixed by upgrading gettext-tiny. Unfortunately, I tried it, and even with the new gettext-tiny version, I still get those failures.
However, I believe the right course of action is to fix the issue in gettext-tiny itself. Could someone report the bug to upstream gettext-tiny ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/1 package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
Hello,
Il 04/04/2019 22:21, Thomas Petazzoni ha scritto:
Quoted 13 lines
Hello,
+Giulio and Vadim in Cc.
Quoted 5 lines · On Tue, 2 Apr 2019 22:32:37 +0200 Fabrice Fontaine…
Don't build and intall i18n if
BR2_SYSTEM_ENABLE_NLSis not set otherwise build will fail with host-gettext-tiny on:msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
fopen: No such file or directory
Quoted 8 lines
This looked a lot like the msgfmt issue that was causing build issues with rygel, and that got fixed by upgrading gettext-tiny. Unfortunately, I tried it, and even with the new gettext-tiny version, I still get those failures.
However, I believe the right course of action is to fix the issue in gettext-tiny itself. Could someone report the bug to upstream gettext-tiny ?
I'm going to reproduce the problem and see if I'm able to fix it if it's easier enough and then upstream.
Otherwise I will open an issue on their github.
Best regards
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH 1/1 package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
Il 04/04/2019 22:38, Giulio Benetti ha scritto:
Quoted 21 lines
Hello,
Il 04/04/2019 22:21, Thomas Petazzoni ha scritto:
Quoted 18 lines
Hello,
+Giulio and Vadim in Cc.
Quoted 5 lines · On Tue, 2 Apr 2019 22:32:37 +0200 Fabrice Fontaine…
Don't build and intall i18n if
BR2_SYSTEM_ENABLE_NLSis not set otherwise build will fail with host-gettext-tiny on:msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
fopen: No such file or directoryThis looked a lot like the msgfmt issue that was causing build issues with rygel, and that got fixed by upgrading gettext-tiny. Unfortunately, I tried it, and even with the new gettext-tiny version, I still get those failures.
Quoted 7 lines
Quoted 3 lines
However, I believe the right course of action is to fix the issue in gettext-tiny itself. Could someone report the bug to upstream gettext-tiny ?
I'm going to reproduce the problem and see if I'm able to fix it if it's easier enough and then upstream.
Otherwise I will open an issue on their github.
I've given up and opened an issue:
https://github.com/sabotage-linux/gettext-tiny/issues/42
IMHO msgmerge seems to be behind respect msgfmt.
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642
PATCH 1/1 package/vdr-plugin-vnsiserver: fix build with host-gettext-tiny
In reply to Fabrice FontaineHello,
Il 02/04/2019 22:32, Fabrice Fontaine ha scritto:
Quoted 10 lines
Don't build and intall i18n if
BR2_SYSTEM_ENABLE_NLSis not set otherwise build will fail with host-gettext-tiny on:msgmerge -U --no-wrap --no-location --backup=none -q -N po/lt_LT.po po/vnsiserver.pot
fopen: No such file or directoryFixes:
- http://autobuild.buildroot.org/results/0c230e49b6e9bf27163f751e6912ee85c6eb62e3Signed-off-by Fabrice Fontaine <[email protected]>
Quoted 32 lines
--- package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk +7
-2@@ -12,6 +12,11 @@ VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr VDR_PLUGIN_VNSISERVER_CXXFLAGS = CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11 -fPIC" +VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS = install-lib +ifeq ($(BR2_SYSTEM_ENABLE_NLS),y) +VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS += install-i18n +endif + define VDR_PLUGIN_VNSISERVER_BUILD_CMDS $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \ $(VDR_PLUGIN_VNSISERVER_CXXFLAGS)@@ -19,8 +24,8 @@ endef define VDR_PLUGIN_VNSISERVER_INSTALL_TARGET_CMDS $(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) \ - install DESTDIR=$(TARGET_DIR) LIBDIR=/usr/lib/vdr \ - LOCDIR=/usr/share/locale + $(VDR_PLUGIN_VNSISERVER_INSTALL_TARGETS) DESTDIR=$(TARGET_DIR) \ + LIBDIR=/usr/lib/vdr LOCDIR=/usr/share/locale endef $(eval $(generic-package))
Signature · 10 lines
Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale ? 26.000 i.v. Iscritta al Reg. Imprese di Padova N. 02663420285 Numero R.E.A. 258642