Skip to contentSkip to conversation

net: npcm: use bitmap functions on link mode params

PATCH Applied Benjamin Fair 2 participants 2 messages Apr 3, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: npcm: use bitmap functions on link mode params

This fixes a compilation error caused by the phy_device "supported" and "advertising" parameters switching from u32 to bitmap.

Fixes 35998b5c4073 ("net: npcm: add NPCM7xx Ethernet MAC controller")
---
 drivers/net/ethernet/nuvoton/npcm7xx_emc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/nuvoton/npcm7xx_emc.c +2 -2
index 3615e227545e..efb441d511c5 100644
@@ -1829,8 +1829,8 @@ static int npcm7xx_mii_setup(struct net_device *dev)
 		goto out3;
 	}
 
-	phydev->supported &= PHY_BASIC_FEATURES;
-	phydev->advertising = phydev->supported;
+	linkmode_and(phydev->supported, phydev->supported, PHY_BASIC_FEATURES);
+	linkmode_copy(phydev->advertising, phydev->supported);
 	ether->phy_dev = phydev;
 
 	return 0;
Signature · 1 line
2.21.0.392.gf8f6787159e-goog
Applied
#1 lore raw
Quoted 7 lines · Benjamin Fair

This fixes a compilation error caused by the phy_device "supported" and "advertising" parameters switching from u32 to bitmap.

Fixes 35998b5c4073 ("net: npcm: add NPCM7xx Ethernet MAC controller")

Thanks, applied to dev-5.0.

Cheers,

Joel