Skip to contentSkip to conversation

staging: gdm724x: Add parenthesis to Macro arguments

PATCH In review Andre Dainez 2 participants 4 messages Apr 3, 2019 – Apr 16, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: gdm724x: Add parenthesis to Macro arguments

Fix checkpatch errors:

CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues
CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues

---
 drivers/staging/gdm724x/netlink_k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/gdm724x/netlink_k.c +2 -2
index 92440c3..36d88f4 100644
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
 #define ND_NLMSG_SPACE(len)	(NLMSG_SPACE(len) + ND_IFINDEX_LEN)
 #define ND_NLMSG_DATA(nlh)	((void *)((char *)NLMSG_DATA(nlh) + \
 						  ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len)	(len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh)	(nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len)	((len) + ND_IFINDEX_LEN)
+#define ND_NLMSG_R_LEN(nlh)	((nlh)->nlmsg_len - ND_IFINDEX_LEN)
 #define ND_NLMSG_IFIDX(nlh)	NLMSG_DATA(nlh)
 #define ND_MAX_MSG_LEN		(1024 * 32)
 
Signature · 1 line
2.7.4
maintainer
#1 lore raw
Quoted 15 lines · Andre Dainez

Fix checkpatch errors:

CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues
CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues

---
 drivers/staging/gdm724x/netlink_k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/gdm724x/netlink_k.c +0 -0
index 92440c3..36d88f4 100644

drivers/staging/gdm724x/netlink_k.c static DEFINE_MUTEX(netlink_mutex); · line 22

Quoted 6 lines
drivers/staging/gdm724x/netlink_k.c +1 -2
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
 #define ND_NLMSG_SPACE(len)	(NLMSG_SPACE(len) + ND_IFINDEX_LEN)
 #define ND_NLMSG_DATA(nlh)	((void *)((char *)NLMSG_DATA(nlh) + \
 						  ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len)	(len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh)	(nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len)	((len) + ND_IFINDEX_LEN)

This makes sense, but:

drivers/staging/gdm724x/netlink_k.c static DEFINE_MUTEX(netlink_mutex); · line 23

Quoted 1 line
drivers/staging/gdm724x/netlink_k.c +1 -0
+#define ND_NLMSG_R_LEN(nlh)	((nlh)->nlmsg_len - ND_IFINDEX_LEN)

That does not, correct?

author
#2 lore raw

Hi Greg, thanks for replying.

Quoted 25 lines · Greg KH
Quoted 15 lines · Andre Dainez

Fix checkpatch errors:

CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues
CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues

---
 drivers/staging/gdm724x/netlink_k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/gdm724x/netlink_k.c +0 -0
index 92440c3..36d88f4 100644

drivers/staging/gdm724x/netlink_k.c static DEFINE_MUTEX(netlink_mutex); · line 22

Quoted 6 lines
drivers/staging/gdm724x/netlink_k.c +1 -2
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
 #define ND_NLMSG_SPACE(len)	(NLMSG_SPACE(len) + ND_IFINDEX_LEN)
 #define ND_NLMSG_DATA(nlh)	((void *)((char *)NLMSG_DATA(nlh) + \
 						  ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len)	(len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh)	(nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len)	((len) + ND_IFINDEX_LEN)

This makes sense, but:

Quoted 4 lines

drivers/staging/gdm724x/netlink_k.c static DEFINE_MUTEX(netlink_mutex); · line 23

Quoted 1 line
drivers/staging/gdm724x/netlink_k.c +1 -0
+#define ND_NLMSG_R_LEN(nlh)	((nlh)->nlmsg_len - ND_IFINDEX_LEN)

That does not, correct?

Could you please clarify why this doesn't make sense?
If, for some reason I calculate by hand the pointer address and call this macro like:
ND_NLMSG_R_LEN(nlh + sizeof(*nlh)),
then it would expand like nlh + sizeof(*nlh)->nlmsg_len - ND_IFINDEX_LEN which looks wrong in my pov, no?

Please, let me know if I misunderstood anything.
Thanks

maintainer
#3 lore raw
Quoted 30 lines · Andre

Hi Greg, thanks for replying.

Quoted 27 lines · Greg KH
Quoted 15 lines · Andre Dainez

Fix checkpatch errors:

CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence issues
CHECK: Macro argument 'nlh' may be better as '(nlh)' to avoid precedence issues

---
 drivers/staging/gdm724x/netlink_k.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/gdm724x/netlink_k.c +0 -0
index 92440c3..36d88f4 100644

drivers/staging/gdm724x/netlink_k.c static DEFINE_MUTEX(netlink_mutex); · line 22

Quoted 6 lines
drivers/staging/gdm724x/netlink_k.c +1 -2
@@ -19,8 +19,8 @@ static DEFINE_MUTEX(netlink_mutex);
 #define ND_NLMSG_SPACE(len)	(NLMSG_SPACE(len) + ND_IFINDEX_LEN)
 #define ND_NLMSG_DATA(nlh)	((void *)((char *)NLMSG_DATA(nlh) + \
 						  ND_IFINDEX_LEN))
-#define ND_NLMSG_S_LEN(len)	(len + ND_IFINDEX_LEN)
-#define ND_NLMSG_R_LEN(nlh)	(nlh->nlmsg_len - ND_IFINDEX_LEN)
+#define ND_NLMSG_S_LEN(len)	((len) + ND_IFINDEX_LEN)

This makes sense, but:

Quoted 1 line
drivers/staging/gdm724x/netlink_k.c +1 -0
+#define ND_NLMSG_R_LEN(nlh)	((nlh)->nlmsg_len - ND_IFINDEX_LEN)
Quoted 7 lines
Quoted 2 lines

That does not, correct?

Could you please clarify why this doesn't make sense?
If, for some reason I calculate by hand the pointer address and call this macro like:
ND_NLMSG_R_LEN(nlh + sizeof(*nlh)),
then it would expand like nlh + sizeof(*nlh)->nlmsg_len - ND_IFINDEX_LEN which looks wrong in my pov, no?

Why would anyone ever do such a thing? :)

That's the issue here, this is not needed as if someone were to want to do something crazy like you are suggesting, it will properly blow up, so no need to change anything here.

thanks,

greg k-h