Skip to contentSkip to conversation

mfd: add support for max77650 PMIC

PATCH Superseded Bartosz Golaszewski 4 participants 23 messages Apr 3, 2019 – Apr 11, 2019

Subsystems (8)

v8 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

v8 cover mfd: add support for max77650 PMIC

From: Bartosz Golaszewski <[email protected]>

This series adds support for max77650 ultra low-power PMIC. It provides the core mfd driver and a set of five sub-drivers for the regulator, power supply, gpio, leds and input subsystems.

Patches 1-4 add the DT binding documents. Patch 5 documents mfd_add_devices(). Patches 6-10 add all drivers. Last patch adds a MAINTAINERS entry for this device.

The regulator part is already upstream.

v1 -> v2:
=========

General:
- use C++ style comments for the SPDX license identifier and the copyright header
- s/MODULE_LICENSE("GPL")/MODULE_LICENSE("GPL v2")/
- lookup the virtual interrupt numbers in the MFD driver, setup resources for child devices and use platform_get_irq_byname() in sub-drivers
- picked up review tags
- use devm_request_any_context_irq() for interrupt requests

LEDs:
- changed the max77650_leds_ prefix to max77650_led_
- drop the max77650_leds structure as the only field it held was the regmap pointer, move said pointer to struct max77650_led
- change the driver name to "max77650-led"
- drop the last return value check and return the result of regmap_write() directly
- change the labeling scheme to one consistent with other LED drivers

ONKEY:
- drop the key reporting helper and call the input functions directly from interrupt handlers
- rename the rv local variable to error
- drop parent device asignment

Regulator:
- drop the unnecessary init_data lookup from the driver code
- drop unnecessary include

Charger:
- disable the charger on driver remove
- change the power supply type to POWER_SUPPLY_TYPE_USB

GPIO:
- drop interrupt support until we have correct implementation of hierarchical irqs in gpiolib

v2 -> v3:
=========

General:
- dropped regulator patches as they're already in Mark Brown's branch

LED:
- fix the compatible string in the DT binding example
- use the max_brightness property
- use a common prefix ("MAX77650_LED") for all defines in the driver

MFD:
- add the MODULE_DEVICE_TABLE()
- add a sentinel to the of_device_id array
- constify the pointers to irq names
- use an enum instead of defines for interrupt indexes

v3 -> v4:
=========

GPIO:
- as discussed with Linus Walleij: the gpio-controller is now part of the core mfd module (we don't spawn a sub-node anymore), the binding document for GPIO has been dropped, the GPIO properties have been defined in the binding document for the mfd core, the interrupt functionality has been reintroduced with the irq directly passed from the mfd part
- due to the above changes the Reviewed-by tag from Linus was dropped

v4 -> v5:
=========

General:
- add a patch documenting mfd_add_devices()

MFD:
- pass the regmap irq_chip irq domain to mfd over mfd_add_devices so that the hw interrupts from resources can be correctly mapped to virtual irqs
- remove the enum listing cell indexes
- extend Kconfig help
- add a link to the programming manual
- use REGMAP_IRQ_REG() for regmap interrupts (except for GPI which has is composed of two hw interrupts for rising and falling edge)
- add error messages in probe
- use PLATFORM_DEVID_NONE constant in devm_mfd_add_devices()
- set irq_base to 0 in regmap_add_irq_chip() as other users to, it's only relevant if it's > 0

Charger:
- use non-maxim specific property names for minimum input voltage and current limit
- code shrink by using the enable/disable charger helpers everywhere
- use more descriptive names for constants

Onkey:
- use EV_SW event type for slide mode

LED:
- remove stray " from Kconfig help

v5 -> v6:
=========

MFD:
- remove stray spaces in the binding document
- rename the example dt node
- remove unnecessary interrupt-parent property from the bindings

LED:
- add a missing dependency on LEDS_CLASS to Kconfig

Onkey:
- use boolean for the slide button property

Charger:
- fix the property names in DT example
- make constants even more readable

v6 -> v7:
=========

Charger:
- rename the current limit property to current-limit-microamp

v7 -> v8:
=========

General:
- collected acks from Lee
- changed the documentation for mfd_add_devices() as suggested by Lee
- rebased on top of v5.1-rc3

Bartosz Golaszewski (11):
dt-bindings: mfd: add DT bindings for max77650
dt-bindings: power: supply: add DT bindings for max77650
dt-bindings: leds: add DT bindings for max77650
dt-bindings: input: add DT bindings for max77650
mfd: core: document mfd_add_devices()
mfd: max77650: new core mfd driver
power: supply: max77650: add support for battery charger
gpio: max77650: add GPIO support
leds: max77650: add LEDs support
input: max77650: add onkey support
MAINTAINERS: add an entry for max77650 mfd driver

 .../bindings/input/max77650-onkey.txt         |  26 ++
 .../bindings/leds/leds-max77650.txt           |  57 +++
 .../devicetree/bindings/mfd/max77650.txt      |  46 +++
 .../power/supply/max77650-charger.txt         |  27 ++
 MAINTAINERS                                   |  14 +
 drivers/gpio/Kconfig                          |   7 +
 drivers/gpio/Makefile                         |   1 +
 drivers/gpio/gpio-max77650.c                  | 190 +++++++++
 drivers/input/misc/Kconfig                    |   9 +
 drivers/input/misc/Makefile                   |   1 +
 drivers/input/misc/max77650-onkey.c           | 121 ++++++
 drivers/leds/Kconfig                          |   6 +
 drivers/leds/Makefile                         |   1 +
 drivers/leds/leds-max77650.c                  | 147 +++++++
 drivers/mfd/Kconfig                           |  14 +
 drivers/mfd/Makefile                          |   1 +
 drivers/mfd/max77650.c                        | 234 +++++++++++
 drivers/mfd/mfd-core.c                        |  13 +
 drivers/power/supply/Kconfig                  |   7 +
 drivers/power/supply/Makefile                 |   1 +
 drivers/power/supply/max77650-charger.c       | 367 ++++++++++++++++++
 include/linux/mfd/max77650.h                  |  59 +++
 22 files changed, 1349 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/max77650-onkey.txt
 create mode 100644 Documentation/devicetree/bindings/leds/leds-max77650.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/max77650.txt
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
 create mode 100644 drivers/gpio/gpio-max77650.c
 create mode 100644 drivers/input/misc/max77650-onkey.c
 create mode 100644 drivers/leds/leds-max77650.c
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 drivers/power/supply/max77650-charger.c
 create mode 100644 include/linux/mfd/max77650.h
Signature · 1 line
2.21.0
#1 lore raw

PATCH v8 1/11 dt-bindings: mfd: add DT bindings for max77650

From: Bartosz Golaszewski <[email protected]>

Add a DT binding document for max77650 ultra-low power PMIC. This describes the core mfd device and the GPIO module.

---
 .../devicetree/bindings/mfd/max77650.txt      | 46 +++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/max77650.txt
Documentation/devicetree/bindings/mfd/max77650.txt new file +46 -0
new file mode 100644
index 000000000000..b529d8d19335
@@ -0,0 +1,46 @@
+MAX77650 ultra low-power PMIC from Maxim Integrated.
+
+Required properties:
+-------------------
+- compatible:		Must be "maxim,max77650"
+- reg:			I2C device address.
+- interrupts:		The interrupt on the parent the controller is
+			connected to.
+- interrupt-controller: Marks the device node as an interrupt controller.
+- #interrupt-cells:	Must be <2>.
+
+- gpio-controller:	Marks the device node as a gpio controller.
+- #gpio-cells:		Must be <2>. The first cell is the pin number and
+			the second cell is used to specify the gpio active
+			state.
+
+Optional properties:
+--------------------
+gpio-line-names:	Single string containing the name of the GPIO line.
+
+The GPIO-controller module is represented as part of the top-level PMIC
+node. The device exposes a single GPIO line.
+
+For device-tree bindings of other sub-modules (regulator, power supply,
+LEDs and onkey) refer to the binding documents under the respective
+sub-system directories.
+
+For more details on GPIO bindings, please refer to the generic GPIO DT
+binding document <devicetree/bindings/gpio/gpio.txt>.
+
+Example:
+--------
+
+	pmic@48 {
+		compatible = "maxim,max77650";
+		reg = <0x48>;
+
+		interrupt-controller;
+		interrupt-parent = <&gpio2>;
+		#interrupt-cells = <2>;
+		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+
+		gpio-controller;
+		#gpio-cells = <2>;
+		gpio-line-names = "max77650-charger";
+	};
Signature · 1 line
2.21.0
#2 lore raw

PATCH v8 2/11 dt-bindings: power: supply: add DT bindings for max77650

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +27 -0
new file mode 100644
index 000000000000..fef188144386
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:
+--------------------
+- compatible:		Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
+- min-microvolt:	Minimum CHGIN regulation voltage (in microvolts). Must be
+			one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+			4500000, 4600000, 4700000.
+- current-limit-microamp:	CHGIN input current limit (in microamps). Must
+				be one of: 95000, 190000, 285000, 380000, 475000.
+
+Example:
+--------
+
+	charger {
+		compatible = "maxim,max77650-charger";
+		min-microvolt = <4200000>;
+		curr-lim-microamp = <285000>;
+	};
Signature · 1 line
2.21.0
maintainer
#3 lore raw

Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

Quoted 24 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +8 -0
new file mode 100644
index 000000000000..fef188144386
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:

Documentation/devicetree/bindings/power/supply/max77650-charger.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +10 -0
+--------------------
+- compatible:		Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
+- min-microvolt:	Minimum CHGIN regulation voltage (in microvolts). Must be
+			one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+			4500000, 4600000, 4700000.
+- current-limit-microamp:	CHGIN input current limit (in microamps). Must
+				be one of: 95000, 190000, 285000, 380000, 475000.

To repeat what I said on v6, these should be common properties IMO (and therefore documented as such).

Quoted 12 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +9 -0
+
+Example:
+--------
+
+	charger {
+		compatible = "maxim,max77650-charger";
+		min-microvolt = <4200000>;
+		curr-lim-microamp = <285000>;
+	};
Signature · 1 line
2.21.0
#4 lore raw

Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

sob., 6 kwi 2019 o 09:07 Rob Herring <[email protected]> napisał(a):

Quoted 31 lines · Bartosz Golaszewski
Quoted 29 lines

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +13 -0
new file mode 100644
index 000000000000..fef188144386
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:
+--------------------
+- compatible:                Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
Quoted 9 lines

Documentation/devicetree/bindings/power/supply/max77650-charger.txt line 18

Quoted 5 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +5 -0
+- min-microvolt:     Minimum CHGIN regulation voltage (in microvolts). Must be
+                     one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+                     4500000, 4600000, 4700000.
+- current-limit-microamp:    CHGIN input current limit (in microamps). Must
+                             be one of: 95000, 190000, 285000, 380000, 475000.

To repeat what I said on v6, these should be common properties IMO (and therefore documented as such).

Do you mean a separate "charger.txt" document in
Documentation/devicetree/bindings/power/supply/?

Bart

Quoted 12 lines
Quoted 12 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +9 -1
+
+Example:
+--------
+
+     charger {
+             compatible = "maxim,max77650-charger";
+             min-microvolt = <4200000>;
+             curr-lim-microamp = <285000>;
+     };
--

2.21.0

maintainer
#5 lore raw

Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

Quoted 43 lines · Bartosz Golaszewski

sob., 6 kwi 2019 o 09:07 Rob Herring <[email protected]> napisał(a):

Quoted 31 lines · Bartosz Golaszewski
Quoted 29 lines

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +13 -0
new file mode 100644
index 000000000000..fef188144386
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:
+--------------------
+- compatible:                Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
Quoted 9 lines

Documentation/devicetree/bindings/power/supply/max77650-charger.txt line 18

Quoted 5 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +5 -0
+- min-microvolt:     Minimum CHGIN regulation voltage (in microvolts). Must be
+                     one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+                     4500000, 4600000, 4700000.
+- current-limit-microamp:    CHGIN input current limit (in microamps). Must
+                             be one of: 95000, 190000, 285000, 380000, 475000.

To repeat what I said on v6, these should be common properties IMO (and therefore documented as such).

Quoted 2 lines

Do you mean a separate "charger.txt" document in
Documentation/devicetree/bindings/power/supply/?

Yes, though I thought we had something already.

Rob

#6 lore raw

Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

wt., 9 kwi 2019 o 03:10 Rob Herring <[email protected]> napisał(a):

Quoted 45 lines · Bartosz Golaszewski
Quoted 43 lines

sob., 6 kwi 2019 o 09:07 Rob Herring <[email protected]> napisał(a):

Quoted 40 lines · Bartosz Golaszewski
Quoted 24 lines

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +8 -0
new file mode 100644
index 000000000000..fef188144386
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:

Documentation/devicetree/bindings/power/supply/max77650-charger.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +10 -0
+--------------------
+- compatible:                Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
+- min-microvolt:     Minimum CHGIN regulation voltage (in microvolts). Must be
+                     one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+                     4500000, 4600000, 4700000.
+- current-limit-microamp:    CHGIN input current limit (in microamps). Must
+                             be one of: 95000, 190000, 285000, 380000, 475000.

To repeat what I said on v6, these should be common properties IMO (and therefore documented as such).

Quoted 6 lines
Quoted 2 lines

Do you mean a separate "charger.txt" document in
Documentation/devicetree/bindings/power/supply/?

Yes, though I thought we had something already.

Rob

We don't AFAICT. There's only a binding document for "simple-battery" in power supply.

Bart

#7 lore raw

Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

wt., 9 kwi 2019 o 13:04 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 50 lines

wt., 9 kwi 2019 o 03:10 Rob Herring <[email protected]> napisał(a):

Quoted 48 lines · Bartosz Golaszewski
Quoted 45 lines

sob., 6 kwi 2019 o 09:07 Rob Herring <[email protected]> napisał(a):

Quoted 31 lines · Bartosz Golaszewski
Quoted 29 lines

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +13 -0
new file mode 100644
index 000000000000..fef188144386
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:
+--------------------
+- compatible:                Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
Quoted 9 lines

Documentation/devicetree/bindings/power/supply/max77650-charger.txt line 18

Quoted 5 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +5 -0
+- min-microvolt:     Minimum CHGIN regulation voltage (in microvolts). Must be
+                     one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+                     4500000, 4600000, 4700000.
+- current-limit-microamp:    CHGIN input current limit (in microamps). Must
+                             be one of: 95000, 190000, 285000, 380000, 475000.

To repeat what I said on v6, these should be common properties IMO (and therefore documented as such).

Do you mean a separate "charger.txt" document in
Documentation/devicetree/bindings/power/supply/?

Quoted 8 lines
Quoted 3 lines

Yes, though I thought we had something already.

Rob

We don't AFAICT. There's only a binding document for "simple-battery" in power supply.

Bart

Can we have it locally for now but without the maxim prefix and then reuse it if any other charger needs such functionality? To make it even more generic we can name it: "input-voltage-min-microvolt" & "input-current-limit-microamp".

Bart

maintainer
#8 lore raw

Re: [PATCH v8 02/11] dt-bindings: power: supply: add DT bindings for max77650

Quoted 59 lines · Bartosz Golaszewski

wt., 9 kwi 2019 o 13:04 Bartosz Golaszewski <[email protected]> napisał(a):

Quoted 57 lines

wt., 9 kwi 2019 o 03:10 Rob Herring <[email protected]> napisał(a):

Quoted 45 lines · Bartosz Golaszewski
Quoted 43 lines

sob., 6 kwi 2019 o 09:07 Rob Herring <[email protected]> napisał(a):

Quoted 40 lines · Bartosz Golaszewski
Quoted 24 lines

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the battery charger module of max77650.

---
 .../power/supply/max77650-charger.txt         | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/supply/max77650-charger.txt
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +8 -0
new file mode 100644
index 000000000000..fef188144386
@@ -0,0 +1,27 @@
+Battery charger driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The charger is represented as a sub-node of the PMIC node on the device tree.
+
+Required properties:

Documentation/devicetree/bindings/power/supply/max77650-charger.txt line 18

Quoted 10 lines
Documentation/devicetree/bindings/power/supply/max77650-charger.txt new file +10 -0
+--------------------
+- compatible:                Must be "maxim,max77650-charger"
+
+Optional properties:
+--------------------
+- min-microvolt:     Minimum CHGIN regulation voltage (in microvolts). Must be
+                     one of: 4000000, 4100000, 4200000, 4300000, 4400000,
+                     4500000, 4600000, 4700000.
+- current-limit-microamp:    CHGIN input current limit (in microamps). Must
+                             be one of: 95000, 190000, 285000, 380000, 475000.

To repeat what I said on v6, these should be common properties IMO (and therefore documented as such).

Quoted 6 lines
Quoted 2 lines

Do you mean a separate "charger.txt" document in
Documentation/devicetree/bindings/power/supply/?

Yes, though I thought we had something already.

Rob

We don't AFAICT. There's only a binding document for "simple-battery" in power supply.

Quoted 6 lines
Quoted 1 line

Bart

Can we have it locally for now but without the maxim prefix and then reuse it if any other charger needs such functionality? To make it even more generic we can name it: "input-voltage-min-microvolt" & "input-current-limit-microamp".

I guess. And defining these as 'input' is good because we do have similar property names already for battery current limit and voltages.

Rob

#9 lore raw

PATCH v8 3/11 dt-bindings: leds: add DT bindings for max77650

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the LEDs module of max77650.

---
 .../bindings/leds/leds-max77650.txt           | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/leds-max77650.txt
Documentation/devicetree/bindings/leds/leds-max77650.txt new file +57 -0
new file mode 100644
index 000000000000..3a67115cc1da
@@ -0,0 +1,57 @@
+LED driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The LED controller is represented as a sub-node of the PMIC node on
+the device tree.
+
+This device has three current sinks.
+
+Required properties:
+--------------------
+- compatible:		Must be "maxim,max77650-led"
+- #address-cells:	Must be <1>.
+- #size-cells:		Must be <0>.
+
+Each LED is represented as a sub-node of the LED-controller node. Up to
+three sub-nodes can be defined.
+
+Required properties of the sub-node:
+------------------------------------
+
+- reg:			Must be <0>, <1> or <2>.
+
+Optional properties of the sub-node:
+------------------------------------
+
+- label:		See Documentation/devicetree/bindings/leds/common.txt
+- linux,default-trigger: See Documentation/devicetree/bindings/leds/common.txt
+
+For more details, please refer to the generic GPIO DT binding document
+<devicetree/bindings/gpio/gpio.txt>.
+
+Example:
+--------
+
+	leds {
+		compatible = "maxim,max77650-led";
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		led@0 {
+			reg = <0>;
+			label = "blue:usr0";
+		};
+
+		led@1 {
+			reg = <1>;
+			label = "red:usr1";
+			linux,default-trigger = "heartbeat";
+		};
+
+		led@2 {
+			reg = <2>;
+			label = "green:usr2";
+		};
+	};
Signature · 1 line
2.21.0
#11 lore raw

PATCH v8 4/11 dt-bindings: input: add DT bindings for max77650

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the DT binding document for the onkey module of max77650.

---
 .../bindings/input/max77650-onkey.txt         | 26 +++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/input/max77650-onkey.txt
Documentation/devicetree/bindings/input/max77650-onkey.txt new file +26 -0
new file mode 100644
index 000000000000..477dc74f452a
@@ -0,0 +1,26 @@
+Onkey driver for MAX77650 PMIC from Maxim Integrated.
+
+This module is part of the MAX77650 MFD device. For more details
+see Documentation/devicetree/bindings/mfd/max77650.txt.
+
+The onkey controller is represented as a sub-node of the PMIC node on
+the device tree.
+
+Required properties:
+--------------------
+- compatible:		Must be "maxim,max77650-onkey".
+
+Optional properties:
+- linux,code:		The key-code to be reported when the key is pressed.
+			Defaults to KEY_POWER.
+- maxim,onkey-slide:	The system's button is a slide switch, not the default
+			push button.
+
+Example:
+--------
+
+	onkey {
+		compatible = "maxim,max77650-onkey";
+		linux,code = <KEY_END>;
+		maxim,onkey-slide;
+	};
Signature · 1 line
2.21.0
#12 lore raw

PATCH v8 5/11 mfd: core: document mfd_add_devices()

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a kernel doc for mfd_add_devices().

---
 drivers/mfd/mfd-core.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)
drivers/mfd/mfd-core.c +13 -0
index 94e3f32ce935..1ade4c8cc91f 100644
@@ -269,6 +269,19 @@ static int mfd_add_device(struct device *parent, int id,
 	return ret;
 }
 
+/**
+ * mfd_add_devices - register child devices
+ *
+ * @parent:	Pointer to parent device.
+ * @id:		Can be PLATFORM_DEVID_AUTO to let the Platform API take care
+ *		of device numbering, or will be added to a device's cell_id.
+ * @cells:	Array of (struct mfd_cell)s describing child devices.
+ * @n_devs:	Number of child devices to register.
+ * @mem_base:	Parent register range resource for child devices.
+ * @irq_base:	Base of the range of virtual interrupt numbers allocated for
+ *		this MFD device. Unused if @domain is specified.
+ * @domain:	Interrupt domain to create mappings for hardware interrupts.
+ */
 int mfd_add_devices(struct device *parent, int id,
 		    const struct mfd_cell *cells, int n_devs,
 		    struct resource *mem_base,
Signature · 1 line
2.21.0
#13 lore raw

Re: [PATCH v8 05/11] mfd: core: document mfd_add_devices()

Quoted 9 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add a kernel doc for mfd_add_devices().

---
 drivers/mfd/mfd-core.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

For my own reference:

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#14 lore raw

PATCH v8 6/11 mfd: max77650: new core mfd driver

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the core mfd driver for max77650 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches.

---
 drivers/mfd/Kconfig          |  14 +++
 drivers/mfd/Makefile         |   1 +
 drivers/mfd/max77650.c       | 234 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max77650.h |  59 +++++++++
 4 files changed, 308 insertions(+)
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 include/linux/mfd/max77650.h
drivers/mfd/Kconfig +14 -0
index 0ce2d8dfc5f1..ade04e124aa0 100644
@@ -733,6 +733,20 @@ config MFD_MAX77620
 	  provides common support for accessing the device; additional drivers
 	  must be enabled in order to use the functionality of the device.
 
+config MFD_MAX77650
+	tristate "Maxim MAX77650/77651 PMIC Support"
+	depends on I2C
+	depends on OF || COMPILE_TEST
+	select MFD_CORE
+	select REGMAP_I2C
+	help
+	  Say Y here to add support for Maxim Semiconductor MAX77650 and
+	  MAX77651 Power Management ICs. This is the core multifunction
+	  driver for interacting with the device. The module name is
+	  'max77650'. Additional drivers can be enabled in order to use
+	  the following functionalities of the device: GPIO, regulator,
+	  charger, LED, onkey.
+
 config MFD_MAX77686
 	tristate "Maxim Semiconductor MAX77686/802 PMIC Support"
 	depends on I2C
drivers/mfd/Makefile +1 -0
index b4569ed7f3f3..5727d099c16f 100644
@@ -155,6 +155,7 @@ obj-$(CONFIG_MFD_DA9150)	+= da9150-core.o
 
 obj-$(CONFIG_MFD_MAX14577)	+= max14577.o
 obj-$(CONFIG_MFD_MAX77620)	+= max77620.o
+obj-$(CONFIG_MFD_MAX77650)	+= max77650.o
 obj-$(CONFIG_MFD_MAX77686)	+= max77686.o
 obj-$(CONFIG_MFD_MAX77693)	+= max77693.o
 obj-$(CONFIG_MFD_MAX77843)	+= max77843.o
drivers/mfd/max77650.c new file +234 -0

234 lines not on this page · raw message

include/linux/mfd/max77650.h new file +59 -0

59 lines not on this page · raw message

Signature · 1 line
2.21.0
#15 lore raw

Re: [PATCH v8 06/11] mfd: max77650: new core mfd driver

Quoted 126 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add the core mfd driver for max77650 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches.

---
 drivers/mfd/Kconfig          |  14 +++
 drivers/mfd/Makefile         |   1 +
 drivers/mfd/max77650.c       | 234 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max77650.h |  59 +++++++++
 4 files changed, 308 insertions(+)
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 include/linux/mfd/max77650.h
drivers/mfd/Kconfig +14 -0
index 0ce2d8dfc5f1..ade04e124aa0 100644
@@ -733,6 +733,20 @@ config MFD_MAX77620
 	  provides common support for accessing the device; additional drivers
 	  must be enabled in order to use the functionality of the device.
 
+config MFD_MAX77650
+	tristate "Maxim MAX77650/77651 PMIC Support"
+	depends on I2C
+	depends on OF || COMPILE_TEST
+	select MFD_CORE
+	select REGMAP_I2C
+	help
+	  Say Y here to add support for Maxim Semiconductor MAX77650 and
+	  MAX77651 Power Management ICs. This is the core multifunction
+	  driver for interacting with the device. The module name is
+	  'max77650'. Additional drivers can be enabled in order to use
+	  the following functionalities of the device: GPIO, regulator,
+	  charger, LED, onkey.
+
 config MFD_MAX77686
 	tristate "Maxim Semiconductor MAX77686/802 PMIC Support"
 	depends on I2C
drivers/mfd/Makefile +1 -0
index b4569ed7f3f3..5727d099c16f 100644
@@ -155,6 +155,7 @@ obj-$(CONFIG_MFD_DA9150)	+= da9150-core.o
 
 obj-$(CONFIG_MFD_MAX14577)	+= max14577.o
 obj-$(CONFIG_MFD_MAX77620)	+= max77620.o
+obj-$(CONFIG_MFD_MAX77650)	+= max77650.o
 obj-$(CONFIG_MFD_MAX77686)	+= max77686.o
 obj-$(CONFIG_MFD_MAX77693)	+= max77693.o
 obj-$(CONFIG_MFD_MAX77843)	+= max77843.o
drivers/mfd/max77650.c new file +68 -0
new file mode 100644
index 000000000000..7a6c0a5cf602
@@ -0,0 +1,234 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (C) 2018 BayLibre SAS
+// Author: Bartosz Golaszewski <[email protected]>
+//
+// Core MFD driver for MAXIM 77650/77651 charger/power-supply.
+// Programming manual: https://pdfserv.maximintegrated.com/en/an/AN6428.pdf
+
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/mfd/core.h>
+#include <linux/mfd/max77650.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
+
+#define MAX77650_INT_GPI_F_MSK		BIT(0)
+#define MAX77650_INT_GPI_R_MSK		BIT(1)
+#define MAX77650_INT_GPI_MSK \
+			(MAX77650_INT_GPI_F_MSK | MAX77650_INT_GPI_R_MSK)
+#define MAX77650_INT_nEN_F_MSK		BIT(2)
+#define MAX77650_INT_nEN_R_MSK		BIT(3)
+#define MAX77650_INT_TJAL1_R_MSK	BIT(4)
+#define MAX77650_INT_TJAL2_R_MSK	BIT(5)
+#define MAX77650_INT_DOD_R_MSK		BIT(6)
+
+#define MAX77650_INT_THM_MSK		BIT(0)
+#define MAX77650_INT_CHG_MSK		BIT(1)
+#define MAX77650_INT_CHGIN_MSK		BIT(2)
+#define MAX77650_INT_TJ_REG_MSK		BIT(3)
+#define MAX77650_INT_CHGIN_CTRL_MSK	BIT(4)
+#define MAX77650_INT_SYS_CTRL_MSK	BIT(5)
+#define MAX77650_INT_SYS_CNFG_MSK	BIT(6)
+
+#define MAX77650_INT_GLBL_OFFSET	0
+#define MAX77650_INT_CHG_OFFSET		1
+
+#define MAX77650_SBIA_LPM_MASK		BIT(5)
+#define MAX77650_SBIA_LPM_DISABLED	0x00
+
+enum {
+	MAX77650_INT_GPI,
+	MAX77650_INT_nEN_F,
+	MAX77650_INT_nEN_R,
+	MAX77650_INT_TJAL1_R,
+	MAX77650_INT_TJAL2_R,
+	MAX77650_INT_DOD_R,
+	MAX77650_INT_THM,
+	MAX77650_INT_CHG,
+	MAX77650_INT_CHGIN,
+	MAX77650_INT_TJ_REG,
+	MAX77650_INT_CHGIN_CTRL,
+	MAX77650_INT_SYS_CTRL,
+	MAX77650_INT_SYS_CNFG,
+};
+
+static const struct resource max77650_charger_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MAX77650_INT_CHG, "CHG"),
+	DEFINE_RES_IRQ_NAMED(MAX77650_INT_CHGIN, "CHGIN"),
+};
+
+static const struct resource max77650_gpio_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MAX77650_INT_GPI, "GPI"),
+};
+
+static const struct resource max77650_onkey_resources[] = {
+	DEFINE_RES_IRQ_NAMED(MAX77650_INT_nEN_F, "nEN_F"),

drivers/mfd/max77650.c line 77

Quoted 10 lines
drivers/mfd/max77650.c new file +9 -0
+	DEFINE_RES_IRQ_NAMED(MAX77650_INT_nEN_R, "nEN_R"),
+};
+
+static const struct mfd_cell max77650_cells[] = {
+	{
+		.name		= "max77650-regulator",
+		.of_compatible	= "maxim,max77650-regulator",
 
+	},
+	{

Nit: Place these all on the same line, like:

	}, {
Quoted 21 lines
drivers/mfd/max77650.c new file +21 -0
+		.name		= "max77650-charger",
+		.of_compatible	= "maxim,max77650-charger",
+		.resources	= max77650_charger_resources,
+		.num_resources	= ARRAY_SIZE(max77650_charger_resources),
+	},
+	{
+		.name		= "max77650-gpio",
+		.of_compatible	= "maxim,max77650-gpio",
+		.resources	= max77650_gpio_resources,
+		.num_resources	= ARRAY_SIZE(max77650_gpio_resources),
+	},
+	{
+		.name		= "max77650-led",
+		.of_compatible	= "maxim,max77650-led",
+	},
+	{
+		.name		= "max77650-onkey",
+		.of_compatible	= "maxim,max77650-onkey",
+		.resources	= max77650_onkey_resources,
+		.num_resources	= ARRAY_SIZE(max77650_onkey_resources),
+	},

drivers/mfd/max77650.c line 108

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+};
+
+static const struct regmap_irq max77650_irqs[] = {
+	[MAX77650_INT_GPI] = {
+		.reg_offset		= MAX77650_INT_GLBL_OFFSET,
+		.mask			= MAX77650_INT_GPI_MSK,
+		.type = {
+			.type_falling_val	= MAX77650_INT_GPI_F_MSK,
+			.type_rising_val	= MAX77650_INT_GPI_R_MSK,
+			.types_supported	= IRQ_TYPE_EDGE_BOTH,

Not really a fan of these silly double/triple tabs everywhere. I like a straight line as much as anyone, but I'd probably remove them from here.

Quoted 49 lines
drivers/mfd/max77650.c new file +49 -0
+		},
+	},
+	REGMAP_IRQ_REG(MAX77650_INT_nEN_F,
+		       MAX77650_INT_GLBL_OFFSET, MAX77650_INT_nEN_F_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_nEN_R,
+		       MAX77650_INT_GLBL_OFFSET, MAX77650_INT_nEN_R_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_TJAL1_R,
+		       MAX77650_INT_GLBL_OFFSET, MAX77650_INT_TJAL1_R_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_TJAL2_R,
+		       MAX77650_INT_GLBL_OFFSET, MAX77650_INT_TJAL2_R_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_DOD_R,
+		       MAX77650_INT_GLBL_OFFSET, MAX77650_INT_DOD_R_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_THM,
+		       MAX77650_INT_CHG_OFFSET, MAX77650_INT_THM_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_CHG,
+		       MAX77650_INT_CHG_OFFSET, MAX77650_INT_CHG_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_CHGIN,
+		       MAX77650_INT_CHG_OFFSET, MAX77650_INT_CHGIN_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_TJ_REG,
+		       MAX77650_INT_CHG_OFFSET, MAX77650_INT_TJ_REG_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_CHGIN_CTRL,
+		       MAX77650_INT_CHG_OFFSET, MAX77650_INT_CHGIN_CTRL_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_SYS_CTRL,
+		       MAX77650_INT_CHG_OFFSET, MAX77650_INT_SYS_CTRL_MSK),
+	REGMAP_IRQ_REG(MAX77650_INT_SYS_CNFG,
+		       MAX77650_INT_CHG_OFFSET, MAX77650_INT_SYS_CNFG_MSK),
+};
+
+static const struct regmap_irq_chip max77650_irq_chip = {
+	.name			= "max77650-irq",
+	.irqs			= max77650_irqs,
+	.num_irqs		= ARRAY_SIZE(max77650_irqs),
+	.num_regs		= 2,
+	.status_base		= MAX77650_REG_INT_GLBL,
+	.mask_base		= MAX77650_REG_INTM_GLBL,
+	.type_in_mask		= true,
+	.type_invert		= true,
+	.init_ack_masked	= true,
+	.clear_on_unmask	= true,
+};
+
+static const struct regmap_config max77650_regmap_config = {
+	.name		= "max77650",
+	.reg_bits	= 8,
+	.val_bits	= 8,
+};
+
+static int max77650_i2c_probe(struct i2c_client *i2c)
+{

drivers/mfd/max77650.c line 167

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+	struct regmap_irq_chip_data *irq_data;
+	struct device *dev = &i2c->dev;
+	struct irq_domain *domain;
+	struct regmap *map;
+	unsigned int val;
+	int rv;
+
+	map = devm_regmap_init_i2c(i2c, &max77650_regmap_config);
+	if (IS_ERR(map)) {
+		dev_err(dev, "unable to initialize i2c regmap\n");

"Unable to initialise I2C Regmap"

drivers/mfd/max77650.c line 173

Quoted 6 lines
drivers/mfd/max77650.c new file +6 -0
+		return PTR_ERR(map);
+	}
+
+	rv = regmap_read(map, MAX77650_REG_CID, &val);
+	if (rv) {
+		dev_err(dev, "unable to read the CID from device\n");

"Unable to read Chip ID"

drivers/mfd/max77650.c line 183

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+		return rv;
+	}
+
+	switch (MAX77650_CID_BITS(val)) {
+	case MAX77650_CID_77650A:
+	case MAX77650_CID_77650C:
+	case MAX77650_CID_77651A:
+	case MAX77650_CID_77651B:
+		break;
+	default:

So you're exiting silently here. What is the user going to think?

"Chip not supported - ID: %d"

Quoted 5 lines
drivers/mfd/max77650.c new file +5 -0
+		return -ENODEV;
+	}
+
+	/*
+	 * This IC has a low-power mode which reduces the quiescent current

drivers/mfd/max77650.c line 198

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+	 * consumption to ~5.6uA but is only suitable for systems consuming
+	 * less than ~2mA. Since this is not likely the case even on
+	 * linux-based wearables - keep the chip in normal power mode.
+	 */
+	rv = regmap_update_bits(map,
+				MAX77650_REG_CNFG_GLBL,
+				MAX77650_SBIA_LPM_MASK,
+				MAX77650_SBIA_LPM_DISABLED);
+	if (rv) {
+		dev_err(dev, "unable to change the power mode\n");

"Unable ..."

drivers/mfd/max77650.c line 206

Quoted 8 lines
drivers/mfd/max77650.c new file +8 -0
+		return rv;
+	}
+
+	rv = devm_regmap_add_irq_chip(dev, map, i2c->irq,
+				      IRQF_ONESHOT | IRQF_SHARED, 0,
+				      &max77650_irq_chip, &irq_data);
+	if (rv) {
+		dev_err(dev, "unable to add the regmap irq chip\n");

"Unable to add Regmap IRQ chip"

drivers/mfd/max77650.c line 210

Quoted 4 lines
drivers/mfd/max77650.c new file +4 -0
+		return rv;
+	}
+
+	domain = regmap_irq_get_domain(irq_data);

No error checking?

Quoted 7 lines
drivers/mfd/max77650.c new file +7 -0
+	return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
+				    max77650_cells, ARRAY_SIZE(max77650_cells),
+				    NULL, 0, domain);
+}
+
+static const struct of_device_id max77650_of_match[] = {
+	{ .compatible = "maxim,max77650" },

drivers/mfd/max77650.c line 228

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+	{ }
+};
+MODULE_DEVICE_TABLE(of, max77650_of_match);
+
+static struct i2c_driver max77650_i2c_driver = {
+	.driver = {
+		.name = "max77650",
+		.of_match_table = of_match_ptr(max77650_of_match),
+	},
+	.probe_new = max77650_i2c_probe,

I wrote this years ago. Hasn't it gone away yet?

Quoted 71 lines
drivers/mfd/max77650.c new file +6 -0
+};
+module_i2c_driver(max77650_i2c_driver);
+
+MODULE_DESCRIPTION("MAXIM 77650/77651 multi-function core driver");
+MODULE_AUTHOR("Bartosz Golaszewski <[email protected]>");
+MODULE_LICENSE("GPL v2");
include/linux/mfd/max77650.h new file +59 -0
new file mode 100644
index 000000000000..c809e211a8cd
@@ -0,0 +1,59 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2018 BayLibre SAS
+ * Author: Bartosz Golaszewski <[email protected]>
+ *
+ * Common definitions for MAXIM 77650/77651 charger/power-supply.
+ */
+
+#ifndef MAX77650_H
+#define MAX77650_H
+
+#include <linux/bits.h>
+
+#define MAX77650_REG_INT_GLBL		0x00
+#define MAX77650_REG_INT_CHG		0x01
+#define MAX77650_REG_STAT_CHG_A		0x02
+#define MAX77650_REG_STAT_CHG_B		0x03
+#define MAX77650_REG_ERCFLAG		0x04
+#define MAX77650_REG_STAT_GLBL		0x05
+#define MAX77650_REG_INTM_GLBL		0x06
+#define MAX77650_REG_INTM_CHG		0x07
+#define MAX77650_REG_CNFG_GLBL		0x10
+#define MAX77650_REG_CID		0x11
+#define MAX77650_REG_CNFG_GPIO		0x12
+#define MAX77650_REG_CNFG_CHG_A		0x18
+#define MAX77650_REG_CNFG_CHG_B		0x19
+#define MAX77650_REG_CNFG_CHG_C		0x1a
+#define MAX77650_REG_CNFG_CHG_D		0x1b
+#define MAX77650_REG_CNFG_CHG_E		0x1c
+#define MAX77650_REG_CNFG_CHG_F		0x1d
+#define MAX77650_REG_CNFG_CHG_G		0x1e
+#define MAX77650_REG_CNFG_CHG_H		0x1f
+#define MAX77650_REG_CNFG_CHG_I		0x20
+#define MAX77650_REG_CNFG_SBB_TOP	0x28
+#define MAX77650_REG_CNFG_SBB0_A	0x29
+#define MAX77650_REG_CNFG_SBB0_B	0x2a
+#define MAX77650_REG_CNFG_SBB1_A	0x2b
+#define MAX77650_REG_CNFG_SBB1_B	0x2c
+#define MAX77650_REG_CNFG_SBB2_A	0x2d
+#define MAX77650_REG_CNFG_SBB2_B	0x2e
+#define MAX77650_REG_CNFG_LDO_A		0x38
+#define MAX77650_REG_CNFG_LDO_B		0x39
+#define MAX77650_REG_CNFG_LED0_A	0x40
+#define MAX77650_REG_CNFG_LED1_A	0x41
+#define MAX77650_REG_CNFG_LED2_A	0x42
+#define MAX77650_REG_CNFG_LED0_B	0x43
+#define MAX77650_REG_CNFG_LED1_B	0x44
+#define MAX77650_REG_CNFG_LED2_B	0x45
+#define MAX77650_REG_CNFG_LED_TOP	0x46
+
+#define MAX77650_CID_MASK		GENMASK(3, 0)
+#define MAX77650_CID_BITS(_reg)		(_reg & MAX77650_CID_MASK)
+
+#define MAX77650_CID_77650A		0x03
+#define MAX77650_CID_77650C		0x0a
+#define MAX77650_CID_77651A		0x06
+#define MAX77650_CID_77651B		0x08
+
+#endif /* MAX77650_H */
Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#16 lore raw

Re: [PATCH v8 06/11] mfd: max77650: new core mfd driver

czw., 4 kwi 2019 o 09:15 Lee Jones <[email protected]> napisał(a):

Quoted 293 lines · Bartosz Golaszewski
Quoted 127 lines

From: Bartosz Golaszewski <[email protected]>

Add the core mfd driver for max77650 PMIC. We define five sub-devices for which the drivers will be added in subsequent patches.

---
 drivers/mfd/Kconfig          |  14 +++
 drivers/mfd/Makefile         |   1 +
 drivers/mfd/max77650.c       | 234 +++++++++++++++++++++++++++++++++++
 include/linux/mfd/max77650.h |  59 +++++++++
 4 files changed, 308 insertions(+)
 create mode 100644 drivers/mfd/max77650.c
 create mode 100644 include/linux/mfd/max77650.h
drivers/mfd/Kconfig +14 -0
index 0ce2d8dfc5f1..ade04e124aa0 100644
@@ -733,6 +733,20 @@ config MFD_MAX77620
        provides common support for accessing the device; additional drivers
        must be enabled in order to use the functionality of the device.
 
+config MFD_MAX77650
+     tristate "Maxim MAX77650/77651 PMIC Support"
+     depends on I2C
+     depends on OF || COMPILE_TEST
+     select MFD_CORE
+     select REGMAP_I2C
+     help
+       Say Y here to add support for Maxim Semiconductor MAX77650 and
+       MAX77651 Power Management ICs. This is the core multifunction
+       driver for interacting with the device. The module name is
+       'max77650'. Additional drivers can be enabled in order to use
+       the following functionalities of the device: GPIO, regulator,
+       charger, LED, onkey.
+
 config MFD_MAX77686
      tristate "Maxim Semiconductor MAX77686/802 PMIC Support"
      depends on I2C
drivers/mfd/Makefile +1 -0
index b4569ed7f3f3..5727d099c16f 100644
@@ -155,6 +155,7 @@ obj-$(CONFIG_MFD_DA9150)  += da9150-core.o
 
 obj-$(CONFIG_MFD_MAX14577)   += max14577.o
 obj-$(CONFIG_MFD_MAX77620)   += max77620.o
+obj-$(CONFIG_MFD_MAX77650)   += max77650.o
 obj-$(CONFIG_MFD_MAX77686)   += max77686.o
 obj-$(CONFIG_MFD_MAX77693)   += max77693.o
 obj-$(CONFIG_MFD_MAX77843)   += max77843.o
drivers/mfd/max77650.c new file +68 -0
new file mode 100644
index 000000000000..7a6c0a5cf602
@@ -0,0 +1,234 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// Copyright (C) 2018 BayLibre SAS
+// Author: Bartosz Golaszewski <[email protected]>
+//
+// Core MFD driver for MAXIM 77650/77651 charger/power-supply.
+// Programming manual: https://pdfserv.maximintegrated.com/en/an/AN6428.pdf
+
+#include <linux/i2c.h>
+#include <linux/interrupt.h>
+#include <linux/irq.h>
+#include <linux/mfd/core.h>
+#include <linux/mfd/max77650.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
+
+#define MAX77650_INT_GPI_F_MSK               BIT(0)
+#define MAX77650_INT_GPI_R_MSK               BIT(1)
+#define MAX77650_INT_GPI_MSK \
+                     (MAX77650_INT_GPI_F_MSK | MAX77650_INT_GPI_R_MSK)
+#define MAX77650_INT_nEN_F_MSK               BIT(2)
+#define MAX77650_INT_nEN_R_MSK               BIT(3)
+#define MAX77650_INT_TJAL1_R_MSK     BIT(4)
+#define MAX77650_INT_TJAL2_R_MSK     BIT(5)
+#define MAX77650_INT_DOD_R_MSK               BIT(6)
+
+#define MAX77650_INT_THM_MSK         BIT(0)
+#define MAX77650_INT_CHG_MSK         BIT(1)
+#define MAX77650_INT_CHGIN_MSK               BIT(2)
+#define MAX77650_INT_TJ_REG_MSK              BIT(3)
+#define MAX77650_INT_CHGIN_CTRL_MSK  BIT(4)
+#define MAX77650_INT_SYS_CTRL_MSK    BIT(5)
+#define MAX77650_INT_SYS_CNFG_MSK    BIT(6)
+
+#define MAX77650_INT_GLBL_OFFSET     0
+#define MAX77650_INT_CHG_OFFSET              1
+
+#define MAX77650_SBIA_LPM_MASK               BIT(5)
+#define MAX77650_SBIA_LPM_DISABLED   0x00
+
+enum {
+     MAX77650_INT_GPI,
+     MAX77650_INT_nEN_F,
+     MAX77650_INT_nEN_R,
+     MAX77650_INT_TJAL1_R,
+     MAX77650_INT_TJAL2_R,
+     MAX77650_INT_DOD_R,
+     MAX77650_INT_THM,
+     MAX77650_INT_CHG,
+     MAX77650_INT_CHGIN,
+     MAX77650_INT_TJ_REG,
+     MAX77650_INT_CHGIN_CTRL,
+     MAX77650_INT_SYS_CTRL,
+     MAX77650_INT_SYS_CNFG,
+};
+
+static const struct resource max77650_charger_resources[] = {
+     DEFINE_RES_IRQ_NAMED(MAX77650_INT_CHG, "CHG"),
+     DEFINE_RES_IRQ_NAMED(MAX77650_INT_CHGIN, "CHGIN"),
+};
+
+static const struct resource max77650_gpio_resources[] = {
+     DEFINE_RES_IRQ_NAMED(MAX77650_INT_GPI, "GPI"),
+};
+
+static const struct resource max77650_onkey_resources[] = {
+     DEFINE_RES_IRQ_NAMED(MAX77650_INT_nEN_F, "nEN_F"),

drivers/mfd/max77650.c line 77

Quoted 10 lines
drivers/mfd/max77650.c new file +9 -0
+     DEFINE_RES_IRQ_NAMED(MAX77650_INT_nEN_R, "nEN_R"),
+};
+
+static const struct mfd_cell max77650_cells[] = {
+     {
+             .name           = "max77650-regulator",
+             .of_compatible  = "maxim,max77650-regulator",
 
+     },
+     {

Nit: Place these all on the same line, like:

        }, {
Quoted 21 lines
drivers/mfd/max77650.c new file +21 -0
+             .name           = "max77650-charger",
+             .of_compatible  = "maxim,max77650-charger",
+             .resources      = max77650_charger_resources,
+             .num_resources  = ARRAY_SIZE(max77650_charger_resources),
+     },
+     {
+             .name           = "max77650-gpio",
+             .of_compatible  = "maxim,max77650-gpio",
+             .resources      = max77650_gpio_resources,
+             .num_resources  = ARRAY_SIZE(max77650_gpio_resources),
+     },
+     {
+             .name           = "max77650-led",
+             .of_compatible  = "maxim,max77650-led",
+     },
+     {
+             .name           = "max77650-onkey",
+             .of_compatible  = "maxim,max77650-onkey",
+             .resources      = max77650_onkey_resources,
+             .num_resources  = ARRAY_SIZE(max77650_onkey_resources),
+     },

drivers/mfd/max77650.c line 108

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+};
+
+static const struct regmap_irq max77650_irqs[] = {
+     [MAX77650_INT_GPI] = {
+             .reg_offset             = MAX77650_INT_GLBL_OFFSET,
+             .mask                   = MAX77650_INT_GPI_MSK,
+             .type = {
+                     .type_falling_val       = MAX77650_INT_GPI_F_MSK,
+                     .type_rising_val        = MAX77650_INT_GPI_R_MSK,
+                     .types_supported        = IRQ_TYPE_EDGE_BOTH,

Not really a fan of these silly double/triple tabs everywhere. I like a straight line as much as anyone, but I'd probably remove them from here.

Quoted 49 lines
drivers/mfd/max77650.c new file +49 -0
+             },
+     },
+     REGMAP_IRQ_REG(MAX77650_INT_nEN_F,
+                    MAX77650_INT_GLBL_OFFSET, MAX77650_INT_nEN_F_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_nEN_R,
+                    MAX77650_INT_GLBL_OFFSET, MAX77650_INT_nEN_R_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_TJAL1_R,
+                    MAX77650_INT_GLBL_OFFSET, MAX77650_INT_TJAL1_R_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_TJAL2_R,
+                    MAX77650_INT_GLBL_OFFSET, MAX77650_INT_TJAL2_R_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_DOD_R,
+                    MAX77650_INT_GLBL_OFFSET, MAX77650_INT_DOD_R_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_THM,
+                    MAX77650_INT_CHG_OFFSET, MAX77650_INT_THM_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_CHG,
+                    MAX77650_INT_CHG_OFFSET, MAX77650_INT_CHG_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_CHGIN,
+                    MAX77650_INT_CHG_OFFSET, MAX77650_INT_CHGIN_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_TJ_REG,
+                    MAX77650_INT_CHG_OFFSET, MAX77650_INT_TJ_REG_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_CHGIN_CTRL,
+                    MAX77650_INT_CHG_OFFSET, MAX77650_INT_CHGIN_CTRL_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_SYS_CTRL,
+                    MAX77650_INT_CHG_OFFSET, MAX77650_INT_SYS_CTRL_MSK),
+     REGMAP_IRQ_REG(MAX77650_INT_SYS_CNFG,
+                    MAX77650_INT_CHG_OFFSET, MAX77650_INT_SYS_CNFG_MSK),
+};
+
+static const struct regmap_irq_chip max77650_irq_chip = {
+     .name                   = "max77650-irq",
+     .irqs                   = max77650_irqs,
+     .num_irqs               = ARRAY_SIZE(max77650_irqs),
+     .num_regs               = 2,
+     .status_base            = MAX77650_REG_INT_GLBL,
+     .mask_base              = MAX77650_REG_INTM_GLBL,
+     .type_in_mask           = true,
+     .type_invert            = true,
+     .init_ack_masked        = true,
+     .clear_on_unmask        = true,
+};
+
+static const struct regmap_config max77650_regmap_config = {
+     .name           = "max77650",
+     .reg_bits       = 8,
+     .val_bits       = 8,
+};
+
+static int max77650_i2c_probe(struct i2c_client *i2c)
+{

drivers/mfd/max77650.c line 167

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+     struct regmap_irq_chip_data *irq_data;
+     struct device *dev = &i2c->dev;
+     struct irq_domain *domain;
+     struct regmap *map;
+     unsigned int val;
+     int rv;
+
+     map = devm_regmap_init_i2c(i2c, &max77650_regmap_config);
+     if (IS_ERR(map)) {
+             dev_err(dev, "unable to initialize i2c regmap\n");

"Unable to initialise I2C Regmap"

drivers/mfd/max77650.c line 173

Quoted 6 lines
drivers/mfd/max77650.c new file +6 -0
+             return PTR_ERR(map);
+     }
+
+     rv = regmap_read(map, MAX77650_REG_CID, &val);
+     if (rv) {
+             dev_err(dev, "unable to read the CID from device\n");

"Unable to read Chip ID"

drivers/mfd/max77650.c line 183

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+             return rv;
+     }
+
+     switch (MAX77650_CID_BITS(val)) {
+     case MAX77650_CID_77650A:
+     case MAX77650_CID_77650C:
+     case MAX77650_CID_77651A:
+     case MAX77650_CID_77651B:
+             break;
+     default:

So you're exiting silently here. What is the user going to think?

"Chip not supported - ID: %d"

Quoted 5 lines
drivers/mfd/max77650.c new file +5 -0
+             return -ENODEV;
+     }
+
+     /*
+      * This IC has a low-power mode which reduces the quiescent current

drivers/mfd/max77650.c line 198

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+      * consumption to ~5.6uA but is only suitable for systems consuming
+      * less than ~2mA. Since this is not likely the case even on
+      * linux-based wearables - keep the chip in normal power mode.
+      */
+     rv = regmap_update_bits(map,
+                             MAX77650_REG_CNFG_GLBL,
+                             MAX77650_SBIA_LPM_MASK,
+                             MAX77650_SBIA_LPM_DISABLED);
+     if (rv) {
+             dev_err(dev, "unable to change the power mode\n");

"Unable ..."

drivers/mfd/max77650.c line 206

Quoted 8 lines
drivers/mfd/max77650.c new file +8 -0
+             return rv;
+     }
+
+     rv = devm_regmap_add_irq_chip(dev, map, i2c->irq,
+                                   IRQF_ONESHOT | IRQF_SHARED, 0,
+                                   &max77650_irq_chip, &irq_data);
+     if (rv) {
+             dev_err(dev, "unable to add the regmap irq chip\n");
Quoted 9 lines

"Unable to add Regmap IRQ chip"

drivers/mfd/max77650.c line 210

Quoted 4 lines
drivers/mfd/max77650.c new file +4 -0
+             return rv;
+     }
+
+     domain = regmap_irq_get_domain(irq_data);

No error checking?

This can only fail is irq_data is NULL and since the previous function succeeded we know it isn't.

Bart

Quoted 97 lines
Quoted 7 lines
drivers/mfd/max77650.c new file +7 -0
+     return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
+                                 max77650_cells, ARRAY_SIZE(max77650_cells),
+                                 NULL, 0, domain);
+}
+
+static const struct of_device_id max77650_of_match[] = {
+     { .compatible = "maxim,max77650" },

drivers/mfd/max77650.c line 228

Quoted 10 lines
drivers/mfd/max77650.c new file +10 -0
+     { }
+};
+MODULE_DEVICE_TABLE(of, max77650_of_match);
+
+static struct i2c_driver max77650_i2c_driver = {
+     .driver = {
+             .name = "max77650",
+             .of_match_table = of_match_ptr(max77650_of_match),
+     },
+     .probe_new = max77650_i2c_probe,

I wrote this years ago. Hasn't it gone away yet?

Quoted 61 lines
drivers/mfd/max77650.c new file +6 -0
+};
+module_i2c_driver(max77650_i2c_driver);
+
+MODULE_DESCRIPTION("MAXIM 77650/77651 multi-function core driver");
+MODULE_AUTHOR("Bartosz Golaszewski <[email protected]>");
+MODULE_LICENSE("GPL v2");
include/linux/mfd/max77650.h new file +49 -0
new file mode 100644
index 000000000000..c809e211a8cd
@@ -0,0 +1,59 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2018 BayLibre SAS
+ * Author: Bartosz Golaszewski <[email protected]>
+ *
+ * Common definitions for MAXIM 77650/77651 charger/power-supply.
+ */
+
+#ifndef MAX77650_H
+#define MAX77650_H
+
+#include <linux/bits.h>
+
+#define MAX77650_REG_INT_GLBL                0x00
+#define MAX77650_REG_INT_CHG         0x01
+#define MAX77650_REG_STAT_CHG_A              0x02
+#define MAX77650_REG_STAT_CHG_B              0x03
+#define MAX77650_REG_ERCFLAG         0x04
+#define MAX77650_REG_STAT_GLBL               0x05
+#define MAX77650_REG_INTM_GLBL               0x06
+#define MAX77650_REG_INTM_CHG                0x07
+#define MAX77650_REG_CNFG_GLBL               0x10
+#define MAX77650_REG_CID             0x11
+#define MAX77650_REG_CNFG_GPIO               0x12
+#define MAX77650_REG_CNFG_CHG_A              0x18
+#define MAX77650_REG_CNFG_CHG_B              0x19
+#define MAX77650_REG_CNFG_CHG_C              0x1a
+#define MAX77650_REG_CNFG_CHG_D              0x1b
+#define MAX77650_REG_CNFG_CHG_E              0x1c
+#define MAX77650_REG_CNFG_CHG_F              0x1d
+#define MAX77650_REG_CNFG_CHG_G              0x1e
+#define MAX77650_REG_CNFG_CHG_H              0x1f
+#define MAX77650_REG_CNFG_CHG_I              0x20
+#define MAX77650_REG_CNFG_SBB_TOP    0x28
+#define MAX77650_REG_CNFG_SBB0_A     0x29
+#define MAX77650_REG_CNFG_SBB0_B     0x2a
+#define MAX77650_REG_CNFG_SBB1_A     0x2b
+#define MAX77650_REG_CNFG_SBB1_B     0x2c
+#define MAX77650_REG_CNFG_SBB2_A     0x2d
+#define MAX77650_REG_CNFG_SBB2_B     0x2e
+#define MAX77650_REG_CNFG_LDO_A              0x38
+#define MAX77650_REG_CNFG_LDO_B              0x39
+#define MAX77650_REG_CNFG_LED0_A     0x40
+#define MAX77650_REG_CNFG_LED1_A     0x41
+#define MAX77650_REG_CNFG_LED2_A     0x42
+#define MAX77650_REG_CNFG_LED0_B     0x43
+#define MAX77650_REG_CNFG_LED1_B     0x44
+#define MAX77650_REG_CNFG_LED2_B     0x45
+#define MAX77650_REG_CNFG_LED_TOP    0x46

include/linux/mfd/max77650.h line 59

Quoted 10 lines
include/linux/mfd/max77650.h new file +10 -0
+
+#define MAX77650_CID_MASK            GENMASK(3, 0)
+#define MAX77650_CID_BITS(_reg)              (_reg & MAX77650_CID_MASK)
+
+#define MAX77650_CID_77650A          0x03
+#define MAX77650_CID_77650C          0x0a
+#define MAX77650_CID_77651A          0x06
+#define MAX77650_CID_77651B          0x08
+
+#endif /* MAX77650_H */

--
Lee Jones [李琼斯]
Linaro Services Technical Lead

Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
#17 lore raw

PATCH v8 7/11 power: supply: max77650: add support for battery charger

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add basic support for the battery charger for max77650 PMIC.

---
 drivers/power/supply/Kconfig            |   7 +
 drivers/power/supply/Makefile           |   1 +
 drivers/power/supply/max77650-charger.c | 367 ++++++++++++++++++++++++
 3 files changed, 375 insertions(+)
 create mode 100644 drivers/power/supply/max77650-charger.c
drivers/power/supply/Kconfig +7 -0
index e901b9879e7e..0230c96fa94d 100644
@@ -499,6 +499,13 @@ config CHARGER_DETECTOR_MAX14656
 	  Revision 1.2 and can be found e.g. in Kindle 4/5th generation
 	  readers and certain LG devices.
 
+config CHARGER_MAX77650
+	tristate "Maxim MAX77650 battery charger driver"
+	depends on MFD_MAX77650
+	help
+	  Say Y to enable support for the battery charger control of MAX77650
+	  PMICs.
+
 config CHARGER_MAX77693
 	tristate "Maxim MAX77693 battery charger driver"
 	depends on MFD_MAX77693
drivers/power/supply/Makefile +1 -0
index b731c2a9b695..b73eb8c5c1a9 100644
@@ -70,6 +70,7 @@ obj-$(CONFIG_CHARGER_MANAGER)	+= charger-manager.o
 obj-$(CONFIG_CHARGER_LTC3651)	+= ltc3651-charger.o
 obj-$(CONFIG_CHARGER_MAX14577)	+= max14577_charger.o
 obj-$(CONFIG_CHARGER_DETECTOR_MAX14656)	+= max14656_charger_detector.o
+obj-$(CONFIG_CHARGER_MAX77650)	+= max77650-charger.o
 obj-$(CONFIG_CHARGER_MAX77693)	+= max77693_charger.o
 obj-$(CONFIG_CHARGER_MAX8997)	+= max8997_charger.o
 obj-$(CONFIG_CHARGER_MAX8998)	+= max8998_charger.o
drivers/power/supply/max77650-charger.c new file +367 -0

367 lines not on this page · raw message

Signature · 1 line
2.21.0
#18 lore raw

PATCH v8 8/11 gpio: max77650: add GPIO support

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add GPIO support for max77650 mfd device. This PMIC exposes a single GPIO line.

---
 drivers/gpio/Kconfig         |   7 ++
 drivers/gpio/Makefile        |   1 +
 drivers/gpio/gpio-max77650.c | 190 +++++++++++++++++++++++++++++++++++
 3 files changed, 198 insertions(+)
 create mode 100644 drivers/gpio/gpio-max77650.c
drivers/gpio/Kconfig +7 -0
index 3f50526a771f..c4f912104440 100644
@@ -1112,6 +1112,13 @@ config GPIO_MAX77620
 	  driver also provides interrupt support for each of the gpios.
 	  Say yes here to enable the max77620 to be used as gpio controller.
 
+config GPIO_MAX77650
+	tristate "Maxim MAX77650/77651 GPIO support"
+	depends on MFD_MAX77650
+	help
+	  GPIO driver for MAX77650/77651 PMIC from Maxim Semiconductor.
+	  These chips have a single pin that can be configured as GPIO.
+
 config GPIO_MSIC
 	bool "Intel MSIC mixed signal gpio support"
 	depends on (X86 || COMPILE_TEST) && MFD_INTEL_MSIC
drivers/gpio/Makefile +1 -0
index 54d55274b93a..075722d8317d 100644
@@ -80,6 +80,7 @@ obj-$(CONFIG_GPIO_MAX7300)	+= gpio-max7300.o
 obj-$(CONFIG_GPIO_MAX7301)	+= gpio-max7301.o
 obj-$(CONFIG_GPIO_MAX732X)	+= gpio-max732x.o
 obj-$(CONFIG_GPIO_MAX77620)	+= gpio-max77620.o
+obj-$(CONFIG_GPIO_MAX77650)	+= gpio-max77650.o
 obj-$(CONFIG_GPIO_MB86S7X)	+= gpio-mb86s7x.o
 obj-$(CONFIG_GPIO_MENZ127)	+= gpio-menz127.o
 obj-$(CONFIG_GPIO_MERRIFIELD)	+= gpio-merrifield.o
drivers/gpio/gpio-max77650.c new file +190 -0

190 lines not on this page · raw message

Signature · 1 line
2.21.0
#19 lore raw

PATCH v8 9/11 leds: max77650: add LEDs support

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs.

---
 drivers/leds/Kconfig         |   6 ++
 drivers/leds/Makefile        |   1 +
 drivers/leds/leds-max77650.c | 147 +++++++++++++++++++++++++++++++++++
 3 files changed, 154 insertions(+)
 create mode 100644 drivers/leds/leds-max77650.c
drivers/leds/Kconfig +6 -0
index a72f97fca57b..d8c70cc6a714 100644
@@ -608,6 +608,12 @@ config LEDS_TLC591XX
 	  This option enables support for Texas Instruments TLC59108
 	  and TLC59116 LED controllers.
 
+config LEDS_MAX77650
+	tristate "LED support for Maxim MAX77650 PMIC"
+	depends on LEDS_CLASS && MFD_MAX77650
+	help
+	  LEDs driver for MAX77650 family of PMICs from Maxim Integrated.
+
 config LEDS_MAX77693
 	tristate "LED support for MAX77693 Flash"
 	depends on LEDS_CLASS_FLASH
drivers/leds/Makefile +1 -0
index 4c1b0054f379..f48b2404dbb7 100644
@@ -61,6 +61,7 @@ obj-$(CONFIG_LEDS_MC13783)		+= leds-mc13783.o
 obj-$(CONFIG_LEDS_NS2)			+= leds-ns2.o
 obj-$(CONFIG_LEDS_NETXBIG)		+= leds-netxbig.o
 obj-$(CONFIG_LEDS_ASIC3)		+= leds-asic3.o
+obj-$(CONFIG_LEDS_MAX77650)		+= leds-max77650.o
 obj-$(CONFIG_LEDS_MAX77693)		+= leds-max77693.o
 obj-$(CONFIG_LEDS_MAX8997)		+= leds-max8997.o
 obj-$(CONFIG_LEDS_LM355x)		+= leds-lm355x.o
drivers/leds/leds-max77650.c new file +147 -0

147 lines not on this page · raw message

Signature · 1 line
2.21.0
Acked-by on v8 9/11
#20 lore raw

Re: [PATCH v8 09/11] leds: max77650: add LEDs support

Quoted 7 lines · Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

This adds basic support for LEDs for the max77650 PMIC. The device has three current sinks for driving LEDs.

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#21 lore raw

PATCH v8 10/11 input: max77650: add onkey support

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

Add support for the push- and slide-button events for max77650.

---
 drivers/input/misc/Kconfig          |   9 +++
 drivers/input/misc/Makefile         |   1 +
 drivers/input/misc/max77650-onkey.c | 121 ++++++++++++++++++++++++++++
 3 files changed, 131 insertions(+)
 create mode 100644 drivers/input/misc/max77650-onkey.c
drivers/input/misc/Kconfig +9 -0
index e15ed1bb8558..85bc675eecd3 100644
@@ -190,6 +190,15 @@ config INPUT_M68K_BEEP
 	tristate "M68k Beeper support"
 	depends on M68K
 
+config INPUT_MAX77650_ONKEY
+	tristate "Maxim MAX77650 ONKEY support"
+	depends on MFD_MAX77650
+	help
+	  Support the ONKEY of the MAX77650 PMIC as an input device.
+
+	  To compile this driver as a module, choose M here: the module
+	  will be called max77650-onkey.
+
 config INPUT_MAX77693_HAPTIC
 	tristate "MAXIM MAX77693/MAX77843 haptic controller support"
 	depends on (MFD_MAX77693 || MFD_MAX77843) && PWM
drivers/input/misc/Makefile +1 -0
index b936c5b1d4ac..ffd72161c79b 100644
@@ -43,6 +43,7 @@ obj-$(CONFIG_INPUT_IXP4XX_BEEPER)	+= ixp4xx-beeper.o
 obj-$(CONFIG_INPUT_KEYSPAN_REMOTE)	+= keyspan_remote.o
 obj-$(CONFIG_INPUT_KXTJ9)		+= kxtj9.o
 obj-$(CONFIG_INPUT_M68K_BEEP)		+= m68kspkr.o
+obj-$(CONFIG_INPUT_MAX77650_ONKEY)	+= max77650-onkey.o
 obj-$(CONFIG_INPUT_MAX77693_HAPTIC)	+= max77693-haptic.o
 obj-$(CONFIG_INPUT_MAX8925_ONKEY)	+= max8925_onkey.o
 obj-$(CONFIG_INPUT_MAX8997_HAPTIC)	+= max8997_haptic.o
drivers/input/misc/max77650-onkey.c new file +121 -0

121 lines not on this page · raw message

Signature · 1 line
2.21.0
#22 lore raw

PATCH v8 11/11 MAINTAINERS: add an entry for max77650 mfd driver

In reply to Bartosz Golaszewski

From: Bartosz Golaszewski <[email protected]>

I plan on extending this set of drivers so add myself as maintainer.

---
 MAINTAINERS | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
MAINTAINERS +14 -0
index 43b36dbed48e..d8bdaeb72b95 100644
@@ -9406,6 +9406,20 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/sound/max9860.txt
 F:	sound/soc/codecs/max9860.*
 
+MAXIM MAX77650 PMIC MFD DRIVER
+M:	Bartosz Golaszewski <[email protected]>
+L:	[email protected]
+S:	Maintained
+F:	Documentation/devicetree/bindings/*/*max77650.txt
+F:	Documentation/devicetree/bindings/*/max77650*.txt
+F:	include/linux/mfd/max77650.h
+F:	drivers/mfd/max77650.c
+F:	drivers/regulator/max77650-regulator.c
+F:	drivers/power/supply/max77650-charger.c
+F:	drivers/input/misc/max77650-onkey.c
+F:	drivers/leds/leds-max77650.c
+F:	drivers/gpio/gpio-max77650.c
+
 MAXIM MAX77802 PMIC REGULATOR DEVICE DRIVER
 M:	Javier Martinez Canillas <[email protected]>
 L:	[email protected]
Signature · 1 line
2.21.0