Skip to contentSkip to conversation

package/luajit: bump to version 2.1.x developpment version

PATCH New Jugurtha BELKALEM 5 participants 6 messages Apr 2, 2019 – Apr 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/luajit: bump to version 2.1.x developpment version

In order to integrate bcc (front end tool for eBPF) into buildroot and testing it on a Raspberry PI 3; We need to upgrade the version of luajit to 2.1.0 to support aarch64.

Currently, luajit aarch64_be support has not been tested.

---
 package/luajit/Config.in   | 2 +-
 package/luajit/luajit.hash | 4 ++--
 package/luajit/luajit.mk   | 5 ++---
 3 files changed, 5 insertions(+), 6 deletions(-)
package/luajit/Config.in +1 -1
index 88c5bcb..9ecf6b4 100644
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
 	bool
-	default y if BR2_i386 || \
+	default y if BR2_i386 || BR2_aarch64 || \
 		(BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
 		BR2_powerpc || BR2_arm || BR2_armeb || \
 		((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT && \
package/luajit/luajit.hash +2 -2
index 2081d12..b422bc9 100644
@@ -1,2 +1,2 @@
-# Hashes from: http://luajit.org/download.html
-md5 48353202cbcacab84ee41a5a70ea0a2c    LuaJIT-2.0.5.tar.gz
+# Localy generated
+sha256 ad5077bd861241bf5e50ae4bf543d291c5fcffab95ccc3218401131f503e45bd luajit-f0e865dd4861520258299d0f2a56491bd9d602e1.tar.gz
package/luajit/luajit.mk +2 -3
index 5b08a42..9a06691 100644
@@ -4,9 +4,8 @@
 #
 ################################################################################
 
-LUAJIT_VERSION = 2.0.5
-LUAJIT_SOURCE = LuaJIT-$(LUAJIT_VERSION).tar.gz
-LUAJIT_SITE = http://luajit.org/download
+LUAJIT_VERSION = f0e865dd4861520258299d0f2a56491bd9d602e1
+LUAJIT_SITE = $(call github,luajit,luajit,$(LUAJIT_VERSION))
 LUAJIT_LICENSE = MIT
 LUAJIT_LICENSE_FILES = COPYRIGHT
 
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/luajit: bump to version 2.1.x developpment version

Le mar. 2 avr. 2019 ? 16:49, Jugurtha BELKALEM <[email protected]> a ?crit :

Quoted 41 lines

In order to integrate bcc (front end tool for eBPF) into buildroot and testing it on a Raspberry PI 3; We need to upgrade the version of luajit to 2.1.0 to support aarch64.

Currently, luajit aarch64_be support has not been tested.

---
 package/luajit/Config.in   | 2 +-
 package/luajit/luajit.hash | 4 ++--
 package/luajit/luajit.mk   | 5 ++---
 3 files changed, 5 insertions(+), 6 deletions(-)
package/luajit/Config.in +1 -1
index 88c5bcb..9ecf6b4 100644
@@ -1,6 +1,6 @@
 config BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS
        bool
-       default y if BR2_i386 || \
+       default y if BR2_i386 || BR2_aarch64 || \
                (BR2_x86_64 && BR2_HOSTARCH='x86_64') || \
                BR2_powerpc || BR2_arm || BR2_armeb || \
                ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT && \
package/luajit/luajit.hash +2 -2
index 2081d12..b422bc9 100644
@@ -1,2 +1,2 @@
-# Hashes from: http://luajit.org/download.html
-md5 48353202cbcacab84ee41a5a70ea0a2c    LuaJIT-2.0.5.tar.gz
+# Localy generated
+sha256 ad5077bd861241bf5e50ae4bf543d291c5fcffab95ccc3218401131f503e45bd

luajit-f0e865dd4861520258299d0f2a56491bd9d602e1.tar.gz

package/luajit/luajit.mk +0 -0
index 5b08a42..9a06691 100644

package/luajit/luajit.mk line 9

Quoted 9 lines
package/luajit/luajit.mk +1 -3
@@ -4,9 +4,8 @@
 #
 
 ################################################################################
 
-LUAJIT_VERSION = 2.0.5
-LUAJIT_SOURCE = LuaJIT-$(LUAJIT_VERSION).tar.gz
-LUAJIT_SITE = http://luajit.org/download
+LUAJIT_VERSION = f0e865dd4861520258299d0f2a56491bd9d602e1
 

Could you use the version 2.1.0-beta3 which is available (with its hash) on
http://luajit.org/download.html ?

Fran?ois

+LUAJIT_SITE = $(call github,luajit,luajit,$(LUAJIT_VERSION))

Quoted 7 lines
package/luajit/luajit.mk +0 -1
 LUAJIT_LICENSE = MIT
 LUAJIT_LICENSE_FILES = COPYRIGHT
 
--

2.7.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190403/0a6cef5e/attachment-0001.html>

#2 lore raw

PATCH 1/1 package/luajit: bump to version 2.1.x developpment version

In reply to Jugurtha BELKALEM

Hello,

Quoted 8 lines · On Tue, 2 Apr 2019 16:49:35 +0200 Jugurtha BELKALEM…

In order to integrate bcc (front end tool for eBPF) into buildroot and testing it on a Raspberry PI 3; We need to upgrade the version of luajit to 2.1.0 to support aarch64.

Currently, luajit aarch64_be support has not been tested.

Perhaps this can be done as part of a larger patch series that introduces 'bcc' as well ? By that time, hopefully LuaJIT 2.1.0 will have been released, and we'll be good ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/luajit: bump to version 2.1.x developpment version

Hi,

To answer the question of Fran?ois : The luajit2.1.0-beta3 version in
http://luajit.org/download.html has not been changed since 2 years (last change in May 2017), so I guess it is better to take a version which is up to date.

To answer the question of Thamas : We have successfully tested bcc on a raspberry PI 3, however; the purpose of this patch is to check that it does not break the build process in buildroot (for example luajit2.1.0 is adding support for aarch64; we need to ensure that it is safe).

Regards.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190403/8b06e2ea/attachment.html>

#4 lore raw

PATCH 1/1 package/luajit: bump to version 2.1.x developpment version

[Please don't remove the quoted text entirely, but quote inline like below.]

Quoted 6 lines · Jugurtha BELKALEM

Hi,

To answer the question of Fran?ois : The luajit2.1.0-beta3 version in
http://luajit.org/download.html has not been changed since 2 years (last change in May 2017), so I guess it is better to take a version which is up to date.

I feel a bit uncomfortable to bump a package to an unreleased version of a
project that is apparently not going anywhere (only a handful of commits in the last year).

Note that any issues are likely to be runtime issues. So it really depends on
the users of luajit (if such users even exist...) to decide if they're willing to take that risk.

Quoted 4 lines

To answer the question of Thamas : We have successfully tested bcc on a raspberry PI 3, however; the purpose of this patch is to check that it does not break the build process in buildroot (for example luajit2.1.0 is adding support for aarch64; we need to ensure that it is safe).

So, IIUC, bcc depends on luajit (not plain Lua)? But it is fine with the
existing luajit version, only then you don't have aarch64 support?

In that case, maybe it's better to make the version dependent on the
architecture, like we sometimes do for other packages. See for instance the arc versions of binutils, gcc, gdb, glibc.

Regards,
Arnout

#5 lore raw

PATCH 1/1 package/luajit: bump to version 2.1.x developpment version

Hi Arnout,

Le 14/04/2019 ? 22:06, Arnout Vandecappelle a ?crit?:

Quoted 5 lines

[Please don't remove the quoted text entirely, but quote inline like below.]

Quoted 2 lines · Jugurtha BELKALEM

Hi,

Quoted 8 lines
Quoted 4 lines

To answer the question of Fran?ois : The luajit2.1.0-beta3 version in
http://luajit.org/download.html has not been changed since 2 years (last change in May 2017), so I guess it is better to take a version which is up to date.

I feel a bit uncomfortable to bump a package to an unreleased version of a
project that is apparently not going anywhere (only a handful of commits in the last year).

luajit2.1.0-beta3 doesn't seems a release version but it's packaged by Debian testing, Fedora 26+, Ubuntu 18.04.

https://repology.org/project/luajit/versions

Quoted 4 lines

Note that any issues are likely to be runtime issues. So it really depends on
the users of luajit (if such users even exist...) to decide if they're willing to take that risk.

ok

Quoted 8 lines
Quoted 5 lines

To answer the question of Thamas : We have successfully tested bcc on a raspberry PI 3, however; the purpose of this patch is to check that it does not break the build process in buildroot (for example luajit2.1.0 is adding support for aarch64; we need to ensure that it is safe).

So, IIUC, bcc depends on luajit (not plain Lua)? But it is fine with the
existing luajit version, only then you don't have aarch64 support?

exact.

Quoted 4 lines

In that case, maybe it's better to make the version dependent on the
architecture, like we sometimes do for other packages. See for instance the arc versions of binutils, gcc, gdb, glibc.

Ok, maybe we should be careful with API break between 2.0.x and 2.1.x...

Best regards,
Romain

Quoted 8 lines

Regards,
Arnout
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot