Skip to contentSkip to conversation

arm: meson: Fix khadas-vim2 USB

PATCH New Neil Armstrong 3 participants 7 messages Apr 3, 2019 Generic PHY framework

lore
Share & tools
lore
#0 lore raw

cover arm: meson: Fix khadas-vim2 USB

This patchset :
- fixes the MESON_GXL_USB_PHY dependency to also allow MESON_GXM
- fixes the khadas-vim2 defconfig

Tom, I know it's _very_ late in the cycle, is it still OK for final 2019.04 release ?

Neil Armstrong (2):
phy: Also allow MESON_GXM for MESON_GXL_USB_PHY
configs: khadas_vim2: Fix defconfig

 configs/khadas-vim2_defconfig | 3 +++
 drivers/phy/Kconfig           | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/2 phy: Also allow MESON_GXM for MESON_GXL_USB_PHY

The MESON_GXL_USB_PHY is also used on the Amlogic Meson GXM SoCs.

Fixes 2960e27e38 ("phy: Add Amlogic Meson USB2 & USB3 Generic PHY drivers")
---
 drivers/phy/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/phy/Kconfig +1 -1
index 825ee7c3be..32bbf41dd1 100644
@@ -141,7 +141,7 @@ config PHY_STM32_USBPHYC
 
 config MESON_GXL_USB_PHY
 	bool "Amlogic Meson GXL USB PHYs"
-	depends on PHY && ARCH_MESON && MESON_GXL
+	depends on PHY && ARCH_MESON && (MESON_GXL || MESON_GXM)
 	imply REGMAP
 	help
 	  This is the generic phy driver for the Amlogic Meson GXL
Signature · 1 line
2.21.0
#2 lore raw

PATCH 1/2 phy: Also allow MESON_GXM for MESON_GXL_USB_PHY

Quoted 4 lines · Neil Armstrong

The MESON_GXL_USB_PHY is also used on the Amlogic Meson GXM SoCs.

Fixes 2960e27e38 ("phy: Add Amlogic Meson USB2 & USB3 Generic PHY drivers")

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190403/b59439ac/attachment.sig>
#3 lore raw

PATCH 2/2 configs: khadas_vim2: Fix defconfig

In reply to Neil Armstrong

The Khadas VIM2 defconfig was missing the USB PHY config and two other misc configs to setup dram banks and call misc_init_r. Align it on the other Amlogic SoC based boards defconfig.

---
 configs/khadas-vim2_defconfig | 3 +++
 1 file changed, 3 insertions(+)
configs/khadas-vim2_defconfig +3 -0
index 0f738cbb90..080dd19590 100644
@@ -6,8 +6,10 @@ CONFIG_DEBUG_UART_BASE=0xc81004c0
 CONFIG_DEBUG_UART_CLOCK=24000000
 CONFIG_IDENT_STRING=" khadas-vim2"
 CONFIG_DEBUG_UART=y
+CONFIG_NR_DRAM_BANKS=1
 CONFIG_OF_BOARD_SETUP=y
 CONFIG_CONSOLE_MUX=y
+CONFIG_MISC_INIT_R=y
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
 # CONFIG_CMD_BDI is not set
@@ -30,6 +32,7 @@ CONFIG_MTD=y
 CONFIG_DM_ETH=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_PHY=y
+CONFIG_MESON_GXL_USB_PHY=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_MESON_GXL=y
 CONFIG_DM_REGULATOR_FIXED=y
Signature · 1 line
2.21.0
#4 lore raw

PATCH 2/2 configs: khadas_vim2: Fix defconfig

Quoted 5 lines · Neil Armstrong

The Khadas VIM2 defconfig was missing the USB PHY config and two other misc configs to setup dram banks and call misc_init_r. Align it on the other Amlogic SoC based boards defconfig.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190403/fcaf3303/attachment.sig>
#5 lore raw

cover arm: meson: Fix khadas-vim2 USB

In reply to Neil Armstrong
Quoted 6 lines · Neil Armstrong

This patchset :
- fixes the MESON_GXL_USB_PHY dependency to also allow MESON_GXM
- fixes the khadas-vim2 defconfig

Tom, I know it's _very_ late in the cycle, is it still OK for final 2019.04 release ?

If it's a fix, it is still OK.

Signature · 2 lines
Best regards,
Marek Vasut
#6 lore raw

cover arm: meson: Fix khadas-vim2 USB

In reply to Neil Armstrong
Quoted 7 lines · Neil Armstrong

This patchset :
- fixes the MESON_GXL_USB_PHY dependency to also allow MESON_GXM
- fixes the khadas-vim2 defconfig

Tom, I know it's _very_ late in the cycle, is it still OK for final 2019.04 release ?

Quoted 7 lines

Neil Armstrong (2):
phy: Also allow MESON_GXM for MESON_GXL_USB_PHY
configs: khadas_vim2: Fix defconfig

 configs/khadas-vim2_defconfig | 3 +++
 drivers/phy/Kconfig           | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

I'm putting this through CI now, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190403/3bb60609/attachment.sig>