Skip to contentSkip to conversation

aspeed: flash: Add MT25QL01GB chip

PATCH In review Adriana Kobylak 3 participants 7 messages Feb 8, 2019 – Apr 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aspeed: flash: Add MT25QL01GB chip

From: Adriana Kobylak <[email protected]>

The MT25QL01GB is a 128MB NOR flash chip planned to be used on a Witherspoon system (AST2500).

---
 arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/mach-aspeed/flash.c +14 -0
index 907e785..54a6059 100644
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];		/* FLASH chips info */
 #define SST25VF040B		0x8d25bf
 #define AT25DF161		0x02461F
 #define AT25DF321		0x01471F
+#define MT25QL01GB		0x21ba20
 
 /* SPI Define */
 #define CS0_CTRL			0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
 			ReadClk  = 50;
 			break;
 
+		case MT25QL01GB:
+			info->sector_count = 2048;
+			info->size = 0x8000000;
+			erase_region_size  = 0x10000;
+			info->readcmd = 0x0b;
+			info->dualport = 0;
+			info->dummybyte = 1;
+			info->buffersize = 1;
+			WriteClk = 50;
+			EraseClk = 25;
+			ReadClk  = 50;
+			break;
+
 		default:	/* use JEDEC ID */
 			printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
 			erase_region_size  = 0x10000;
Signature · 1 line
1.8.3.1
#1 lore raw

PATCH 1/1 aspeed: flash: Add MT25QL01GB chip

The MT25QL01GB is a 128MB NOR flash chip planned to be used on a Witherspoon system (AST2500).

---
 arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/mach-aspeed/flash.c +14 -0
index 907e785..54a6059 100644
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];		/* FLASH chips info */
 #define SST25VF040B		0x8d25bf
 #define AT25DF161		0x02461F
 #define AT25DF321		0x01471F
+#define MT25QL01GB		0x21ba20
 
 /* SPI Define */
 #define CS0_CTRL			0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
 			ReadClk  = 50;
 			break;
 
+		case MT25QL01GB:
+			info->sector_count = 2048;
+			info->size = 0x8000000;
+			erase_region_size  = 0x10000;
+			info->readcmd = 0x0b;
+			info->dualport = 0;
+			info->dummybyte = 1;
+			info->buffersize = 1;
+			WriteClk = 50;
+			EraseClk = 25;
+			ReadClk  = 50;
+			break;
+
 		default:	/* use JEDEC ID */
 			printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
 			erase_region_size  = 0x10000;
Signature · 1 line
1.8.3.1
#2 lore raw
In reply to Adriana Kobylak
Quoted 44 lines · Adriana Kobylak

From: Adriana Kobylak <[email protected]>

The MT25QL01GB is a 128MB NOR flash chip planned to be used on a Witherspoon system (AST2500).

---
arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++

1 file changed, 14 insertions(+)
arch/arm/mach-aspeed/flash.c +14 -0
index 907e785..54a6059 100644
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];		/* FLASH chips info */
 #define SST25VF040B		0x8d25bf
 #define AT25DF161		0x02461F
 #define AT25DF321		0x01471F
+#define MT25QL01GB		0x21ba20
 
 /* SPI Define */
 #define CS0_CTRL			0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
 			ReadClk  = 50;
 			break;
 
+		case MT25QL01GB:
+			info->sector_count = 2048;
+			info->size = 0x8000000;
+			erase_region_size  = 0x10000;
+			info->readcmd = 0x0b;
+			info->dualport = 0;
+			info->dummybyte = 1;
+			info->buffersize = 1;
+			WriteClk = 50;
+			EraseClk = 25;
+			ReadClk  = 50;
+			break;
+
 		default:	/* use JEDEC ID */
 			printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
 			erase_region_size  = 0x10000;
Signature · 1 line
1.8.3.1

Hi Joel

Would you be willing to carry this u-boot patch and if so, what all would you like to see from our end to enable that?

thx - Brad

maintainer
#3 lore raw
Quoted 11 lines · Brad Bishop
Quoted 5 lines · Adriana Kobylak

From: Adriana Kobylak <[email protected]>

The MT25QL01GB is a 128MB NOR flash chip planned to be used on a Witherspoon system (AST2500).

Would you be willing to carry this u-boot patch and if so, what all would you like to see from our end to enable that?

Where does Adriana want it applied? The subject doesn't indicate a branch.

I didn't look at it becuase I assumed it was an upstream patch. Looking at it now it is obviously meant for the ancient openbmc tree. I have applied it to v2016.07-aspeed-openbmc.

In the future, adding the correct tags to the subject, and sending reviewed and tested tags will help me apply your patch.

Cheers,

Joel

maintainer
#4 lore raw
Quoted 5 lines · Joel Stanley
Quoted 3 lines · Brad Bishop
Quoted 1 line · Adriana Kobylak

From: Adriana Kobylak <[email protected]>

Adriana, you need to fix up your email address. Once you've done that regenerate the patch with --reset-author and make sure the signed-off-by is correct.

Cheers,

Joel

Quoted 21 lines
Quoted 8 lines
Quoted 4 lines

The MT25QL01GB is a 128MB NOR flash chip planned to be used on a Witherspoon system (AST2500).

Would you be willing to carry this u-boot patch and if so, what all would you like to see from our end to enable that?

Where does Adriana want it applied? The subject doesn't indicate a branch.

I didn't look at it becuase I assumed it was an upstream patch. Looking at it now it is obviously meant for the ancient openbmc tree. I have applied it to v2016.07-aspeed-openbmc.

In the future, adding the correct tags to the subject, and sending reviewed and tested tags will help me apply your patch.

Cheers,

Joel

#5 lore raw

PATCH 1/1 aspeed/flash: Add MT25QL01GB chip

From: Adriana Kobylak <[email protected]>

The MT25QL01GB is a 128MB NOR flash chip planned to be used on a Witherspoon system (AST2500).

---
 arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/mach-aspeed/flash.c +14 -0
index 907e785..54a6059 100644
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];		/* FLASH chips info */
 #define SST25VF040B		0x8d25bf
 #define AT25DF161		0x02461F
 #define AT25DF321		0x01471F
+#define MT25QL01GB		0x21ba20
 
 /* SPI Define */
 #define CS0_CTRL			0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
 			ReadClk  = 50;
 			break;
 
+		case MT25QL01GB:
+			info->sector_count = 2048;
+			info->size = 0x8000000;
+			erase_region_size  = 0x10000;
+			info->readcmd = 0x0b;
+			info->dualport = 0;
+			info->dummybyte = 1;
+			info->buffersize = 1;
+			WriteClk = 50;
+			EraseClk = 25;
+			ReadClk  = 50;
+			break;
+
 		default:	/* use JEDEC ID */
 			printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
 			erase_region_size  = 0x10000;
Signature · 1 line
1.8.3.1
maintainer
#6 lore raw

Re: [PATCH u-boot v2016.07-aspeed-openbmc] aspeed/flash: Add MT25QL01GB chip

Quoted 8 lines · Adriana Kobylak

From: Adriana Kobylak <[email protected]>

The MT25QL01GB is a 128MB NOR flash chip planned to be used on a Witherspoon system (AST2500).

That looks better. I've applied this one.

Thanks,

Joel

Quoted 39 lines
---
 arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/mach-aspeed/flash.c +14 -1
index 907e785..54a6059 100644
@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];          /* FLASH chips info */
 #define SST25VF040B            0x8d25bf
 #define AT25DF161              0x02461F
 #define AT25DF321              0x01471F
+#define MT25QL01GB             0x21ba20
 
 /* SPI Define */
 #define CS0_CTRL                       0x10
@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
                        ReadClk  = 50;
                        break;
 
+               case MT25QL01GB:
+                       info->sector_count = 2048;
+                       info->size = 0x8000000;
+                       erase_region_size  = 0x10000;
+                       info->readcmd = 0x0b;
+                       info->dualport = 0;
+                       info->dummybyte = 1;
+                       info->buffersize = 1;
+                       WriteClk = 50;
+                       EraseClk = 25;
+                       ReadClk  = 50;
+                       break;
+
                default:        /* use JEDEC ID */
                        printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
                        erase_region_size  = 0x10000;
--

1.8.3.1