Skip to contentSkip to conversation

arm64/vdso: don't leak kernel addresses

PATCH In review Matteo Croce 3 participants 5 messages Apr 1, 2019 – Apr 3, 2019 arm64

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 arm64/vdso: don't leak kernel addresses

Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), two obfuscated kernel pointer are printed at every boot:

    vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))

Remove the the print completely, as it's useless without the addresses.

Fixes ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
---
 arch/arm64/kernel/vdso.c | 2 --
 1 file changed, 2 deletions(-)
arch/arm64/kernel/vdso.c +0 -2
index 2d419006ad43..9fb0c0c95a85 100644
@@ -146,8 +146,6 @@ static int __init vdso_init(void)
 	}
 
 	vdso_pages = (vdso_end - vdso_start) >> PAGE_SHIFT;
-	pr_info("vdso: %ld pages (%ld code @ %p, %ld data @ %p)\n",
-		vdso_pages + 1, vdso_pages, vdso_start, 1L, vdso_data);
 
 	/* Allocate the vDSO pagelist, plus a page for the data. */
 	vdso_pagelist = kcalloc(vdso_pages + 1, sizeof(struct page *),
Signature · 7 lines
2.20.1


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#1 lore raw
Quoted 10 lines · Matteo Croce

Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), two obfuscated kernel pointer are printed at every boot:

    vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))

Remove the the print completely, as it's useless without the addresses.

Fixes ad67b74d2469d9b8 ("printk: hash addresses printed with %p")

Cheers, I'll pick this up.

Will

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 7 lines · Will Deacon
Quoted 5 lines · Matteo Croce

Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), two obfuscated kernel pointer are printed at every boot:

    vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))
Quoted 7 lines
Quoted 5 lines

Remove the the print completely, as it's useless without the addresses.

Fixes ad67b74d2469d9b8 ("printk: hash addresses printed with %p")

Cheers, I'll pick this up.

Maybe you can fixup the dupe in: "Remove the the print completely"

Regards.

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
Quoted 16 lines · Marc Gonzalez
Quoted 13 lines · Will Deacon
Quoted 10 lines · Matteo Croce

Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), two obfuscated kernel pointer are printed at every boot:

    vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))

Remove the the print completely, as it's useless without the addresses.

Fixes ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
Quoted 5 lines
Quoted 1 line

Cheers, I'll pick this up.

Maybe you can fixup the dupe in: "Remove the the print completely"

Regards.

Oops, please remove it, I didn't notice in time.
Nice catch, thanks

--
Matteo Croce
per aspera ad upstream

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#4 lore raw
Quoted 17 lines · Matteo Croce
Quoted 16 lines · Marc Gonzalez
Quoted 13 lines · Will Deacon
Quoted 10 lines · Matteo Croce

Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), two obfuscated kernel pointer are printed at every boot:

    vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____))

Remove the the print completely, as it's useless without the addresses.

Fixes ad67b74d2469d9b8 ("printk: hash addresses printed with %p")
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Cheers, I'll pick this up.

Maybe you can fixup the dupe in: "Remove the the print completely"

Regards.

Oops, please remove it, I didn't notice in time.
Nice catch, thanks

Damn, I already pushed this out, so I'm afraid it's stuck there now.

Will

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel