Skip to contentSkip to conversation

tests: Remove i915_missed_irq

PATCH In review José Roberto de Souza 4 participants 8 messages Apr 3, 2019 Arm/Amlogic Meson SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests: Remove i915_missed_irq

i915_ring_missed_irq was removed from debugfs in kernel patch 789659f4307a ("drm/i915: Drop fake breadcrumb irq") and it was the base of which i915_missed_irq was written, so removing this test for good.

---
 tests/Makefile.sources       |   3 -
 tests/i915/i915_missed_irq.c | 165 -----------------------------------
 tests/meson.build            |   1 -
 3 files changed, 169 deletions(-)
 delete mode 100644 tests/i915/i915_missed_irq.c
tests/Makefile.sources +0 -3
index 71ccf00a..9e4862c8 100644
@@ -474,9 +474,6 @@ i915_getparams_basic_SOURCES = i915/i915_getparams_basic.c
 TESTS_progs += i915_hangman
 i915_hangman_SOURCES = i915/i915_hangman.c
 
-TESTS_progs += i915_missed_irq
-i915_missed_irq_SOURCES = i915/i915_missed_irq.c
-
 TESTS_progs += i915_module_load
 i915_module_load_SOURCES = i915/i915_module_load.c
 
tests/i915/i915_missed_irq.c deleted +0 -165

165 lines not on this page · raw message

tests/meson.build +0 -1
index 9015f809..7d2ff948 100644
@@ -215,7 +215,6 @@ i915_progs = [
 	'i915_fb_tiling',
 	'i915_getparams_basic',
 	'i915_hangman',
-	'i915_missed_irq',
 	'i915_module_load',
 	'i915_pm_backlight',
 	'i915_pm_lpsp',
Signature · 6 lines
2.21.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests: Remove i915_missed_irq

== Series Details ==

== Series Details ==

Series: tests: Remove i915_missed_irq
URL : https://patchwork.freedesktop.org/series/58901/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5858 -> IGTPW_2768
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/58901/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2768 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live_uncore:
- fi-ivb-3770: PASS -> DMESG-FAIL [fdo#110210]

* igt@kms_chamelium@dp-hpd-fast:
- fi-skl-6700k2: NOTRUN -> SKIP [fdo#109271] +31

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- fi-skl-6700k2: INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS

* igt@i915_selftest@live_execlists:
- fi-apl-guc: INCOMPLETE [fdo#103927] / [fdo#109720] -> PASS

#### Warnings ####

* igt@i915_selftest@live_contexts:
- fi-icl-u3: INCOMPLETE [fdo#108569] -> DMESG-FAIL [fdo#108569]
- fi-icl-u2: INCOMPLETE [fdo#108569] -> DMESG-FAIL [fdo#108569]

[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109720]: https://bugs.freedesktop.org/show_bug.cgi?id=109720
[fdo#110210]: https://bugs.freedesktop.org/show_bug.cgi?id=110210

Participating hosts (47 -> 42)
------------------------------

Missing (5): fi-ilk-m540 fi-byt-squawks fi-bwr-2160 fi-ctg-p8600 fi-bdw-samus

Build changes
-------------

* IGT: IGT_4922 -> IGTPW_2768

CI_DRM_5858: 79fda73b53d7233c94922601d42aa0b7625544de @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2768: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2768/
IGT_4922: e941e4a29438c7130554492e4daf52afbc99ffdf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Testlist changes ==

-igt@i915_missed_irq

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2768/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#2 lore raw
In reply to José Roberto de Souza

Quoting José Roberto de Souza (2019-04-03 01:20:12)

Quoted 4 lines

i915_ring_missed_irq was removed from debugfs in kernel patch 789659f4307a ("drm/i915: Drop fake breadcrumb irq") and it was the base of which i915_missed_irq was written, so removing this test for good.

Has it been removed from all trees yet? Is it even gone from Linus? -Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Acked-by
#3 lore raw
Quoted 7 lines · Chris Wilson

Quoting José Roberto de Souza (2019-04-03 01:20:12)

Quoted 4 lines

i915_ring_missed_irq was removed from debugfs in kernel patch 789659f4307a ("drm/i915: Drop fake breadcrumb irq") and it was the base of which i915_missed_irq was written, so removing this test for good.

Has it been removed from all trees yet? Is it even gone from Linus?

We won't be able to remove it from older igt releases either ... I think we'll be fine.

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#4 lore raw

Quoting Daniel Vetter (2019-04-03 09:40:09)

Quoted 11 lines · Chris Wilson
Quoted 7 lines

Quoting José Roberto de Souza (2019-04-03 01:20:12)

Quoted 4 lines

i915_ring_missed_irq was removed from debugfs in kernel patch 789659f4307a ("drm/i915: Drop fake breadcrumb irq") and it was the base of which i915_missed_irq was written, so removing this test for good.

Has it been removed from all trees yet? Is it even gone from Linus?

We won't be able to remove it from older igt releases either ... I think we'll be fine.

I was more curious if it is still in use for any of the CI trees - I think the oldest of which we test is linus.
-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#5 lore raw
Quoted 8 lines · Chris Wilson

Quoting Daniel Vetter (2019-04-03 09:40:09)

Quoted 7 lines · Chris Wilson
Quoted 6 lines

Quoting José Roberto de Souza (2019-04-03 01:20:12)

Quoted 4 lines

i915_ring_missed_irq was removed from debugfs in kernel patch 789659f4307a ("drm/i915: Drop fake breadcrumb irq") and it was the base of which i915_missed_irq was written, so removing this test for good.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Has it been removed from all trees yet? Is it even gone from Linus?

We won't be able to remove it from older igt releases either ... I think we'll be fine.

I was more curious if it is still in use for any of the CI trees - I think the oldest of which we test is linus.

Good point. Seems to be gone from Linus' tree too, which is the last one we care about I think.
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Reviewed-by
#6 lore raw

Quoting Daniel Vetter (2019-04-03 09:46:08)

Quoted 11 lines · Chris Wilson
Quoted 10 lines

Quoting Daniel Vetter (2019-04-03 09:40:09)

Quoted 9 lines · Chris Wilson
Quoted 7 lines

Quoting José Roberto de Souza (2019-04-03 01:20:12)

Quoted 4 lines

i915_ring_missed_irq was removed from debugfs in kernel patch 789659f4307a ("drm/i915: Drop fake breadcrumb irq") and it was the base of which i915_missed_irq was written, so removing this test for good.

Has it been removed from all trees yet? Is it even gone from Linus?

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

We won't be able to remove it from older igt releases either ... I think we'll be fine.

I was more curious if it is still in use for any of the CI trees - I think the oldest of which we test is linus.

Good point. Seems to be gone from Linus' tree too, which is the last one we care about I think.

Although shedding a tear over some crafty code, as CI is not using it any more, there's no point keeping around dead code. Git, ad memoriam.

-Chris
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#7 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for tests: Remove i915_missed_irq

In reply to José Roberto de Souza
== Series Details ==

== Series Details ==

Series: tests: Remove i915_missed_irq
URL : https://patchwork.freedesktop.org/series/58901/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5858_full -> IGTPW_2768_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://patchwork.freedesktop.org/api/1.0/series/58901/revisions/1/mbox/

Known issues
------------

Here are the changes found in IGTPW_2768_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_exec_params@no-bsd:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +11

* igt@gem_stolen@large-object-alloc:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +2

* igt@gem_stolen@stolen-clear:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +22

* igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
- shard-apl: PASS -> FAIL [fdo#109660]

* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-hsw: PASS -> DMESG-WARN [fdo#110222] +2

* igt@kms_busy@extended-modeset-hang-newfb-render-d:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1

* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-c:
- shard-kbl: PASS -> DMESG-WARN [fdo#110222]

* igt@kms_busy@extended-pageflip-hang-newfb-render-d:
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]

* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: PASS -> FAIL [fdo#105363]

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-apl: PASS -> FAIL [fdo#103167]
- shard-kbl: PASS -> FAIL [fdo#103167]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-snb: NOTRUN -> SKIP [fdo#109271] +44

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-snb: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +2

* igt@kms_plane_scaling@pipe-a-scaler-with-clipping-clamping:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278] +2

* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]

* igt@kms_vblank@pipe-a-ts-continuation-dpms-rpm:
- shard-apl: PASS -> FAIL [fdo#104894] +1

#### Possible fixes ####

* igt@kms_busy@extended-modeset-hang-newfb-render-b:

    - shard-hsw:          DMESG-WARN [fdo#110222] -> PASS +1
    - shard-kbl:          DMESG-WARN [fdo#110222] -> PASS +2
    - shard-snb:          DMESG-WARN [fdo#110222] -> PASS +1

* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: FAIL [fdo#109016] -> PASS

* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS

* igt@kms_vblank@pipe-c-ts-continuation-modeset-hang:
- shard-apl: FAIL [fdo#104894] -> PASS

[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104894]: https://bugs.freedesktop.org/show_bug.cgi?id=104894
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109660]: https://bugs.freedesktop.org/show_bug.cgi?id=109660
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912

Participating hosts (10 -> 5)
------------------------------

Missing (5): shard-skl pig-hsw-4770r pig-glk-j5005 shard-iclb pig-skl-6260u

Build changes
-------------

* IGT: IGT_4922 -> IGTPW_2768
* Piglit: piglit_4509 -> None

CI_DRM_5858: 79fda73b53d7233c94922601d42aa0b7625544de @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2768: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2768/
IGT_4922: e941e4a29438c7130554492e4daf52afbc99ffdf @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2768/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev