Skip to contentSkip to conversation

nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1

PATCH RESEND Superseded Ming Lei 2 participants 4 messages Apr 2, 2019 – Apr 24, 2019

Subsystems (2)
lore
Share & tools
lore

Ming Lei

author
#0 lore raw

PATCH RESEND 1/1 nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1

NVMe target only accepts single-page sg list, either file or block device backed target code follows this assumption.

However, loop target is one exception, given the sg list is from the host queue directly.

This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 for following NVMe target assumption.

Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36 ("nvmet: fix building bvec from sg list") can fix the current issue simply without needing to limit the segment size for nvme-loop.

Reported-by Yi Zhang <yi.zhang at redhat.com>
Fixes 3a85a5de29ea ("nvme-loop: add a NVMe loopback host driver")
Cc Yi Zhang <yi.zhang at redhat.com>
Cc Sagi Grimberg <sagi at grimberg.me>
Cc Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
Cc <stable at vger.kernel.org>
Signed-off-by Ming Lei <ming.lei at redhat.com>
---
 drivers/nvme/target/loop.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/nvme/target/loop.c +3 -0
index b9f623ab01f3..7194f86b9dac 100644
@@ -549,6 +549,9 @@ static int nvme_loop_create_io_queues(struct nvme_loop_ctrl *ctrl)
 	if (ret)
 		goto out_cleanup_connect_q;
 
+	/* target only accepts single-page sg list */
+	blk_queue_segment_boundary(ctrl->ctrl.connect_q, PAGE_SIZE - 1);
+
 	return 0;
 
 out_cleanup_connect_q:
Signature · 1 line
2.9.5
#1 lore raw

PATCH RESEND 1/1 nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1

Quoted 6 lines · Ming Lei

NVMe target only accepts single-page sg list, either file or block device backed target code follows this assumption.

However, loop target is one exception, given the sg list is from the host queue directly.

Quoted 6 lines

This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 for following NVMe target assumption.

Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36 ("nvmet: fix building bvec from sg list") can fix the current issue simply without needing to limit the segment size for nvme-loop.

I don't understand, 02db99548d36 does not work for older kernels, so because of that, you need/want this patch to be applied? If so, what specific kernel versions do you want this to go to?

thanks,

greg k-h

author
#2 lore raw

PATCH RESEND 1/1 nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1

Quoted 10 lines · Greg KH
Quoted 9 lines · Ming Lei

NVMe target only accepts single-page sg list, either file or block device backed target code follows this assumption.

However, loop target is one exception, given the sg list is from the host queue directly.

This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 for following NVMe target assumption.

Quoted 7 lines
Quoted 3 lines

Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36 ("nvmet: fix building bvec from sg list") can fix the current issue simply without needing to limit the segment size for nvme-loop.

I don't understand, 02db99548d36 does not work for older kernels, so because of that, you need/want this patch to be applied? If so, what specific kernel versions do you want this to go to?

Old kernel needs both this patch and 02db99548d36, and you should see the description in 02db99548d36 commit log too.

This patch should be needed since nvme-loop is introduced.

Thanks,
Ming

#3 lore raw

PATCH RESEND 1/1 nvmet: set loop queue's segment boundary mask as PAGE_SIZE - 1

Quoted 15 lines · Ming Lei
Quoted 14 lines · Greg KH
Quoted 12 lines · Ming Lei

NVMe target only accepts single-page sg list, either file or block device backed target code follows this assumption.

However, loop target is one exception, given the sg list is from the host queue directly.

This patch sets loop queue's segment boundary mask as PAGE_SIZE - 1 for following NVMe target assumption.

Multi-page bvec has been merged to v5.1-rc1, so commit 02db99548d36 ("nvmet: fix building bvec from sg list") can fix the current issue simply without needing to limit the segment size for nvme-loop.

Quoted 8 lines
Quoted 3 lines

I don't understand, 02db99548d36 does not work for older kernels, so because of that, you need/want this patch to be applied? If so, what specific kernel versions do you want this to go to?

Old kernel needs both this patch and 02db99548d36, and you should see the description in 02db99548d36 commit log too.

This patch should be needed since nvme-loop is introduced.

I'm sorry, I still do not understand. Please resend the patches that you wish to have applied, with the proper git commit ids, and let us know what trees they should be applied to. I can not parse the above text, sorry.

greg k-h