Skip to contentSkip to conversation

staging: rtl8188eu: remove unnecessary declaration

PATCH New Michael Straube 1 participant 2 messages Apr 3, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 staging: rtl8188eu: remove unnecessary declaration

The declaration of sta2sta_data_frame() is directly above the function definition. Remove the unnecessary declaration.

This also clears a checkpatch issue.
CHECK: Lines should not end with a '('

---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/staging/rtl8188eu/core/rtw_recv.c +0 -6
index b7abe8c7c8cd..3a621d58e53d 100644
@@ -632,12 +632,6 @@ static void count_rx_stats(struct adapter *padapter,
 	}
 }
 
-int sta2sta_data_frame(
-	struct adapter *adapter,
-	struct recv_frame *precv_frame,
-	struct sta_info **psta
-);
-
 int sta2sta_data_frame(struct adapter *adapter, struct recv_frame *precv_frame,
 		       struct sta_info **psta)
 {
Signature · 1 line
2.21.0
#1 lore raw

PATCH 2/2 staging: rtl8188eu: make sta2sta_data_frame() static

Function sta2sta_data_frame() is only used in rtw_recv.c. So make it static.

---
 drivers/staging/rtl8188eu/core/rtw_recv.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/rtl8188eu/core/rtw_recv.c +3 -2
index 3a621d58e53d..087f6c9a5826 100644
@@ -632,8 +632,9 @@ static void count_rx_stats(struct adapter *padapter,
 	}
 }
 
-int sta2sta_data_frame(struct adapter *adapter, struct recv_frame *precv_frame,
-		       struct sta_info **psta)
+static int sta2sta_data_frame(struct adapter *adapter,
+			      struct recv_frame *precv_frame,
+			      struct sta_info **psta)
 {
 	int ret = _SUCCESS;
 	struct rx_pkt_attrib *pattrib = &precv_frame->attrib;
Signature · 1 line
2.21.0