of: Improve of_phandle_iterator_next() error message
PATCH 1/1 of: Improve of_phandle_iterator_next() error message
Understanding why of_phandle_iterator_next() returns an error can sometimes be hard to decipher based solely on the error message, a typical error example is that #foo-cells = <X> and the phandle property used has a smaller number of cells specified, e.g.:
#thermal-sensor-cells = <1>; phandle = <&scmi_sensor>
instead of:
phandle <&scmi_sensor 0>;
Instead, make it clear what the expectations are towards debugging incorrect Device Tree faster:
OF: /thermal-zones/scmi-thermal: #thermal-sensor-cells = 1, found 0 instead
--- drivers/of/base.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/of/base.c +3 -2
@@ -1350,8 +1350,9 @@ int of_phandle_iterator_next(struct of_phandle_iterator *it)* property data length */ if (it->cur + count > it->list_end) { -pr_err ("%pOF: arguments longer than property\n" , - it->parent); +pr_err ("%pOF: %s = %d found %d\n" , + it->parent, it->cells_name, + count, it->cell_count); goto err; } }
Signature · 1 line
2.17.1
Quoted 15 lines · Florian Fainelli
Understanding why
of_phandle_iterator_next()returns an error can sometimes be hard to decipher based solely on the error message, a typical error example is that #foo-cells = <X> and the phandle property used has a smaller number of cells specified, e.g.:#thermal-sensor-cells = <1>; phandle = <&scmi_sensor>instead of:
phandle <&scmi_sensor 0>;Instead, make it clear what the expectations are towards debugging incorrect Device Tree faster:
Quoted 6 lines
OF: /thermal-zones/scmi-thermal: #thermal-sensor-cells = 1, found 0 instead
Signed-off-by Florian Fainelli <[email protected]>--- drivers/of/base.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Applied.
Rob