mmc: mtk-sd: check for valid optional memory resource
Subsystems (3)
PATCH v2 1/1 mmc: mtk-sd: check for valid optional memory resource
'top_base' memory region is optional. Check that the resource is valid before using it. This avoid getting a "invalid resource" error message printed by the kernel.
Signed-off-by Fabien Parent <[email protected]>
---
V2:
Fix invalid condition: check against 'res' variable instead of 'ret'.
--- drivers/mmc/host/mtk-sd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/mmc/host/mtk-sd.c +5 -3
@@ -2123,9 +2123,11 @@ static int msdc_drv_probe(struct platform_device *pdev) } res =platform_get_resource (pdev,IORESOURCE_MEM ,1 ); - host->top_base =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (host->top_base)) - host->top_base =NULL ; +if (res) { + host->top_base =devm_ioremap_resource (&pdev->dev, res); +if (IS_ERR (host->top_base)) + host->top_base =NULL ; + } ret =mmc_regulator_get_supply (mmc);if (ret)
Signature · 1 line
2.20.1
Quoted 6 lines · Fabien Parent
'
top_base' memory region is optional. Check that the resource is valid before using it. This avoid getting a "invalid resource" error message printed by the kernel.Signed-off-by Fabien Parent <[email protected]>
Applied for next, thanks!
Kind regards
Uffe
Quoted 31 lines
---
V2:
Fix invalid condition: check against 'res' variable instead of 'ret'.--- drivers/mmc/host/mtk-sd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)drivers/mmc/host/mtk-sd.c +5
-4@@ -2123,9 +2123,11 @@ static int msdc_drv_probe(struct platform_device *pdev) } res =platform_get_resource (pdev,IORESOURCE_MEM ,1 ); - host->top_base =devm_ioremap_resource (&pdev->dev, res); -if (IS_ERR (host->top_base)) - host->top_base =NULL ; +if (res) { + host->top_base =devm_ioremap_resource (&pdev->dev, res); +if (IS_ERR (host->top_base)) + host->top_base =NULL ; + } ret =mmc_regulator_get_supply (mmc);if (ret) --2.20.1