Skip to contentSkip to conversation

gnome-desktop3: remove gconf from DEPENDS

PATCH In review Andreas Müller 2 participants 4 messages Apr 3, 2019 – Apr 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 gnome-desktop3: remove gconf from DEPENDS

Modern gnome does not use gconf anymore.

---
 meta-gnome/recipes-gnome/gnome-desktop/gnome-desktop3_3.32.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-gnome/recipes-gnome/gnome-desktop/gnome-desktop3_3.32.0.bb +1 -1
index 185a25359..c1a67bda9 100644
@@ -15,7 +15,7 @@ SRC_URI[archive.sha256sum] = "a6393dc5fc29fc0652ac84c73b3da205d0b0168128c4cf6d27
 
 SRC_URI += "file://gnome-desktop-thumbnail-don-t-assume-time_t-is-long.patch"
 
-DEPENDS += "itstool-native gsettings-desktop-schemas gconf virtual/libx11 gtk+3 glib-2.0 startup-notification xkeyboard-config iso-codes udev"
+DEPENDS += "itstool-native gsettings-desktop-schemas virtual/libx11 gtk+3 startup-notification xkeyboard-config iso-codes udev"
 
 inherit distro_features_check gtk-doc
 REQUIRED_DISTRO_FEATURES = "x11"
Signature · 1 line
2.20.1
#1 lore raw

PATCH 2/2 gnome-desktop3: rework gobject-introspection handling

gobject-introspection is mandatory for gnome-desktop3 - there is no configure option to enable or disable it.

To handle properly, this patch does:

* Make 'gobject-introspection-data' a required distro feature
* To avoid trouble once pending patch removing
'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
are in oe-core [1] - set in recipe to avoid
| ERROR: gnome-desktop3-3.32.0-r0 do_configure: QA Issue: gnome-desktop3: configure was passed unrecognised options: introspection [unknown-configure-option]

This does not handle MACHINE_FEATURES / qemu-usermode case but there other issues of higher priority.

[1] http://lists.openembedded.org/pipermail/openembedded-core/2019-April/280711.html

---
 .../recipes-gnome/gnome-desktop/gnome-desktop3_3.32.0.bb    | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
meta-gnome/recipes-gnome/gnome-desktop/gnome-desktop3_3.32.0.bb +5 -1
index c1a67bda9..bba81663d 100644
@@ -8,7 +8,11 @@ BPN = "gnome-desktop"
 
 GNOMEBASEBUILDCLASS = "meson"
 
-inherit gnome pkgconfig upstream-version-is-even gobject-introspection
+inherit gnome pkgconfig upstream-version-is-even gobject-introspection distro_features_check
+
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " introspection"
 
 SRC_URI[archive.md5sum] = "e423ed6d648c6c4f9798fa9cd9ea8d99"
 SRC_URI[archive.sha256sum] = "a6393dc5fc29fc0652ac84c73b3da205d0b0168128c4cf6d27797a08f3d07b54"
Signature · 1 line
2.20.1
#2 lore raw
In reply to Andreas Müller

Andreas

I am seeing this

https://errors.yoctoproject.org/Errors/Details/235565/

Maybe turning libseccomp into packageconfig and disabling it by default would be right thing here

Quoted 29 lines · Andreas Müller

Modern gnome does not use gconf anymore.

---
 meta-gnome/recipes-gnome/gnome-desktop/gnome-desktop3_3.32.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-gnome/recipes-gnome/gnome-desktop/gnome-desktop3_3.32.0.bb +1 -2
index 185a25359..c1a67bda9 100644
@@ -15,7 +15,7 @@ SRC_URI[archive.sha256sum] = "a6393dc5fc29fc0652ac84c73b3da205d0b0168128c4cf6d27
 
 SRC_URI += "file://gnome-desktop-thumbnail-don-t-assume-time_t-is-long.patch"
 
-DEPENDS += "itstool-native gsettings-desktop-schemas gconf virtual/libx11 gtk+3 glib-2.0 startup-notification xkeyboard-config iso-codes udev"
+DEPENDS += "itstool-native gsettings-desktop-schemas virtual/libx11 gtk+3 startup-notification xkeyboard-config iso-codes udev"
 
 inherit distro_features_check gtk-doc
 REQUIRED_DISTRO_FEATURES = "x11"
--

2.20.1

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel