Skip to contentSkip to conversation

utils/getdeveloperlib.py: print warnings/errors to stderr

PATCH New Peter Korsgaard 1 participant 2 messages Apr 4, 2019 – Apr 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 utils/getdeveloperlib.py: print warnings/errors to stderr

Instead of stdout where it gets mixed with the normal output, confusing software parsing the output (E.G. get-developers -e as git sendemail.ccCmd).

---
 utils/getdeveloperlib.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
utils/getdeveloperlib.py +8 -3
index 2c8d477583..35c618f791 100644
@@ -1,7 +1,9 @@
+from __future__ import print_function
 import os
 import re
 import glob
 import subprocess
+import sys
 
 #
 # Patch parsing functions
@@ -167,13 +169,15 @@ def parse_developers(basepath=None):
                 continue
             elif line.startswith("N:"):
                 if name is not None or len(files) != 0:
-                    print("Syntax error in DEVELOPERS file, line %d" % linen)
+                    print("Syntax error in DEVELOPERS file, line %d" % linen,
+                          file=sys.stderr)
                 name = line[2:].strip()
             elif line.startswith("F:"):
                 fname = line[2:].strip()
                 dev_files = glob.glob(os.path.join(basepath, fname))
                 if len(dev_files) == 0:
-                    print("WARNING: '%s' doesn't match any file" % fname)
+                    print("WARNING: '%s' doesn't match any file" % fname,
+                          file=sys.stderr)
                 files += dev_files
             elif line == "":
                 if not name:
@@ -182,7 +186,8 @@ def parse_developers(basepath=None):
                 files = []
                 name = None
             else:
-                print("Syntax error in DEVELOPERS file, line %d: '%s'" % (linen, line))
+                print("Syntax error in DEVELOPERS file, line %d: '%s'" % (linen, line),
+                      file=sys.stderr)
                 return None
             linen += 1
     # handle last developer
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 utils/getdeveloperlib.py: print warnings/errors to stderr

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Korsgaard <[email protected]> writes:

Instead of stdout where it gets mixed with the normal output, confusing software parsing the output (E.G. get-developers -e as git sendemail.ccCmd).

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard