drm/i915/gvt: Annotate iomem usage
PATCH 1/1 drm/i915/gvt: Annotate iomem usage
Fix the sparse warning for blithely using iomem with normal memcpy:
drivers/gpu/drm/i915/gvt/kvmgt.c:916:21: warning: incorrect type in assignment (different address spaces)drivers/gpu/drm/i915/gvt/kvmgt.c:916:21: expected void *aperture_vadrivers/gpu/drm/i915/gvt/kvmgt.c:916:21: got void [noderef] <asn:2> *drivers/gpu/drm/i915/gvt/kvmgt.c:927:26: warning: incorrect type in argument 1 (different address spaces)drivers/gpu/drm/i915/gvt/kvmgt.c:927:26: expected void [noderef] <asn:2> *vaddrdrivers/gpu/drm/i915/gvt/kvmgt.c:927:26: got void *aperture_va
--- drivers/gpu/drm/i915/gvt/kvmgt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gvt/kvmgt.c +3 -3
@@ -905,7 +905,7 @@ static inline bool intel_vgpu_in_aperture(struct intel_vgpu *vgpu, u64 off)static int intel_vgpu_aperture_rw (struct intel_vgpu *vgpu,u64 off,void *buf,unsigned long count,bool is_write) { -void *aperture_va; +void __iomem *aperture_va;if (!intel_vgpu_in_aperture (vgpu, off) || !intel_vgpu_in_aperture (vgpu, off + count)) {
@@ -920,9 +920,9 @@ static int intel_vgpu_aperture_rw(struct intel_vgpu *vgpu, u64 off,return -EIO ;if (is_write) -memcpy (aperture_va +offset_in_page (off), buf, count); +memcpy_toio (aperture_va +offset_in_page (off), buf, count);else -memcpy (buf, aperture_va +offset_in_page (off), count); +memcpy_fromio (buf, aperture_va +offset_in_page (off), count);io_mapping_unmap (aperture_va);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 34 lines · Chris Wilson
Fix the sparse warning for blithely using iomem with normal memcpy:
drivers/gpu/drm/i915/gvt/kvmgt.c:916:21: warning: incorrect type in assignment (different address spaces)drivers/gpu/drm/i915/gvt/kvmgt.c:916:21: expected void*aperture_vadrivers/gpu/drm/i915/gvt/kvmgt.c:916:21: got void [noderef] <asn:2> *drivers/gpu/drm/i915/gvt/kvmgt.c:927:26: warning: incorrect type in argument 1 (different address spaces)drivers/gpu/drm/i915/gvt/kvmgt.c:927:26: expected void [noderef] <asn:2> *vaddrdrivers/gpu/drm/i915/gvt/kvmgt.c:927:26: got void*aperture_vaFixes d480b28a41a6 ("drm/i915/gvt: Fix aperture read/write emulation when enable x-no-mmap=on")Signed-off-by Chris Wilson <[email protected]>Cc Zhenyu Wang <[email protected]>Cc Changbin Du <[email protected]>Cc Zhi Wang <[email protected]>--- drivers/gpu/drm/i915/gvt/kvmgt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/gvt/kvmgt.c +1
-1@@ -905,7 +905,7 @@ static inline bool intel_vgpu_in_aperture(struct intel_vgpu *vgpu, u64 off)static int intel_vgpu_aperture_rw (struct intel_vgpu *vgpu,u64 off,void *buf,unsigned long count,bool is_write) { -void *aperture_va; +void __iomem *aperture_va;if (!intel_vgpu_in_aperture (vgpu, off) || !intel_vgpu_in_aperture (vgpu, off + count)) {@@ -920,9 +920,9 @@ static int intel_vgpu_aperture_rw(struct intel_vgpu *vgpu, u64 off,return -EIO ;
drivers/gpu/drm/i915/gvt/kvmgt.c static int intel_vgpu_aperture_rw(struct intel_vgpu *vgpu, u64 off, · line 928
Quoted 10 lines
drivers/gpu/drm/i915/gvt/kvmgt.c +2
-2if (is_write) -memcpy (aperture_va +offset_in_page (off), buf, count); +memcpy_toio (aperture_va +offset_in_page (off), buf, count);else -memcpy (buf, aperture_va +offset_in_page (off), count); +memcpy_fromio (buf, aperture_va +offset_in_page (off), count);io_mapping_unmap (aperture_va);
thanks!
Signature · 3 lines
Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915/gvt: Annotate iomem usage
In reply to Chris Wilson== Series Details ==
== Series Details ==
Series: drm/i915/gvt: Annotate iomem usage
URL : https://patchwork.freedesktop.org/series/58979/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5869 -> Patchwork_12679
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_12679 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_12679, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/58979/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_12679:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_contexts:
- fi-skl-gvtdvm: PASS -> DMESG-FAIL
Known issues
------------
Here are the changes found in Patchwork_12679 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_basic@gtt-bsd2:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] +57
* igt@i915_module_load@reload-with-fault-injection:
- fi-icl-y: PASS -> INCOMPLETE [fdo#107713]
* igt@kms_busy@basic-flip-a:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_busy@basic-flip-c:
- fi-byt-clapper: NOTRUN -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_chamelium@hdmi-crc-fast:
- fi-bsw-n3050: NOTRUN -> SKIP [fdo#109271] +62
* igt@kms_frontbuffer_tracking@basic:
- fi-byt-clapper: NOTRUN -> FAIL [fdo#103167]
* igt@runner@aborted:
- fi-bxt-dsi: NOTRUN -> FAIL [fdo#109516]
#### Possible fixes ####
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: FAIL [fdo#104008] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#104008]: https://bugs.freedesktop.org/show_bug.cgi?id=104008
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109516]: https://bugs.freedesktop.org/show_bug.cgi?id=109516
Participating hosts (47 -> 39)
------------------------------
Additional (3): fi-bxt-dsi fi-byt-clapper fi-bsw-n3050
Missing (11): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bsw-cyan fi-apl-guc fi-ctg-p8600 fi-gdg-551 fi-blb-e6850 fi-skl-6600u
Build changes
-------------
* Linux: CI_DRM_5869 -> Patchwork_12679
CI_DRM_5869: 03f8f3298b90c7f80da6a98c3eb8413d7aeaa52b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4926: c9a9cf357b6b2a304623790bf8dae797e12888a8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_12679: 7cee7bb7c94374460425ace810fb3d7f394e6537 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7cee7bb7c943 drm/i915/gvt: Annotate iomem usage
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_12679/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx