Skip to contentSkip to conversation

soundwire: cdns: Fix compilation error on arm64

PATCH Applied Jan Kotas 4 participants 7 messages Apr 4, 2019 – May 27, 2019 SoundWire

lore
Share & tools
lore

Jan Kotas

author
#0 lore raw

PATCH 1/1 soundwire: cdns: Fix compilation error on arm64

On arm64 the cadence_master.c file doesn't compile.

readl and writel are undefined.
This patch fixes that by including io.h.

---
 drivers/soundwire/cadence_master.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soundwire/cadence_master.c +1 -0
index cb6a331f4..0b5bcc209 100644
@@ -9,6 +9,7 @@
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/soundwire/sdw_registers.h>
Signature · 1 line
2.15.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jan Kotas

On arm64 the cadence_master.c file doesn't compile.

readl and writel are undefined.
This patch fixes that by including io.h.

Cheers,
-Mukesh

Quoted 16 lines
---
  drivers/soundwire/cadence_master.c | 1 +
  1 file changed, 1 insertion(+)
drivers/soundwire/cadence_master.c +1 -0
index cb6a331f4..0b5bcc209 100644
@@ -9,6 +9,7 @@
  #include <linux/delay.h>
  #include <linux/device.h>
  #include <linux/interrupt.h>
+#include <linux/io.h>
  #include <linux/module.h>
  #include <linux/mod_devicetable.h>
  #include <linux/soundwire/sdw_registers.h>
maintainer
#2 lore raw
In reply to Jan Kotas
Quoted 4 lines · Jan Kotas

On arm64 the cadence_master.c file doesn't compile.

readl and writel are undefined.
This patch fixes that by including io.h.

And I cant verify that without hacking kconfig to force compile the lib.

Quoted 11 lines
---
 drivers/soundwire/cadence_master.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soundwire/cadence_master.c +0 -0
index cb6a331f4..0b5bcc209 100644

drivers/soundwire/cadence_master.c line 12

Quoted 4 lines
drivers/soundwire/cadence_master.c +1 -0
@@ -9,6 +9,7 @@
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>

Why not add asm/io.h which is the header that actually defines readl/writel?

Quoted 5 lines
drivers/soundwire/cadence_master.c +0 -0
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/soundwire/sdw_registers.h>
Signature · 1 line
2.15.0
Signature · 1 line
~Vinod
#3 lore raw
Quoted 13 lines

drivers/soundwire/cadence_master.c line 12

Quoted 10 lines
drivers/soundwire/cadence_master.c +1 -0
index cb6a331f4..0b5bcc209 100644
@@ -9,6 +9,7 @@
  #include <linux/delay.h>
  #include <linux/device.h>
  #include <linux/interrupt.h>
+#include <linux/io.h>

Why not add asm/io.h which is the header that actually defines readl/writel?

The vast majority of kernel code uses linux/io.h.
We use linux/io.h for SOF as well.

Quoted 7 lines
Quoted 6 lines
drivers/soundwire/cadence_master.c +0 -0
  #include <linux/module.h>
  #include <linux/mod_devicetable.h>
  #include <linux/soundwire/sdw_registers.h>
Signature · 1 line
2.15.0
author
#4 lore raw
Quoted 10 lines · Vinod Koul
Quoted 4 lines · Jan Kotas

On arm64 the cadence_master.c file doesn't compile.

readl and writel are undefined.
This patch fixes that by including io.h.

And I cant verify that without hacking kconfig to force compile the lib.

I’m working on a new driver which uses the SOUNDWIRE_CADENCE:
Here’s a diff of the Kconfig, it’s a very early stage.

drivers/soundwire/Kconfig +6 -0
index 19c8efb9a..90d569e03 100644
@@ -34,4 +34,10 @@ config SOUNDWIRE_INTEL
      enable this config option to get the SoundWire support for that
      device.
 
+config SOUNDWIRE_CADENCE_PLATFORM
+   tristate "SoundWire Cadence Platform driver"
+   select SOUNDWIRE_CADENCE
+   select SOUNDWIRE_BUS
+   help
+     SoundWire Cadence Platform drivers.
 endif

I haven’t modified any of the existing lines. SOUNDWIRE_CADENCE doesn’t depend on anything, except SOUNDWIRE, so it should work, when selected.

Quoted 15 lines · Pierre-Louis Bossart
Quoted 13 lines

drivers/soundwire/cadence_master.c line 12

Quoted 11 lines
drivers/soundwire/cadence_master.c +1 -0
index cb6a331f4..0b5bcc209 100644
@@ -9,6 +9,7 @@
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>

Why not add asm/io.h which is the header that actually defines readl/writel?

Quoted 2 lines

The vast majority of kernel code uses linux/io.h.
We use linux/io.h for SOF as well.

I use linux/io.h in my other drivers too.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/soundwire/cadence_master.c +0 -0
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/soundwire/sdw_registers.h>
Signature · 1 line
2.15.0
author
#5 lore raw

Hello,

Is there a reason for not accepting this patch?
Do you want me to change anything in v2?

Regards,
Jan

Quoted 51 lines · Jan Kotas
Quoted 11 lines · Vinod Koul
Quoted 4 lines · Jan Kotas

On arm64 the cadence_master.c file doesn't compile.

readl and writel are undefined.
This patch fixes that by including io.h.

And I cant verify that without hacking kconfig to force compile the lib.

I’m working on a new driver which uses the SOUNDWIRE_CADENCE:
Here’s a diff of the Kconfig, it’s a very early stage.

drivers/soundwire/Kconfig +6 -0
index 19c8efb9a..90d569e03 100644
@@ -34,4 +34,10 @@ config SOUNDWIRE_INTEL
     enable this config option to get the SoundWire support for that
     device.
 
+config SOUNDWIRE_CADENCE_PLATFORM
+   tristate "SoundWire Cadence Platform driver"
+   select SOUNDWIRE_CADENCE
+   select SOUNDWIRE_BUS
+   help
+     SoundWire Cadence Platform drivers.

endif

I haven’t modified any of the existing lines. SOUNDWIRE_CADENCE doesn’t depend on anything, except SOUNDWIRE, so it should work, when selected.

Quoted 15 lines · Pierre-Louis Bossart
Quoted 13 lines

drivers/soundwire/cadence_master.c line 12

Quoted 11 lines
drivers/soundwire/cadence_master.c +1 -0
index cb6a331f4..0b5bcc209 100644
@@ -9,6 +9,7 @@
 #include <linux/delay.h>
 #include <linux/device.h>
 #include <linux/interrupt.h>
+#include <linux/io.h>

Why not add asm/io.h which is the header that actually defines readl/writel?

Quoted 11 lines
Quoted 2 lines

The vast majority of kernel code uses linux/io.h.
We use linux/io.h for SOF as well.

I use linux/io.h in my other drivers too.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
drivers/soundwire/cadence_master.c +0 -0
 #include <linux/module.h>
 #include <linux/mod_devicetable.h>
 #include <linux/soundwire/sdw_registers.h>
Signature · 1 line
2.15.0

_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

maintainer Applied
#6 lore raw
In reply to Jan Kotas
Quoted 4 lines · Jan Kotas

On arm64 the cadence_master.c file doesn't compile.

readl and writel are undefined.
This patch fixes that by including io.h.

Applied, thanks

Signature · 1 line
~Vinod