dt-bindings: phy: tegra-xusb: List PLL power supplies
PATCH 1/8 dt-bindings: phy: tegra-xusb: List PLL power supplies
From: Thierry Reding <[email protected]>
These power supplies provide power for various PLLs that are set up and driven by the XUSB pad controller. These power supplies were previously improperly added to the PCIe and XUSB controllers, but depending on the driver probe order, power to the PLLs will not be supplied soon enough and cause initialization to fail.
--- .../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)
Documentation/devicetree/bindings/phy/nvidia,tegra124-xusb-padctl.txt +12 -0
@@ -42,6 +42,18 @@ Required properties: - reset-names: Must include the following entries: - "padctl" +For Tegra124: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-erefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- avdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 3.3 V. + +For Tegra210: +- avdd-pll-utmip-supply: UTMI PLL power supply. Must supply 1.8 V. +- avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V. +- dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V. +- hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V. + For Tegra186: - avdd-pll-erefeut-supply: UPHY brick and reference clock as well as UTMI PHY power supply. Must supply 1.8 V.
Signature · 1 line
2.21.0
PATCH 2/8 ARM: tegra: apalis: Move PLL power supplies to XUSB pad controller
From: Thierry Reding <[email protected]>
The XUSB pad controller is responsible for supplying power to the PLLs used to drive the various USB, PCI and SATA pads. Move the PLL power supplies from the PCIe and XUSB controllers to the XUSB pad controller to make sure they are available when needed.
--- arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 7 +++++++ arch/arm/boot/dts/tegra124-apalis.dtsi | 5 +++++ 2 files changed, 12 insertions(+)
arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi +7 -0
@@ -17,6 +17,7 @@ pcie@1003000 { status = "okay"; + avddio-pex-supply = <®_1v05_vdd>; avdd-pex-pll-supply = <®_1v05_vdd>; avdd-pll-erefe-supply = <®_1v05_avdd>;
@@ -1796,6 +1797,7 @@ <&{/padctl@7009f000/pads/usb2/lanes/usb2-2}>, <&{/padctl@7009f000/pads/pcie/lanes/pcie-0}>; phy-names = "usb2-0", "usb3-1", "usb2-1", "usb2-2", "usb3-0"; + avddio-pex-supply = <®_1v05_vdd>; avdd-pll-erefe-supply = <®_1v05_avdd>; avdd-pll-utmip-supply = <®_1v8_vddio>;
@@ -1807,6 +1809,11 @@ }; padctl@7009f000 { + avdd-pll-utmip-supply = <®_1v8_vddio>; + avdd-pll-erefe-supply = <®_1v05_avdd>; + avdd-pex-pll-supply = <®_1v05_vdd>; + hvdd-pex-pll-e-supply = <®_module_3v3>; + pads { usb2 { status = "okay";
arch/arm/boot/dts/tegra124-apalis.dtsi +5 -0
@@ -1837,6 +1837,11 @@ }; padctl@7009f000 { + avdd-pll-utmip-supply = <®_1v8_vddio>; + avdd-pll-erefe-supply = <®_1v05_avdd>; + avdd-pex-pll-supply = <®_1v05_vdd>; + hvdd-pex-pll-e-supply = <®_module_3v3>; + pads { usb2 { status = "okay";
Signature · 1 line
2.21.0
PATCH 3/8 ARM: tegra: jetson-tk1: Move PLL power supplies to XUSB pad controller
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The XUSB pad controller is responsible for supplying power to the PLLs used to drive the various USB, PCI and SATA pads. Move the PLL power supplies from the PCIe and XUSB controllers to the XUSB pad controller to make sure they are available when needed.
--- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tegra124-jetson-tk1.dts +5 -0
@@ -1721,6 +1721,11 @@ padctl@7009f000 { status = "okay"; + avdd-pll-utmip-supply = <&vddio_1v8>; + avdd-pll-erefe-supply = <&avdd_1v05_run>; + avdd-pex-pll-supply = <&vdd_1v05_run>; + hvdd-pex-pll-e-supply = <&vdd_3v3_lp0>; + pads { usb2 { status = "okay";
Signature · 1 line
2.21.0
PATCH 4/8 ARM: tegra: nyan: Move PLL power supplies to XUSB pad controller
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The XUSB pad controller is responsible for supplying power to the PLLs used to drive the various USB, PCI and SATA pads. Move the PLL power supplies from the XUSB controller to the XUSB pad controller to make sure they are available when needed.
--- arch/arm/boot/dts/tegra124-nyan.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tegra124-nyan.dtsi +5 -0
@@ -414,6 +414,11 @@ padctl@7009f000 { status = "okay"; + avdd-pll-utmip-supply = <&vddio_1v8>; + avdd-pll-erefe-supply = <&avdd_1v05_run>; + avdd-pex-pll-supply = <&vdd_1v05_run>; + hvdd-pex-pll-e-supply = <&vdd_3v3_lp0>; + pads { usb2 { status = "okay";
Signature · 1 line
2.21.0
PATCH 5/8 ARM: tegra: venice2: Move PLL power supplies to XUSB pad controller
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The XUSB pad controller is responsible for supplying power to the PLLs used to drive the various USB, PCI and SATA pads. Move the PLL power supplies from the PCIe and XUSB controllers to the XUSB pad controller to make sure they are available when needed.
--- arch/arm/boot/dts/tegra124-venice2.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm/boot/dts/tegra124-venice2.dts +5 -0
@@ -921,6 +921,11 @@ }; padctl@7009f000 { + avdd-pll-utmip-supply = <&vddio_1v8>; + avdd-pll-erefe-supply = <&avdd_1v05_run>; + avdd-pex-pll-supply = <&vdd_1v05_run>; + hvdd-pex-pll-e-supply = <&vdd_3v3_lp0>; + pads { usb2 { status = "okay";
Signature · 1 line
2.21.0
PATCH 6/8 arm64: tegra: jetson-tx1: Move PLL power supplies to XUSB pad controller
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The XUSB pad controller is responsible for supplying power to the PLLs used to drive the various USB, PCI and SATA pads. Move the PLL power supplies from the PCIe and XUSB controllers to the XUSB pad controller to make sure they are available when needed.
--- arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi +5 -0
@@ -1352,6 +1352,11 @@ padctl@7009f000 { status = "okay"; + avdd-pll-utmip-supply = <&vdd_1v8>; + avdd-pll-uerefe-supply = <&avdd_1v05_pll>; + dvdd-pex-pll-supply = <&vdd_pex_1v05>; + hvdd-pex-pll-e-supply = <&vdd_1v8>; + pads { usb2 { status = "okay";
Signature · 1 line
2.21.0
PATCH v2 8/8 arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The Jetson Nano Developer Kit is a Tegra X1 based development board. It is similar to Jetson TX1 but it is not pin compatible. It features 4 GB of LPDDR4, an SPI NOR flash for early boot firmware and an SD card slot used for storage.
HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB 2.0 and 1 USB 3.0) can be used to attach a variety of peripherals and a PCI Ethernet controller provides onboard network connectivity.
A 40-pin header on the board can be used to extend the capabilities and exposed interfaces of the Jetson Nano.
---
Changes in v2:
- add obsolete PCIe and XUSB power supplies for backwards compatibility
- remove pinmux node
arch/arm64/boot/dts/nvidia/Makefile | 1 + .../boot/dts/nvidia/tegra210-p3450-0000.dts | 648 ++++++++++++++++++ 2 files changed, 649 insertions(+) create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts
arch/arm64/boot/dts/nvidia/Makefile +1 -0
@@ -3,6 +3,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb +dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p3450-0000.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2894-0050-a08.dtb dtb-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186-p2771-0000.dtb
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts new file +648 -0
648 lines not on this page · raw message
Signature · 1 line
2.21.0
Re: [PATCH v2 8/8] arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support
Quoted 24 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The Jetson Nano Developer Kit is a Tegra X1 based development board. It is similar to Jetson TX1 but it is not pin compatible. It features 4 GB of LPDDR4, an SPI NOR flash for early boot firmware and an SD card slot used for storage.
HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB 2.0 and 1 USB 3.0) can be used to attach a variety of peripherals and a PCI Ethernet controller provides onboard network connectivity.
A 40-pin header on the board can be used to extend the capabilities and exposed interfaces of the Jetson Nano.
Signed-off-by Thierry Reding <[email protected]>---
Changes in v2:
- add obsolete PCIe and XUSB power supplies for backwards compatibility
- remove pinmux nodearch/arm64/boot/dts/nvidia/Makefile | 1 + .../boot/dts/nvidia/tegra210-p3450-0000.dts | 648 ++++++++++++++++++ 2 files changed, 649 insertions(+) create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts
...
Review
Quoted 2 lines
(quoted diff) +2
-0+ hda@70030000 { + status = "okay";
Do you mind adding the following here ...
nvidia,model = "jetson-nano-hda";
This will be consistent with what Sameer has added for Jetson TX1, TX2 and Xavier. Probably not so important for Tegra210 because there is only one output stream but nonetheless consistent.
Otherwise ...
Cheers
Jon
Signature · 1 line
nvpublic
Re: [PATCH v2 8/8] arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support
Quoted 4 lines · Jon Hunter
Quoted 2 lines · Thierry Reding
From: Thierry Reding <[email protected]>
Quoted 8 lines
Quoted 8 lines
The Jetson Nano Developer Kit is a Tegra X1 based development board. It is similar to Jetson TX1 but it is not pin compatible. It features 4 GB of LPDDR4, an SPI NOR flash for early boot firmware and an SD card slot used for storage.
HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB 2.0 and 1 USB 3.0) can be used to attach a variety of peripherals and a PCI Ethernet controller provides onboard network connectivity.
Nano also has an open M.2 Key-E slot with another PCIe root port being used for this slot.
Quoted 35 lines
Quoted 14 lines
A 40-pin header on the board can be used to extend the capabilities and exposed interfaces of the Jetson Nano.
Signed-off-by Thierry Reding <[email protected]>---
Changes in v2:
- add obsolete PCIe and XUSB power supplies for backwards compatibility
- remove pinmux nodearch/arm64/boot/dts/nvidia/Makefile | 1 + .../boot/dts/nvidia/tegra210-p3450-0000.dts | 648 ++++++++++++++++++ 2 files changed, 649 insertions(+)create mode 100644
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts...
Review
Quoted 2 lines
(quoted diff) +2
-0+ hda@70030000 { + status = "okay";Do you mind adding the following here ...
nvidia,model = "jetson-nano-hda";This will be consistent with what Sameer has added for Jetson TX1, TX2 and Xavier. Probably not so important for Tegra210 because there is only one output stream but nonetheless consistent.
Otherwise ...
Acked-by Jon Hunter <[email protected]>Cheers
Jon
Re: [PATCH v2 8/8] arm64: tegra: Add NVIDIA Jetson Nano Developer Kit support
In reply to Thierry RedingQuoted 67 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The Jetson Nano Developer Kit is a Tegra X1 based development board. It is similar to Jetson TX1 but it is not pin compatible. It features 4 GB of LPDDR4, an SPI NOR flash for early boot firmware and an SD card slot used for storage.
HDMI 2.0 or DP 1.2 are available for display, four USB ports (3 USB 2.0 and 1 USB 3.0) can be used to attach a variety of peripherals and a PCI Ethernet controller provides onboard network connectivity.
A 40-pin header on the board can be used to extend the capabilities and exposed interfaces of the Jetson Nano.
Signed-off-by Thierry Reding <[email protected]>---
Changes in v2:
- add obsolete PCIe and XUSB power supplies for backwards compatibility
- remove pinmux nodearch/arm64/boot/dts/nvidia/Makefile | 1 + .../boot/dts/nvidia/tegra210-p3450-0000.dts | 648 ++++++++++++++++++ 2 files changed, 649 insertions(+) create mode 100644 arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dtsarch/arm64/boot/dts/nvidia/Makefile +1
-0@@ -3,6 +3,7 @@ dtb-$(CONFIG_ARCH_TEGRA_132_SOC) += tegra132-norrin.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-0000.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2371-2180.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2571.dtb +dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p3450-0000.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-smaug.dtb dtb-$(CONFIG_ARCH_TEGRA_210_SOC) += tegra210-p2894-0050-a08.dtb dtb-$(CONFIG_ARCH_TEGRA_186_SOC) += tegra186-p2771-0000.dtbarch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts new file +23
-0@@ -0,0 +1,648 @@ +// SPDX-License-Identifier: GPL-2.0 +/dts-v1/; + +#include <dt-bindings/input/gpio-keys.h> +#include <dt-bindings/input/linux-event-codes.h> +#include <dt-bindings/mfd/max77620.h> + +#include "tegra210.dtsi" + +/ { + model = "NVIDIA Jetson Nano Developer Kit"; + compatible = "nvidia,p3450-0000", "nvidia,tegra210"; + + aliases { + ethernet = "/pcie@1003000/pci@2,0/ethernet@0,0"; + rtc0 = "/i2c@7000d000/pmic@3c"; + rtc1 = "/rtc@7000e000"; + serial0 = &uarta; + }; + + chosen { + stdout-path = "serial0:115200n8"; + };
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts line 33
Quoted 10 lines
arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts new file +10
-0+ + memory { + device_type = "memory"; + reg = <0x0 0x80000000 0x1 0x0>; + }; + + pcie@1003000 { + status = "okay"; + + avdd-pll-uerefe-supply = <&avdd_pex_1v05>;
When trying to apply this serie on top of kernel 5.1-rc3, I have ERROR (phandle_references): /pcie@1003000: Reference to non-existent node or label "avdd_pex_1v05"
I haven't seen any reference of avdd_pex_1v05 in the tegra mailing list, so I assume it should be changed to vdd_pex_1v05 instead (without the leading "a").
Also the dt-binding from this serie doesn't apply, so I suspect a missing change in-between ?
Thx
--
-
Nicolas (kwizart)
PATCH 7/8 arm64: tegra: smaug: Move PLL power supplies to XUSB pad controller
In reply to Thierry RedingFrom: Thierry Reding <[email protected]>
The XUSB pad controller is responsible for supplying power to the PLLs used to drive the various USB, PCI and SATA pads. Move the PLL power supplies from the PCIe and XUSB controllers to the XUSB pad controller to make sure they are available when needed.
--- arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 5 +++++ 1 file changed, 5 insertions(+)
arch/arm64/boot/dts/nvidia/tegra210-smaug.dts +5 -0
@@ -1654,6 +1654,11 @@ padctl@7009f000 { status = "okay"; + avdd-pll-utmip-supply = <&pp1800>; + avdd-pll-uerefe-supply = <&pp1050_avdd>; + dvdd-pex-pll-supply = <&avddio_1v05>; + hvdd-pex-pll-e-supply = <&pp1800>; + pads { usb2 { status = "okay";
Signature · 1 line
2.21.0
Quoted 8 lines · Thierry Reding
From: Thierry Reding <[email protected]>
These power supplies provide power for various PLLs that are set up and driven by the XUSB pad controller. These power supplies were previously improperly added to the PCIe and XUSB controllers, but depending on the driver probe order, power to the PLLs will not be supplied soon enough and cause initialization to fail.
Quoted 5 lines
Signed-off-by Thierry Reding <[email protected]>--- .../bindings/phy/nvidia,tegra124-xusb-padctl.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+)