ASoC: cs35l35: Disable regulators on driver removal
Subsystems (3)
PATCH 1/1 ASoC: cs35l35: Disable regulators on driver removal
The chips main power supplies VA and VP are enabled during probe but then never disabled, this will cause warnings from the regulator framework on driver removal. Fix this by adding a remove callback and disabling the supplies, whilst doing so follow best practice and put the chip back into reset as well.
--- sound/soc/codecs/cs35l35.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
sound/soc/codecs/cs35l35.c +11 -0
@@ -1635,6 +1635,16 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,return ret; } +static int cs35l35_i2c_remove (struct i2c_client *i2c_client) +{ +struct cs35l35_private *cs35l35 =i2c_get_clientdata (i2c_client); + +regulator_bulk_disable (cs35l35->num_supplies, cs35l35->supplies); +gpiod_set_value_cansleep (cs35l35->reset_gpio,0 ); + +return 0 ; +} +static const struct of_device_id cs35l35_of_match[] = { {.compatible ="cirrus,cs35l35" }, {},
@@ -1655,6 +1665,7 @@ static struct i2c_driver cs35l35_i2c_driver = { }, .id_table = cs35l35_id, .probe = cs35l35_i2c_probe, + .remove = cs35l35_i2c_remove, };module_i2c_driver (cs35l35_i2c_driver);
Signature · 1 line
2.11.0
Mark Brown
maintainerApplied "ASoC: cs35l35: Disable regulators on driver removal" to the asoc tree
The patch
ASoC: cs35l35: Disable regulators on driver removal
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
47c4cc08cb5b34e93ab337b924c5ede77ca3c936Mon Sep 17 00:00:00 2001
From: Charles Keepax <[email protected]>
Date: Thu, 4 Apr 2019 17:27:20 +0100
Subject: [PATCH] ASoC: cs35l35: Disable regulators on driver removal
The chips main power supplies VA and VP are enabled during probe but then never disabled, this will cause warnings from the regulator framework on driver removal. Fix this by adding a remove callback and disabling the supplies, whilst doing so follow best practice and put the chip back into reset as well.
--- sound/soc/codecs/cs35l35.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
sound/soc/codecs/cs35l35.c +11 -0
@@ -1635,6 +1635,16 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,return ret; } +static int cs35l35_i2c_remove (struct i2c_client *i2c_client) +{ +struct cs35l35_private *cs35l35 =i2c_get_clientdata (i2c_client); + +regulator_bulk_disable (cs35l35->num_supplies, cs35l35->supplies); +gpiod_set_value_cansleep (cs35l35->reset_gpio,0 ); + +return 0 ; +} +static const struct of_device_id cs35l35_of_match[] = { {.compatible ="cirrus,cs35l35" }, {},
@@ -1655,6 +1665,7 @@ static struct i2c_driver cs35l35_i2c_driver = { }, .id_table = cs35l35_id, .probe = cs35l35_i2c_probe, + .remove = cs35l35_i2c_remove, };module_i2c_driver (cs35l35_i2c_driver);
Signature · 1 line
2.20.1