Log error status on Identify Namespace failure
PATCH 1/1 Log error status on Identify Namespace failure
Identify Namespace failures are logged as a warning but there is not an indication of the cause for the failure. Update the log message to include the error status.
Signed-off-by Kenneth Heitke <kenneth.heitke at intel.com>
--- drivers/nvme/host/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/core.c +1 -1
@@ -1105,7 +1105,7 @@ static struct nvme_id_ns *nvme_identify_ns(struct nvme_ctrl *ctrl, error =nvme_submit_sync_cmd (ctrl->admin_q, &c, id,sizeof (*id));if (error) { -dev_warn (ctrl->device,"Identify namespace failed\n" ); +dev_warn (ctrl->device,"Identify namespace failed (%d)\n" , error);kfree (id);return NULL ; }
Signature · 1 line
2.17.1
PATCH 1/1 Log error status on Identify Namespace failure
Looks good.
Reviewed-by Chaitanya Kulkarni <chaitanya.kulkarni at wdc.com>
On 4/4/19, 11:57 AM, "Linux-nvme on behalf of Kenneth Heitke" <[email protected] on behalf of [email protected]> wrote:
Identify Namespace failures are logged as a warning but there is not
an indication of the cause for the failure. Update the log message to
include the error status.
Signed-off-by: Kenneth Heitke <kenneth.heitke at intel.com>
---
drivers/nvme/host/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index b5939112b9b6..ddb943395118 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -1105,7 +1105,7 @@ static struct nvme_id_ns *nvme_identify_ns(struct nvme_ctrl *ctrl,
error = nvme_submit_sync_cmd(ctrl->admin_q, &c, id, sizeof(*id));
if (error) {
- dev_warn(ctrl->device, "Identify namespace failed\n");
+ dev_warn(ctrl->device, "Identify namespace failed (%d)\n", error);
kfree(id);
return NULL;
}
--
2.17.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvmePATCH 1/1 Log error status on Identify Namespace failure
In reply to Kenneth HeitkeApplied to nvme-5.2 after fixing up the one-liner summary to include the "nvme: " prefix.