staging: rtl8192u: ieee80211: add space around '==' and before '('
PATCH 1/1 staging: rtl8192u: ieee80211: add space around '==' and before '('
Fix checkpatch coding style errors on rtl819x_TSProc.c
- space required before the open parenthesis '('
- spaces required around that '=='
--- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +1 -1
@@ -373,7 +373,7 @@ bool GetTs(if (!list_empty (pUnusedList)) { (*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);list_del_init (&(*ppTS)->list); -if (TxRxSelect==TX_DIR ) { +if (TxRxSelect ==TX_DIR ) { struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);ResetTxTsEntry (tmp); }else {
Signature · 1 line
2.21.0
Quoted 14 lines · Caio Salvador Rohwedder
Fix checkpatch coding style errors on
rtl819x_TSProc.c
- space required before the open parenthesis '('
- spaces required around that '=='Signed-off-by Caio Salvador Rohwedder <[email protected]>--- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +0
-0
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c bool GetTs( · line 377
Quoted 6 lines
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +1
-1@@ -373,7 +373,7 @@ bool GetTs(if (!list_empty (pUnusedList)) { (*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);list_del_init (&(*ppTS)->list); -if (TxRxSelect==TX_DIR ) { +if (TxRxSelect ==TX_DIR ) { struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);
This line seems over 80 characters, may also be fixed.
In fact, this file has so many code style issues, see
./scripts/checkpatch.pl --no-tree -f drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
Quoted 3 lines
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +0
-0ResetTxTsEntry (tmp); }else {
Quoted 10 lines · YueHaibing
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c bool GetTs( · line 377
Quoted 6 lines · Caio Salvador Rohwedder
drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c +1
-1if (!list_empty (pUnusedList)) { (*ppTS) = list_entry(pUnusedList->next, struct ts_common_info, list);list_del_init (&(*ppTS)->list); -if (TxRxSelect==TX_DIR ) { +if (TxRxSelect ==TX_DIR ) { struct tx_ts_record *tmp = container_of(*ppTS, struct tx_ts_record, ts_common_info);This line seems over 80 characters, may also be fixed.
The 80 character problem isn't really related to the "space required" problem. Those would need to be fixed in separate patches.
Quoted 4 lines
In fact, this file has so many code style issues, see
./scripts/checkpatch.pl--no-tree -fdrivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c
Yes. Of course it has millions of style issues. It's staging code. Leave it. We'll fix it little by little.
That said, I kind of would prefer to review patches which fix all the "space[s] required" checkpatch warnings in a file in one go...
regards,
dan carpenter