Skip to contentSkip to conversation

gstreamer1.0-python: rework gobject-introspection handling

PATCH Superseded Andreas Müller 2 participants 3 messages Apr 5, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gstreamer1.0-python: rework gobject-introspection handling

gobject-introspection is mandatory for gstreamer1.0-python - there is no configure option to enable or disable it.

To handle properly, this patch does:

* Make 'gobject-introspection-data' a required distro feature
* Add
'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
- it was removed in gobject-introspection.bbclass to avoid
| ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]

---
 .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb +4 -0
index 8d45ca2668..fb76a37b92 100644
@@ -16,6 +16,10 @@ PNREAL = "gst-python"
 
 S = "${WORKDIR}/${PNREAL}-${PV}"
 
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
+
 inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
 
 do_install_append() {
Signature · 1 line
2.20.1
#1 lore raw
Quoted 21 lines · Andreas Müller

gobject-introspection is mandatory for gstreamer1.0-python - there is no configure option to enable or disable it.

To handle properly, this patch does:

* Make 'gobject-introspection-data' a required distro feature
* Add
'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
- it was removed in gobject-introspection.bbclass to avoid
| ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]

---
 .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb +0 -0
index 8d45ca2668..fb76a37b92 100644

meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb PNREAL = "gst-python" · line 20

Quoted 5 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb +2 -0
@@ -16,6 +16,10 @@ PNREAL = "gst-python"
 
 S = "${WORKDIR}/${PNREAL}-${PV}"
 
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"

Is distro_features_check inherited somewhere? I don't see it in this part and the above IIRC doesn't work without distro_features_check inherit.

Cheers,

Quoted 13 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb +2 -0
+UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"
+
 inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
 
 do_install_append() {
Signature · 7 lines
2.20.1

-- 
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 26 lines · Martin Jansa
Quoted 24 lines · Andreas Müller

gobject-introspection is mandatory for gstreamer1.0-python - there is no configure option to enable or disable it.

To handle properly, this patch does:

* Make 'gobject-introspection-data' a required distro feature
* Add
'UNKNOWN_CONFIGURE_WHITELIST_append = " --enable-introspection --disable-introspection"'
- it was removed in gobject-introspection.bbclass to avoid
| ERROR: libgee-0.18.0-r0 do_configure: QA Issue: libgee: configure was passed unrecognised options: --disable-schemas-install [unknown-configure-option]

---
 .../gstreamer/gstreamer1.0-python_1.14.4.bb                   | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb +0 -0
index 8d45ca2668..fb76a37b92 100644
@@ -16,6 +16,10 @@ PNREAL = "gst-python"
 
 S = "${WORKDIR}/${PNREAL}-${PV}"
 
Quoted 8 lines

meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb PNREAL = "gst-python" · line 20

Quoted 2 lines
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb +2 -0
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"

Is distro_features_check inherited somewhere? I don't see it in this part and the above IIRC doesn't work without distro_features_check inherit.

Cheers,

At the time you wrote that V2 was prepared :)

I tend to forget that - need to check my meta-gnome patches for that...

Andreas