Skip to contentSkip to conversation

lib/librte_table: fix arm64 hash function selection

PATCH Applied Jerin Jacob Kollanukkaran 3 participants 3 messages Apr 6, 2019 – Apr 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/librte_table: fix arm64 hash function selection

From: Jerin Jacob <[email protected]>

Use CRC32 instruction only when it is available to avoid the build issue like below.

{standard input}:16: Error:
selected processor does not support `crc32cx w3,w3,x0'

Fixes ea7be0a0386e ("lib/librte_table: add hash function headers")
Cc Gavin Hu <[email protected]>
---
 lib/librte_table/rte_table_hash_func.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/librte_table/rte_table_hash_func.h +1 -1
index 02296eabe..11ea5a90e 100644
@@ -40,7 +40,7 @@ rte_crc32_u64(uint64_t crc, uint64_t v)
 	return _mm_crc32_u64(crc, v);
 }
 
-#elif defined(RTE_ARCH_ARM64)
+#elif defined(RTE_ARCH_ARM64) && defined(RTE_MACHINE_CPUFLAG_CRC32)
 #include "rte_table_hash_func_arm64.h"
 #else
 
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 19 lines

-----Original Message-----
From: Jerin Jacob Kollanukkaran [mailto:[email protected]]
Sent: Saturday, April 6, 2019 2:30 PM
To: Dumitrescu, Cristian <[email protected]>
Cc: [email protected]; [email protected]; Jerin Jacob Kollanukkaran <[email protected]>; Gavin Hu <[email protected]>; [email protected]
Subject: [dpdk-dev] [PATCH] lib/librte_table: fix arm64 hash function selection

From: Jerin Jacob <[email protected]>

Use CRC32 instruction only when it is available to avoid the build issue like below.

{standard input}:16: Error:
selected processor does not support `crc32cx w3,w3,x0'

Quoted 9 lines
Fixes ea7be0a0386e ("lib/librte_table: add hash function headers")
Cc Gavin Hu <[email protected]>
---
 lib/librte_table/rte_table_hash_func.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
#2 lore raw
Quoted 8 lines
Quoted 8 lines

From: Jerin Jacob <[email protected]>

Use CRC32 instruction only when it is available to avoid the build issue like below.

{standard input}:16: Error:
selected processor does not support `crc32cx w3,w3,x0'

Quoted 7 lines
Quoted 5 lines
Fixes ea7be0a0386e ("lib/librte_table: add hash function headers")
Cc Gavin Hu <[email protected]>

Applied, thanks