Skip to contentSkip to conversation

gstreamer1.0-python: Remove --enable-introspection

PATCH In review Khem Raj 2 participants 4 messages Apr 6, 2019

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/1 gstreamer1.0-python: Remove --enable-introspection

This option is not available and recently it is reported as error

do_configure: QA Issue: gstreamer1.0-python: configur
e was passed unrecognised options: --enable-introspection [unknown-configure-option]

---
 meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-multimedia/gstreamer/gstreamer1.0-python_1.14.4.bb +1 -0
index 8d45ca2668..3358352128 100644
@@ -18,6 +18,7 @@ S = "${WORKDIR}/${PNREAL}-${PV}"
 
 inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
 
+EXTRA_OECONF_remove = "--enable-introspection"
 do_install_append() {
     # gstpythonplugin hardcodes the location of the libpython from the build
     # workspace and then fails at runtime. We can override it using
Signature · 1 line
2.21.0
#1 lore raw
Quoted 6 lines · Khem Raj

This option is not available and recently it is reported as error

do_configure: QA Issue: gstreamer1.0-python: configur
e was passed unrecognised options: --enable-introspection [unknown-configure-option]

Send out a patch already addressing [1] but honestly I parts of this parts more: remove option instead of ignoring.

Cann you add:

-inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
+inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection distro_features_check
+# gobject-introspection is mandatory and cannot be configured +REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"

or shall I send V3?

[1] http://lists.openembedded.org/pipermail/openembedded-core/2019-April/280958.html

Andreas

#2 lore raw

On Sat, Apr 6, 2019 at 8:27 PM Andreas Müller <[email protected]> wrote:
AArgh recent comment went out way too early.

This patch won't work if gobject-introspection-data is not in distro features. Then there would be unknown configure option --disable-introspection.

So what do others think: ignore unknown options (then my patch is OK) or remove?

Andreas

Quoted 25 lines · Khem Raj
Quoted 6 lines

This option is not available and recently it is reported as error

do_configure: QA Issue: gstreamer1.0-python: configur
e was passed unrecognised options: --enable-introspection [unknown-configure-option]

Send out a patch already addressing [1] but honestly I parts of this parts more: remove option instead of ignoring.

Cann you add:

-inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
+inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection distro_features_check

(quoted diff) +2 -0
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"

or shall I send V3?

[1] http://lists.openembedded.org/pipermail/openembedded-core/2019-April/280958.html

Andreas

author
#3 lore raw
In reply to Andreas Müller
Quoted 20 lines · Andreas Müller
Quoted 6 lines · Khem Raj

This option is not available and recently it is reported as error

do_configure: QA Issue: gstreamer1.0-python: configur
e was passed unrecognised options: --enable-introspection [unknown-configure-option]

Send out a patch already addressing [1] but honestly I parts of this parts more: remove option instead of ignoring.

Cann you add:

-inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection
+inherit autotools pkgconfig distutils3-base upstream-version-is-even gobject-introspection distro_features_check

(quoted diff) +2 -0
+# gobject-introspection is mandatory and cannot be configured
+REQUIRED_DISTRO_FEATURES = "gobject-introspection-data"
Quoted 1 line

or shall I send V3?

seems better please do

Quoted 4 lines

[1] http://lists.openembedded.org/pipermail/openembedded-core/2019-April/280958.html

Andreas