Skip to contentSkip to conversation

scsi: mvumi: fix warning Using plain integer as NULL pointer

PATCH In review Hariprasad Kelam 3 participants 3 messages Apr 6, 2019 – Apr 9, 2019 SCSI

lore
Share & tools
lore

Hariprasad Kelam

author
#0 lore raw

PATCH 1/1 scsi: mvumi: fix warning Using plain integer as NULL pointer

Changed "0 to NULL" to avoid below sparse warnings

drivers/scsi/mvumi.c:755:58: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:1797:48: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:2142:50: warning: Using plain integer as NULL pointer

Signed-off-by Hariprasad Kelam <[email protected]>
---
 drivers/scsi/mvumi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/mvumi.c +3 -3
index 3df0269..a541061 100644
@@ -752,7 +752,7 @@ static int mvumi_issue_blocked_cmd(struct mvumi_hba *mhba,
 		spin_lock_irqsave(mhba->shost->host_lock, flags);
 		atomic_dec(&cmd->sync_cmd);
 		if (mhba->tag_cmd[cmd->frame->tag]) {
-			mhba->tag_cmd[cmd->frame->tag] = 0;
+			mhba->tag_cmd[cmd->frame->tag] = NULL;
 			dev_warn(&mhba->pdev->dev, "TIMEOUT:release tag [%d]\n",
 							cmd->frame->tag);
 			tag_release_one(mhba, &mhba->tag_pool, cmd->frame->tag);

@@ -1794,7 +1794,7 @@ static void mvumi_handle_clob(struct mvumi_hba *mhba)
 		cmd = mhba->tag_cmd[ob_frame->tag];
 
 		atomic_dec(&mhba->fw_outstanding);
-		mhba->tag_cmd[ob_frame->tag] = 0;
+		mhba->tag_cmd[ob_frame->tag] = NULL;
 		tag_release_one(mhba, &mhba->tag_pool, ob_frame->tag);
 		if (cmd->scmd)
 			mvumi_complete_cmd(mhba, cmd, ob_frame);

@@ -2139,7 +2139,7 @@ static enum blk_eh_timer_return mvumi_timed_out(struct scsi_cmnd *scmd)
 	spin_lock_irqsave(mhba->shost->host_lock, flags);
 
 	if (mhba->tag_cmd[cmd->frame->tag]) {
-		mhba->tag_cmd[cmd->frame->tag] = 0;
+		mhba->tag_cmd[cmd->frame->tag] = NULL;
 		tag_release_one(mhba, &mhba->tag_pool, cmd->frame->tag);
 	}
 	if (!list_empty(&cmd->queue_pointer))
Signature · 1 line
2.7.4
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Hariprasad Kelam

Changed "0 to NULL" to avoid below sparse warnings

drivers/scsi/mvumi.c:755:58: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:1797:48: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:2142:50: warning: Using plain integer as NULL pointer

Signed-off-by Hariprasad Kelam <[email protected]>
Reviewed-by Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

Quoted 35 lines
---
  drivers/scsi/mvumi.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)
drivers/scsi/mvumi.c +3 -3
index 3df0269..a541061 100644
@@ -752,7 +752,7 @@ static int mvumi_issue_blocked_cmd(struct mvumi_hba *mhba,
  		spin_lock_irqsave(mhba->shost->host_lock, flags);
  		atomic_dec(&cmd->sync_cmd);
  		if (mhba->tag_cmd[cmd->frame->tag]) {
-			mhba->tag_cmd[cmd->frame->tag] = 0;
+			mhba->tag_cmd[cmd->frame->tag] = NULL;
  			dev_warn(&mhba->pdev->dev, "TIMEOUT:release tag [%d]\n",
  							cmd->frame->tag);
  			tag_release_one(mhba, &mhba->tag_pool, cmd->frame->tag);

@@ -1794,7 +1794,7 @@ static void mvumi_handle_clob(struct mvumi_hba *mhba)
  		cmd = mhba->tag_cmd[ob_frame->tag];
 
  		atomic_dec(&mhba->fw_outstanding);
-		mhba->tag_cmd[ob_frame->tag] = 0;
+		mhba->tag_cmd[ob_frame->tag] = NULL;
  		tag_release_one(mhba, &mhba->tag_pool, ob_frame->tag);
  		if (cmd->scmd)
  			mvumi_complete_cmd(mhba, cmd, ob_frame);

@@ -2139,7 +2139,7 @@ static enum blk_eh_timer_return mvumi_timed_out(struct scsi_cmnd *scmd)
  	spin_lock_irqsave(mhba->shost->host_lock, flags);
 
  	if (mhba->tag_cmd[cmd->frame->tag]) {
-		mhba->tag_cmd[cmd->frame->tag] = 0;
+		mhba->tag_cmd[cmd->frame->tag] = NULL;
  		tag_release_one(mhba, &mhba->tag_pool, cmd->frame->tag);
  	}
  	if (!list_empty(&cmd->queue_pointer))
#2 lore raw
In reply to Hariprasad Kelam

Hi Hariprasad,

Quoted 8 lines

Changed "0 to NULL" to avoid below sparse warnings

drivers/scsi/mvumi.c:755:58: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:1797:48: warning: Using plain integer as NULL pointer
drivers/scsi/mvumi.c:2142:50: warning: Using plain integer as NULL pointer

This has already been fixed up in 7512ddef6307. In the future, please make sure to submit patches against my for-next branch.

Thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering