powerpc/pseries/pmem: fix a set but not used value
PATCH 1/1 powerpc/pseries/pmem: fix a set but not used value
The commit 4c5d87db4978 ("powerpc/pseries: PAPR persistent memory support") set a local variable "count" in dlpar_hp_pmem() but never use it.
arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem':arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count' set but not used [-Wunused-but-set-variable]
--- arch/powerpc/platforms/pseries/pmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
arch/powerpc/platforms/pseries/pmem.c +1 -2
@@ -106,7 +106,7 @@ static ssize_t pmem_drc_remove_node(u32 drc_index)int dlpar_hp_pmem (struct pseries_hp_errorlog *hp_elog) { -u32 count, drc_index; +u32 drc_index;int rc;/* slim chance, but we might get a hotplug event while booting */
@@ -123,7 +123,6 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)return -EINVAL ; } - count = hp_elog->_drc_u.drc_count; drc_index = hp_elog->_drc_u.drc_index;lock_device_hotplug ();
Signature · 1 line
2.17.2 (Apple Git-113)
Quoted 9 lines · Qian Cai
The commit
4c5d87db4978("powerpc/pseries: PAPR persistent memory support") set a local variable "count" indlpar_hp_pmem()but never use it.
arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem':arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count' set but not used [-Wunused-but-set-variable]Signed-off-by Qian Cai <[email protected]>
Cheers,
-Mukesh
Quoted 25 lines
--- arch/powerpc/platforms/pseries/pmem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)arch/powerpc/platforms/pseries/pmem.c +1
-2@@ -106,7 +106,7 @@ static ssize_t pmem_drc_remove_node(u32 drc_index)int dlpar_hp_pmem (struct pseries_hp_errorlog *hp_elog) { -u32 count, drc_index; +u32 drc_index;int rc;/* slim chance, but we might get a hotplug event while booting */ @@ -123,7 +123,6 @@ int dlpar_hp_pmem(struct pseries_hp_errorlog *hp_elog)return -EINVAL ; } - count = hp_elog->_drc_u.drc_count; drc_index = hp_elog->_drc_u.drc_index;lock_device_hotplug ();
Michael Ellerman
AppliedQuoted 10 lines · Qian Cai
The commit
4c5d87db4978("powerpc/pseries: PAPR persistent memory support") set a local variable "count" indlpar_hp_pmem()but never use it.
arch/powerpc/platforms/pseries/pmem.c: In function 'dlpar_hp_pmem':arch/powerpc/platforms/pseries/pmem.c:109:6: warning: variable 'count' set but not used [-Wunused-but-set-variable]Signed-off-by Qian Cai <[email protected]>Reviewed-by Mukesh Ojha <[email protected]>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/e663e1e06089773cdab03023563aead6
cheers