Skip to contentSkip to conversation

regulator: bd718x7: Use rdev_get_id() to get regulator id

PATCH In review Axel Lin 2 participants 2 messages Apr 7, 2019 – Apr 8, 2019

Subsystems (2)
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/1 regulator: bd718x7: Use rdev_get_id() to get regulator id

Use rdev_get_id() instead of directly access rdev->desc->id. While at it also remove unneeded init for ramp_value variable.

---
 drivers/regulator/bd718x7-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/bd718x7-regulator.c +2 -2
index b2191be49670..fde4264da6ff 100644
@@ -27,8 +27,8 @@
 static int bd718xx_buck1234_set_ramp_delay(struct regulator_dev *rdev,
 					   int ramp_delay)
 {
-	int id = rdev->desc->id;
-	unsigned int ramp_value = BUCK_RAMPRATE_10P00MV;
+	int id = rdev_get_id(rdev);
+	unsigned int ramp_value;
 
 	dev_dbg(&rdev->dev, "Buck[%d] Set Ramp = %d\n", id + 1,
 		ramp_delay);
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw
Quoted 26 lines · Axel Lin

Use rdev_get_id() instead of directly access rdev->desc->id. While at it also remove unneeded init for ramp_value variable.

---
 drivers/regulator/bd718x7-regulator.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/regulator/bd718x7-regulator.c +2 -2
index b2191be49670..fde4264da6ff 100644
@@ -27,8 +27,8 @@
 static int bd718xx_buck1234_set_ramp_delay(struct regulator_dev *rdev,
 					   int ramp_delay)
 {
-	int id = rdev->desc->id;
-	unsigned int ramp_value = BUCK_RAMPRATE_10P00MV;
+	int id = rdev_get_id(rdev);
+	unsigned int ramp_value;
 
 	dev_dbg(&rdev->dev, "Buck[%d] Set Ramp = %d\n", id + 1,
 		ramp_delay);
Signature · 1 line
2.17.1