Skip to contentSkip to conversation

ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl

PATCH New Parthiban Nallathambi 3 participants 4 messages Apr 7, 2019 – Jun 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl

u-boot,dm-spl property is specific to U-Boot, so created one for i.MX6ULL platforms.

---
 arch/arm/dts/imx6ull-u-boot.dtsi | 34 ++++++++++++++++++++++++++++++++
 board/phytec/pcl063/MAINTAINERS  |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 arch/arm/dts/imx6ull-u-boot.dtsi
arch/arm/dts/imx6ull-u-boot.dtsi new file +34 -0
new file mode 100644
index 0000000000..74ca95fa2c
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Parthiban Nallathambi <[email protected]>
+ */
+
+/ {
+	soc {
+		u-boot,dm-spl;
+	};
+};
+
+&aips1 {
+	u-boot,dm-spl;
+};
+
+&aips2 {
+	u-boot,dm-spl;
+};
+
+&aips3 {
+	u-boot,dm-spl;
+};
+
+&gpio1 {
+	u-boot,dm-spl;
+};
+
+&gpio4 {
+	u-boot,dm-spl;
+};
+
+&iomuxc {
+	u-boot,dm-spl;
+};
board/phytec/pcl063/MAINTAINERS +1 -0
index 70e03cfe71..7d9978c339 100644
@@ -3,6 +3,7 @@ M:	Martyn Welch <[email protected]>
 M:	Parthiban Nallathambi <[email protected]>
 S:	Maintained
 F:	arch/arm/dts/imx6ul-phycore-segin.dts
+F:	arch/arm/dts/imx6ull-u-boot.dtsi
 F:	arch/arm/dts/imx6ull-phycore-segin.dts
 F:	arch/arm/dts/pcl063-common.dtsi
 F:	board/phytec/pcl063/
Signature · 1 line
2.17.2
#1 lore raw

PATCH 1/1 ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl

Hi Parthiban

Quoted 2 lines · Parthiban Nallathambi

u-boot,dm-spl property is specific to U-Boot, so created one for i.MX6ULL platforms.

What exactly makes you so sure others do want your exact configuration thereof as well? Shouldn't you make this board specific instead like e.g. done elsewhere [1]?

[1]
https://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/dts/am335x-chiliboard-u-boot.dtsi;h=4f9d3080394be001f79731b736c5eac934c07ebf;hb=HEAD

Cheers

Marcel

Quoted 62 lines
---
 arch/arm/dts/imx6ull-u-boot.dtsi | 34
++++++++++++++++++++++++++++++++
 board/phytec/pcl063/MAINTAINERS  |  1 +
 2 files changed, 35 insertions(+)
 create mode 100644 arch/arm/dts/imx6ull-u-boot.dtsi
arch/arm/dts/imx6ull- renamed from arch/arm/dts/imx6ull-u-boot.dtsi +0 -0

u-boot.dtsi
new file mode 100644
index 0000000000..74ca95fa2c

arch/arm/dts/imx6ull-u-boot.dtsi new file +34 -0
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Parthiban Nallathambi <[email protected]>
+ */
+
+/ {
+	soc {
+		u-boot,dm-spl;
+	};
+};
+
+&aips1 {
+	u-boot,dm-spl;
+};
+
+&aips2 {
+	u-boot,dm-spl;
+};
+
+&aips3 {
+	u-boot,dm-spl;
+};
+
+&gpio1 {
+	u-boot,dm-spl;
+};
+
+&gpio4 {
+	u-boot,dm-spl;
+};
+
+&iomuxc {
+	u-boot,dm-spl;
+};
board/phytec/pcl063/MAINTAINERS +1 -0
index 70e03cfe71..7d9978c339 100644
@@ -3,6 +3,7 @@ M:	Martyn Welch <[email protected]>
 M:	Parthiban Nallathambi <[email protected]>
 S:	Maintained
 F:	arch/arm/dts/imx6ul-phycore-segin.dts
+F:	arch/arm/dts/imx6ull-u-boot.dtsi
 F:	arch/arm/dts/imx6ull-phycore-segin.dts
 F:	arch/arm/dts/pcl063-common.dtsi
 F:	board/phytec/pcl063/
#2 lore raw

PATCH 1/1 ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot, dm-spl

Hi Marcel,

Quoted 9 lines · Marcel Ziswiler

Hi Parthiban

Quoted 2 lines · Parthiban Nallathambi

u-boot,dm-spl property is specific to U-Boot, so created one for i.MX6ULL platforms.

What exactly makes you so sure others do want your exact configuration thereof as well? Shouldn't you make this board specific instead like e.g. done elsewhere [1]?

Sure, thanks for pointing it. I will move them to my board specific files.

Thanks,
Parthiban N

Quoted 70 lines

[1]
https://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/dts/am335x-chiliboard-u-boot.dtsi;h=4f9d3080394be001f79731b736c5eac934c07ebf;hb=HEAD

Cheers

Marcel

Quoted 62 lines
---
  arch/arm/dts/imx6ull-u-boot.dtsi | 34
++++++++++++++++++++++++++++++++
  board/phytec/pcl063/MAINTAINERS  |  1 +
  2 files changed, 35 insertions(+)

create mode 100644 arch/arm/dts/imx6ull-u-boot.dtsi

arch/arm/dts/imx6ull- renamed from arch/arm/dts/imx6ull-u-boot.dtsi +0 -0

u-boot.dtsi
new file mode 100644
index 0000000000..74ca95fa2c

arch/arm/dts/imx6ull-u-boot.dtsi new file +34 -0
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019 Parthiban Nallathambi <[email protected]>
+ */
+
+/ {
+	soc {
+		u-boot,dm-spl;
+	};
+};
+
+&aips1 {
+	u-boot,dm-spl;
+};
+
+&aips2 {
+	u-boot,dm-spl;
+};
+
+&aips3 {
+	u-boot,dm-spl;
+};
+
+&gpio1 {
+	u-boot,dm-spl;
+};
+
+&gpio4 {
+	u-boot,dm-spl;
+};
+
+&iomuxc {
+	u-boot,dm-spl;
+};
board/phytec/pcl063/MAINTAINERS +1 -0
index 70e03cfe71..7d9978c339 100644
@@ -3,6 +3,7 @@ M:	Martyn Welch <[email protected]>
  M:	Parthiban Nallathambi <[email protected]>
  S:	Maintained
  F:	arch/arm/dts/imx6ul-phycore-segin.dts
+F:	arch/arm/dts/imx6ull-u-boot.dtsi
  F:	arch/arm/dts/imx6ull-phycore-segin.dts
  F:	arch/arm/dts/pcl063-common.dtsi
  F:	board/phytec/pcl063/
#3 lore raw

PATCH 1/1 ARM: dts: i.MX6ULL: U-Boot specific dts for u-boot,

In reply to Parthiban Nallathambi
Quoted 3 lines

u-boot,dm-spl property is specific to U-Boot, so created one for i.MX6ULL platforms.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================