ext4_subdir_limit_test.sh: fix "No Space" issue
PATCH 1/1 ext4_subdir_limit_test.sh: fix "No Space" issue
From: Xiaoli Feng <[email protected]>
1G ext4 filesystem default has 65536 inode. And some inodes will be used after format. So it will be failed when try to create 65536 sub-directorys in this ext4 mountpoint. Change it to create 65536 - used inodes directorys.
---
Re-send this mail again. Because I subscripted the ltp mail list failed last time.
Thanks.
.../ext4-subdir-limit/ext4_subdir_limit_test.sh | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-)
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +11 -5
@@ -46,6 +46,8 @@ prev_result=$FAIL ext4_run_case() { local dir_name_len= + local free_inode= + local max_directorys=$1 if [ $2 -eq $SHORT_DIR ]; then dir_name_len="short name"
@@ -53,9 +55,6 @@ ext4_run_case() dir_name_len="long name" fi - tst_resm TINFO "Num of dirs to create: $1, Dir name len: $dir_name_len, " \ - "Parent dir: $3, Block size: $4" - # only mkfs if block size has been changed, # or previous case failed if [ $prev_result -ne $PASS -o $4 -ne $prev_block_size ]; then
@@ -80,11 +79,18 @@ ext4_run_case() # create directories mkdir -p $3 2> /dev/null + free_inode=`df -i $EXT4_DEV | awk '{print $4}' | tr -cd "[0-9]"` + if [ "$free_inode" -lt "$1" ]; then + max_directorys=$free_inode + fi + + tst_resm TINFO "Num of dirs to create: $max_directorys, Dir name len: $dir_name_len, " \ + "Parent dir: $3, Block size: $4" if [ $2 -eq $SHORT_DIR ]; then - create_short_dirs $1 $3 + create_short_dirs $max_directorys $3 else - create_long_dirs $1 $3 + create_long_dirs $max_directorys $3 fi if [ $? -ne 0 ]; then
Signature · 1 line
2.18.1
PATCH 1/1 ext4_subdir_limit_test.sh: fix "No Space" issue
Hi Xiaoli,
Quoted 10 lines
From: Xiaoli Feng <[email protected]>
1G ext4 filesystem default has 65536 inode. And some inodes will be used after format. So it will be failed when try to create 65536 sub-directorys in this ext4 mountpoint. Change it to create 65536 - used inodes directorys.
---Re-send this mail again. Because I subscripted the ltp mail list failed last time.
We got your patch twice, even into patchwork ([1]). I disabled the first patch in patchwork.
...
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh prev_result=$FAIL · line 50
Quoted 7 lines
+++
b/testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.shtestcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +2
-0@@ -46,6 +46,8 @@ prev_result=$FAIL ext4_run_case() { local dir_name_len= + local free_inode= + local max_directorys=$1
max_directories, please (or better max_dirs) :).
Quoted 13 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +0
-3if [ $2 -eq $SHORT_DIR ]; then dir_name_len="short name"@@ -53,9 +55,6 @@ ext4_run_case() dir_name_len="long name" fi - tst_resm TINFO "Num of dirs to create: $1, Dir name len: $dir_name_len, " \ - "Parent dir: $3, Block size: $4" - # only mkfs if block size has been changed, # or previous case failed if [ $prev_result -ne $PASS -o $4 -ne $prev_block_size ]; then
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh ext4_run_case() · line 82
Quoted 4 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +1
-0@@ -80,11 +79,18 @@ ext4_run_case() # create directories mkdir -p $3 2> /dev/null + free_inode=`df -i $EXT4_DEV | awk '{print $4}' | tr -cd "[0-9]"`
How about using tail instead of tr?
df -i $EXT4_DEV | tail -1 | awk '{print $4}'
Maybe tail is more reliable and readable (and available [*]) than tr.
Not, sure if this is a correct usage:
# dd if=/dev/zero of=test_file bs=5000MB count=1 # /opt/ltp/runltp -f fs_ext4 -z /root/test_file but in this case is zero Inodes:
Filesystem Inodes IUsed IFree IUse% Mounted on/dev/vda2 0 0 0 - /
[*]: In new API it's needed to specify required commands in TST_NEEDS_CMDS variable (i.e. TST_NEEDS_CMDS="tr"), but this is legacy API, which does not have it.
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh ext4_run_case() · line 83
Quoted 1 line
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +1
-0+ if [ "$free_inode" -lt "$1" ]; then
I guess here you should use $max_directorys instead of $1
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh ext4_run_case() · line 91
Quoted 9 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +6
-1+ max_directorys=$free_inode + fi + + tst_resm TINFO "Num of dirs to create: $max_directorys, Dir name len: $dir_name_len, " \ + "Parent dir: $3, Block size: $4" if [ $2 -eq $SHORT_DIR ]; then - create_short_dirs $1 $3 + create_short_dirs $max_directorys $3
Ad $3: I hate using direct positional variables, but that's not related to the fix. Whole ext4-new-features tests would deserve rewrite into new API and cleanup (big work due they all depend on ext4_funcs.sh).
Kind regards,
Petr
PATCH 1/1 ext4_subdir_limit_test.sh: fix "No Space" issue
Hi,
----- Original Message -----
Quoted 24 lines
From: "Petr Vorel" <[email protected]>
To: "XiaoLi Feng" <[email protected]>
Cc: [email protected], "Xiaoli Feng" <[email protected]>
Sent: Friday, April 12, 2019 5:35:09 AM
Subject: Re: [LTP] [PATCH v1]ext4_subdir_limit_test.sh: fix "No Space" issueHi Xiaoli,
Quoted 11 lines
From: Xiaoli Feng <[email protected]>
1G ext4 filesystem default has 65536 inode. And some inodes will be used after format. So it will be failed when try to create 65536 sub-directorys in this ext4 mountpoint. Change it to create 65536 - used inodes directorys.
---Re-send this mail again. Because I subscripted the ltp mail list failed last
time.We got your patch twice, even into patchwork ([1]). I disabled the first patch
in patchwork....
Quoted 9 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh prev_result=$FAIL · line 50
Quoted 8 lines
+++
b/testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.shtestcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +2
-0@@ -46,6 +46,8 @@ prev_result=$FAIL ext4_run_case() { local dir_name_len= + local free_inode= + local max_directorys=$1
max_directories, please (or bettermax_dirs) :).
Thanks Petr for the review. Yes, max_dirs is better.
Quoted 16 lines
Quoted 15 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +0
-3if [ $2 -eq $SHORT_DIR ]; then dir_name_len="short name"@@ -53,9 +55,6 @@ ext4_run_case() dir_name_len="long name" fi - tst_resm TINFO "Num of dirs to create: $1, Dir name len: $dir_name_len, " \ - "Parent dir: $3, Block size: $4" - # only mkfs if block size has been changed, # or previous case failedtestcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +0
-0if [ $prev_result -ne $PASS -o $4 -ne $prev_block_size ]; then@@ -80,11 +79,18 @@ ext4_run_case()
Quoted 7 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh ext4_run_case() · line 82
Quoted 3 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +1
-0# create directories mkdir -p $3 2> /dev/null + free_inode=`df -i $EXT4_DEV | awk '{print $4}' | tr -cd "[0-9]"`How about using tail instead of tr?
df -i $EXT4_DEV | tail -1 | awk '{print $4}'Maybe tail is more reliable and readable (and available [*]) than tr.
Ok. "tail" is more reliable.
Quoted 9 lines
Not, sure if this is a correct usage:
# dd if=/dev/zero of=test_file bs=5000MB count=1 # /opt/ltp/runltp -f fs_ext4 -z /root/test_file but in this case is zero Inodes:Filesystem Inodes IUsed IFree IUse% Mounted on
/dev/vda20 0 0 - /
I can't reproduce it when I execute "/opt/ltp/runltp -f fs_ext4 -z /root/test_file". Do you format the device /dev/vda2?
Quoted 14 lines
[*]: In new API it's needed to specify required commands in
TST_NEEDS_CMDSvariable (i.e. TST_NEEDS_CMDS="tr"), but this is legacy API, which does not have
it.testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh ext4_run_case() · line 83
Quoted 1 line
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +1
-0+ if [ "$free_inode" -lt "$1" ]; thenI guess here you should use $max_directorys instead of $1
Quoted 6 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +5
-0+ max_directorys=$free_inode + fi + + tst_resm TINFO "Num of dirs to create: $max_directorys, Dir name len: $dir_name_len, " \ + "Parent dir: $3, Block size: $4"
Quoted 5 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh ext4_run_case() · line 91
Quoted 3 lines
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh +1
-1if [ $2 -eq $SHORT_DIR ]; then - create_short_dirs $1 $3 + create_short_dirs $max_directorys $3Ad $3: I hate using direct positional variables, but that's not related to the
I also hate it. :)
Quoted 2 lines
fix. Whole ext4-new-features tests would deserve rewrite into new API and cleanup (big work due they all depend on
ext4_funcs.sh).
Yes, they would deserve rewrite. I will have a try.
Quoted 7 lines
Kind regards,
Petr