Skip to contentSkip to conversation

drm/komeda: Creates plane alpha and blend mode properties

RFC PATCH Superseded Lowry Li (Arm Technology China) 2 participants 2 messages Apr 4, 2019 – Apr 8, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

RFC PATCH v2 1/1 drm/komeda: Creates plane alpha and blend mode properties

Creates plane alpha and blend mode properties attached to plane.

This patch depends on:
- https://patchwork.freedesktop.org/series/54448/
- https://patchwork.freedesktop.org/series/54449/
- https://patchwork.freedesktop.org/series/54450/

Changes since v1:
- Adds patch denpendency in the comment

---
 drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/gpu/drm/arm/display/komeda/komeda_plane.c +11 -0
index 68cd2c9e..aae5e80 100644
@@ -220,6 +220,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
 
 	drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
 
+	err = drm_plane_create_alpha_property(plane);
+	if (err)
+		goto cleanup;
+
+	err = drm_plane_create_blend_mode_property(plane,
+			BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+			BIT(DRM_MODE_BLEND_PREMULTI)   |
+			BIT(DRM_MODE_BLEND_COVERAGE));
+	if (err)
+		goto cleanup;
+
 	return 0;
 cleanup:
 	komeda_plane_destroy(plane);
Signature · 1 line
1.9.1
#1 lore raw
Quoted 27 lines · Lowry Li (Arm Technology China)

Creates plane alpha and blend mode properties attached to plane.

This patch depends on:
- https://patchwork.freedesktop.org/series/54448/
- https://patchwork.freedesktop.org/series/54449/
- https://patchwork.freedesktop.org/series/54450/

Changes since v1:
- Adds patch denpendency in the comment

---
 drivers/gpu/drm/arm/display/komeda/komeda_plane.c | 11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/gpu/drm/arm/display/komeda/komeda_plane.c +4 -0
index 68cd2c9e..aae5e80 100644
@@ -220,6 +220,17 @@ static int komeda_plane_add(struct komeda_kms_dev *kms,
 
 	drm_plane_helper_add(plane, &komeda_plane_helper_funcs);
 
+	err = drm_plane_create_alpha_property(plane);
+	if (err)
+		goto cleanup;
+

drivers/gpu/drm/arm/display/komeda/komeda_plane.c static int komeda_plane_add(struct komeda_kms_dev *kms, · line 236

Quoted 10 lines
drivers/gpu/drm/arm/display/komeda/komeda_plane.c +7 -0
+	err = drm_plane_create_blend_mode_property(plane,
+			BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+			BIT(DRM_MODE_BLEND_PREMULTI)   |
+			BIT(DRM_MODE_BLEND_COVERAGE));
+	if (err)
+		goto cleanup;
+
 	return 0;
 cleanup:
 	komeda_plane_destroy(plane);

Looks good to me.