app/test-crypto-perf: fix missing bounds check on socket id
PATCH 1/1 app/test-crypto-perf: fix missing bounds check on socket id
The socket_id is used as an array index so should be within the range of zero to max numa nodes. Add a range check to ensure we don't get excessive values.
Coverity issue: 336812
Coverity issue: 336829
Fixes 2c59bd32b70d ("cryptodev: do not create session mempool internally")
CC Declan Doherty <[email protected]>
CC Fan Zhang <[email protected]>
Signed-off-by Bruce Richardson <[email protected]>
--- app/test-crypto-perf/main.c | 5 +++++ 1 file changed, 5 insertions(+)
app/test-crypto-perf/main.c +5 -0
@@ -183,6 +183,11 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs)struct rte_cryptodev_info cdev_info;uint8_t socket_id =rte_cryptodev_socket_id (cdev_id); +/* range check the socket_id - negative values become big +* positive ones due to use of unsigned value +*/ +if (socket_id >=RTE_MAX_NUMA_NODES ) + socket_id =0 ;rte_cryptodev_info_get (cdev_id, &cdev_info);if (opts->nb_qps > cdev_info.max_nb_queue_pairs) {
Signature · 1 line
2.20.1
Quoted 4 lines
The
socket_idis used as an array index so should be within the range of zero to max numa nodes. Add a range check to ensure we don't get excessive values.
Quoted 8 lines
Coverity issue: 336812
Coverity issue: 336829Fixes 2c59bd32b70d ("cryptodev: do not create session mempool internally")CC Declan Doherty <[email protected]>CC Fan Zhang <[email protected]>Signed-off-by Bruce Richardson <[email protected]>
Acked-by Akhil Goyal <[email protected]>
Akhil Goyal
AppliedQuoted 11 lines
Quoted 11 lines
The
socket_idis used as an array index so should be within the range of zero to max numa nodes. Add a range check to ensure we don't get excessive values.Coverity issue: 336812
Coverity issue: 336829Fixes 2c59bd32b70d ("cryptodev: do not create session mempool internally")CC Declan Doherty <[email protected]>CC Fan Zhang <[email protected]>
Quoted 3 lines
Quoted 1 line
Signed-off-by Bruce Richardson <[email protected]>Acked-by Akhil Goyal <[email protected]>
Applied to dpdk-next-crypto
Thanks.