Skip to contentSkip to conversation

drm/lima: add missing Kconfig dependency

PATCH Applied Qiang Yu 2 participants 6 messages Apr 9, 2019

Subsystems (3)
lore
Share & tools
lore

Qiang Yu

author maintainer
#0 lore raw

PATCH 1/2 drm/lima: add missing Kconfig dependency

Current implementation does not support MMU-less
plarforms.

Cc Randy Dunlap <[email protected]>
Cc Neil Armstrong <[email protected]>
Fixes a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
---
 drivers/gpu/drm/lima/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/lima/Kconfig +3 -0
index f11314448093..bb4ddc6bb0a6 100644
@@ -5,6 +5,9 @@ config DRM_LIMA
        tristate "LIMA (DRM support for ARM Mali 400/450 GPU)"
        depends on DRM
        depends on ARM || ARM64 || COMPILE_TEST
+       depends on MMU
+       depends on COMMON_CLK
+       depends on OF
        select DRM_SCHED
        help
          DRM driver for ARM Mali 400/450 GPUs.
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
author maintainer
#1 lore raw

PATCH 2/2 drm/lima: include used header file explicitly

To prevent build fail on some platform which does not have it in the include file chain.

Cc Neil Armstrong <[email protected]>
Fixes a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
---
 drivers/gpu/drm/lima/lima_gem.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/lima/lima_gem.c +1 -0
index 2d3cf96f6c58..1d69498bc17e 100644
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0 OR MIT
 /* Copyright 2017-2019 Qiang Yu <[email protected]> */
 
+#include <linux/mm.h>
 #include <linux/sync_file.h>
 #include <linux/pfn_t.h>
 
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/lima: include used header file explicitly

Quoted 17 lines · Qiang Yu

To prevent build fail on some platform which does not have it in the include file chain.

Cc Neil Armstrong <[email protected]>
Fixes a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
---
 drivers/gpu/drm/lima/lima_gem.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/lima/lima_gem.c +0 -0
index 2d3cf96f6c58..1d69498bc17e 100644

drivers/gpu/drm/lima/lima_gem.c line 7

Quoted 7 lines
drivers/gpu/drm/lima/lima_gem.c +1 -0
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0 OR MIT
 /* Copyright 2017-2019 Qiang Yu <[email protected]> */
 
+#include <linux/mm.h>
 #include <linux/sync_file.h>
 #include <linux/pfn_t.h>
 

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer Applied
#3 lore raw

Re: [PATCH 2/2] drm/lima: include used header file explicitly

In reply to Qiang Yu

Pushed to drm-misc-next.

Thanks,
Qiang

Quoted 25 lines · Qiang Yu

To prevent build fail on some platform which does not have it in the include file chain.

Cc Neil Armstrong <[email protected]>
Fixes a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
---
 drivers/gpu/drm/lima/lima_gem.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/lima/lima_gem.c +1 -1
index 2d3cf96f6c58..1d69498bc17e 100644
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0 OR MIT
 /* Copyright 2017-2019 Qiang Yu <[email protected]> */
 
+#include <linux/mm.h>
 #include <linux/sync_file.h>
 #include <linux/pfn_t.h>
 
--
Quoted 2 lines

2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reviewed-by on v1 1/2
#4 lore raw
In reply to Qiang Yu
Quoted 4 lines · Qiang Yu

Current implementation does not support MMU-less
plarforms.

Cc Randy Dunlap <[email protected]>

You could also add :

Like patch 2.

But you can fix it while applying it

Quoted 13 lines
Cc Neil Armstrong <[email protected]>
Fixes a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
---
 drivers/gpu/drm/lima/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/lima/Kconfig +0 -0
index f11314448093..bb4ddc6bb0a6 100644

drivers/gpu/drm/lima/Kconfig config DRM_LIMA · line 13

Quoted 9 lines
drivers/gpu/drm/lima/Kconfig +3 -0
@@ -5,6 +5,9 @@ config DRM_LIMA
        tristate "LIMA (DRM support for ARM Mali 400/450 GPU)"
        depends on DRM
        depends on ARM || ARM64 || COMPILE_TEST
+       depends on MMU
+       depends on COMMON_CLK
+       depends on OF
        select DRM_SCHED
        help
          DRM driver for ARM Mali 400/450 GPUs.

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

author maintainer
#5 lore raw
In reply to Qiang Yu

Modify comments and pushed to drm-misc-next.

Thanks,
Qiang

Quoted 27 lines · Qiang Yu

Current implementation does not support MMU-less
plarforms.

Cc Randy Dunlap <[email protected]>
Cc Neil Armstrong <[email protected]>
Fixes a1d2a6339961 ("drm/lima: driver for ARM Mali4xx GPUs")
---
 drivers/gpu/drm/lima/Kconfig | 3 +++
 1 file changed, 3 insertions(+)
drivers/gpu/drm/lima/Kconfig +3 -1
index f11314448093..bb4ddc6bb0a6 100644
@@ -5,6 +5,9 @@ config DRM_LIMA
        tristate "LIMA (DRM support for ARM Mali 400/450 GPU)"
        depends on DRM
        depends on ARM || ARM64 || COMPILE_TEST
+       depends on MMU
+       depends on COMMON_CLK
+       depends on OF
        select DRM_SCHED
        help
          DRM driver for ARM Mali 400/450 GPUs.
--
Quoted 2 lines

2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel