Skip to contentSkip to conversation

vhost: reject zero size iova range

PATCH In review Jason Wang 3 participants 5 messages Apr 9, 2019 – Apr 11, 2019

Subsystems (5)
lore
Share & tools
lore

Jason Wang

author
#0 lore raw

PATCH 1/1 vhost: reject zero size iova range

We used to accept zero size iova range which will lead a infinite loop in translate_desc(). Fixing this by failing the request in this case.

Reported-by [email protected]
Fixes 6b1e6cc7 ("vhost: new device IOTLB API")
---
 drivers/vhost/vhost.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/vhost/vhost.c +5 -1
index 5ace833de746..351af88231ad 100644
@@ -911,8 +911,12 @@ static int vhost_new_umem_range(struct vhost_umem *umem,
 				u64 start, u64 size, u64 end,
 				u64 userspace_addr, int perm)
 {
-	struct vhost_umem_node *tmp, *node = kmalloc(sizeof(*node), GFP_ATOMIC);
+	struct vhost_umem_node *tmp, *node;
 
+	if (!size)
+		return -EFAULT;
+
+	node = kmalloc(sizeof(*node), GFP_ATOMIC);
 	if (!node)
 		return -ENOMEM;
 
Signature · 1 line
2.19.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jason Wang

We used to accept zero size iova range which will lead a infinite loop in translate_desc(). Fixing this by failing the request in this case.

Reported-by [email protected]
Fixes 6b1e6cc7 ("vhost: new device IOTLB API")

Seems appropriate for stable.

Quoted 24 lines
---
 drivers/vhost/vhost.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/vhost/vhost.c +5 -1
index 5ace833de746..351af88231ad 100644
@@ -911,8 +911,12 @@ static int vhost_new_umem_range(struct vhost_umem *umem,
 				u64 start, u64 size, u64 end,
 				u64 userspace_addr, int perm)
 {
-	struct vhost_umem_node *tmp, *node = kmalloc(sizeof(*node), GFP_ATOMIC);
+	struct vhost_umem_node *tmp, *node;
 
+	if (!size)
+		return -EFAULT;
+
+	node = kmalloc(sizeof(*node), GFP_ATOMIC);
 	if (!node)
 		return -ENOMEM;
 
Signature · 1 line
2.19.1
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Jason Wang
Quoted 6 lines · Jason Wang

We used to accept zero size iova range which will lead a infinite loop in translate_desc(). Fixing this by failing the request in this case.

Reported-by [email protected]
Fixes 6b1e6cc7 ("vhost: new device IOTLB API")

Seems appropriate for stable.

Quoted 24 lines
---
 drivers/vhost/vhost.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/vhost/vhost.c +5 -1
index 5ace833de746..351af88231ad 100644
@@ -911,8 +911,12 @@ static int vhost_new_umem_range(struct vhost_umem *umem,
 				u64 start, u64 size, u64 end,
 				u64 userspace_addr, int perm)
 {
-	struct vhost_umem_node *tmp, *node = kmalloc(sizeof(*node), GFP_ATOMIC);
+	struct vhost_umem_node *tmp, *node;
 
+	if (!size)
+		return -EFAULT;
+
+	node = kmalloc(sizeof(*node), GFP_ATOMIC);
 	if (!node)
 		return -ENOMEM;
 
Signature · 1 line
2.19.1