Skip to contentSkip to conversation

riscv: set preboot and increase kernel size

PATCH New David Abdurachmanov 6 participants 16 messages Apr 9, 2019 – May 9, 2019 2 messages not in the archive RISC-V

lore
Share & tools
lore
#0 lore raw

cover riscv: set preboot and increase kernel size

The following two changes are used by Fedora/RISCV with 5.1-rc3+ kernel using OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

Cc rick at andestech.com
Cc atish.patra at wdc.com
Cc Anup.Patel at wdc.com
Cc lukas.auer at aisec.fraunhofer.de

David Abdurachmanov (2):
riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M
riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

 include/configs/qemu-riscv.h | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/qemu-riscv.h +6 -6
index 2588c5a0b2..22a5cd7365 100644
@@ -15,7 +15,7 @@
 
 #define CONFIG_SYS_MALLOC_LEN		SZ_8M
 
-#define CONFIG_SYS_BOOTM_LEN		SZ_16M
+#define CONFIG_SYS_BOOTM_LEN		SZ_64M
 
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
 
@@ -41,11 +41,11 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
-	"kernel_addr_r=0x81000000\0" \
-	"fdt_addr_r=0x82000000\0" \
-	"scriptaddr=0x82100000\0" \
-	"pxefile_addr_r=0x82200000\0" \
-	"ramdisk_addr_r=0x82300000\0" \
+	"kernel_addr_r=0x84000000\0" \
+	"fdt_addr_r=0x88000000\0" \
+	"scriptaddr=0x88100000\0" \
+	"pxefile_addr_r=0x88200000\0" \
+	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
 #endif /* __CONFIG_H */
Signature · 1 line
2.20.1
#2 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

Quoted 29 lines · David Abdurachmanov

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/qemu-riscv.h +1 -1
index 2588c5a0b2..22a5cd7365 100644
@@ -15,7 +15,7 @@
 
 #define CONFIG_SYS_MALLOC_LEN		SZ_8M
 
-#define CONFIG_SYS_BOOTM_LEN		SZ_16M
+#define CONFIG_SYS_BOOTM_LEN		SZ_64M
 
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
 
@@ -41,11 +41,11 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \

include/configs/qemu-riscv.h line 48

Quoted 10 lines
include/configs/qemu-riscv.h +5 -5
-	"kernel_addr_r=0x81000000\0" \
-	"fdt_addr_r=0x82000000\0" \
-	"scriptaddr=0x82100000\0" \
-	"pxefile_addr_r=0x82200000\0" \
-	"ramdisk_addr_r=0x82300000\0" \
+	"kernel_addr_r=0x84000000\0" \
+	"fdt_addr_r=0x88000000\0" \
+	"scriptaddr=0x88100000\0" \
+	"pxefile_addr_r=0x88200000\0" \
+	"ramdisk_addr_r=0x88300000\0" \

As a follow-up, I really dislike fdt_high/initrd_high being set such that we disable relocation, that just leads to down the line "kernel/initrd grew, was overwritten". We should be using bootm_size to define the area in memory that everything can reside in, so that U-Boot can be smart about relocations.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190409/2334c9db/attachment.sig>
#3 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

In reply to David Abdurachmanov
Quoted 54 lines

-----Original Message-----
From: David Abdurachmanov <[email protected]>
Sent: Tuesday, April 9, 2019 4:13 PM
To: rick at andestech.com; Atish Patra <[email protected]>; Anup Patel <[email protected]>; lukas.auer at aisec.fraunhofer.de; u- boot at lists.denx.de
Cc: David Abdurachmanov <[email protected]>
Subject: [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/qemu-riscv.h +6 -7
index 2588c5a0b2..22a5cd7365 100644
@@ -15,7 +15,7 @@
 
 #define CONFIG_SYS_MALLOC_LEN		SZ_8M
 
-#define CONFIG_SYS_BOOTM_LEN		SZ_16M
+#define CONFIG_SYS_BOOTM_LEN		SZ_64M
 
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
 
@@ -41,11 +41,11 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
-	"kernel_addr_r=0x81000000\0" \
-	"fdt_addr_r=0x82000000\0" \
-	"scriptaddr=0x82100000\0" \
-	"pxefile_addr_r=0x82200000\0" \
-	"ramdisk_addr_r=0x82300000\0" \
+	"kernel_addr_r=0x84000000\0" \
+	"fdt_addr_r=0x88000000\0" \
+	"scriptaddr=0x88100000\0" \
+	"pxefile_addr_r=0x88200000\0" \
+	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
 #endif /* __CONFIG_H */
--
Quoted 1 line

2.20.1

Looks good to me.

Regards,
Anup

#4 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

In reply to David Abdurachmanov

+ Bin
[Please use get_maintainer or patman to include all maintainers on CC]

Quoted 26 lines · David Abdurachmanov

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/qemu-riscv.h +1 -1
index 2588c5a0b2..22a5cd7365 100644
@@ -15,7 +15,7 @@
 
 #define CONFIG_SYS_MALLOC_LEN		SZ_8M
 
-#define CONFIG_SYS_BOOTM_LEN		SZ_16M
+#define CONFIG_SYS_BOOTM_LEN		SZ_64M
 
 #define CONFIG_STANDALONE_LOAD_ADDR	0x80200000
 

include/configs/qemu-riscv.h line 44

Quoted 9 lines
include/configs/qemu-riscv.h +1 -5
@@ -41,11 +41,11 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"fdt_high=0xffffffffffffffff\0" \
 	"initrd_high=0xffffffffffffffff\0" \
-	"kernel_addr_r=0x81000000\0" \
-	"fdt_addr_r=0x82000000\0" \
-	"scriptaddr=0x82100000\0" \
-	"pxefile_addr_r=0x82200000\0" \
-	"ramdisk_addr_r=0x82300000\0" \
+	"kernel_addr_r=0x84000000\0" \

Why are you also moving kernel_addr_r?

Thanks,
Lukas

Quoted 7 lines
include/configs/qemu-riscv.h +4 -0
+	"fdt_addr_r=0x88000000\0" \
+	"scriptaddr=0x88100000\0" \
+	"pxefile_addr_r=0x88200000\0" \
+	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
 #endif /* __CONFIG_H */
#5 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

Quoted 3 lines · Lukas

+ Bin
[Please use get_maintainer or patman to include all maintainers on CC]

Thanks.

Hm.. get_maintainer and patman are not mentioned on wiki page:
"Patches and Feature Requests". It only mentions to CC people from:
http://www.denx.de/wiki/U-Boot/Custodians

Quoted 27 lines · David Abdurachmanov
Quoted 25 lines

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/qemu-riscv.h +1 -1
index 2588c5a0b2..22a5cd7365 100644
@@ -15,7 +15,7 @@
 
 #define CONFIG_SYS_MALLOC_LEN                SZ_8M
 
-#define CONFIG_SYS_BOOTM_LEN         SZ_16M
+#define CONFIG_SYS_BOOTM_LEN         SZ_64M
 
 #define CONFIG_STANDALONE_LOAD_ADDR  0x80200000
 
Quoted 12 lines

include/configs/qemu-riscv.h line 44

Quoted 10 lines
include/configs/qemu-riscv.h +1 -5
@@ -41,11 +41,11 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
      "fdt_high=0xffffffffffffffff\0" \
      "initrd_high=0xffffffffffffffff\0" \
-     "kernel_addr_r=0x81000000\0" \
-     "fdt_addr_r=0x82000000\0" \
-     "scriptaddr=0x82100000\0" \
-     "pxefile_addr_r=0x82200000\0" \
-     "ramdisk_addr_r=0x82300000\0" \
+     "kernel_addr_r=0x84000000\0" \

Why are you also moving kernel_addr_r?

I think there two 16MB windows here for kernel:
- 0x80000000 - 0x81000000 (kernel_addr_r), and kernel is loaded at 0x80200000
- 0x81000000 (kernel_addr_r) - 0x82000000 (fdt_addr_r)

From U-Boot documentation:

[..]
236 kernel_addr_r:
237
238 Mandatory. The location in RAM where the kernel will be loaded
to when
239 processing the kernel option in the extlinux.conf.
[..]

Thus I moved it to ensure that both windows are 64MB.

Quoted 11 lines

Thanks,
Lukas

Quoted 7 lines
include/configs/qemu-riscv.h +4 -0
+     "fdt_addr_r=0x88000000\0" \
+     "scriptaddr=0x88100000\0" \
+     "pxefile_addr_r=0x88200000\0" \
+     "ramdisk_addr_r=0x88300000\0" \
      BOOTENV
 
 #endif /* __CONFIG_H */
#6 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

Quoted 11 lines · David Abdurachmanov
Quoted 2 lines · Lukas

+ Bin
[Please use get_maintainer or patman to include all maintainers on CC]

Thanks.

Hm.. get_maintainer and patman are not mentioned on wiki page:
"Patches and Feature Requests". It only mentions to CC people from:
http://www.denx.de/wiki/U-Boot/Custodians

Hm, you are right, it's not really stated explicitly.

Quoted 53 lines
Quoted 26 lines · David Abdurachmanov
Quoted 25 lines

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
include/configs/qemu-riscv.h +1 -1
index 2588c5a0b2..22a5cd7365 100644
@@ -15,7 +15,7 @@
 
 #define CONFIG_SYS_MALLOC_LEN                SZ_8M
 
-#define CONFIG_SYS_BOOTM_LEN         SZ_16M
+#define CONFIG_SYS_BOOTM_LEN         SZ_64M
 
 #define CONFIG_STANDALONE_LOAD_ADDR  0x80200000
 
Quoted 12 lines

include/configs/qemu-riscv.h line 44

Quoted 10 lines
include/configs/qemu-riscv.h +1 -5
@@ -41,11 +41,11 @@
 #define CONFIG_EXTRA_ENV_SETTINGS \
      "fdt_high=0xffffffffffffffff\0" \
      "initrd_high=0xffffffffffffffff\0" \
-     "kernel_addr_r=0x81000000\0" \
-     "fdt_addr_r=0x82000000\0" \
-     "scriptaddr=0x82100000\0" \
-     "pxefile_addr_r=0x82200000\0" \
-     "ramdisk_addr_r=0x82300000\0" \
+     "kernel_addr_r=0x84000000\0" \

Why are you also moving kernel_addr_r?

I think there two 16MB windows here for kernel:
- 0x80000000 - 0x81000000 (kernel_addr_r), and kernel is loaded at 0x80200000
- 0x81000000 (kernel_addr_r) - 0x82000000 (fdt_addr_r)

From U-Boot documentation:

[..]
236 kernel_addr_r:
237
238 Mandatory. The location in RAM where the kernel will be loaded
to when
239 processing the kernel option in the extlinux.conf.
[..]

Quoted 2 lines

Thus I moved it to ensure that both windows are 64MB.

Ok you are right, that makes sense.

#7 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

In reply to David Abdurachmanov
Quoted 5 lines · David Abdurachmanov

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

Quoted 8 lines

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

A message that is not in the archive (sent off-list or not yet received): [email protected]

#9 lore raw

PATCH 1/2 riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

Quoted 13 lines

Subject: Re: [U-Boot] [PATCH 1/2] riscv: set CONFIG_SYS_BOOTM_LEN to SZ_64M

Quoted 8 lines · David Abdurachmanov

After updating Fedora/RISCV kernel to 5.1-rc3+ the size increased above the current threshold. Looking into HiKey, Dragonboards, etc. seems that SZ_64M is a popular option.

This sucessfully boots Fedora/RISCV with 5.1-rc3+ kernel on QEMU 4.0 (master) with OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

Quoted 7 lines
Quoted 5 lines
---
 include/configs/qemu-riscv.h | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Applied to u-boot-riscv/master, thanks!

#10 lore raw

PATCH 2/2 riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

In reply to David Abdurachmanov

- Set fdt_addr variable, which is needed for extlinux to find FDT. Otherwise booting kernel using extlinux results in missing FDT.

- Also run fdt addr with FDT address so that fdt commands would work out of the box in U-Boot prompt.

This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/qemu-riscv.h +4 -0
index 22a5cd7365..b7110edebc 100644
@@ -48,4 +48,8 @@
 	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
+#define CONFIG_PREBOOT \
+	"setenv fdt_addr ${fdtcontroladdr};" \
+	"fdt addr ${fdtcontroladdr};"
+
 #endif /* __CONFIG_H */
Signature · 1 line
2.20.1
#11 lore raw

PATCH 2/2 riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

Quoted 40 lines

-----Original Message-----
From: David Abdurachmanov <[email protected]>
Sent: Tuesday, April 9, 2019 4:13 PM
To: rick at andestech.com; Atish Patra <[email protected]>; Anup Patel <[email protected]>; lukas.auer at aisec.fraunhofer.de; u- boot at lists.denx.de
Cc: David Abdurachmanov <[email protected]>
Subject: [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

- Set fdt_addr variable, which is needed for extlinux to find FDT. Otherwise booting kernel using extlinux results in missing FDT.

- Also run fdt addr with FDT address so that fdt commands would work out of the box in U-Boot prompt.

This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/qemu-riscv.h +4 -1
index 22a5cd7365..b7110edebc 100644
@@ -48,4 +48,8 @@
 	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
+#define CONFIG_PREBOOT \
+	"setenv fdt_addr ${fdtcontroladdr};" \
+	"fdt addr ${fdtcontroladdr};"
+
 #endif /* __CONFIG_H */
--
Quoted 1 line

2.20.1

Looks good to me.

Regards,
Anup

#12 lore raw

PATCH 2/2 riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

In reply to David Abdurachmanov

+ Bin

Quoted 5 lines · David Abdurachmanov

- Set fdt_addr variable, which is needed for extlinux to find FDT. Otherwise booting kernel using extlinux results in missing FDT.

- Also run fdt addr with FDT address so that fdt commands would work out of the box in U-Boot prompt.

While often useful to have, the fdt command is not used during a normal boot. I think we should avoid calling commands, which are not normally needed. Can you remove this from your patch?

Thanks,
Lukas

Quoted 22 lines

This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/qemu-riscv.h +4 -0
index 22a5cd7365..b7110edebc 100644
@@ -48,4 +48,8 @@
 	"ramdisk_addr_r=0x88300000\0" \
 	BOOTENV
 
+#define CONFIG_PREBOOT \
+	"setenv fdt_addr ${fdtcontroladdr};" \
+	"fdt addr ${fdtcontroladdr};"
+
 #endif /* __CONFIG_H */
#13 lore raw

PATCH 2/2 riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

Quoted 7 lines · Lukas

+ Bin

Quoted 3 lines · David Abdurachmanov

- Set fdt_addr variable, which is needed for extlinux to find FDT. Otherwise booting kernel using extlinux results in missing FDT.

Quoted 6 lines
Quoted 2 lines

- Also run fdt addr with FDT address so that fdt commands would work out of the box in U-Boot prompt.

While often useful to have, the fdt command is not used during a normal boot. I think we should avoid calling commands, which are not normally needed. Can you remove this from your patch?

I borrowed idea from other boards, and I find it useful to have fdt working out-of-the-box without trying to figure the correct variable which holds address of FDT.

I can remove it from the patch, but I will probably keep adding it as Fedora specific patch then.

Quoted 26 lines

Thanks,
Lukas

Quoted 22 lines

This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/qemu-riscv.h +4 -0
index 22a5cd7365..b7110edebc 100644
@@ -48,4 +48,8 @@
      "ramdisk_addr_r=0x88300000\0" \
      BOOTENV
 
+#define CONFIG_PREBOOT \
+     "setenv fdt_addr ${fdtcontroladdr};" \
+     "fdt addr ${fdtcontroladdr};"
+
 #endif /* __CONFIG_H */
#14 lore raw

PATCH 2/2 riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

Quoted 15 lines · David Abdurachmanov
Quoted 6 lines · Lukas

+ Bin

Quoted 3 lines · David Abdurachmanov

- Set fdt_addr variable, which is needed for extlinux to find FDT. Otherwise booting kernel using extlinux results in missing FDT.

Quoted 6 lines
Quoted 2 lines

- Also run fdt addr with FDT address so that fdt commands would work out of the box in U-Boot prompt.

While often useful to have, the fdt command is not used during a normal boot. I think we should avoid calling commands, which are not normally needed. Can you remove this from your patch?

Quoted 7 lines

I borrowed idea from other boards, and I find it useful to have fdt working out-of-the-box without trying to figure the correct variable which holds address of FDT.

I can remove it from the patch, but I will probably keep adding it as Fedora specific patch then.

That makes sense. I would still tend towards removing it, but will wait to see what everybody else thinks.

Other than that, the patch looks good to me.

Quoted 24 lines
Quoted 24 lines

Thanks,
Lukas

Quoted 21 lines

This is successfully used by Fedora/RISCV with 5.1-rc3+ kernel using OpenSBI -> U-Boot (S-mode) [extlinux] -> Kernel setup.

---
 include/configs/qemu-riscv.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/qemu-riscv.h +4 -0
index 22a5cd7365..b7110edebc 100644
@@ -48,4 +48,8 @@
      "ramdisk_addr_r=0x88300000\0" \
      BOOTENV
 
+#define CONFIG_PREBOOT \
+     "setenv fdt_addr ${fdtcontroladdr};" \
+     "fdt addr ${fdtcontroladdr};"
+
 #endif /* __CONFIG_H */
#15 lore raw

PATCH 2/2 riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

Quoted 21 lines · Lukas
Quoted 19 lines · David Abdurachmanov
Quoted 6 lines · Lukas

+ Bin

Quoted 3 lines · David Abdurachmanov

- Set fdt_addr variable, which is needed for extlinux to find FDT. Otherwise booting kernel using extlinux results in missing FDT.

Quoted 6 lines
Quoted 2 lines

- Also run fdt addr with FDT address so that fdt commands would work out of the box in U-Boot prompt.

While often useful to have, the fdt command is not used during a normal boot. I think we should avoid calling commands, which are not normally needed. Can you remove this from your patch?

I borrowed idea from other boards, and I find it useful to have fdt working out-of-the-box without trying to figure the correct variable which holds address of FDT.

Quoted 6 lines
Quoted 3 lines

I can remove it from the patch, but I will probably keep adding it as Fedora specific patch then.

That makes sense. I would still tend towards removing it, but will wait to see what everybody else thinks.

Yes, I am inclined to not include "fdt addr ${fdtcontroladdr};" too.

Quoted 5 lines

Other than that, the patch looks good to me.

Regards,
Bin

A message that is not in the archive (sent off-list or not yet received): [email protected]

#17 lore raw

PATCH 2/2 riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

Quoted 36 lines

Subject: Re: [PATCH 2/2] riscv: qemu-riscv.h: define CONFIG_PREBOOT (enables extlinux)

Quoted 21 lines · Lukas
Quoted 19 lines · David Abdurachmanov
Quoted 6 lines · Lukas

+ Bin

On Tue, 2019-04-09 at 12:42 +0200, David Abdurachmanov wrote:
- Set fdt_addr variable, which is needed for extlinux to find FDT. Otherwise booting kernel using extlinux results in missing FDT.

Quoted 6 lines

- Also run fdt addr with FDT address so that fdt commands would work out of the box in U-Boot prompt.

While often useful to have, the fdt command is not used during a normal boot. I think we should avoid calling commands, which are not normally needed. Can you remove this from your patch?

I borrowed idea from other boards, and I find it useful to have fdt working out-of-the-box without trying to figure the correct variable which holds address of FDT.

Quoted 6 lines
Quoted 3 lines

I can remove it from the patch, but I will probably keep adding it as Fedora specific patch then.

That makes sense. I would still tend towards removing it, but will wait to see what everybody else thinks.

Yes, I am inclined to not include "fdt addr ${fdtcontroladdr};" too.

Quoted 1 line
Quoted 6 lines
Quoted 4 lines

Other than that, the patch looks good to me.

Applied to u-boot-riscv/master, thanks!