Skip to contentSkip to conversation

ARM: dts: imx6: RDU2: Use new CODEC reset pin name

PATCH In review Andrew F. Davis 3 participants 6 messages Mar 29, 2019 – Apr 11, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/4 ARM: dts: imx6: RDU2: Use new CODEC reset pin name

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here.

Note the GPIO polarity in the driver was ignored before and always assumed to be active low, when all the DTs are fixed we will start respecting the specified polarity. Switch polarity in DT to the currently assumed one, this way when the driver changes the behavior will not change.

---
 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi +2 -2
index 69942c7ff89d..cbf7c9cae565 100644
@@ -384,7 +384,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
 	};
 
 	accel@1c {
@@ -572,7 +572,7 @@
 		AVDD-supply = <&reg_3p3v>;
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&vgen4_reg>;
-		gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+		reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
 	};
 
 	touchscreen@20 {
Signature · 1 line
2.21.0
#1 lore raw

PATCH 2/4 ARM: dts: imx: Use new CODEC reset pin name

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here.

---
 arch/arm/boot/dts/imx6qdl-gw5903.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-gw5903.dtsi +1 -1
index 9cb9a7439121..aee9221f0f29 100644
@@ -311,7 +311,7 @@
 	tlv320aic3105: codec@18 {
 		compatible = "ti,tlv320aic3x";
 		reg = <0x18>;
-		gpio-reset = <&gpio5 17 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 17 GPIO_ACTIVE_LOW>;
 		clocks = <&clks IMX6QDL_CLK_CKO>;
 		ai3x-micbias-vg = <2>; /* MICBIAS_2_5V */
 		/* Regulators */
Signature · 1 line
2.21.0
#2 lore raw

PATCH 3/4 ARM: dts: imx6qdl: Use new CODEC reset pin name

In reply to Andrew F. Davis

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here.

---
 arch/arm/boot/dts/imx6qdl-var-dart.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl-var-dart.dtsi +1 -1
index 8752a4961c47..c41cac502bac 100644
@@ -183,7 +183,7 @@
 		IOVDD-supply = <&reg_3p3v>;
 		DVDD-supply = <&reg_3p3v>;
 		ai3x-ocmv = <0>;
-		gpio-reset = <&gpio5 5 GPIO_ACTIVE_LOW>;
+		reset-gpios = <&gpio5 5 GPIO_ACTIVE_LOW>;
 	};
 };
 
Signature · 1 line
2.21.0
#3 lore raw

PATCH 4/4 ARM: dts: omap2420-n810: Use new CODEC reset pin name

In reply to Andrew F. Davis

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here.

---
 arch/arm/boot/dts/omap2420-n810.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/omap2420-n810.dts +1 -1
index 96b9913ecc1f..09c1dbc0bb69 100644
@@ -48,7 +48,7 @@
 		pinctrl-names = "default";
 		pinctrl-0 = <&aic33_pins>;
 
-		gpio-reset = <&gpio4 22 GPIO_ACTIVE_LOW>; /* gpio118 */
+		reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; /* gpio118 */
 
 		ai3x-gpio-func = <
 			10 /* AIC3X_GPIO1_FUNC_DIGITAL_MIC_MODCLK */
Signature · 1 line
2.21.0
#4 lore raw

Re: [PATCH 4/4] ARM: dts: omap2420-n810: Use new CODEC reset pin name

Quoted 2 lines · Andrew F. Davis

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here.

I'll apply this patch into omap-for-v5.2/dt thanks.

Tony

#5 lore raw
In reply to Andrew F. Davis
Quoted 10 lines · Andrew F. Davis

The correct DT property for specifying a GPIO used for reset is "reset-gpios", the driver now accepts this name, use it here.

Note the GPIO polarity in the driver was ignored before and always assumed to be active low, when all the DTs are fixed we will start respecting the specified polarity. Switch polarity in DT to the currently assumed one, this way when the driver changes the behavior will not change.

I fixed up the prefix to use board name, and applied patch #1 ~ #3.

Shawn