Skip to contentSkip to conversation

colibri imx8qxp 2gb wb it v1.0b module support

PATCH Superseded Marcel Ziswiler 5 participants 25 messages Apr 9, 2019 – Apr 26, 2019

Subsystems (4)

v2 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v2 cover colibri imx8qxp 2gb wb it v1.0b module support

This series fixes the i.MX 8QXP SCFW API header file, adds support for more lpuart instances, cleans-up and extends the Toradex SKU handling and last but not least introduces support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module.

This series is available together with my previous series addressing Apalis and Colibri iMX6 as well as Colibri Vybrid aka VF50/VF61 and Colibri iMX6ULL on our git server [1].

[1] http://git.toradex.com/cgit/u-boot-toradex.git/log/?h=for-next

Changes in v2:
- Added Peng and Igor's reviewed-by.
- Added Peng and Igor's reviewed-by.
- Added Igor's reviewed-by.
- Added Igor's reviewed-by.
- Changed imx-atf git clone command to include initial branch information as suggested by Igor.
- Sorted board file includes alphabetically as suggested by Igor.
- Got rid of SPL configuration in legacy header file as suggested by Igor and the whole use of SPL on i.MX 8X anyway neither works well nor makes any much sense at all.

Marcel Ziswiler (5):
misc: imx8: remove duplicates from scfw api
arm: dts: imx8dx: add lpuart1, lpuart2, lpuart3
board: toradex: tdx-cfg-block: clean-up sku handling
board: toradex: tdx-cfg-block: add new skus
board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

 arch/arm/dts/Makefile                         |   4 +-
 arch/arm/dts/fsl-imx8dx.dtsi                  |  54 +++
 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  | 112 ++++++
 arch/arm/dts/fsl-imx8qxp-colibri.dts          | 328 ++++++++++++++++++
 arch/arm/include/asm/arch-imx8/sci/sci.h      |   4 -
 arch/arm/mach-imx/imx8/Kconfig                |   6 +
 board/toradex/colibri-imx8qxp/Kconfig         |  30 ++
 board/toradex/colibri-imx8qxp/MAINTAINERS     |   9 +
 board/toradex/colibri-imx8qxp/Makefile        |   7 +
 board/toradex/colibri-imx8qxp/README          |  66 ++++
 .../toradex/colibri-imx8qxp/colibri-imx8qxp.c | 212 +++++++++++
 board/toradex/colibri-imx8qxp/imximage.cfg    |  24 ++
 board/toradex/common/tdx-cfg-block.c          |  19 +-
 board/toradex/common/tdx-cfg-block.h          |  29 +-
 configs/colibri-imx8qxp_defconfig             |  53 +++
 include/configs/colibri-imx8qxp.h             | 214 ++++++++++++
 16 files changed, 1152 insertions(+), 19 deletions(-)
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri.dts
 create mode 100644 board/toradex/colibri-imx8qxp/Kconfig
 create mode 100644 board/toradex/colibri-imx8qxp/MAINTAINERS
 create mode 100644 board/toradex/colibri-imx8qxp/Makefile
 create mode 100644 board/toradex/colibri-imx8qxp/README
 create mode 100644 board/toradex/colibri-imx8qxp/colibri-imx8qxp.c
 create mode 100644 board/toradex/colibri-imx8qxp/imximage.cfg
 create mode 100644 configs/colibri-imx8qxp_defconfig
 create mode 100644 include/configs/colibri-imx8qxp.h
Signature · 1 line
2.20.1
#1 lore raw

PATCH v2 1/5 misc: imx8: remove duplicates from scfw api

From: Marcel Ziswiler <[email protected]>

Remove duplicate function declarations from the SCFW API header file.

---

Changes in v2:
- Added Peng and Igor's reviewed-by.

 arch/arm/include/asm/arch-imx8/sci/sci.h | 4 ----
 1 file changed, 4 deletions(-)
arch/arm/include/asm/arch-imx8/sci/sci.h +0 -4
index d1621669e2..97377697f0 100644
@@ -62,10 +62,6 @@ int sc_pm_set_clock_rate(sc_ipc_t ipc, sc_rsrc_t resource, sc_pm_clk_t clk,
 			 sc_pm_clock_rate_t *rate);
 int sc_pm_get_clock_rate(sc_ipc_t ipc, sc_rsrc_t resource, sc_pm_clk_t clk,
 			 sc_pm_clock_rate_t *rate);
-int sc_pm_set_clock_rate(sc_ipc_t ipc, sc_rsrc_t resource, sc_pm_clk_t clk,
-			 sc_pm_clock_rate_t *rate);
-int sc_pm_get_clock_rate(sc_ipc_t ipc, sc_rsrc_t resource, sc_pm_clk_t clk,
-			 sc_pm_clock_rate_t *rate);
 int sc_pm_clock_enable(sc_ipc_t ipc, sc_rsrc_t resource, sc_pm_clk_t clk,
 		       sc_bool_t enable, sc_bool_t autog);
 
Signature · 1 line
2.20.1
#2 lore raw

PATCH v2 1/5 misc: imx8: remove duplicates from scfw api

Quoted 5 lines

From: Marcel Ziswiler <[email protected]>
Remove duplicate function declarations from the SCFW API header file.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#3 lore raw

PATCH v2 2/5 arm: dts: imx8dx: add lpuart1, lpuart2, lpuart3

In reply to Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add support for lpuart1, lpuart2 and lpuart3.

---

Changes in v2:
- Added Peng and Igor's reviewed-by.

 arch/arm/dts/fsl-imx8dx.dtsi | 54 ++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
arch/arm/dts/fsl-imx8dx.dtsi +54 -0
index 3b1a2a20e3..715abb413d 100644
@@ -236,6 +236,21 @@
 				power-domains = <&pd_dma>;
 				wakeup-irq = <225>;
 			};
+			pd_dma_lpuart1: PD_DMA_UART1 {
+				reg = <SC_R_UART_1>;
+				#power-domain-cells = <0>;
+				power-domains = <&pd_dma>;
+			};
+			pd_dma_lpuart2: PD_DMA_UART2 {
+				reg = <SC_R_UART_2>;
+				#power-domain-cells = <0>;
+				power-domains = <&pd_dma>;
+			};
+			pd_dma_lpuart3: PD_DMA_UART3 {
+				reg = <SC_R_UART_3>;
+				#power-domain-cells = <0>;
+				power-domains = <&pd_dma>;
+			};
 		};
 	};
 
@@ -402,6 +417,45 @@
 		status = "disabled";
 	};
 
+	lpuart1: serial at 5a070000 {
+		compatible = "fsl,imx8qm-lpuart";
+		reg = <0x0 0x5a070000 0x0 0x1000>;
+		interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&clk IMX8QXP_UART1_CLK>,
+			 <&clk IMX8QXP_UART1_IPG_CLK>;
+		clock-names = "per", "ipg";
+		assigned-clocks = <&clk IMX8QXP_UART1_CLK>;
+		assigned-clock-rates = <80000000>;
+		power-domains = <&pd_dma_lpuart1>;
+		status = "disabled";
+	};
+
+	lpuart2: serial at 5a080000 {
+		compatible = "fsl,imx8qm-lpuart";
+		reg = <0x0 0x5a080000 0x0 0x1000>;
+		interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&clk IMX8QXP_UART2_CLK>,
+			 <&clk IMX8QXP_UART2_IPG_CLK>;
+		clock-names = "per", "ipg";
+		assigned-clocks = <&clk IMX8QXP_UART2_CLK>;
+		assigned-clock-rates = <80000000>;
+		power-domains = <&pd_dma_lpuart2>;
+		status = "disabled";
+	};
+
+	lpuart3: serial at 5a090000 {
+		compatible = "fsl,imx8qm-lpuart";
+		reg = <0x0 0x5a090000 0x0 0x1000>;
+		interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
+		clocks = <&clk IMX8QXP_UART3_CLK>,
+			 <&clk IMX8QXP_UART3_IPG_CLK>;
+		clock-names = "per", "ipg";
+		assigned-clocks = <&clk IMX8QXP_UART3_CLK>;
+		assigned-clock-rates = <80000000>;
+		power-domains = <&pd_dma_lpuart3>;
+		status = "disabled";
+	};
+
 	usdhc1: usdhc at 5b010000 {
 		compatible = "fsl,imx8qm-usdhc", "fsl,imx6sl-usdhc";
 		interrupt-parent = <&gic>;
Signature · 1 line
2.20.1
#4 lore raw

PATCH v2 2/5 arm: dts: imx8dx: add lpuart1, lpuart2, lpuart3

Quoted 5 lines

From: Marcel Ziswiler <[email protected]> Add support for lpuart1, lpuart2 and lpuart3.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#5 lore raw

PATCH v2 3/5 board: toradex: tdx-cfg-block: clean-up sku handling

In reply to Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Clean-up handling of several SKUs.

---

Changes in v2:
- Added Igor's reviewed-by.

 board/toradex/common/tdx-cfg-block.c | 12 ++++++++----
 board/toradex/common/tdx-cfg-block.h | 22 ++++++++++++----------
 2 files changed, 20 insertions(+), 14 deletions(-)
board/toradex/common/tdx-cfg-block.c +8 -4
index 71ff40cfad..7e529afc7f 100644
@@ -6,7 +6,9 @@
 #include <common.h>
 #include "tdx-cfg-block.h"
 
-#if defined(CONFIG_TARGET_APALIS_IMX6) || defined(CONFIG_TARGET_COLIBRI_IMX6)
+#if defined(CONFIG_TARGET_APALIS_IMX6) || \
+	defined(CONFIG_TARGET_COLIBRI_IMX6) || \
+	defined(CONFIG_TARGET_COLIBRI_IMX8QXP)
 #include <asm/arch/sys_proto.h>
 #else
 #define is_cpu_type(cpu) (0)
@@ -92,10 +94,10 @@ const char * const toradex_modules[] = {
 	[34] = "Apalis TK1 2GB",
 	[35] = "Apalis iMX6 Dual 1GB IT",
 	[36] = "Colibri iMX6ULL 256MB",
-	[37] = "Apalis iMX8 QuadMax 4GB Wi-Fi / Bluetooth",
-	[38] = "Colibri iMX8X",
+	[37] = "Apalis iMX8 QuadMax 4GB Wi-Fi / BT IT",
+	[38] = "Colibri iMX8 QuadXPlus 2GB Wi-Fi / BT IT",
 	[39] = "Colibri iMX7 Dual 1GB (eMMC)",
-	[40] = "Colibri iMX6ULL 512MB Wi-Fi / Bluetooth IT",
+	[40] = "Colibri iMX6ULL 512MB Wi-Fi / BT IT",
 	[41] = "Colibri iMX7 Dual 512MB EPDC",
 	[42] = "Apalis TK1 4GB",
 	[43] = "Colibri T20 512MB IT SETEK",
@@ -340,6 +342,8 @@ static int get_cfgblock_interactive(void)
 		tdx_hw_tag.prodid = COLIBRI_IMX7D;
 	else if (!strcmp("imx7s", soc))
 		tdx_hw_tag.prodid = COLIBRI_IMX7S;
+	else if (is_cpu_type(MXC_CPU_IMX8QXP))
+		tdx_hw_tag.prodid = COLIBRI_IMX8QXP_WIFI_BT_IT;
 	else if (!strcmp("tegra20", soc)) {
 		if (it == 'y' || it == 'Y')
 			if (gd->ram_size == 0x10000000)
board/toradex/common/tdx-cfg-block.h +12 -10
index 961bb4394f..b20b522e1d 100644
@@ -25,42 +25,44 @@ enum {
 	COLIBRI_PXA270_V1_520MHZ,
 	COLIBRI_PXA320,
 	COLIBRI_PXA300,
-	COLIBRI_PXA310,
+	COLIBRI_PXA310, /* 5 */
 	COLIBRI_PXA320_IT,
 	COLIBRI_PXA300_XT,
 	COLIBRI_PXA270_312MHZ,
 	COLIBRI_PXA270_520MHZ,
-	COLIBRI_VF50, /* not currently on sale */
-	COLIBRI_VF61,
+	COLIBRI_VF50, /* 10 */
+	COLIBRI_VF61, /* not currently on sale */
 	COLIBRI_VF61_IT,
 	COLIBRI_VF50_IT,
 	COLIBRI_IMX6S,
-	COLIBRI_IMX6DL,
+	COLIBRI_IMX6DL, /* 15 */
 	COLIBRI_IMX6S_IT,
 	COLIBRI_IMX6DL_IT,
+	/* 18 */
+	/* 19 */
 	COLIBRI_T20_256MB = 20,
 	COLIBRI_T20_512MB,
 	COLIBRI_T20_512MB_IT,
 	COLIBRI_T30,
 	COLIBRI_T20_256MB_IT,
-	APALIS_T30_2GB,
+	APALIS_T30_2GB, /* 25 */
 	APALIS_T30_1GB,
 	APALIS_IMX6Q,
 	APALIS_IMX6Q_IT,
 	APALIS_IMX6D,
-	COLIBRI_T30_IT,
+	COLIBRI_T30_IT, /* 30 */
 	APALIS_T30_IT,
 	COLIBRI_IMX7S,
 	COLIBRI_IMX7D,
 	APALIS_TK1_2GB,
-	APALIS_IMX6D_IT,
+	APALIS_IMX6D_IT, /* 35 */
 	COLIBRI_IMX6ULL,
-	APALIS_IMX8QM, /* 37 */
-	COLIBRI_IMX8X,
+	APALIS_IMX8QM_WIFI_BT_IT,
+	COLIBRI_IMX8QXP_WIFI_BT_IT,
 	COLIBRI_IMX7D_EMMC,
 	COLIBRI_IMX6ULL_WIFI_BT_IT, /* 40 */
 	COLIBRI_IMX7D_EPDC,
-	APALIS_TK1_4GB,
+	APALIS_TK1_4GB, /* not currently on sale */
 	COLIBRI_T20_512MB_IT_SETEK,
 	COLIBRI_IMX6ULL_IT,
 	COLIBRI_IMX6ULL_WIFI_BT, /* 45 */
Signature · 1 line
2.20.1
#6 lore raw

PATCH v2 3/5 board: toradex: tdx-cfg-block: clean-up sku handling

Quoted 4 lines

From: Marcel Ziswiler <[email protected]> Clean-up handling of several SKUs.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#7 lore raw

PATCH v2 4/5 board: toradex: tdx-cfg-block: add new skus

In reply to Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

Add all the latest new SKUs:
- Apalis iMX8 QuadXPlus 2GB Wi-Fi / BT IT
- Apalis iMX8 QuadMax 4GB IT
- Apalis iMX8 QuadPlus 2GB Wi-Fi / BT
- Apalis iMX8 QuadPlus 2GB",
- Colibri iMX8 QuadXPlus 2GB IT
- Colibri iMX8 DualX 1GB Wi-Fi / Bluetooth
- Colibri iMX8 DualX 1GB

---

Changes in v2:
- Added Igor's reviewed-by.

 board/toradex/common/tdx-cfg-block.c | 7 +++++++
 board/toradex/common/tdx-cfg-block.h | 7 +++++++
 2 files changed, 14 insertions(+)
board/toradex/common/tdx-cfg-block.c +7 -0
index 7e529afc7f..f69c4433b2 100644
@@ -103,6 +103,13 @@ const char * const toradex_modules[] = {
 	[43] = "Colibri T20 512MB IT SETEK",
 	[44] = "Colibri iMX6ULL 512MB IT",
 	[45] = "Colibri iMX6ULL 512MB Wi-Fi / Bluetooth",
+	[46] = "Apalis iMX8 QuadXPlus 2GB Wi-Fi / BT IT",
+	[47] = "Apalis iMX8 QuadMax 4GB IT",
+	[48] = "Apalis iMX8 QuadPlus 2GB Wi-Fi / BT",
+	[49] = "Apalis iMX8 QuadPlus 2GB",
+	[50] = "Colibri iMX8 QuadXPlus 2GB IT",
+	[51] = "Colibri iMX8 DualX 1GB Wi-Fi / Bluetooth",
+	[52] = "Colibri iMX8 DualX 1GB",
 };
 
 #ifdef CONFIG_TDX_CFG_BLOCK_IS_IN_MMC
board/toradex/common/tdx-cfg-block.h +7 -0
index b20b522e1d..bfdc8b7f70 100644
@@ -66,6 +66,13 @@ enum {
 	COLIBRI_T20_512MB_IT_SETEK,
 	COLIBRI_IMX6ULL_IT,
 	COLIBRI_IMX6ULL_WIFI_BT, /* 45 */
+	APALIS_IMX8QXP_WIFI_BT_IT,
+	APALIS_IMX8QM_IT,
+	APALIS_IMX8QP_WIFI_BT,
+	APALIS_IMX8QP,
+	COLIBRI_IMX8QXP_IT, /* 50 */
+	COLIBRI_IMX8DX_WIFI_BT,
+	COLIBRI_IMX8DX,
 };
 
 extern const char * const toradex_modules[];
Signature · 1 line
2.20.1
#8 lore raw

PATCH v2 4/5 board: toradex: tdx-cfg-block: add new skus

Quoted 11 lines

From: Marcel Ziswiler <[email protected]> Add all the latest new SKUs:
- Apalis iMX8 QuadXPlus 2GB Wi-Fi / BT IT
- Apalis iMX8 QuadMax 4GB IT
- Apalis iMX8 QuadPlus 2GB Wi-Fi / BT
- Apalis iMX8 QuadPlus 2GB",
- Colibri iMX8 QuadXPlus 2GB IT
- Colibri iMX8 DualX 1GB Wi-Fi / Bluetooth
- Colibri iMX8 DualX 1GB

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#9 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

In reply to Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U-Boot supports either booting from the on-module eMMC or may be used for recovery purpose using the universal update utility (uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

---

Changes in v2:
- Changed imx-atf git clone command to include initial branch information as suggested by Igor.
- Sorted board file includes alphabetically as suggested by Igor.
- Got rid of SPL configuration in legacy header file as suggested by Igor and the whole use of SPL on i.MX 8X anyway neither works well nor makes any much sense at all.

 arch/arm/dts/Makefile                         |   4 +-
 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  | 112 ++++++
 arch/arm/dts/fsl-imx8qxp-colibri.dts          | 328 ++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   6 +
 board/toradex/colibri-imx8qxp/Kconfig         |  30 ++
 board/toradex/colibri-imx8qxp/MAINTAINERS     |   9 +
 board/toradex/colibri-imx8qxp/Makefile        |   7 +
 board/toradex/colibri-imx8qxp/README          |  66 ++++
 .../toradex/colibri-imx8qxp/colibri-imx8qxp.c | 212 +++++++++++
 board/toradex/colibri-imx8qxp/imximage.cfg    |  24 ++
 configs/colibri-imx8qxp_defconfig             |  53 +++
 include/configs/colibri-imx8qxp.h             | 214 ++++++++++++
 12 files changed, 1064 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri.dts
 create mode 100644 board/toradex/colibri-imx8qxp/Kconfig
 create mode 100644 board/toradex/colibri-imx8qxp/MAINTAINERS
 create mode 100644 board/toradex/colibri-imx8qxp/Makefile
 create mode 100644 board/toradex/colibri-imx8qxp/README
 create mode 100644 board/toradex/colibri-imx8qxp/colibri-imx8qxp.c
 create mode 100644 board/toradex/colibri-imx8qxp/imximage.cfg
 create mode 100644 configs/colibri-imx8qxp_defconfig
 create mode 100644 include/configs/colibri-imx8qxp.h
arch/arm/dts/Makefile +3 -1
index 13d1d67624..2a551d42a4 100644
@@ -559,7 +559,9 @@ dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
-dtb-$(CONFIG_ARCH_IMX8) += fsl-imx8qxp-mek.dtb
+dtb-$(CONFIG_ARCH_IMX8) += \
+	fsl-imx8qxp-colibri.dtb \
+	fsl-imx8qxp-mek.dtb
 
 dtb-$(CONFIG_ARCH_IMX8M) += fsl-imx8mq-evk.dtb
 
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi new file +112 -0

112 lines not on this page · raw message

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +328 -0

328 lines not on this page · raw message

arch/arm/mach-imx/imx8/Kconfig +6 -0
index f76a139684..feea07f135 100644
@@ -22,6 +22,11 @@ choice
 	prompt "i.MX8 board select"
 	optional
 
+config TARGET_COLIBRI_IMX8QXP
+	bool "Support Colibri iMX8QXP module"
+	select BOARD_LATE_INIT
+	select IMX8QXP
+
 config TARGET_IMX8QXP_MEK
 	bool "Support i.MX8QXP MEK board"
 	select BOARD_LATE_INIT
@@ -30,5 +35,6 @@ config TARGET_IMX8QXP_MEK
 endchoice
 
 source "board/freescale/imx8qxp_mek/Kconfig"
+source "board/toradex/colibri-imx8qxp/Kconfig"
 
 endif
board/toradex/colibri-imx8qxp/Kconfig new file +30 -0
new file mode 100644
index 0000000000..340fe72816
@@ -0,0 +1,30 @@
+if TARGET_COLIBRI_IMX8QXP
+
+config SYS_BOARD
+	default "colibri-imx8qxp"
+
+config SYS_VENDOR
+	default "toradex"
+
+config SYS_CONFIG_NAME
+	default "colibri-imx8qxp"
+
+config TDX_CFG_BLOCK
+	default y
+
+config TDX_HAVE_MMC
+	default y
+
+config TDX_CFG_BLOCK_DEV
+	default "0"
+
+config TDX_CFG_BLOCK_PART
+	default "1"
+
+# Toradex config block in eMMC, at the end of 1st "boot sector"
+config TDX_CFG_BLOCK_OFFSET
+	default "-512"
+
+source "board/toradex/common/Kconfig"
+
+endif
board/toradex/colibri-imx8qxp/MAINTAINERS new file +9 -0
new file mode 100644
index 0000000000..39a9eb79b7
@@ -0,0 +1,9 @@
+Colibri iMX8QXP
+M:	Marcel Ziswiler <[email protected]>
+W:	http://developer.toradex.com/software/linux/linux-software
+S:	Maintained
+F:	arch/arm/dts/fsl-imx8qxp-colibri.dts
+F:	arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
+F:	board/toradex/colibri-imx8qxp/
+F:	configs/colibri-imx8qxp_defconfig
+F:	include/configs/colibri-imx8qxp.h
board/toradex/colibri-imx8qxp/Makefile new file +7 -0
new file mode 100644
index 0000000000..f6342e1dca
@@ -0,0 +1,7 @@
+#
+# Copyright 2019 Toradex
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += colibri-imx8qxp.o
board/toradex/colibri-imx8qxp/README new file +66 -0

66 lines not on this page · raw message

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +212 -0

212 lines not on this page · raw message

board/toradex/colibri-imx8qxp/imximage.cfg new file +24 -0
new file mode 100644
index 0000000000..ce9e66c64d
@@ -0,0 +1,24 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ *
+ * Refer doc/README.imx8image for more details about how-to configure
+ * and create imx8image boot image
+ */
+
+#define __ASSEMBLY__
+
+/* Boot from SD, sector size 0x400 */
+BOOT_FROM EMMC_FASTBOOT 0x400
+/* SoC type IMX8QX */
+SOC_TYPE IMX8QX
+/* Append seco container image */
+APPEND ahab-container.img
+/* Create the 2nd container */
+CONTAINER
+/* Add scfw image with exec attribute */
+IMAGE SCU mx8qx-colibri-scfw-tcm.bin
+/* Add ATF image with exec attribute */
+IMAGE A35 bl31.bin 0x80000000
+/* Add U-Boot image with load attribute */
+DATA A35 u-boot-dtb.bin 0x80020000
configs/colibri-imx8qxp_defconfig new file +53 -0

53 lines not on this page · raw message

include/configs/colibri-imx8qxp.h new file +214 -0

214 lines not on this page · raw message

Signature · 1 line
2.20.1
#10 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Some minor comments below (can be addressed in different patch):

Quoted 293 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U-Boot supports either booting from the on-module eMMC or may be used for recovery purpose using the universal update utility (uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

---

Changes in v2:
- Changed imx-atf git clone command to include initial branch information as suggested by Igor.
- Sorted board file includes alphabetically as suggested by Igor.
- Got rid of SPL configuration in legacy header file as suggested by Igor and the whole use of SPL on i.MX 8X anyway neither works well nor makes any much sense at all.

 arch/arm/dts/Makefile                         |   4 +-
 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  | 112 ++++++
 arch/arm/dts/fsl-imx8qxp-colibri.dts          | 328 ++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   6 +
 board/toradex/colibri-imx8qxp/Kconfig         |  30 ++
 board/toradex/colibri-imx8qxp/MAINTAINERS     |   9 +
 board/toradex/colibri-imx8qxp/Makefile        |   7 +
 board/toradex/colibri-imx8qxp/README          |  66 ++++
 .../toradex/colibri-imx8qxp/colibri-imx8qxp.c | 212 +++++++++++
 board/toradex/colibri-imx8qxp/imximage.cfg    |  24 ++
 configs/colibri-imx8qxp_defconfig             |  53 +++
 include/configs/colibri-imx8qxp.h             | 214 ++++++++++++
 12 files changed, 1064 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri.dts
 create mode 100644 board/toradex/colibri-imx8qxp/Kconfig
 create mode 100644 board/toradex/colibri-imx8qxp/MAINTAINERS
 create mode 100644 board/toradex/colibri-imx8qxp/Makefile
 create mode 100644 board/toradex/colibri-imx8qxp/README
 create mode 100644 board/toradex/colibri-imx8qxp/colibri-imx8qxp.c
 create mode 100644 board/toradex/colibri-imx8qxp/imximage.cfg
 create mode 100644 configs/colibri-imx8qxp_defconfig
 create mode 100644 include/configs/colibri-imx8qxp.h
arch/arm/dts/Makefile +3 -1
index 13d1d67624..2a551d42a4 100644
@@ -559,7 +559,9 @@ dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
-dtb-$(CONFIG_ARCH_IMX8) += fsl-imx8qxp-mek.dtb
+dtb-$(CONFIG_ARCH_IMX8) += \
+       fsl-imx8qxp-colibri.dtb \
+       fsl-imx8qxp-mek.dtb
 
 dtb-$(CONFIG_ARCH_IMX8M) += fsl-imx8mq-evk.dtb
 
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi new file +112 -0
new file mode 100644
index 0000000000..f8686befdf
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+&mu {
+       u-boot,dm-spl;
+};
+
+&clk {
+       u-boot,dm-spl;
+};
+
+&iomuxc {
+       u-boot,dm-spl;
+};
+
+&pd_lsio {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio0 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio1 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio2 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio3 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio4 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio5 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio6 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio7 {
+       u-boot,dm-spl;
+};
+
+&pd_conn {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch0 {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch1 {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch2 {
+       u-boot,dm-spl;
+};
+
+&gpio0 {
+       u-boot,dm-spl;
+};
+
+&gpio1 {
+       u-boot,dm-spl;
+};
+
+&gpio2 {
+       u-boot,dm-spl;
+};
+
+&gpio3 {
+       u-boot,dm-spl;
+};
+
+&gpio4 {
+       u-boot,dm-spl;
+};
+
+&gpio5 {
+       u-boot,dm-spl;
+};
+
+&gpio6 {
+       u-boot,dm-spl;
+};
+
+&gpio7 {
+       u-boot,dm-spl;
+};
+
+&lpuart3 {
+       u-boot,dm-spl;
+};
+
+&usdhc1 {
+       u-boot,dm-spl;
+};
+
+&usdhc2 {
+       u-boot,dm-spl;
+};
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +98 -0
new file mode 100644
index 0000000000..0c20edf2cf
@@ -0,0 +1,328 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+/dts-v1/;
+
+#include "fsl-imx8qxp.dtsi"
+#include "fsl-imx8qxp-colibri-u-boot.dtsi"
+
+/ {
+       model = "Toradex Colibri iMX8QXP";
+       compatible = "toradex,colibri-imx8qxp", "fsl,imx8qxp";
+
+       chosen {
+               bootargs = "console=ttyLP3,115200 earlycon=lpuart32,0x5a090000,115200";
+               stdout-path = &lpuart3;
+       };
+
+       reg_usbh_vbus: regulator-usbh-vbus {
+               compatible = "regulator-fixed";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_usbh1_reg>;
+               regulator-name = "usbh_vbus";
+               regulator-min-microvolt = <5000000>;
+               regulator-max-microvolt = <5000000>;
+               gpio = <&gpio4 3 GPIO_ACTIVE_LOW>;
+       };
+};
+
+&iomuxc {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_hog0>, <&pinctrl_hog1>, <&pinctrl_hog2>;
+
+       colibri-imx8qxp {
+               pinctrl_lpuart0: lpuart0grp {
+                       fsl,pins = <
+                               SC_P_UART0_RX_ADMA_UART0_RX     0x06000020
+                               SC_P_UART0_TX_ADMA_UART0_TX     0x06000020
+                       >;
+               };
+
+               pinctrl_lpuart3: lpuart3grp {
+                       fsl,pins = <
+                               SC_P_FLEXCAN2_RX_ADMA_UART3_RX  0x06000020
+                               SC_P_FLEXCAN2_TX_ADMA_UART3_TX  0x06000020
+                       >;
+               };
+
+               pinctrl_lpuart3_ctrl: lpuart3ctrlgrp {
+                       fsl,pins = <
+                               SC_P_MIPI_DSI1_GPIO0_01_LSIO_GPIO2_IO00 0x00000020 /* DTR */
+                               SC_P_SAI1_RXD_LSIO_GPIO0_IO29           0x00000020 /* CTS */
+                               SC_P_SAI1_RXC_LSIO_GPIO0_IO30           0x00000020 /* RTS */
+                               SC_P_CSI_RESET_LSIO_GPIO3_IO03          0x00000020 /* DSR */
+                               SC_P_USDHC1_CD_B_LSIO_GPIO4_IO22        0x00000020 /* DCD */
+                               SC_P_CSI_EN_LSIO_GPIO3_IO02             0x00000020 /* RI */
+                       >;
+               };
+
+               pinctrl_fec1: fec1grp {
+                       fsl,pins = <
+                               SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB0_PAD      0x000014a0 /* Use pads in 3.3V mode */
+                               SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB1_PAD      0x000014a0 /* Use pads in 3.3V mode */
+                               SC_P_ENET0_MDC_CONN_ENET0_MDC                   0x06000020
+                               SC_P_ENET0_MDIO_CONN_ENET0_MDIO                 0x06000020
+                               SC_P_ENET0_RGMII_TX_CTL_CONN_ENET0_RGMII_TX_CTL 0x00000061
+                               SC_P_ENET0_RGMII_TXC_CONN_ENET0_RCLK50M_OUT     0x06000061
+                               SC_P_ENET0_RGMII_TXD0_CONN_ENET0_RGMII_TXD0     0x00000061
+                               SC_P_ENET0_RGMII_TXD1_CONN_ENET0_RGMII_TXD1     0x00000061
+                               SC_P_ENET0_RGMII_RX_CTL_CONN_ENET0_RGMII_RX_CTL 0x00000061
+                               SC_P_ENET0_RGMII_RXD0_CONN_ENET0_RGMII_RXD0     0x00000061
+                               SC_P_ENET0_RGMII_RXD1_CONN_ENET0_RGMII_RXD1     0x00000061
+                               SC_P_ENET0_RGMII_RXD2_CONN_ENET0_RMII_RX_ER     0x00000061
+                       >;
+               };
+
+               pinctrl_gpio_bl_on: gpio-bl-on {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA3_LSIO_GPIO3_IO12       0x00000040
+                       >;
+               };
+
+               pinctrl_hog0: hog0grp {
+                       fsl,pins = <
+                               SC_P_COMP_CTL_GPIO_1V8_3V3_GPIORHB_PAD  0x000514a0 /* Use pads in 3.3V mode */
+                       >;
+               };
+
+               pinctrl_hog1: hog1grp {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA1_LSIO_GPIO3_IO10       0x00000020 /*  45 */
+                               SC_P_ENET0_RGMII_TXD3_LSIO_GPIO5_IO02   0x06000020 /*  65 */
+                                       SC_P_CSI_D07_CI_PI_D09          0x00000061
+                               SC_P_QSPI0A_DATA2_LSIO_GPIO3_IO11       0x00000020 /*  69 */
+                               SC_P_QSPI0A_DQS_LSIO_GPIO3_IO13         0x00000020 /*  73 */
+                               SC_P_SAI0_TXC_LSIO_GPIO0_IO26           0x00000020 /*  79 */
+                                       SC_P_CSI_D02_CI_PI_D04          0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts line 108

Quoted 10 lines
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +10 -0
+                               SC_P_ENET0_RGMII_RXC_LSIO_GPIO5_IO03    0x06000020 /*  85 */
+                                       SC_P_CSI_D06_CI_PI_D08          0x00000061
+                               SC_P_QSPI0B_SCLK_LSIO_GPIO3_IO17        0x00000020 /*  95 */
+                               SC_P_SAI0_RXD_LSIO_GPIO0_IO27           0x00000020 /*  97 */
+                                       SC_P_CSI_D03_CI_PI_D05          0x00000061
+                               SC_P_QSPI0B_DATA0_LSIO_GPIO3_IO18       0x00000020 /*  99 */
+                               SC_P_SAI0_TXFS_LSIO_GPIO0_IO28          0x00000020 /* 101 */
+                                       SC_P_CSI_D00_CI_PI_D02          0x00000061
+                               SC_P_SAI0_TXD_LSIO_GPIO0_IO25           0x00000020 /* 103 */
+                                       SC_P_CSI_D01_CI_PI_D03          0x00000061

I seems that in 20 lines above alignment is broken a bit.

Quoted 300 lines
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +220 -0
+                               SC_P_QSPI0B_DATA1_LSIO_GPIO3_IO19       0x00000020 /* 105 */
+                               SC_P_QSPI0B_DATA2_LSIO_GPIO3_IO20       0x00000020 /* 107 */
+                               SC_P_USB_SS3_TC2_LSIO_GPIO4_IO05        0x00000020 /* 127 */
+                               SC_P_USB_SS3_TC3_LSIO_GPIO4_IO06        0x00000020 /* 131 */
+                               SC_P_USB_SS3_TC1_LSIO_GPIO4_IO04        0x00000020 /* 133 */
+                               SC_P_CSI_PCLK_LSIO_GPIO3_IO00           0x00000020 /*  96 */
+                               SC_P_QSPI0B_DATA3_LSIO_GPIO3_IO21       0x00000020 /*  98 */
+                               SC_P_SAI1_RXFS_LSIO_GPIO0_IO31          0x00000020 /* 100 */
+                               SC_P_QSPI0B_DQS_LSIO_GPIO3_IO22         0x00000020 /* 102 */
+                               SC_P_QSPI0B_SS0_B_LSIO_GPIO3_IO23       0x00000020 /* 104 */
+                               SC_P_QSPI0B_SS1_B_LSIO_GPIO3_IO24       0x00000020 /* 106 */
+                       >;
+               };
+
+               pinctrl_hog2: hog2grp {
+                       fsl,pins = <
+                               SC_P_CSI_MCLK_LSIO_GPIO3_IO01           0x00000020 /*  75 */
+                               SC_P_QSPI0A_SS0_B_LSIO_GPIO3_IO14       0x00000020 /*  77 */
+                               SC_P_QSPI0A_SS1_B_LSIO_GPIO3_IO15       0x00000020 /*  89 */
+                               SC_P_QSPI0A_SCLK_LSIO_GPIO3_IO16        0x00000020 /*  93 */
+                       >;
+               };
+
+               /* Off Module I2C */
+               pinctrl_i2c1: i2c1grp {
+                       fsl,pins = <
+                               SC_P_MIPI_DSI0_GPIO0_00_ADMA_I2C1_SCL   0x06000021
+                               SC_P_MIPI_DSI0_GPIO0_01_ADMA_I2C1_SDA   0x06000021
+                       >;
+               };
+
+               /*INT*/
+               pinctrl_usb3503a: usb3503a-grp {
+                       fsl,pins = <
+                               SC_P_MIPI_CSI0_MCLK_OUT_LSIO_GPIO3_IO04 0x00000061
+                       >;
+               };
+
+               pinctrl_usbc_det: usbc-det {
+                       fsl,pins = <
+                               SC_P_ENET0_REFCLK_125M_25M_LSIO_GPIO5_IO09      0x06000040
+                       >;
+               };
+
+               pinctrl_usbh1_reg: usbh1-reg {
+                       fsl,pins = <
+                               SC_P_USB_SS3_TC0_LSIO_GPIO4_IO03        0x06000040
+                       >;
+               };
+
+               pinctrl_usdhc1: usdhc1grp {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK           0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD           0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0       0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1       0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2       0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3       0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4       0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5       0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6       0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7       0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B   0x00000021
+                       >;
+               };
+
+               pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK           0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD           0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0       0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1       0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2       0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3       0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4       0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5       0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6       0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7       0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B   0x00000021
+                       >;
+               };
+
+               pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK           0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD           0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0       0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1       0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2       0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3       0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4       0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5       0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6       0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7       0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B   0x00000021
+                       >;
+               };
+
+               pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA0_LSIO_GPIO3_IO09       0x06000021
+                       >;
+               };
+
+               pinctrl_usdhc2: usdhc2grp {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK         0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD         0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT 0x00000021
+                       >;
+               };
+
+               pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK         0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD         0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT 0x00000021
+                       >;
+               };
+
+               pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK         0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD         0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT 0x00000021
+                       >;
+               };
+       };
+};
+
+&lpuart0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lpuart0>;
+       status = "okay";
+};
+
+&lpuart3 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lpuart3>, <&pinctrl_lpuart3_ctrl>;
+       status = "okay";
+};
+
+&gpio0 {
+       status = "okay";
+};
+
+&gpio1 {
+       status = "okay";
+};
+
+&gpio3 {
+       status = "okay";
+};
+
+&gpio4 {
+       status = "okay";
+};
+
+&fec1 {
+       phy-handle = <&ethphy0>;
+       phy-mode = "rmii";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_fec1>;
+       status = "okay";
+
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               ethphy0: ethernet-phy at 2 {
+                       compatible = "ethernet-phy-ieee802.3-c22";
+                       max-speed = <100>;
+                       reg = <2>;
+               };
+       };
+};
+
+&i2c1 {
+       #address-cells = <1>;
+       #size-cells = <0>;
+       clock-frequency = <100000>;
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_i2c1>;
+       status = "okay";
+};
+
+&usdhc1 {
+       bus-width = <8>;
+       non-removable;
+       pinctrl-names = "default", "state_100mhz", "state_200mhz";
+       pinctrl-0 = <&pinctrl_usdhc1>;
+       pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+       pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+       status = "okay";
+};
+
+&usdhc2 {
+       bus-width = <4>;
+       cd-gpios = <&gpio3 9 GPIO_ACTIVE_LOW>;
+       pinctrl-names = "default", "state_100mhz", "state_200mhz";
+       pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+       pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+       pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+       status = "okay";
+};
arch/arm/mach-imx/imx8/Kconfig +6 -0
index f76a139684..feea07f135 100644
@@ -22,6 +22,11 @@ choice
        prompt "i.MX8 board select"
        optional
 
+config TARGET_COLIBRI_IMX8QXP
+       bool "Support Colibri iMX8QXP module"
+       select BOARD_LATE_INIT
+       select IMX8QXP
+
 config TARGET_IMX8QXP_MEK
        bool "Support i.MX8QXP MEK board"
        select BOARD_LATE_INIT
@@ -30,5 +35,6 @@ config TARGET_IMX8QXP_MEK
 endchoice
 
 source "board/freescale/imx8qxp_mek/Kconfig"
+source "board/toradex/colibri-imx8qxp/Kconfig"
 
 endif
board/toradex/colibri-imx8qxp/Kconfig new file +30 -0
new file mode 100644
index 0000000000..340fe72816
@@ -0,0 +1,30 @@
+if TARGET_COLIBRI_IMX8QXP
+
+config SYS_BOARD
+       default "colibri-imx8qxp"
+
+config SYS_VENDOR
+       default "toradex"
+
+config SYS_CONFIG_NAME
+       default "colibri-imx8qxp"
+
+config TDX_CFG_BLOCK
+       default y
+
+config TDX_HAVE_MMC
+       default y
+
+config TDX_CFG_BLOCK_DEV
+       default "0"
+
+config TDX_CFG_BLOCK_PART
+       default "1"
+
+# Toradex config block in eMMC, at the end of 1st "boot sector"
+config TDX_CFG_BLOCK_OFFSET
+       default "-512"
+
+source "board/toradex/common/Kconfig"
+
+endif
board/toradex/colibri-imx8qxp/MAINTAINERS new file +9 -0
new file mode 100644
index 0000000000..39a9eb79b7
@@ -0,0 +1,9 @@
+Colibri iMX8QXP
+M:     Marcel Ziswiler <[email protected]>
+W:     http://developer.toradex.com/software/linux/linux-software
+S:     Maintained
+F:     arch/arm/dts/fsl-imx8qxp-colibri.dts
+F:     arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
+F:     board/toradex/colibri-imx8qxp/
+F:     configs/colibri-imx8qxp_defconfig
+F:     include/configs/colibri-imx8qxp.h
board/toradex/colibri-imx8qxp/Makefile new file +0 -0
new file mode 100644
index 0000000000..f6342e1dca

board/toradex/colibri-imx8qxp/Makefile line 4

Quoted 4 lines
board/toradex/colibri-imx8qxp/Makefile new file +4 -0
@@ -0,0 +1,7 @@
+#
+# Copyright 2019 Toradex
+#
+# SPDX-License-Identifier:     GPL-2.0+

SPDX line should be in the beginning of the file.

Quoted 415 lines
board/toradex/colibri-imx8qxp/Makefile new file +3 -0
+#
+
+obj-y += colibri-imx8qxp.o
board/toradex/colibri-imx8qxp/README new file +66 -0
new file mode 100644
index 0000000000..e68d183fe6
@@ -0,0 +1,66 @@
+U-Boot for the Toradex Colibri iMX8QXP V1.0B module
+
+Quick Start
+===========
+
+- Build the ARM trusted firmware binary
+- Get scfw_tcm.bin and ahab-container.img
+- Build U-Boot
+- Load U-Boot binary using uuu
+- Flash U-Boot binary into the eMMC
+- Boot
+
+Get and Build the ARM Trusted Firmware
+======================================
+
+$ git clone -b imx_4.14.78_1.0.0_ga https://source.codeaurora.org/external/imx/imx-atf
+$ cd imx-atf/
+$ make PLAT=imx8qxp bl31
+
+Get scfw_tcm.bin and ahab-container.img
+=======================================
+
+$ wget https://github.com/toradex/meta-fsl-bsp-release/blob/toradex-sumo-4.14.78-1.0.0_ga-bringup/imx/meta-bsp/recipes-bsp/imx-sc-firmware/files/mx8qx-colibri-scfw-tcm.bin?raw=true
+$ mv mx8qx-colibri-scfw-tcm.bin\?raw\=true mx8qx-colibri-scfw-tcm.bin
+$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-7.6.bin
+$ chmod +x firmware-imx-7.6.bin
+$ ./firmware-imx-7.6.bin
+
+Copy the following binaries to the U-Boot folder:
+
+$ cp imx-atf/build/imx8qxp/release/bl31.bin .
+$ cp u-boot/u-boot.bin .
+
+Copy the following firmware to the U-Boot folder:
+
+$ cp firmware-imx-7.6/firmware/seco/ahab-container.img .
+
+Build U-Boot
+============
+
+$ make colibri-imx8qxp_defconfig
+$ make u-boot-dtb.imx
+
+Load the U-Boot Binary Using UUU
+================================
+
+Get the latest version of the universal update utility (uuu) aka mfgtools 3.0:
+
+https://community.nxp.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2FNXPmicro%2Fmfgtools%2Freleases
+
+Put the module into USB recovery aka serial downloader mode, connect USB device
+to your host and execute uuu:
+
+sudo ./uuu u-boot/u-boot-dtb.imx
+
+Flash the U-Boot Binary into the eMMC
+=====================================
+
+Burn the u-boot-dtb.imx binary to the primary eMMC hardware boot area partition:
+
+load mmc 1:1 $loadaddr u-boot-dtb.imx
+setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt ${blkcnt} / 0x200
+mmc dev 0 1
+mmc write ${loadaddr} 0x0 ${blkcnt}
+
+Boot
board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +212 -0
new file mode 100644
index 0000000000..9aa0f096d2
@@ -0,0 +1,212 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019 Toradex
+ */
+
+#include <common.h>
+
+#include <asm/arch/clock.h>
+#include <asm/arch/imx8-pins.h>
+#include <asm/arch/iomux.h>
+#include <asm/arch/sci/sci.h>
+#include <asm/arch/sys_proto.h>
+#include <asm/gpio.h>
+#include <asm/io.h>
+#include <asm/mach-imx/video.h>
+#include <dm.h>
+#include <environment.h>
+#include <errno.h>
+#include <fdt_support.h>
+#include <fsl_esdhc.h>
+#include <fsl_ifc.h>
+#include <i2c.h>
+#include <linux/libfdt.h>
+#include <malloc.h>
+#include <netdev.h>
+#include <power-domain.h>
+#include <usb.h>
+
+#include "../common/tdx-cfg-block.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define GPIO_PAD_CTRL  ((SC_PAD_CONFIG_NORMAL << PADRING_CONFIG_SHIFT) | \
+                        (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT) | \
+                        (SC_PAD_28FDSOI_DSE_DV_HIGH << PADRING_DSE_SHIFT) | \
+                        (SC_PAD_28FDSOI_PS_PU << PADRING_PULL_SHIFT))
+
+#define UART_PAD_CTRL  ((SC_PAD_CONFIG_OUT_IN << PADRING_CONFIG_SHIFT) | \
+                        (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT) | \
+                        (SC_PAD_28FDSOI_DSE_DV_HIGH << PADRING_DSE_SHIFT) | \
+                        (SC_PAD_28FDSOI_PS_PU << PADRING_PULL_SHIFT))
+
+static iomux_cfg_t uart3_pads[] = {
+       SC_P_FLEXCAN2_RX | MUX_MODE_ALT(2) | MUX_PAD_CTRL(UART_PAD_CTRL),
+       SC_P_FLEXCAN2_TX | MUX_MODE_ALT(2) | MUX_PAD_CTRL(UART_PAD_CTRL),
+       /* Transceiver FORCEOFF# signal, mux to use pullup */
+       SC_P_QSPI0B_DQS | MUX_MODE_ALT(4) | MUX_PAD_CTRL(UART_PAD_CTRL),
+};
+
+static void setup_iomux_uart(void)
+{
+       imx8_iomux_setup_multiple_pads(uart3_pads, ARRAY_SIZE(uart3_pads));
+}
+
+int board_early_init_f(void)
+{
+       sc_pm_clock_rate_t rate;
+       sc_err_t err = 0;
+
+       /*
+        * This works around that having only UART3 up the baudrate is 1.2M
+        * instead of 115.2k. Set UART0 clock root to 80 MHz
+        */
+       rate = 80000000;
+       err = sc_pm_set_clock_rate(-1, SC_R_UART_0, SC_PM_CLK_PER, &rate);
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Power up UART3 */
+       err = sc_pm_set_resource_power_mode(-1, SC_R_UART_3, SC_PM_PW_MODE_ON);
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Set UART3 clock root to 80 MHz */
+       rate = 80000000;
+       err = sc_pm_set_clock_rate(-1, SC_R_UART_3, SC_PM_CLK_PER, &rate);
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Enable UART3 clock root */
+       err = sc_pm_clock_enable(-1, SC_R_UART_3, SC_PM_CLK_PER, true, false);
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       setup_iomux_uart();
+
+       return 0;
+}
+
+#undef CONFIG_MXC_GPIO /* TODO */
+#ifdef CONFIG_MXC_GPIO
+#define IOEXP_RESET IMX_GPIO_NR(1, 1)
+
+static iomux_cfg_t board_gpios[] = {
+       SC_P_SPI2_SDO | MUX_MODE_ALT(4) | MUX_PAD_CTRL(GPIO_PAD_CTRL),
+       SC_P_ENET0_REFCLK_125M_25M | MUX_MODE_ALT(4) | \
+               MUX_PAD_CTRL(GPIO_PAD_CTRL),
+};
+
+static void board_gpio_init(void)
+{
+       struct gpio_desc desc;
+       int ret;
+
+       ret = dm_gpio_lookup_name("gpio at 1a_3", &desc);
+       if (ret)
+               return;
+
+       ret = dm_gpio_request(&desc, "bb_per_rst_b");
+       if (ret)
+               return;
+
+       dm_gpio_set_dir_flags(&desc, GPIOD_IS_OUT);
+       dm_gpio_set_value(&desc, 0);
+       udelay(50);
+       dm_gpio_set_value(&desc, 1);
+
+       imx8_iomux_setup_multiple_pads(board_gpios, ARRAY_SIZE(board_gpios));
+
+       /* enable i2c port expander assert reset line */
+       gpio_request(IOEXP_RESET, "ioexp_rst");
+       gpio_direction_output(IOEXP_RESET, 1);
+}
+#else
+static inline void board_gpio_init(void) {}
+#endif
+
+#if IS_ENABLED(CONFIG_FEC_MXC)
+#include <miiphy.h>
+
+int board_phy_config(struct phy_device *phydev)
+{
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
+
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
+
+       if (phydev->drv->config)
+               phydev->drv->config(phydev);
+
+       return 0;
+}
+#endif
+
+void build_info(void)
+{
+       u32 sc_build = 0, sc_commit = 0;
+
+       /* Get SCFW build and commit id */
+       sc_misc_build_info(-1, &sc_build, &sc_commit);
+       if (!sc_build) {
+               printf("SCFW does not support build info\n");
+               sc_commit = 0; /* Display 0 if build info not supported */
+       }
+       printf("Build: SCFW %x\n", sc_commit);
+}
+
+int checkboard(void)
+{
+       puts("Model: Toradex Colibri iMX8X\n");
+
+       build_info();
+       print_bootinfo();
+
+       return 0;
+}
+
+int board_init(void)
+{
+       board_gpio_init();
+
+       return 0;
+}
+
+void detail_board_ddr_info(void)
+{
+       puts("\nDDR    ");
+}
+
+/*
+ * Board specific reset that is system reset.
+ */
+void reset_cpu(ulong addr)
+{
+       /* TODO */
+}
+
+#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
+int ft_board_setup(void *blob, bd_t *bd)
+{
+       return ft_common_board_setup(blob, bd);
+}
+#endif
+
+int board_mmc_get_env_dev(int devno)
+{
+       return devno;
+}
+
+int board_late_init(void)
+{
+#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+/* TODO move to common */
+       env_set("board_name", "Colibri iMX8QXP");
+       env_set("board_rev", "v1.0");
+#endif
+
+       return 0;
+}
board/toradex/colibri-imx8qxp/imximage.cfg new file +24 -0
new file mode 100644
index 0000000000..ce9e66c64d
@@ -0,0 +1,24 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ *
+ * Refer doc/README.imx8image for more details about how-to configure
+ * and create imx8image boot image
+ */
+
+#define __ASSEMBLY__
+
+/* Boot from SD, sector size 0x400 */
+BOOT_FROM EMMC_FASTBOOT 0x400
+/* SoC type IMX8QX */
+SOC_TYPE IMX8QX
+/* Append seco container image */
+APPEND ahab-container.img
+/* Create the 2nd container */
+CONTAINER
+/* Add scfw image with exec attribute */
+IMAGE SCU mx8qx-colibri-scfw-tcm.bin
+/* Add ATF image with exec attribute */
+IMAGE A35 bl31.bin 0x80000000
+/* Add U-Boot image with load attribute */
+DATA A35 u-boot-dtb.bin 0x80020000
configs/colibri-imx8qxp_defconfig new file +53 -0
new file mode 100644
index 0000000000..d697546ed7
@@ -0,0 +1,53 @@
+CONFIG_ARM=y
+CONFIG_ARCH_IMX8=y
+CONFIG_SYS_TEXT_BASE=0x80020000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_TARGET_COLIBRI_IMX8QXP=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=3
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri-imx8qxp/imximage.cfg"
+CONFIG_LOG=y
+CONFIG_VERSION_VARIABLE=y
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_CMD_CPU=y
+# CONFIG_CMD_IMPORTENV is not set
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_DM=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_UUID=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-colibri"
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_CLK_IMX8=y
+CONFIG_CPU=y
+CONFIG_DM_GPIO=y
+CONFIG_MXC_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_IMX_LPI2C=y
+CONFIG_MISC=y
+CONFIG_DM_MMC=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_ADDR_ENABLE=y
+CONFIG_PHY_MICREL=y
+CONFIG_DM_ETH=y
+CONFIG_FEC_MXC_SHARE_MDIO=y
+CONFIG_FEC_MXC_MDIO_BASE=0x5B040000
+CONFIG_FEC_MXC=y
+CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX8=y
+CONFIG_POWER_DOMAIN=y
+CONFIG_IMX8_POWER_DOMAIN=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+CONFIG_FSL_LPUART=y
+CONFIG_DM_THERMAL=y
+# CONFIG_EFI_LOADER is not set
include/configs/colibri-imx8qxp.h new file +27 -0
new file mode 100644
index 0000000000..33cbcb44a9
@@ -0,0 +1,214 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ */
+
+#ifndef __COLIBRI_IMX8QXP_H
+#define __COLIBRI_IMX8QXP_H
+
+#include <asm/arch/imx-regs.h>
+#include <linux/sizes.h>
+
+#define CONFIG_REMAKE_ELF
+
+#define CONFIG_DISPLAY_BOARDINFO_LATE
+
+#undef CONFIG_CMD_EXPORTENV
+#undef CONFIG_CMD_IMPORTENV
+#undef CONFIG_CMD_IMLS
+
+#undef CONFIG_CMD_CRC32
+#undef CONFIG_BOOTM_NETBSD
+
+#define CONFIG_FSL_ESDHC
+#define CONFIG_FSL_USDHC
+#define CONFIG_SYS_FSL_ESDHC_ADDR      0
+#define USDHC1_BASE_ADDR               0x5B010000
+#define USDHC2_BASE_ADDR               0x5B020000

include/configs/colibri-imx8qxp.h line 37

Quoted 10 lines
include/configs/colibri-imx8qxp.h new file +10 -0
+#define CONFIG_SUPPORT_EMMC_BOOT       /* eMMC specific */
+
+#define CONFIG_ENV_OVERWRITE
+
+#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+
+#define FEC_QUIRK_ENET_MAC
+
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE          4096

4096 can be replaced with SZ_4K (from include/linux/sizes.h)

Quoted 128 lines
include/configs/colibri-imx8qxp.h new file +128 -0
+#define CONFIG_TFTP_TSIZE
+
+#define CONFIG_IPADDR                  192.168.10.2
+#define CONFIG_NETMASK                 255.255.255.0
+#define CONFIG_SERVERIP                        192.168.10.1
+
+#define MEM_LAYOUT_ENV_SETTINGS \
+       "fdt_addr_r=0x84000000\0" \
+       "kernel_addr_r=0x82000000\0" \
+       "ramdisk_addr_r=0x84100000\0"
+
+#ifdef CONFIG_AHAB_BOOT
+#define AHAB_ENV "sec_boot=yes\0"
+#else
+#define AHAB_ENV "sec_boot=no\0"
+#endif
+
+/* Boot M4 */
+#define M4_BOOT_ENV \
+       "m4_0_image=m4_0.bin\0" \
+       "loadm4image_0=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} " \
+               "${m4_0_image}\0" \
+       "m4boot_0=run loadm4image_0; dcache flush; bootaux ${loadaddr} 0\0" \
+
+#define MFG_NAND_PARTITION ""
+
+#define BOOT_TARGET_DEVICES(func) \
+       func(MMC, mmc, 0) \
+       func(MMC, mmc, 1) \
+       func(DHCP, dhcp, na)
+#include <config_distro_bootcmd.h>
+#undef BOOTENV_RUN_NET_USB_START
+#define BOOTENV_RUN_NET_USB_START ""
+
+#define CONFIG_MFG_ENV_SETTINGS \
+       "mfgtool_args=setenv bootargs console=${console},${baudrate} " \
+               "rdinit=/linuxrc g_mass_storage.stall=0 " \
+               "g_mass_storage.removable=1 g_mass_storage.idVendor=0x066F " \
+               "g_mass_storage.idProduct=0x37FF " \
+               "g_mass_storage.iSerialNumber=\"\" "\
+               MFG_NAND_PARTITION \
+               "video=imxdpufb5:off video=imxdpufb6:off video=imxdpufb7:off " \
+               "clk_ignore_unused "\
+               "\0" \
+       "initrd_addr=0x83800000\0" \
+       "initrd_high=0xffffffff\0" \
+       "bootcmd_mfg=run mfgtool_args;booti ${loadaddr} ${initrd_addr} " \
+               "${fdt_addr};\0" \
+
+/* Initial environment variables */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+       AHAB_ENV \
+       BOOTENV \
+       CONFIG_MFG_ENV_SETTINGS \
+       M4_BOOT_ENV \
+       MEM_LAYOUT_ENV_SETTINGS \
+       "boot_fdt=try\0" \
+       "bootscript=echo Running bootscript from mmc ...; source\0" \
+       "console=ttyLP3,115200 earlycon=lpuart32,0x5a090000,115200\0" \
+       "fdt_addr=0x83000000\0"                 \
+       "fdt_file=fsl-imx8qxp-colibri-eval-v3.dtb\0" \
+       "fdt_high=0xffffffffffffffff\0"         \
+       "finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
+       "image=Image\0" \
+       "initrd_addr=0x83800000\0"              \
+       "initrd_high=0xffffffffffffffff\0" \
+       "loadbootscript=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} " \
+               "${script};\0" \
+       "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+       "loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
+       "mmcargs=setenv bootargs console=${console},${baudrate} " \
+               "root=PARTUUID=${uuid} rootwait " \
+       "mmcautodetect=yes\0" \
+       "mmcboot=echo Booting from mmc ...; " \
+               "run finduuid; run mmcargs; " \
+               "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
+                       "if run loadfdt; then " \
+                               "booti ${loadaddr} - ${fdt_addr}; " \
+                       "else " \
+                               "echo WARN: Cannot load the DT; " \
+                       "fi; " \
+               "else " \
+                       "echo wait for boot; " \
+               "fi;\0" \
+       "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
+       "mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
+       "netargs=setenv bootargs console=${console} root=/dev/nfs ip=dhcp " \
+               "nfsroot=${serverip}:${nfsroot},v3,tcp video=imxdpufb5:off " \
+               "video=imxdpufb6:off video=imxdpufb7:off\0" \
+       "netboot=echo Booting from net ...; " \
+               "run netargs; " \
+               "if test ${ip_dyn} = yes; then " \
+                       "setenv get_cmd dhcp; " \
+               "else " \
+                       "setenv get_cmd tftp; " \
+               "fi; " \
+               "${get_cmd} ${loadaddr} ${image}; " \
+               "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
+                       "if ${get_cmd} ${fdt_addr} ${fdt_file}; then " \
+                               "booti ${loadaddr} - ${fdt_addr}; " \
+                       "else " \
+                               "echo WARN: Cannot load the DT; " \
+                       "fi; " \
+               "else " \
+                       "booti; " \
+               "fi;\0" \
+       "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp ${fdt_addr} " \
+               "colibri-imx8qxp/${fdt_file}; booti ${loadaddr} - " \
+               "${fdt_addr}\0" \
+       "panel=NULL\0" \
+       "script=boot.scr\0" \
+       "video=imxdpufb5:off video=imxdpufb6:off video=imxdpufb7:off\0"
+
+#undef CONFIG_BOOTCOMMAND
+#define CONFIG_BOOTCOMMAND \
+          "mmc dev ${mmcdev}; if mmc rescan; then " \
+                  "if run loadbootscript; then " \
+                          "run bootscript; " \
+                  "else " \
+                          "if run loadimage; then " \
+                                  "run mmcboot; " \
+                          "else run netboot; " \
+                          "fi; " \
+                  "fi; " \
+          "else booti ${loadaddr} - ${fdt_addr}; fi"
+
+/* Link Definitions */
+#define CONFIG_LOADADDR                        0x80280000

include/configs/colibri-imx8qxp.h line 175

Quoted 10 lines
include/configs/colibri-imx8qxp.h new file +10 -0
+
+#define CONFIG_SYS_LOAD_ADDR           CONFIG_LOADADDR
+
+#define CONFIG_SYS_INIT_SP_ADDR                0x80200000
+
+#define CONFIG_SYS_MEMTEST_START       0x88000000
+#define CONFIG_SYS_MEMTEST_END         0x89000000
+
+/* Environment in eMMC, before config block at the end of 1st "boot sector" */
+#define CONFIG_ENV_SIZE                        (8 * 1024)

(8 * 1024) can be replaced with SZ_8K (from include/linux/sizes.h)

Quoted 9 lines
include/configs/colibri-imx8qxp.h new file +9 -0
+#define CONFIG_ENV_OFFSET              (-CONFIG_ENV_SIZE + \
+                                        CONFIG_TDX_CFG_BLOCK_OFFSET)
+#define CONFIG_SYS_MMC_ENV_DEV         0
+#define CONFIG_SYS_MMC_ENV_PART                1
+
+#define CONFIG_SYS_MMC_IMG_LOAD_PART   1
+
+/* On Colibri iMX8 USDHC1 is eMMC, USDHC2 is 4-bit SD */
+#define CONFIG_SYS_MMC_ENV_DEV         0                /* USDHC1 eMMC */

include/configs/colibri-imx8qxp.h line 194

Quoted 10 lines
include/configs/colibri-imx8qxp.h new file +10 -0
+#define CONFIG_SYS_FSL_USDHC_NUM       2
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN          ((CONFIG_ENV_SIZE + (32 * 1024)) * 1024)
+
+#define CONFIG_SYS_SDRAM_BASE          0x80000000
+#define CONFIG_NR_DRAM_BANKS           3
+#define PHYS_SDRAM_1                   0x80000000
+#define PHYS_SDRAM_2                   0x880000000
+#define PHYS_SDRAM_1_SIZE              0x80000000      /* 2 GB */

0x80000000 can be replaced with SZ_2G (from include/linux/sizes.h)

include/configs/colibri-imx8qxp.h line 202

Quoted 8 lines
include/configs/colibri-imx8qxp.h new file +8 -0
+#define PHYS_SDRAM_2_SIZE              0x00000000      /* 0 GB */
+
+/* Serial */
+#define CONFIG_BAUDRATE                        115200
+
+/* Monitor Command Prompt */
+#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
+#define CONFIG_SYS_CBSIZE              2048

Same as above

include/configs/colibri-imx8qxp.h line 212

Quoted 10 lines
include/configs/colibri-imx8qxp.h new file +10 -0
+#define CONFIG_SYS_MAXARGS             64
+#define CONFIG_SYS_BARGSIZE            CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_PBSIZE              (CONFIG_SYS_CBSIZE + \
+                                       sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* Generic Timer Definitions */
+#define COUNTER_FREQUENCY              8000000 /* 8MHz */
+
+#define BOOTAUX_RESERVED_MEM_BASE 0x88000000
+#define BOOTAUX_RESERVED_MEM_SIZE 0x08000000 /* Reserve from second 128MB */

Same as above

Quoted 9 lines
include/configs/colibri-imx8qxp.h new file +2 -1
+
+#endif /* __COLIBRI_IMX8QXP_H */
--

2.20.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Signature · 8 lines
Best regards - Freundliche Grüsse - Meilleures salutations

Igor Opaniuk

mailto: igor.opaniuk at gmail.com
skype: igor.opanyuk
+380 (93) 836 40 67
http://ua.linkedin.com/in/iopaniuk
#11 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Igor

Sorry, somehow I missed your comments below (;-p).

I will send out a v4 (yes there already was a v3 BTW) shortly including the SPL resp. without SPL build fix.

Quoted 357 lines · Igor Opaniuk

Hi Marcel,

Some minor comments below (can be addressed in different patch):

Quoted 349 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB
IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which
are factory fused to properly boot from their on-module eMMC. U- Boot
supports either booting from the on-module eMMC or may be used for recovery purpose using the universal update utility (uuu) aka mfgtools
3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Unfortunately, there is no USB functionality for the i.MX 8QXP as of
yet.

---

Changes in v2:
- Changed imx-atf git clone command to include initial branch information as suggested by Igor.
- Sorted board file includes alphabetically as suggested by Igor.
- Got rid of SPL configuration in legacy header file as suggested by
Igor and the whole use of SPL on i.MX 8X anyway neither works
well
nor makes any much sense at all.

 arch/arm/dts/Makefile                         |   4 +-
 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  | 112 ++++++
 arch/arm/dts/fsl-imx8qxp-colibri.dts          | 328
++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   6 +
 board/toradex/colibri-imx8qxp/Kconfig         |  30 ++
 board/toradex/colibri-imx8qxp/MAINTAINERS     |   9 +
 board/toradex/colibri-imx8qxp/Makefile        |   7 +
 board/toradex/colibri-imx8qxp/README          |  66 ++++
 .../toradex/colibri-imx8qxp/colibri-imx8qxp.c | 212 +++++++++++
 board/toradex/colibri-imx8qxp/imximage.cfg    |  24 ++
 configs/colibri-imx8qxp_defconfig             |  53 +++
 include/configs/colibri-imx8qxp.h             | 214 ++++++++++++
 12 files changed, 1064 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri.dts
 create mode 100644 board/toradex/colibri-imx8qxp/Kconfig
 create mode 100644 board/toradex/colibri-imx8qxp/MAINTAINERS
 create mode 100644 board/toradex/colibri-imx8qxp/Makefile
 create mode 100644 board/toradex/colibri-imx8qxp/README
 create mode 100644 board/toradex/colibri-imx8qxp/colibri-imx8qxp.c
 create mode 100644 board/toradex/colibri-imx8qxp/imximage.cfg
 create mode 100644 configs/colibri-imx8qxp_defconfig
 create mode 100644 include/configs/colibri-imx8qxp.h
arch/arm/dts/Makefile +3 -1
index 13d1d67624..2a551d42a4 100644
@@ -559,7 +559,9 @@ dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
-dtb-$(CONFIG_ARCH_IMX8) += fsl-imx8qxp-mek.dtb
+dtb-$(CONFIG_ARCH_IMX8) += \
+       fsl-imx8qxp-colibri.dtb \
+       fsl-imx8qxp-mek.dtb
 
 dtb-$(CONFIG_ARCH_IMX8M) += fsl-imx8mq-evk.dtb
 
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi new file +112 -0
new file mode 100644
index 0000000000..f8686befdf
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+&mu {
+       u-boot,dm-spl;
+};
+
+&clk {
+       u-boot,dm-spl;
+};
+
+&iomuxc {
+       u-boot,dm-spl;
+};
+
+&pd_lsio {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio0 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio1 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio2 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio3 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio4 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio5 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio6 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio7 {
+       u-boot,dm-spl;
+};
+
+&pd_conn {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch0 {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch1 {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch2 {
+       u-boot,dm-spl;
+};
+
+&gpio0 {
+       u-boot,dm-spl;
+};
+
+&gpio1 {
+       u-boot,dm-spl;
+};
+
+&gpio2 {
+       u-boot,dm-spl;
+};
+
+&gpio3 {
+       u-boot,dm-spl;
+};
+
+&gpio4 {
+       u-boot,dm-spl;
+};
+
+&gpio5 {
+       u-boot,dm-spl;
+};
+
+&gpio6 {
+       u-boot,dm-spl;
+};
+
+&gpio7 {
+       u-boot,dm-spl;
+};
+
+&lpuart3 {
+       u-boot,dm-spl;
+};
+
+&usdhc1 {
+       u-boot,dm-spl;
+};
+
+&usdhc2 {
+       u-boot,dm-spl;
+};
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +16 -0
new file mode 100644
index 0000000000..0c20edf2cf
@@ -0,0 +1,328 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+/dts-v1/;
+
+#include "fsl-imx8qxp.dtsi"
+#include "fsl-imx8qxp-colibri-u-boot.dtsi"
+
+/ {
+       model = "Toradex Colibri iMX8QXP";
+       compatible = "toradex,colibri-imx8qxp", "fsl,imx8qxp";
+
+       chosen {
+               bootargs = "console=ttyLP3,115200

earlycon=lpuart32,0x5a090000,115200";

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +17 -0
+               stdout-path = &lpuart3;
+       };
+
+       reg_usbh_vbus: regulator-usbh-vbus {
+               compatible = "regulator-fixed";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_usbh1_reg>;
+               regulator-name = "usbh_vbus";
+               regulator-min-microvolt = <5000000>;
+               regulator-max-microvolt = <5000000>;
+               gpio = <&gpio4 3 GPIO_ACTIVE_LOW>;
+       };
+};
+
+&iomuxc {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_hog0>, <&pinctrl_hog1>,

<&pinctrl_hog2>;

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +5 -0
+
+       colibri-imx8qxp {
+               pinctrl_lpuart0: lpuart0grp {
+                       fsl,pins = <
+                               SC_P_UART0_RX_ADMA_UART0_RX     0x0

6000020
+ SC_P_UART0_TX_ADMA_UART0_TX 0x0
6000020

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                       >;
+               };
+
+               pinctrl_lpuart3: lpuart3grp {
+                       fsl,pins = <
+                               SC_P_FLEXCAN2_RX_ADMA_UART3_RX  0x0

6000020
+ SC_P_FLEXCAN2_TX_ADMA_UART3_TX 0x0
6000020

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                       >;
+               };
+
+               pinctrl_lpuart3_ctrl: lpuart3ctrlgrp {
+                       fsl,pins = <
+                               SC_P_MIPI_DSI1_GPIO0_01_LSIO_GPIO2_

IO00 0x00000020 /* DTR */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +11 -0
+                               SC_P_SAI1_RXD_LSIO_GPIO0_IO29      
     0x00000020 /* CTS */
+                               SC_P_SAI1_RXC_LSIO_GPIO0_IO30      
     0x00000020 /* RTS */
+                               SC_P_CSI_RESET_LSIO_GPIO3_IO03     
     0x00000020 /* DSR */
+                               SC_P_USDHC1_CD_B_LSIO_GPIO4_IO22   
     0x00000020 /* DCD */
+                               SC_P_CSI_EN_LSIO_GPIO3_IO02        
     0x00000020 /* RI */
+                       >;
+               };
+
+               pinctrl_fec1: fec1grp {
+                       fsl,pins = <
+                               SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENE

TB0_PAD 0x000014a0 /* Use pads in 3.3V mode */
+ SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENE
TB1_PAD 0x000014a0 /* Use pads in 3.3V mode */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +3 -0
+                               SC_P_ENET0_MDC_CONN_ENET0_MDC      
             0x06000020
+                               SC_P_ENET0_MDIO_CONN_ENET0_MDIO    
             0x06000020
+                               SC_P_ENET0_RGMII_TX_CTL_CONN_ENET0_

RGMII_TX_CTL 0x00000061
+ SC_P_ENET0_RGMII_TXC_CONN_ENET0_RCL
K50M_OUT 0x06000061
+ SC_P_ENET0_RGMII_TXD0_CONN_ENET0_RG
MII_TXD0 0x00000061
+ SC_P_ENET0_RGMII_TXD1_CONN_ENET0_RG
MII_TXD1 0x00000061
+ SC_P_ENET0_RGMII_RX_CTL_CONN_ENET0_
RGMII_RX_CTL 0x00000061
+ SC_P_ENET0_RGMII_RXD0_CONN_ENET0_RG
MII_RXD0 0x00000061
+ SC_P_ENET0_RGMII_RXD1_CONN_ENET0_RG
MII_RXD1 0x00000061
+ SC_P_ENET0_RGMII_RXD2_CONN_ENET0_RM
II_RX_ER 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +12 -0
+                       >;
+               };
+
+               pinctrl_gpio_bl_on: gpio-bl-on {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA3_LSIO_GPIO3_IO12  
     0x00000040
+                       >;
+               };
+
+               pinctrl_hog0: hog0grp {
+                       fsl,pins = <
+                               SC_P_COMP_CTL_GPIO_1V8_3V3_GPIORHB_

PAD 0x000514a0 /* Use pads in 3.3V mode */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +7 -0
+                       >;
+               };
+
+               pinctrl_hog1: hog1grp {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA1_LSIO_GPIO3_IO10  
     0x00000020 /*  45 */
+                               SC_P_ENET0_RGMII_TXD3_LSIO_GPIO5_IO

02 0x06000020 /* 65 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                                       SC_P_CSI_D07_CI_PI_D09     
     0x00000061
+                               SC_P_QSPI0A_DATA2_LSIO_GPIO3_IO11  
     0x00000020 /*  69 */
+                               SC_P_QSPI0A_DQS_LSIO_GPIO3_IO13    
     0x00000020 /*  73 */
+                               SC_P_SAI0_TXC_LSIO_GPIO0_IO26      
     0x00000020 /*  79 */
+                                       SC_P_CSI_D02_CI_PI_D04     
     0x00000061
+                               SC_P_ENET0_RGMII_RXC_LSIO_GPIO5_IO0

3 0x06000020 /* 85 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                                       SC_P_CSI_D06_CI_PI_D08     
     0x00000061
+                               SC_P_QSPI0B_SCLK_LSIO_GPIO3_IO17   
     0x00000020 /*  95 */
+                               SC_P_SAI0_RXD_LSIO_GPIO0_IO27      
     0x00000020 /*  97 */
+                                       SC_P_CSI_D03_CI_PI_D05     
     0x00000061
+                               SC_P_QSPI0B_DATA0_LSIO_GPIO3_IO18  
     0x00000020 /*  99 */
+                               SC_P_SAI0_TXFS_LSIO_GPIO0_IO28     
     0x00000020 /* 101 */
Quoted 8 lines

arch/arm/dts/fsl-imx8qxp-colibri.dts

Quoted 6 lines
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +3 -0
+                                       SC_P_CSI_D00_CI_PI_D02     
     0x00000061
+                               SC_P_SAI0_TXD_LSIO_GPIO0_IO25      
     0x00000020 /* 103 */
+                                       SC_P_CSI_D01_CI_PI_D03     
     0x00000061

I seems that in 20 lines above alignment is broken a bit.

No, I believe Max intentionally did it that way downstream indicating that those SODIMM pins are each multiplexed onto two SoC balls. Toradex does this at times to gain greater pin compatibility across our module families.

Further comments down below taken into account. Thanks!

Cheers

Marcel

Quoted 1,074 lines
Quoted 384 lines
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +27 -0
+                               SC_P_QSPI0B_DATA1_LSIO_GPIO3_IO19  
     0x00000020 /* 105 */
+                               SC_P_QSPI0B_DATA2_LSIO_GPIO3_IO20  
     0x00000020 /* 107 */
+                               SC_P_USB_SS3_TC2_LSIO_GPIO4_IO05   
     0x00000020 /* 127 */
+                               SC_P_USB_SS3_TC3_LSIO_GPIO4_IO06   
     0x00000020 /* 131 */
+                               SC_P_USB_SS3_TC1_LSIO_GPIO4_IO04   
     0x00000020 /* 133 */
+                               SC_P_CSI_PCLK_LSIO_GPIO3_IO00      
     0x00000020 /*  96 */
+                               SC_P_QSPI0B_DATA3_LSIO_GPIO3_IO21  
     0x00000020 /*  98 */
+                               SC_P_SAI1_RXFS_LSIO_GPIO0_IO31     
     0x00000020 /* 100 */
+                               SC_P_QSPI0B_DQS_LSIO_GPIO3_IO22    
     0x00000020 /* 102 */
+                               SC_P_QSPI0B_SS0_B_LSIO_GPIO3_IO23  
     0x00000020 /* 104 */
+                               SC_P_QSPI0B_SS1_B_LSIO_GPIO3_IO24  
     0x00000020 /* 106 */
+                       >;
+               };
+
+               pinctrl_hog2: hog2grp {
+                       fsl,pins = <
+                               SC_P_CSI_MCLK_LSIO_GPIO3_IO01      
     0x00000020 /*  75 */
+                               SC_P_QSPI0A_SS0_B_LSIO_GPIO3_IO14  
     0x00000020 /*  77 */
+                               SC_P_QSPI0A_SS1_B_LSIO_GPIO3_IO15  
     0x00000020 /*  89 */
+                               SC_P_QSPI0A_SCLK_LSIO_GPIO3_IO16   
     0x00000020 /*  93 */
+                       >;
+               };
+
+               /* Off Module I2C */
+               pinctrl_i2c1: i2c1grp {
+                       fsl,pins = <
+                               SC_P_MIPI_DSI0_GPIO0_00_ADMA_I2C1_S

CL 0x06000021
+ SC_P_MIPI_DSI0_GPIO0_01_ADMA_I2C1_S
DA 0x06000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +7 -0
+                       >;
+               };
+
+               /*INT*/
+               pinctrl_usb3503a: usb3503a-grp {
+                       fsl,pins = <
+                               SC_P_MIPI_CSI0_MCLK_OUT_LSIO_GPIO3_

IO04 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                       >;
+               };
+
+               pinctrl_usbc_det: usbc-det {
+                       fsl,pins = <
+                               SC_P_ENET0_REFCLK_125M_25M_LSIO_GPI

O5_IO09 0x06000040

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +23 -0
+                       >;
+               };
+
+               pinctrl_usbh1_reg: usbh1-reg {
+                       fsl,pins = <
+                               SC_P_USB_SS3_TC0_LSIO_GPIO4_IO03   
     0x06000040
+                       >;
+               };
+
+               pinctrl_usdhc1: usdhc1grp {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK      
     0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD      
     0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0  
     0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1  
     0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2  
     0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3  
     0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4  
     0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5  
     0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6  
     0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7  
     0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE
     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET

_B 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +17 -0
+                       >;
+               };
+
+               pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK      
     0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD      
     0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0  
     0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1  
     0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2  
     0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3  
     0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4  
     0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5  
     0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6  
     0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7  
     0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE
     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET

_B 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +17 -0
+                       >;
+               };
+
+               pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK      
     0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD      
     0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0  
     0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1  
     0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2  
     0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3  
     0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4  
     0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5  
     0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6  
     0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7  
     0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE
     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET

_B 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +18 -0
+                       >;
+               };
+
+               pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA0_LSIO_GPIO3_IO09  
     0x06000021
+                       >;
+               };
+
+               pinctrl_usdhc2: usdhc2grp {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK    
     0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD    
     0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0
     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1
     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2
     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3
     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSE

LECT 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +12 -0
+                       >;
+               };
+
+               pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK    
     0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD    
     0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0
     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1
     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2
     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3
     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSE

LECT 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +12 -0
+                       >;
+               };
+
+               pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK    
     0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD    
     0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0
     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1
     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2
     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3
     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSE

LECT 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +77 -0
+                       >;
+               };
+       };
+};
+
+&lpuart0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lpuart0>;
+       status = "okay";
+};
+
+&lpuart3 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lpuart3>, <&pinctrl_lpuart3_ctrl>;
+       status = "okay";
+};
+
+&gpio0 {
+       status = "okay";
+};
+
+&gpio1 {
+       status = "okay";
+};
+
+&gpio3 {
+       status = "okay";
+};
+
+&gpio4 {
+       status = "okay";
+};
+
+&fec1 {
+       phy-handle = <&ethphy0>;
+       phy-mode = "rmii";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_fec1>;
+       status = "okay";
+
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               ethphy0: ethernet-phy at 2 {
+                       compatible = "ethernet-phy-ieee802.3-c22";
+                       max-speed = <100>;
+                       reg = <2>;
+               };
+       };
+};
+
+&i2c1 {
+       #address-cells = <1>;
+       #size-cells = <0>;
+       clock-frequency = <100000>;
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_i2c1>;
+       status = "okay";
+};
+
+&usdhc1 {
+       bus-width = <8>;
+       non-removable;
+       pinctrl-names = "default", "state_100mhz", "state_200mhz";
+       pinctrl-0 = <&pinctrl_usdhc1>;
+       pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+       pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+       status = "okay";
+};
+
+&usdhc2 {
+       bus-width = <4>;
+       cd-gpios = <&gpio3 9 GPIO_ACTIVE_LOW>;
+       pinctrl-names = "default", "state_100mhz", "state_200mhz";
+       pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+       pinctrl-1 = <&pinctrl_usdhc2_100mhz>,

<&pinctrl_usdhc2_gpio>;
+ pinctrl-2 = <&pinctrl_usdhc2_200mhz>,
<&pinctrl_usdhc2_gpio>;

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +2 -0
+       status = "okay";
+};
arch/arm/mach- renamed from arch/arm/mach-imx/imx8/Kconfig +0 -0

imx/imx8/Kconfig
index f76a139684..feea07f135 100644

arch/arm/mach-imx/imx8/Kconfig +6 -0
@@ -22,6 +22,11 @@ choice
        prompt "i.MX8 board select"
        optional
 
+config TARGET_COLIBRI_IMX8QXP
+       bool "Support Colibri iMX8QXP module"
+       select BOARD_LATE_INIT
+       select IMX8QXP
+
 config TARGET_IMX8QXP_MEK
        bool "Support i.MX8QXP MEK board"
        select BOARD_LATE_INIT
@@ -30,5 +35,6 @@ config TARGET_IMX8QXP_MEK
 endchoice
 
 source "board/freescale/imx8qxp_mek/Kconfig"
+source "board/toradex/colibri-imx8qxp/Kconfig"
 
 endif
board/toradex/colibri-imx8qxp/Kconfig new file +30 -0
new file mode 100644
index 0000000000..340fe72816
@@ -0,0 +1,30 @@
+if TARGET_COLIBRI_IMX8QXP
+
+config SYS_BOARD
+       default "colibri-imx8qxp"
+
+config SYS_VENDOR
+       default "toradex"
+
+config SYS_CONFIG_NAME
+       default "colibri-imx8qxp"
+
+config TDX_CFG_BLOCK
+       default y
+
+config TDX_HAVE_MMC
+       default y
+
+config TDX_CFG_BLOCK_DEV
+       default "0"
+
+config TDX_CFG_BLOCK_PART
+       default "1"
+
+# Toradex config block in eMMC, at the end of 1st "boot sector"
+config TDX_CFG_BLOCK_OFFSET
+       default "-512"
+
+source "board/toradex/common/Kconfig"
+
+endif
board/toradex/colibri-imx8qxp/MAINTAINERS new file +9 -0
new file mode 100644
index 0000000000..39a9eb79b7
@@ -0,0 +1,9 @@
+Colibri iMX8QXP
+M:     Marcel Ziswiler <[email protected]>
+W:     http://developer.toradex.com/software/linux/linux-software
+S:     Maintained
+F:     arch/arm/dts/fsl-imx8qxp-colibri.dts
+F:     arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
+F:     board/toradex/colibri-imx8qxp/
+F:     configs/colibri-imx8qxp_defconfig
+F:     include/configs/colibri-imx8qxp.h
board/toradex/colibri-imx8qxp/Makefile new file +0 -0
new file mode 100644
index 0000000000..f6342e1dca

board/toradex/colibri-imx8qxp/Makefile line 4

Quoted 4 lines
board/toradex/colibri-imx8qxp/Makefile new file +4 -0
@@ -0,0 +1,7 @@
+#
+# Copyright 2019 Toradex
+#
+# SPDX-License-Identifier:     GPL-2.0+

SPDX line should be in the beginning of the file.

Quoted 451 lines
board/toradex/colibri-imx8qxp/Makefile new file +3 -0
+#
+
+obj-y += colibri-imx8qxp.o
board/toradex/colibri-imx8qxp/README new file +16 -0
new file mode 100644
index 0000000000..e68d183fe6
@@ -0,0 +1,66 @@
+U-Boot for the Toradex Colibri iMX8QXP V1.0B module
+
+Quick Start
+===========
+
+- Build the ARM trusted firmware binary
+- Get scfw_tcm.bin and ahab-container.img
+- Build U-Boot
+- Load U-Boot binary using uuu
+- Flash U-Boot binary into the eMMC
+- Boot
+
+Get and Build the ARM Trusted Firmware
+======================================
+
+$ git clone -b imx_4.14.78_1.0.0_ga 

https://source.codeaurora.org/external/imx/imx-atf
+$ cd imx-atf/
+$ make PLAT=imx8qxp bl31

board/toradex/colibri-imx8qxp/README new file +5 -0
+
+Get scfw_tcm.bin and ahab-container.img
+=======================================
+
+$ wget 

https://github.com/toradex/meta-fsl-bsp-release/blob/toradex-sumo-4.14.78-1.0.0_ga-bringup/imx/meta-bsp/recipes-bsp/imx-sc-firmware/files/mx8qx-colibri-scfw-tcm.bin?raw=true
+$ mv mx8qx-colibri-scfw-tcm.bin\?raw\=true mx8qx-colibri-scfw- tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-7.6.bin
+$ chmod +x firmware-imx-7.6.bin
+$ ./firmware-imx-7.6.bin

board/toradex/colibri-imx8qxp/README new file +20 -0
+
+Copy the following binaries to the U-Boot folder:
+
+$ cp imx-atf/build/imx8qxp/release/bl31.bin .
+$ cp u-boot/u-boot.bin .
+
+Copy the following firmware to the U-Boot folder:
+
+$ cp firmware-imx-7.6/firmware/seco/ahab-container.img .
+
+Build U-Boot
+============
+
+$ make colibri-imx8qxp_defconfig
+$ make u-boot-dtb.imx
+
+Load the U-Boot Binary Using UUU
+================================
+
+Get the latest version of the universal update utility (uuu) aka

mfgtools 3.0:

board/toradex/colibri-imx8qxp/README new file +2 -0
+
+

https://community.nxp.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2FNXPmicro%2Fmfgtools%2Freleases

board/toradex/colibri-imx8qxp/README new file +2 -0
+
+Put the module into USB recovery aka serial downloader mode,

connect USB device

board/toradex/colibri-imx8qxp/README new file +8 -0
+to your host and execute uuu:
+
+sudo ./uuu u-boot/u-boot-dtb.imx
+
+Flash the U-Boot Binary into the eMMC
+=====================================
+
+Burn the u-boot-dtb.imx binary to the primary eMMC hardware boot

area partition:

board/toradex/colibri-imx8qxp/README new file +3 -0
+
+load mmc 1:1 $loadaddr u-boot-dtb.imx
+setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt ${blkcnt} /

0x200

board/toradex/colibri-imx8qxp/README new file +4 -0
+mmc dev 0 1
+mmc write ${loadaddr} 0x0 ${blkcnt}
+
+Boot
board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +33 -0
new file mode 100644
index 0000000000..9aa0f096d2
@@ -0,0 +1,212 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019 Toradex
+ */
+
+#include <common.h>
+
+#include <asm/arch/clock.h>
+#include <asm/arch/imx8-pins.h>
+#include <asm/arch/iomux.h>
+#include <asm/arch/sci/sci.h>
+#include <asm/arch/sys_proto.h>
+#include <asm/gpio.h>
+#include <asm/io.h>
+#include <asm/mach-imx/video.h>
+#include <dm.h>
+#include <environment.h>
+#include <errno.h>
+#include <fdt_support.h>
+#include <fsl_esdhc.h>
+#include <fsl_ifc.h>
+#include <i2c.h>
+#include <linux/libfdt.h>
+#include <malloc.h>
+#include <netdev.h>
+#include <power-domain.h>
+#include <usb.h>
+
+#include "../common/tdx-cfg-block.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define GPIO_PAD_CTRL  ((SC_PAD_CONFIG_NORMAL <<

PADRING_CONFIG_SHIFT) | \
+ (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT)
| \
+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \
+ (SC_PAD_28FDSOI_PS_PU <<
PADRING_PULL_SHIFT))

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +2 -0
+
+#define UART_PAD_CTRL  ((SC_PAD_CONFIG_OUT_IN <<

PADRING_CONFIG_SHIFT) | \
+ (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT)
| \
+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \
+ (SC_PAD_28FDSOI_PS_PU <<
PADRING_PULL_SHIFT))

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +3 -0
+
+static iomux_cfg_t uart3_pads[] = {
+       SC_P_FLEXCAN2_RX | MUX_MODE_ALT(2) |

MUX_PAD_CTRL(UART_PAD_CTRL),
+ SC_P_FLEXCAN2_TX | MUX_MODE_ALT(2) |
MUX_PAD_CTRL(UART_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +2 -0
+       /* Transceiver FORCEOFF# signal, mux to use pullup */
+       SC_P_QSPI0B_DQS | MUX_MODE_ALT(4) |

MUX_PAD_CTRL(UART_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+};
+
+static void setup_iomux_uart(void)
+{
+       imx8_iomux_setup_multiple_pads(uart3_pads,

ARRAY_SIZE(uart3_pads));

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +9 -0
+}
+
+int board_early_init_f(void)
+{
+       sc_pm_clock_rate_t rate;
+       sc_err_t err = 0;
+
+       /*
+        * This works around that having only UART3 up the baudrate

is 1.2M

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +4 -0
+        * instead of 115.2k. Set UART0 clock root to 80 MHz
+        */
+       rate = 80000000;
+       err = sc_pm_set_clock_rate(-1, SC_R_UART_0, SC_PM_CLK_PER,

&rate);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Power up UART3 */
+       err = sc_pm_set_resource_power_mode(-1, SC_R_UART_3,

SC_PM_PW_MODE_ON);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +6 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Set UART3 clock root to 80 MHz */
+       rate = 80000000;
+       err = sc_pm_set_clock_rate(-1, SC_R_UART_3, SC_PM_CLK_PER,

&rate);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Enable UART3 clock root */
+       err = sc_pm_clock_enable(-1, SC_R_UART_3, SC_PM_CLK_PER,

true, false);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +14 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       setup_iomux_uart();
+
+       return 0;
+}
+
+#undef CONFIG_MXC_GPIO /* TODO */
+#ifdef CONFIG_MXC_GPIO
+#define IOEXP_RESET IMX_GPIO_NR(1, 1)
+
+static iomux_cfg_t board_gpios[] = {
+       SC_P_SPI2_SDO | MUX_MODE_ALT(4) |

MUX_PAD_CTRL(GPIO_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +23 -0
+       SC_P_ENET0_REFCLK_125M_25M | MUX_MODE_ALT(4) | \
+               MUX_PAD_CTRL(GPIO_PAD_CTRL),
+};
+
+static void board_gpio_init(void)
+{
+       struct gpio_desc desc;
+       int ret;
+
+       ret = dm_gpio_lookup_name("gpio at 1a_3", &desc);
+       if (ret)
+               return;
+
+       ret = dm_gpio_request(&desc, "bb_per_rst_b");
+       if (ret)
+               return;
+
+       dm_gpio_set_dir_flags(&desc, GPIOD_IS_OUT);
+       dm_gpio_set_value(&desc, 0);
+       udelay(50);
+       dm_gpio_set_value(&desc, 1);
+
+       imx8_iomux_setup_multiple_pads(board_gpios,

ARRAY_SIZE(board_gpios));

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +38 -0
+
+       /* enable i2c port expander assert reset line */
+       gpio_request(IOEXP_RESET, "ioexp_rst");
+       gpio_direction_output(IOEXP_RESET, 1);
+}
+#else
+static inline void board_gpio_init(void) {}
+#endif
+
+#if IS_ENABLED(CONFIG_FEC_MXC)
+#include <miiphy.h>
+
+int board_phy_config(struct phy_device *phydev)
+{
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
+
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
+
+       if (phydev->drv->config)
+               phydev->drv->config(phydev);
+
+       return 0;
+}
+#endif
+
+void build_info(void)
+{
+       u32 sc_build = 0, sc_commit = 0;
+
+       /* Get SCFW build and commit id */
+       sc_misc_build_info(-1, &sc_build, &sc_commit);
+       if (!sc_build) {
+               printf("SCFW does not support build info\n");
+               sc_commit = 0; /* Display 0 if build info not

supported */

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +56 -0
+       }
+       printf("Build: SCFW %x\n", sc_commit);
+}
+
+int checkboard(void)
+{
+       puts("Model: Toradex Colibri iMX8X\n");
+
+       build_info();
+       print_bootinfo();
+
+       return 0;
+}
+
+int board_init(void)
+{
+       board_gpio_init();
+
+       return 0;
+}
+
+void detail_board_ddr_info(void)
+{
+       puts("\nDDR    ");
+}
+
+/*
+ * Board specific reset that is system reset.
+ */
+void reset_cpu(ulong addr)
+{
+       /* TODO */
+}
+
+#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
+int ft_board_setup(void *blob, bd_t *bd)
+{
+       return ft_common_board_setup(blob, bd);
+}
+#endif
+
+int board_mmc_get_env_dev(int devno)
+{
+       return devno;
+}
+
+int board_late_init(void)
+{
+#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+/* TODO move to common */
+       env_set("board_name", "Colibri iMX8QXP");
+       env_set("board_rev", "v1.0");
+#endif
+
+       return 0;
+}
board/toradex/colibri-imx8qxp/imximage.cfg new file +5 -0
new file mode 100644
index 0000000000..ce9e66c64d
@@ -0,0 +1,24 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ *
+ * Refer doc/README.imx8image for more details about how-to

configure
+ * and create imx8image boot image
+ */

board/toradex/colibri-imx8qxp/imximage.cfg new file +17 -0
+
+#define __ASSEMBLY__
+
+/* Boot from SD, sector size 0x400 */
+BOOT_FROM EMMC_FASTBOOT 0x400
+/* SoC type IMX8QX */
+SOC_TYPE IMX8QX
+/* Append seco container image */
+APPEND ahab-container.img
+/* Create the 2nd container */
+CONTAINER
+/* Add scfw image with exec attribute */
+IMAGE SCU mx8qx-colibri-scfw-tcm.bin
+/* Add ATF image with exec attribute */
+IMAGE A35 bl31.bin 0x80000000
+/* Add U-Boot image with load attribute */
+DATA A35 u-boot-dtb.bin 0x80020000
configs/colibri- renamed from configs/colibri-imx8qxp_defconfig +0 -0

imx8qxp_defconfig
new file mode 100644
index 0000000000..d697546ed7

configs/colibri-imx8qxp_defconfig new file +9 -0
@@ -0,0 +1,53 @@
+CONFIG_ARM=y
+CONFIG_ARCH_IMX8=y
+CONFIG_SYS_TEXT_BASE=0x80020000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_TARGET_COLIBRI_IMX8QXP=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=3
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri-

imx8qxp/imximage.cfg"

configs/colibri-imx8qxp_defconfig new file +44 -0
+CONFIG_LOG=y
+CONFIG_VERSION_VARIABLE=y
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_CMD_CPU=y
+# CONFIG_CMD_IMPORTENV is not set
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_DM=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_UUID=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-colibri"
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_CLK_IMX8=y
+CONFIG_CPU=y
+CONFIG_DM_GPIO=y
+CONFIG_MXC_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_IMX_LPI2C=y
+CONFIG_MISC=y
+CONFIG_DM_MMC=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_ADDR_ENABLE=y
+CONFIG_PHY_MICREL=y
+CONFIG_DM_ETH=y
+CONFIG_FEC_MXC_SHARE_MDIO=y
+CONFIG_FEC_MXC_MDIO_BASE=0x5B040000
+CONFIG_FEC_MXC=y
+CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX8=y
+CONFIG_POWER_DOMAIN=y
+CONFIG_IMX8_POWER_DOMAIN=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+CONFIG_FSL_LPUART=y
+CONFIG_DM_THERMAL=y
+# CONFIG_EFI_LOADER is not set
include/configs/colibri-imx8qxp.h new file +27 -0
new file mode 100644
index 0000000000..33cbcb44a9
@@ -0,0 +1,214 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ */
+
+#ifndef __COLIBRI_IMX8QXP_H
+#define __COLIBRI_IMX8QXP_H
+
+#include <asm/arch/imx-regs.h>
+#include <linux/sizes.h>
+
+#define CONFIG_REMAKE_ELF
+
+#define CONFIG_DISPLAY_BOARDINFO_LATE
+
+#undef CONFIG_CMD_EXPORTENV
+#undef CONFIG_CMD_IMPORTENV
+#undef CONFIG_CMD_IMLS
+
+#undef CONFIG_CMD_CRC32
+#undef CONFIG_BOOTM_NETBSD
+
+#define CONFIG_FSL_ESDHC
+#define CONFIG_FSL_USDHC
+#define CONFIG_SYS_FSL_ESDHC_ADDR      0
+#define USDHC1_BASE_ADDR               0x5B010000
+#define USDHC2_BASE_ADDR               0x5B020000

include/configs/colibri-imx8qxp.h line 37

Quoted 10 lines
include/configs/colibri-imx8qxp.h new file +10 -0
+#define CONFIG_SUPPORT_EMMC_BOOT       /* eMMC specific */
+
+#define CONFIG_ENV_OVERWRITE
+
+#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+
+#define FEC_QUIRK_ENET_MAC
+
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE          4096

4096 can be replaced with SZ_4K (from include/linux/sizes.h)

Quoted 158 lines
include/configs/colibri-imx8qxp.h new file +21 -0
+#define CONFIG_TFTP_TSIZE
+
+#define CONFIG_IPADDR                  192.168.10.2
+#define CONFIG_NETMASK                 255.255.255.0
+#define CONFIG_SERVERIP                        192.168.10.1
+
+#define MEM_LAYOUT_ENV_SETTINGS \
+       "fdt_addr_r=0x84000000\0" \
+       "kernel_addr_r=0x82000000\0" \
+       "ramdisk_addr_r=0x84100000\0"
+
+#ifdef CONFIG_AHAB_BOOT
+#define AHAB_ENV "sec_boot=yes\0"
+#else
+#define AHAB_ENV "sec_boot=no\0"
+#endif
+
+/* Boot M4 */
+#define M4_BOOT_ENV \
+       "m4_0_image=m4_0.bin\0" \
+       "loadm4image_0=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}

" \

include/configs/colibri-imx8qxp.h new file +2 -0
+               "${m4_0_image}\0" \
+       "m4boot_0=run loadm4image_0; dcache flush; bootaux

${loadaddr} 0\0" \

include/configs/colibri-imx8qxp.h new file +13 -0
+
+#define MFG_NAND_PARTITION ""
+
+#define BOOT_TARGET_DEVICES(func) \
+       func(MMC, mmc, 0) \
+       func(MMC, mmc, 1) \
+       func(DHCP, dhcp, na)
+#include <config_distro_bootcmd.h>
+#undef BOOTENV_RUN_NET_USB_START
+#define BOOTENV_RUN_NET_USB_START ""
+
+#define CONFIG_MFG_ENV_SETTINGS \
+       "mfgtool_args=setenv bootargs

console=${console},${baudrate} " \

include/configs/colibri-imx8qxp.h new file +2 -0
+               "rdinit=/linuxrc g_mass_storage.stall=0 " \
+               "g_mass_storage.removable=1

g_mass_storage.idVendor=0x066F " \

include/configs/colibri-imx8qxp.h new file +4 -0
+               "g_mass_storage.idProduct=0x37FF " \
+               "g_mass_storage.iSerialNumber=\"\" "\
+               MFG_NAND_PARTITION \
+               "video=imxdpufb5:off video=imxdpufb6:off

video=imxdpufb7:off " \

include/configs/colibri-imx8qxp.h new file +5 -0
+               "clk_ignore_unused "\
+               "\0" \
+       "initrd_addr=0x83800000\0" \
+       "initrd_high=0xffffffff\0" \
+       "bootcmd_mfg=run mfgtool_args;booti ${loadaddr}

${initrd_addr} " \

include/configs/colibri-imx8qxp.h new file +11 -0
+               "${fdt_addr};\0" \
+
+/* Initial environment variables */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+       AHAB_ENV \
+       BOOTENV \
+       CONFIG_MFG_ENV_SETTINGS \
+       M4_BOOT_ENV \
+       MEM_LAYOUT_ENV_SETTINGS \
+       "boot_fdt=try\0" \
+       "bootscript=echo Running bootscript from mmc ...; source\0"

\
+ "console=ttyLP3,115200
earlycon=lpuart32,0x5a090000,115200\0" \

include/configs/colibri-imx8qxp.h new file +8 -0
+       "fdt_addr=0x83000000\0"                 \
+       "fdt_file=fsl-imx8qxp-colibri-eval-v3.dtb\0" \
+       "fdt_high=0xffffffffffffffff\0"         \
+       "finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
+       "image=Image\0" \
+       "initrd_addr=0x83800000\0"              \
+       "initrd_high=0xffffffffffffffff\0" \
+       "loadbootscript=fatload mmc ${mmcdev}:${mmcpart}

${loadaddr} " \

include/configs/colibri-imx8qxp.h new file +2 -0
+               "${script};\0" \
+       "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}

${fdt_file}\0" \
+ "loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${image}\0" \

include/configs/colibri-imx8qxp.h new file +6 -0
+       "mmcargs=setenv bootargs console=${console},${baudrate} " \
+               "root=PARTUUID=${uuid} rootwait " \
+       "mmcautodetect=yes\0" \
+       "mmcboot=echo Booting from mmc ...; " \
+               "run finduuid; run mmcargs; " \
+               "if test ${boot_fdt} = yes || test ${boot_fdt} =

try; then " \

include/configs/colibri-imx8qxp.h new file +2 -0
+                       "if run loadfdt; then " \
+                               "booti ${loadaddr} - ${fdt_addr}; "

\

include/configs/colibri-imx8qxp.h new file +9 -0
+                       "else " \
+                               "echo WARN: Cannot load the DT; " \
+                       "fi; " \
+               "else " \
+                       "echo wait for boot; " \
+               "fi;\0" \
+       "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
+       "mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
+       "netargs=setenv bootargs console=${console} root=/dev/nfs

ip=dhcp " \
+ "nfsroot=${serverip}:${nfsroot},v3,tcp
video=imxdpufb5:off " \

include/configs/colibri-imx8qxp.h new file +10 -0
+               "video=imxdpufb6:off video=imxdpufb7:off\0" \
+       "netboot=echo Booting from net ...; " \
+               "run netargs; " \
+               "if test ${ip_dyn} = yes; then " \
+                       "setenv get_cmd dhcp; " \
+               "else " \
+                       "setenv get_cmd tftp; " \
+               "fi; " \
+               "${get_cmd} ${loadaddr} ${image}; " \
+               "if test ${boot_fdt} = yes || test ${boot_fdt} =

try; then " \
+ "if ${get_cmd} ${fdt_addr} ${fdt_file};
then " \
+ "booti ${loadaddr} - ${fdt_addr}; "
\

include/configs/colibri-imx8qxp.h new file +7 -0
+                       "else " \
+                               "echo WARN: Cannot load the DT; " \
+                       "fi; " \
+               "else " \
+                       "booti; " \
+               "fi;\0" \
+       "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp

${fdt_addr} " \
+ "colibri-imx8qxp/${fdt_file}; booti ${loadaddr} - "
\

include/configs/colibri-imx8qxp.h new file +4 -0
+               "${fdt_addr}\0" \
+       "panel=NULL\0" \
+       "script=boot.scr\0" \
+       "video=imxdpufb5:off video=imxdpufb6:off

video=imxdpufb7:off\0"

include/configs/colibri-imx8qxp.h new file +25 -0
+
+#undef CONFIG_BOOTCOMMAND
+#define CONFIG_BOOTCOMMAND \
+          "mmc dev ${mmcdev}; if mmc rescan; then " \
+                  "if run loadbootscript; then " \
+                          "run bootscript; " \
+                  "else " \
+                          "if run loadimage; then " \
+                                  "run mmcboot; " \
+                          "else run netboot; " \
+                          "fi; " \
+                  "fi; " \
+          "else booti ${loadaddr} - ${fdt_addr}; fi"
+
+/* Link Definitions */
+#define CONFIG_LOADADDR                        0x80280000
+
+#define CONFIG_SYS_LOAD_ADDR           CONFIG_LOADADDR
+
+#define CONFIG_SYS_INIT_SP_ADDR                0x80200000
+
+#define CONFIG_SYS_MEMTEST_START       0x88000000
+#define CONFIG_SYS_MEMTEST_END         0x89000000
+
+/* Environment in eMMC, before config block at the end of 1st
Quoted 2 lines

"boot sector" */
+#define CONFIG_ENV_SIZE (8 * 1024)

(8 * 1024) can be replaced with SZ_8K (from include/linux/sizes.h)

Quoted 16 lines
include/configs/colibri-imx8qxp.h new file +2 -0
+#define CONFIG_ENV_OFFSET              (-CONFIG_ENV_SIZE + \
+                                        CONFIG_TDX_CFG_BLOCK_OFFSE

T)

include/configs/colibri-imx8qxp.h new file +7 -0
+#define CONFIG_SYS_MMC_ENV_DEV         0
+#define CONFIG_SYS_MMC_ENV_PART                1
+
+#define CONFIG_SYS_MMC_IMG_LOAD_PART   1
+
+/* On Colibri iMX8 USDHC1 is eMMC, USDHC2 is 4-bit SD */
+#define CONFIG_SYS_MMC_ENV_DEV         0                /* USDHC1

eMMC */

include/configs/colibri-imx8qxp.h new file +4 -0
+#define CONFIG_SYS_FSL_USDHC_NUM       2
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN          ((CONFIG_ENV_SIZE + (32 *

1024)) * 1024)

include/configs/colibri-imx8qxp.h line 194

Quoted 6 lines
include/configs/colibri-imx8qxp.h new file +6 -0
+
+#define CONFIG_SYS_SDRAM_BASE          0x80000000
+#define CONFIG_NR_DRAM_BANKS           3
+#define PHYS_SDRAM_1                   0x80000000
+#define PHYS_SDRAM_2                   0x880000000
+#define PHYS_SDRAM_1_SIZE              0x80000000      /* 2 GB */

0x80000000 can be replaced with SZ_2G (from include/linux/sizes.h)

include/configs/colibri-imx8qxp.h line 202

Quoted 8 lines
include/configs/colibri-imx8qxp.h new file +8 -0
+#define PHYS_SDRAM_2_SIZE              0x00000000      /* 0 GB */
+
+/* Serial */
+#define CONFIG_BAUDRATE                        115200
+
+/* Monitor Command Prompt */
+#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
+#define CONFIG_SYS_CBSIZE              2048

Same as above

Quoted 11 lines
include/configs/colibri-imx8qxp.h new file +4 -0
+#define CONFIG_SYS_MAXARGS             64
+#define CONFIG_SYS_BARGSIZE            CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_PBSIZE              (CONFIG_SYS_CBSIZE + \
+                                       sizeof(CONFIG_SYS_PROMPT) +

16)

include/configs/colibri-imx8qxp.h new file +6 -0
+
+/* Generic Timer Definitions */
+#define COUNTER_FREQUENCY              8000000 /* 8MHz */
+
+#define BOOTAUX_RESERVED_MEM_BASE 0x88000000
+#define BOOTAUX_RESERVED_MEM_SIZE 0x08000000 /* Reserve from
Quoted 1 line

second 128MB */

Same as above

Quoted 9 lines
include/configs/colibri-imx8qxp.h new file +2 -1
+
+#endif /* __COLIBRI_IMX8QXP_H */
--

2.20.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

#12 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Quoted 6 lines · Marcel Ziswiler

Hi Igor

Sorry, somehow I missed your comments below (;-p).

I will send out a v4 (yes there already was a v3 BTW) shortly including the SPL resp. without SPL build fix.

Fine - the series (without 5/5) is already applied on u-boot-imx. Please just send 5/5.

Regards,
Stefano

Quoted 1,453 lines · Igor Opaniuk
Quoted 357 lines

Hi Marcel,

Some minor comments below (can be addressed in different patch):

Quoted 349 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB
IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which
are factory fused to properly boot from their on-module eMMC. U- Boot
supports either booting from the on-module eMMC or may be used for recovery purpose using the universal update utility (uuu) aka mfgtools
3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Unfortunately, there is no USB functionality for the i.MX 8QXP as of
yet.

---

Changes in v2:
- Changed imx-atf git clone command to include initial branch information as suggested by Igor.
- Sorted board file includes alphabetically as suggested by Igor.
- Got rid of SPL configuration in legacy header file as suggested by
Igor and the whole use of SPL on i.MX 8X anyway neither works
well
nor makes any much sense at all.

 arch/arm/dts/Makefile                         |   4 +-
 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  | 112 ++++++
 arch/arm/dts/fsl-imx8qxp-colibri.dts          | 328
++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   6 +
 board/toradex/colibri-imx8qxp/Kconfig         |  30 ++
 board/toradex/colibri-imx8qxp/MAINTAINERS     |   9 +
 board/toradex/colibri-imx8qxp/Makefile        |   7 +
 board/toradex/colibri-imx8qxp/README          |  66 ++++
 .../toradex/colibri-imx8qxp/colibri-imx8qxp.c | 212 +++++++++++
 board/toradex/colibri-imx8qxp/imximage.cfg    |  24 ++
 configs/colibri-imx8qxp_defconfig             |  53 +++
 include/configs/colibri-imx8qxp.h             | 214 ++++++++++++
 12 files changed, 1064 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri.dts
 create mode 100644 board/toradex/colibri-imx8qxp/Kconfig
 create mode 100644 board/toradex/colibri-imx8qxp/MAINTAINERS
 create mode 100644 board/toradex/colibri-imx8qxp/Makefile
 create mode 100644 board/toradex/colibri-imx8qxp/README
 create mode 100644 board/toradex/colibri-imx8qxp/colibri-imx8qxp.c
 create mode 100644 board/toradex/colibri-imx8qxp/imximage.cfg
 create mode 100644 configs/colibri-imx8qxp_defconfig
 create mode 100644 include/configs/colibri-imx8qxp.h
arch/arm/dts/Makefile +3 -1
index 13d1d67624..2a551d42a4 100644
@@ -559,7 +559,9 @@ dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
-dtb-$(CONFIG_ARCH_IMX8) += fsl-imx8qxp-mek.dtb
+dtb-$(CONFIG_ARCH_IMX8) += \
+       fsl-imx8qxp-colibri.dtb \
+       fsl-imx8qxp-mek.dtb
 
 dtb-$(CONFIG_ARCH_IMX8M) += fsl-imx8mq-evk.dtb
 
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi new file +112 -0
new file mode 100644
index 0000000000..f8686befdf
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+&mu {
+       u-boot,dm-spl;
+};
+
+&clk {
+       u-boot,dm-spl;
+};
+
+&iomuxc {
+       u-boot,dm-spl;
+};
+
+&pd_lsio {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio0 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio1 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio2 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio3 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio4 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio5 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio6 {
+       u-boot,dm-spl;
+};
+
+&pd_lsio_gpio7 {
+       u-boot,dm-spl;
+};
+
+&pd_conn {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch0 {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch1 {
+       u-boot,dm-spl;
+};
+
+&pd_conn_sdch2 {
+       u-boot,dm-spl;
+};
+
+&gpio0 {
+       u-boot,dm-spl;
+};
+
+&gpio1 {
+       u-boot,dm-spl;
+};
+
+&gpio2 {
+       u-boot,dm-spl;
+};
+
+&gpio3 {
+       u-boot,dm-spl;
+};
+
+&gpio4 {
+       u-boot,dm-spl;
+};
+
+&gpio5 {
+       u-boot,dm-spl;
+};
+
+&gpio6 {
+       u-boot,dm-spl;
+};
+
+&gpio7 {
+       u-boot,dm-spl;
+};
+
+&lpuart3 {
+       u-boot,dm-spl;
+};
+
+&usdhc1 {
+       u-boot,dm-spl;
+};
+
+&usdhc2 {
+       u-boot,dm-spl;
+};
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +16 -0
new file mode 100644
index 0000000000..0c20edf2cf
@@ -0,0 +1,328 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+/dts-v1/;
+
+#include "fsl-imx8qxp.dtsi"
+#include "fsl-imx8qxp-colibri-u-boot.dtsi"
+
+/ {
+       model = "Toradex Colibri iMX8QXP";
+       compatible = "toradex,colibri-imx8qxp", "fsl,imx8qxp";
+
+       chosen {
+               bootargs = "console=ttyLP3,115200

earlycon=lpuart32,0x5a090000,115200";

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +17 -0
+               stdout-path = &lpuart3;
+       };
+
+       reg_usbh_vbus: regulator-usbh-vbus {
+               compatible = "regulator-fixed";
+               pinctrl-names = "default";
+               pinctrl-0 = <&pinctrl_usbh1_reg>;
+               regulator-name = "usbh_vbus";
+               regulator-min-microvolt = <5000000>;
+               regulator-max-microvolt = <5000000>;
+               gpio = <&gpio4 3 GPIO_ACTIVE_LOW>;
+       };
+};
+
+&iomuxc {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_hog0>, <&pinctrl_hog1>,

<&pinctrl_hog2>;

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +5 -0
+
+       colibri-imx8qxp {
+               pinctrl_lpuart0: lpuart0grp {
+                       fsl,pins = <
+                               SC_P_UART0_RX_ADMA_UART0_RX     0x0

6000020
+ SC_P_UART0_TX_ADMA_UART0_TX 0x0
6000020

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                       >;
+               };
+
+               pinctrl_lpuart3: lpuart3grp {
+                       fsl,pins = <
+                               SC_P_FLEXCAN2_RX_ADMA_UART3_RX  0x0

6000020
+ SC_P_FLEXCAN2_TX_ADMA_UART3_TX 0x0
6000020

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                       >;
+               };
+
+               pinctrl_lpuart3_ctrl: lpuart3ctrlgrp {
+                       fsl,pins = <
+                               SC_P_MIPI_DSI1_GPIO0_01_LSIO_GPIO2_

IO00 0x00000020 /* DTR */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +11 -0
+                               SC_P_SAI1_RXD_LSIO_GPIO0_IO29      
     0x00000020 /* CTS */
+                               SC_P_SAI1_RXC_LSIO_GPIO0_IO30      
     0x00000020 /* RTS */
+                               SC_P_CSI_RESET_LSIO_GPIO3_IO03     
     0x00000020 /* DSR */
+                               SC_P_USDHC1_CD_B_LSIO_GPIO4_IO22   
     0x00000020 /* DCD */
+                               SC_P_CSI_EN_LSIO_GPIO3_IO02        
     0x00000020 /* RI */
+                       >;
+               };
+
+               pinctrl_fec1: fec1grp {
+                       fsl,pins = <
+                               SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENE

TB0_PAD 0x000014a0 /* Use pads in 3.3V mode */
+ SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENE
TB1_PAD 0x000014a0 /* Use pads in 3.3V mode */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +3 -0
+                               SC_P_ENET0_MDC_CONN_ENET0_MDC      
             0x06000020
+                               SC_P_ENET0_MDIO_CONN_ENET0_MDIO    
             0x06000020
+                               SC_P_ENET0_RGMII_TX_CTL_CONN_ENET0_

RGMII_TX_CTL 0x00000061
+ SC_P_ENET0_RGMII_TXC_CONN_ENET0_RCL
K50M_OUT 0x06000061
+ SC_P_ENET0_RGMII_TXD0_CONN_ENET0_RG
MII_TXD0 0x00000061
+ SC_P_ENET0_RGMII_TXD1_CONN_ENET0_RG
MII_TXD1 0x00000061
+ SC_P_ENET0_RGMII_RX_CTL_CONN_ENET0_
RGMII_RX_CTL 0x00000061
+ SC_P_ENET0_RGMII_RXD0_CONN_ENET0_RG
MII_RXD0 0x00000061
+ SC_P_ENET0_RGMII_RXD1_CONN_ENET0_RG
MII_RXD1 0x00000061
+ SC_P_ENET0_RGMII_RXD2_CONN_ENET0_RM
II_RX_ER 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +12 -0
+                       >;
+               };
+
+               pinctrl_gpio_bl_on: gpio-bl-on {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA3_LSIO_GPIO3_IO12  
     0x00000040
+                       >;
+               };
+
+               pinctrl_hog0: hog0grp {
+                       fsl,pins = <
+                               SC_P_COMP_CTL_GPIO_1V8_3V3_GPIORHB_

PAD 0x000514a0 /* Use pads in 3.3V mode */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +7 -0
+                       >;
+               };
+
+               pinctrl_hog1: hog1grp {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA1_LSIO_GPIO3_IO10  
     0x00000020 /*  45 */
+                               SC_P_ENET0_RGMII_TXD3_LSIO_GPIO5_IO

02 0x06000020 /* 65 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                                       SC_P_CSI_D07_CI_PI_D09     
     0x00000061
+                               SC_P_QSPI0A_DATA2_LSIO_GPIO3_IO11  
     0x00000020 /*  69 */
+                               SC_P_QSPI0A_DQS_LSIO_GPIO3_IO13    
     0x00000020 /*  73 */
+                               SC_P_SAI0_TXC_LSIO_GPIO0_IO26      
     0x00000020 /*  79 */
+                                       SC_P_CSI_D02_CI_PI_D04     
     0x00000061
+                               SC_P_ENET0_RGMII_RXC_LSIO_GPIO5_IO0

3 0x06000020 /* 85 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                                       SC_P_CSI_D06_CI_PI_D08     
     0x00000061
+                               SC_P_QSPI0B_SCLK_LSIO_GPIO3_IO17   
     0x00000020 /*  95 */
+                               SC_P_SAI0_RXD_LSIO_GPIO0_IO27      
     0x00000020 /*  97 */
+                                       SC_P_CSI_D03_CI_PI_D05     
     0x00000061
+                               SC_P_QSPI0B_DATA0_LSIO_GPIO3_IO18  
     0x00000020 /*  99 */
+                               SC_P_SAI0_TXFS_LSIO_GPIO0_IO28     
     0x00000020 /* 101 */
Quoted 8 lines

arch/arm/dts/fsl-imx8qxp-colibri.dts

Quoted 6 lines
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +3 -0
+                                       SC_P_CSI_D00_CI_PI_D02     
     0x00000061
+                               SC_P_SAI0_TXD_LSIO_GPIO0_IO25      
     0x00000020 /* 103 */
+                                       SC_P_CSI_D01_CI_PI_D03     
     0x00000061

I seems that in 20 lines above alignment is broken a bit.

No, I believe Max intentionally did it that way downstream indicating that those SODIMM pins are each multiplexed onto two SoC balls. Toradex does this at times to gain greater pin compatibility across our module families.

Further comments down below taken into account. Thanks!

Cheers

Marcel

Quoted 1,074 lines
Quoted 384 lines
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +27 -0
+                               SC_P_QSPI0B_DATA1_LSIO_GPIO3_IO19  
     0x00000020 /* 105 */
+                               SC_P_QSPI0B_DATA2_LSIO_GPIO3_IO20  
     0x00000020 /* 107 */
+                               SC_P_USB_SS3_TC2_LSIO_GPIO4_IO05   
     0x00000020 /* 127 */
+                               SC_P_USB_SS3_TC3_LSIO_GPIO4_IO06   
     0x00000020 /* 131 */
+                               SC_P_USB_SS3_TC1_LSIO_GPIO4_IO04   
     0x00000020 /* 133 */
+                               SC_P_CSI_PCLK_LSIO_GPIO3_IO00      
     0x00000020 /*  96 */
+                               SC_P_QSPI0B_DATA3_LSIO_GPIO3_IO21  
     0x00000020 /*  98 */
+                               SC_P_SAI1_RXFS_LSIO_GPIO0_IO31     
     0x00000020 /* 100 */
+                               SC_P_QSPI0B_DQS_LSIO_GPIO3_IO22    
     0x00000020 /* 102 */
+                               SC_P_QSPI0B_SS0_B_LSIO_GPIO3_IO23  
     0x00000020 /* 104 */
+                               SC_P_QSPI0B_SS1_B_LSIO_GPIO3_IO24  
     0x00000020 /* 106 */
+                       >;
+               };
+
+               pinctrl_hog2: hog2grp {
+                       fsl,pins = <
+                               SC_P_CSI_MCLK_LSIO_GPIO3_IO01      
     0x00000020 /*  75 */
+                               SC_P_QSPI0A_SS0_B_LSIO_GPIO3_IO14  
     0x00000020 /*  77 */
+                               SC_P_QSPI0A_SS1_B_LSIO_GPIO3_IO15  
     0x00000020 /*  89 */
+                               SC_P_QSPI0A_SCLK_LSIO_GPIO3_IO16   
     0x00000020 /*  93 */
+                       >;
+               };
+
+               /* Off Module I2C */
+               pinctrl_i2c1: i2c1grp {
+                       fsl,pins = <
+                               SC_P_MIPI_DSI0_GPIO0_00_ADMA_I2C1_S

CL 0x06000021
+ SC_P_MIPI_DSI0_GPIO0_01_ADMA_I2C1_S
DA 0x06000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +7 -0
+                       >;
+               };
+
+               /*INT*/
+               pinctrl_usb3503a: usb3503a-grp {
+                       fsl,pins = <
+                               SC_P_MIPI_CSI0_MCLK_OUT_LSIO_GPIO3_

IO04 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+                       >;
+               };
+
+               pinctrl_usbc_det: usbc-det {
+                       fsl,pins = <
+                               SC_P_ENET0_REFCLK_125M_25M_LSIO_GPI

O5_IO09 0x06000040

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +23 -0
+                       >;
+               };
+
+               pinctrl_usbh1_reg: usbh1-reg {
+                       fsl,pins = <
+                               SC_P_USB_SS3_TC0_LSIO_GPIO4_IO03   
     0x06000040
+                       >;
+               };
+
+               pinctrl_usdhc1: usdhc1grp {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK      
     0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD      
     0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0  
     0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1  
     0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2  
     0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3  
     0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4  
     0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5  
     0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6  
     0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7  
     0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE
     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET

_B 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +17 -0
+                       >;
+               };
+
+               pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK      
     0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD      
     0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0  
     0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1  
     0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2  
     0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3  
     0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4  
     0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5  
     0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6  
     0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7  
     0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE
     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET

_B 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +17 -0
+                       >;
+               };
+
+               pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
+                       fsl,pins = <
+                               SC_P_EMMC0_CLK_CONN_EMMC0_CLK      
     0x06000041
+                               SC_P_EMMC0_CMD_CONN_EMMC0_CMD      
     0x00000021
+                               SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0  
     0x00000021
+                               SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1  
     0x00000021
+                               SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2  
     0x00000021
+                               SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3  
     0x00000021
+                               SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4  
     0x00000021
+                               SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5  
     0x00000021
+                               SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6  
     0x00000021
+                               SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7  
     0x00000021
+                               SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE
     0x00000041
+                               SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET

_B 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +18 -0
+                       >;
+               };
+
+               pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+                       fsl,pins = <
+                               SC_P_QSPI0A_DATA0_LSIO_GPIO3_IO09  
     0x06000021
+                       >;
+               };
+
+               pinctrl_usdhc2: usdhc2grp {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK    
     0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD    
     0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0
     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1
     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2
     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3
     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSE

LECT 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +12 -0
+                       >;
+               };
+
+               pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK    
     0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD    
     0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0
     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1
     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2
     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3
     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSE

LECT 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +12 -0
+                       >;
+               };
+
+               pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
+                       fsl,pins = <
+                               SC_P_USDHC1_CLK_CONN_USDHC1_CLK    
     0x06000041
+                               SC_P_USDHC1_CMD_CONN_USDHC1_CMD    
     0x00000021
+                               SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0
     0x00000021
+                               SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1
     0x00000021
+                               SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2
     0x00000021
+                               SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3
     0x00000021
+                               SC_P_USDHC1_VSELECT_CONN_USDHC1_VSE

LECT 0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +77 -0
+                       >;
+               };
+       };
+};
+
+&lpuart0 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lpuart0>;
+       status = "okay";
+};
+
+&lpuart3 {
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_lpuart3>, <&pinctrl_lpuart3_ctrl>;
+       status = "okay";
+};
+
+&gpio0 {
+       status = "okay";
+};
+
+&gpio1 {
+       status = "okay";
+};
+
+&gpio3 {
+       status = "okay";
+};
+
+&gpio4 {
+       status = "okay";
+};
+
+&fec1 {
+       phy-handle = <&ethphy0>;
+       phy-mode = "rmii";
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_fec1>;
+       status = "okay";
+
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               ethphy0: ethernet-phy at 2 {
+                       compatible = "ethernet-phy-ieee802.3-c22";
+                       max-speed = <100>;
+                       reg = <2>;
+               };
+       };
+};
+
+&i2c1 {
+       #address-cells = <1>;
+       #size-cells = <0>;
+       clock-frequency = <100000>;
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_i2c1>;
+       status = "okay";
+};
+
+&usdhc1 {
+       bus-width = <8>;
+       non-removable;
+       pinctrl-names = "default", "state_100mhz", "state_200mhz";
+       pinctrl-0 = <&pinctrl_usdhc1>;
+       pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+       pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+       status = "okay";
+};
+
+&usdhc2 {
+       bus-width = <4>;
+       cd-gpios = <&gpio3 9 GPIO_ACTIVE_LOW>;
+       pinctrl-names = "default", "state_100mhz", "state_200mhz";
+       pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+       pinctrl-1 = <&pinctrl_usdhc2_100mhz>,

<&pinctrl_usdhc2_gpio>;
+ pinctrl-2 = <&pinctrl_usdhc2_200mhz>,
<&pinctrl_usdhc2_gpio>;

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +2 -0
+       status = "okay";
+};
arch/arm/mach- renamed from arch/arm/mach-imx/imx8/Kconfig +0 -0

imx/imx8/Kconfig
index f76a139684..feea07f135 100644

arch/arm/mach-imx/imx8/Kconfig +6 -0
@@ -22,6 +22,11 @@ choice
        prompt "i.MX8 board select"
        optional
 
+config TARGET_COLIBRI_IMX8QXP
+       bool "Support Colibri iMX8QXP module"
+       select BOARD_LATE_INIT
+       select IMX8QXP
+
 config TARGET_IMX8QXP_MEK
        bool "Support i.MX8QXP MEK board"
        select BOARD_LATE_INIT
@@ -30,5 +35,6 @@ config TARGET_IMX8QXP_MEK
 endchoice
 
 source "board/freescale/imx8qxp_mek/Kconfig"
+source "board/toradex/colibri-imx8qxp/Kconfig"
 
 endif
board/toradex/colibri-imx8qxp/Kconfig new file +30 -0
new file mode 100644
index 0000000000..340fe72816
@@ -0,0 +1,30 @@
+if TARGET_COLIBRI_IMX8QXP
+
+config SYS_BOARD
+       default "colibri-imx8qxp"
+
+config SYS_VENDOR
+       default "toradex"
+
+config SYS_CONFIG_NAME
+       default "colibri-imx8qxp"
+
+config TDX_CFG_BLOCK
+       default y
+
+config TDX_HAVE_MMC
+       default y
+
+config TDX_CFG_BLOCK_DEV
+       default "0"
+
+config TDX_CFG_BLOCK_PART
+       default "1"
+
+# Toradex config block in eMMC, at the end of 1st "boot sector"
+config TDX_CFG_BLOCK_OFFSET
+       default "-512"
+
+source "board/toradex/common/Kconfig"
+
+endif
board/toradex/colibri-imx8qxp/MAINTAINERS new file +9 -0
new file mode 100644
index 0000000000..39a9eb79b7
@@ -0,0 +1,9 @@
+Colibri iMX8QXP
+M:     Marcel Ziswiler <[email protected]>
+W:     http://developer.toradex.com/software/linux/linux-software
+S:     Maintained
+F:     arch/arm/dts/fsl-imx8qxp-colibri.dts
+F:     arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
+F:     board/toradex/colibri-imx8qxp/
+F:     configs/colibri-imx8qxp_defconfig
+F:     include/configs/colibri-imx8qxp.h
board/toradex/colibri-imx8qxp/Makefile new file +0 -0
new file mode 100644
index 0000000000..f6342e1dca

board/toradex/colibri-imx8qxp/Makefile line 4

Quoted 4 lines
board/toradex/colibri-imx8qxp/Makefile new file +4 -0
@@ -0,0 +1,7 @@
+#
+# Copyright 2019 Toradex
+#
+# SPDX-License-Identifier:     GPL-2.0+

SPDX line should be in the beginning of the file.

Quoted 451 lines
board/toradex/colibri-imx8qxp/Makefile new file +3 -0
+#
+
+obj-y += colibri-imx8qxp.o
board/toradex/colibri-imx8qxp/README new file +16 -0
new file mode 100644
index 0000000000..e68d183fe6
@@ -0,0 +1,66 @@
+U-Boot for the Toradex Colibri iMX8QXP V1.0B module
+
+Quick Start
+===========
+
+- Build the ARM trusted firmware binary
+- Get scfw_tcm.bin and ahab-container.img
+- Build U-Boot
+- Load U-Boot binary using uuu
+- Flash U-Boot binary into the eMMC
+- Boot
+
+Get and Build the ARM Trusted Firmware
+======================================
+
+$ git clone -b imx_4.14.78_1.0.0_ga 

https://source.codeaurora.org/external/imx/imx-atf
+$ cd imx-atf/
+$ make PLAT=imx8qxp bl31

board/toradex/colibri-imx8qxp/README new file +5 -0
+
+Get scfw_tcm.bin and ahab-container.img
+=======================================
+
+$ wget 

https://github.com/toradex/meta-fsl-bsp-release/blob/toradex-sumo-4.14.78-1.0.0_ga-bringup/imx/meta-bsp/recipes-bsp/imx-sc-firmware/files/mx8qx-colibri-scfw-tcm.bin?raw=true
+$ mv mx8qx-colibri-scfw-tcm.bin\?raw\=true mx8qx-colibri-scfw- tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-7.6.bin
+$ chmod +x firmware-imx-7.6.bin
+$ ./firmware-imx-7.6.bin

board/toradex/colibri-imx8qxp/README new file +20 -0
+
+Copy the following binaries to the U-Boot folder:
+
+$ cp imx-atf/build/imx8qxp/release/bl31.bin .
+$ cp u-boot/u-boot.bin .
+
+Copy the following firmware to the U-Boot folder:
+
+$ cp firmware-imx-7.6/firmware/seco/ahab-container.img .
+
+Build U-Boot
+============
+
+$ make colibri-imx8qxp_defconfig
+$ make u-boot-dtb.imx
+
+Load the U-Boot Binary Using UUU
+================================
+
+Get the latest version of the universal update utility (uuu) aka

mfgtools 3.0:

board/toradex/colibri-imx8qxp/README new file +2 -0
+
+

https://community.nxp.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2FNXPmicro%2Fmfgtools%2Freleases

board/toradex/colibri-imx8qxp/README new file +2 -0
+
+Put the module into USB recovery aka serial downloader mode,

connect USB device

board/toradex/colibri-imx8qxp/README new file +8 -0
+to your host and execute uuu:
+
+sudo ./uuu u-boot/u-boot-dtb.imx
+
+Flash the U-Boot Binary into the eMMC
+=====================================
+
+Burn the u-boot-dtb.imx binary to the primary eMMC hardware boot

area partition:

board/toradex/colibri-imx8qxp/README new file +3 -0
+
+load mmc 1:1 $loadaddr u-boot-dtb.imx
+setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt ${blkcnt} /

0x200

board/toradex/colibri-imx8qxp/README new file +4 -0
+mmc dev 0 1
+mmc write ${loadaddr} 0x0 ${blkcnt}
+
+Boot
board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +33 -0
new file mode 100644
index 0000000000..9aa0f096d2
@@ -0,0 +1,212 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019 Toradex
+ */
+
+#include <common.h>
+
+#include <asm/arch/clock.h>
+#include <asm/arch/imx8-pins.h>
+#include <asm/arch/iomux.h>
+#include <asm/arch/sci/sci.h>
+#include <asm/arch/sys_proto.h>
+#include <asm/gpio.h>
+#include <asm/io.h>
+#include <asm/mach-imx/video.h>
+#include <dm.h>
+#include <environment.h>
+#include <errno.h>
+#include <fdt_support.h>
+#include <fsl_esdhc.h>
+#include <fsl_ifc.h>
+#include <i2c.h>
+#include <linux/libfdt.h>
+#include <malloc.h>
+#include <netdev.h>
+#include <power-domain.h>
+#include <usb.h>
+
+#include "../common/tdx-cfg-block.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define GPIO_PAD_CTRL  ((SC_PAD_CONFIG_NORMAL <<

PADRING_CONFIG_SHIFT) | \
+ (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT)
| \
+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \
+ (SC_PAD_28FDSOI_PS_PU <<
PADRING_PULL_SHIFT))

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +2 -0
+
+#define UART_PAD_CTRL  ((SC_PAD_CONFIG_OUT_IN <<

PADRING_CONFIG_SHIFT) | \
+ (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT)
| \
+ (SC_PAD_28FDSOI_DSE_DV_HIGH <<
PADRING_DSE_SHIFT) | \
+ (SC_PAD_28FDSOI_PS_PU <<
PADRING_PULL_SHIFT))

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +3 -0
+
+static iomux_cfg_t uart3_pads[] = {
+       SC_P_FLEXCAN2_RX | MUX_MODE_ALT(2) |

MUX_PAD_CTRL(UART_PAD_CTRL),
+ SC_P_FLEXCAN2_TX | MUX_MODE_ALT(2) |
MUX_PAD_CTRL(UART_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +2 -0
+       /* Transceiver FORCEOFF# signal, mux to use pullup */
+       SC_P_QSPI0B_DQS | MUX_MODE_ALT(4) |

MUX_PAD_CTRL(UART_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+};
+
+static void setup_iomux_uart(void)
+{
+       imx8_iomux_setup_multiple_pads(uart3_pads,

ARRAY_SIZE(uart3_pads));

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +9 -0
+}
+
+int board_early_init_f(void)
+{
+       sc_pm_clock_rate_t rate;
+       sc_err_t err = 0;
+
+       /*
+        * This works around that having only UART3 up the baudrate

is 1.2M

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +4 -0
+        * instead of 115.2k. Set UART0 clock root to 80 MHz
+        */
+       rate = 80000000;
+       err = sc_pm_set_clock_rate(-1, SC_R_UART_0, SC_PM_CLK_PER,

&rate);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Power up UART3 */
+       err = sc_pm_set_resource_power_mode(-1, SC_R_UART_3,

SC_PM_PW_MODE_ON);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +6 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Set UART3 clock root to 80 MHz */
+       rate = 80000000;
+       err = sc_pm_set_clock_rate(-1, SC_R_UART_3, SC_PM_CLK_PER,

&rate);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       /* Enable UART3 clock root */
+       err = sc_pm_clock_enable(-1, SC_R_UART_3, SC_PM_CLK_PER,

true, false);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +14 -0
+       if (err != SC_ERR_NONE)
+               return 0;
+
+       setup_iomux_uart();
+
+       return 0;
+}
+
+#undef CONFIG_MXC_GPIO /* TODO */
+#ifdef CONFIG_MXC_GPIO
+#define IOEXP_RESET IMX_GPIO_NR(1, 1)
+
+static iomux_cfg_t board_gpios[] = {
+       SC_P_SPI2_SDO | MUX_MODE_ALT(4) |

MUX_PAD_CTRL(GPIO_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +23 -0
+       SC_P_ENET0_REFCLK_125M_25M | MUX_MODE_ALT(4) | \
+               MUX_PAD_CTRL(GPIO_PAD_CTRL),
+};
+
+static void board_gpio_init(void)
+{
+       struct gpio_desc desc;
+       int ret;
+
+       ret = dm_gpio_lookup_name("gpio at 1a_3", &desc);
+       if (ret)
+               return;
+
+       ret = dm_gpio_request(&desc, "bb_per_rst_b");
+       if (ret)
+               return;
+
+       dm_gpio_set_dir_flags(&desc, GPIOD_IS_OUT);
+       dm_gpio_set_value(&desc, 0);
+       udelay(50);
+       dm_gpio_set_value(&desc, 1);
+
+       imx8_iomux_setup_multiple_pads(board_gpios,

ARRAY_SIZE(board_gpios));

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +38 -0
+
+       /* enable i2c port expander assert reset line */
+       gpio_request(IOEXP_RESET, "ioexp_rst");
+       gpio_direction_output(IOEXP_RESET, 1);
+}
+#else
+static inline void board_gpio_init(void) {}
+#endif
+
+#if IS_ENABLED(CONFIG_FEC_MXC)
+#include <miiphy.h>
+
+int board_phy_config(struct phy_device *phydev)
+{
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
+
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
+       phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
+
+       if (phydev->drv->config)
+               phydev->drv->config(phydev);
+
+       return 0;
+}
+#endif
+
+void build_info(void)
+{
+       u32 sc_build = 0, sc_commit = 0;
+
+       /* Get SCFW build and commit id */
+       sc_misc_build_info(-1, &sc_build, &sc_commit);
+       if (!sc_build) {
+               printf("SCFW does not support build info\n");
+               sc_commit = 0; /* Display 0 if build info not

supported */

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +56 -0
+       }
+       printf("Build: SCFW %x\n", sc_commit);
+}
+
+int checkboard(void)
+{
+       puts("Model: Toradex Colibri iMX8X\n");
+
+       build_info();
+       print_bootinfo();
+
+       return 0;
+}
+
+int board_init(void)
+{
+       board_gpio_init();
+
+       return 0;
+}
+
+void detail_board_ddr_info(void)
+{
+       puts("\nDDR    ");
+}
+
+/*
+ * Board specific reset that is system reset.
+ */
+void reset_cpu(ulong addr)
+{
+       /* TODO */
+}
+
+#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
+int ft_board_setup(void *blob, bd_t *bd)
+{
+       return ft_common_board_setup(blob, bd);
+}
+#endif
+
+int board_mmc_get_env_dev(int devno)
+{
+       return devno;
+}
+
+int board_late_init(void)
+{
+#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+/* TODO move to common */
+       env_set("board_name", "Colibri iMX8QXP");
+       env_set("board_rev", "v1.0");
+#endif
+
+       return 0;
+}
board/toradex/colibri-imx8qxp/imximage.cfg new file +5 -0
new file mode 100644
index 0000000000..ce9e66c64d
@@ -0,0 +1,24 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ *
+ * Refer doc/README.imx8image for more details about how-to

configure
+ * and create imx8image boot image
+ */

board/toradex/colibri-imx8qxp/imximage.cfg new file +17 -0
+
+#define __ASSEMBLY__
+
+/* Boot from SD, sector size 0x400 */
+BOOT_FROM EMMC_FASTBOOT 0x400
+/* SoC type IMX8QX */
+SOC_TYPE IMX8QX
+/* Append seco container image */
+APPEND ahab-container.img
+/* Create the 2nd container */
+CONTAINER
+/* Add scfw image with exec attribute */
+IMAGE SCU mx8qx-colibri-scfw-tcm.bin
+/* Add ATF image with exec attribute */
+IMAGE A35 bl31.bin 0x80000000
+/* Add U-Boot image with load attribute */
+DATA A35 u-boot-dtb.bin 0x80020000
configs/colibri- renamed from configs/colibri-imx8qxp_defconfig +0 -0

imx8qxp_defconfig
new file mode 100644
index 0000000000..d697546ed7

configs/colibri-imx8qxp_defconfig new file +9 -0
@@ -0,0 +1,53 @@
+CONFIG_ARM=y
+CONFIG_ARCH_IMX8=y
+CONFIG_SYS_TEXT_BASE=0x80020000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_TARGET_COLIBRI_IMX8QXP=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=3
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri-

imx8qxp/imximage.cfg"

configs/colibri-imx8qxp_defconfig new file +44 -0
+CONFIG_LOG=y
+CONFIG_VERSION_VARIABLE=y
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_CMD_CPU=y
+# CONFIG_CMD_IMPORTENV is not set
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_DM=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_UUID=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-colibri"
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_CLK_IMX8=y
+CONFIG_CPU=y
+CONFIG_DM_GPIO=y
+CONFIG_MXC_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_IMX_LPI2C=y
+CONFIG_MISC=y
+CONFIG_DM_MMC=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_ADDR_ENABLE=y
+CONFIG_PHY_MICREL=y
+CONFIG_DM_ETH=y
+CONFIG_FEC_MXC_SHARE_MDIO=y
+CONFIG_FEC_MXC_MDIO_BASE=0x5B040000
+CONFIG_FEC_MXC=y
+CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX8=y
+CONFIG_POWER_DOMAIN=y
+CONFIG_IMX8_POWER_DOMAIN=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+CONFIG_FSL_LPUART=y
+CONFIG_DM_THERMAL=y
+# CONFIG_EFI_LOADER is not set
include/configs/colibri-imx8qxp.h new file +27 -0
new file mode 100644
index 0000000000..33cbcb44a9
@@ -0,0 +1,214 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ */
+
+#ifndef __COLIBRI_IMX8QXP_H
+#define __COLIBRI_IMX8QXP_H
+
+#include <asm/arch/imx-regs.h>
+#include <linux/sizes.h>
+
+#define CONFIG_REMAKE_ELF
+
+#define CONFIG_DISPLAY_BOARDINFO_LATE
+
+#undef CONFIG_CMD_EXPORTENV
+#undef CONFIG_CMD_IMPORTENV
+#undef CONFIG_CMD_IMLS
+
+#undef CONFIG_CMD_CRC32
+#undef CONFIG_BOOTM_NETBSD
+
+#define CONFIG_FSL_ESDHC
+#define CONFIG_FSL_USDHC
+#define CONFIG_SYS_FSL_ESDHC_ADDR      0
+#define USDHC1_BASE_ADDR               0x5B010000
+#define USDHC2_BASE_ADDR               0x5B020000

include/configs/colibri-imx8qxp.h line 37

Quoted 10 lines
include/configs/colibri-imx8qxp.h new file +10 -0
+#define CONFIG_SUPPORT_EMMC_BOOT       /* eMMC specific */
+
+#define CONFIG_ENV_OVERWRITE
+
+#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+
+#define FEC_QUIRK_ENET_MAC
+
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE          4096

4096 can be replaced with SZ_4K (from include/linux/sizes.h)

Quoted 158 lines
include/configs/colibri-imx8qxp.h new file +21 -0
+#define CONFIG_TFTP_TSIZE
+
+#define CONFIG_IPADDR                  192.168.10.2
+#define CONFIG_NETMASK                 255.255.255.0
+#define CONFIG_SERVERIP                        192.168.10.1
+
+#define MEM_LAYOUT_ENV_SETTINGS \
+       "fdt_addr_r=0x84000000\0" \
+       "kernel_addr_r=0x82000000\0" \
+       "ramdisk_addr_r=0x84100000\0"
+
+#ifdef CONFIG_AHAB_BOOT
+#define AHAB_ENV "sec_boot=yes\0"
+#else
+#define AHAB_ENV "sec_boot=no\0"
+#endif
+
+/* Boot M4 */
+#define M4_BOOT_ENV \
+       "m4_0_image=m4_0.bin\0" \
+       "loadm4image_0=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}

" \

include/configs/colibri-imx8qxp.h new file +2 -0
+               "${m4_0_image}\0" \
+       "m4boot_0=run loadm4image_0; dcache flush; bootaux

${loadaddr} 0\0" \

include/configs/colibri-imx8qxp.h new file +13 -0
+
+#define MFG_NAND_PARTITION ""
+
+#define BOOT_TARGET_DEVICES(func) \
+       func(MMC, mmc, 0) \
+       func(MMC, mmc, 1) \
+       func(DHCP, dhcp, na)
+#include <config_distro_bootcmd.h>
+#undef BOOTENV_RUN_NET_USB_START
+#define BOOTENV_RUN_NET_USB_START ""
+
+#define CONFIG_MFG_ENV_SETTINGS \
+       "mfgtool_args=setenv bootargs

console=${console},${baudrate} " \

include/configs/colibri-imx8qxp.h new file +2 -0
+               "rdinit=/linuxrc g_mass_storage.stall=0 " \
+               "g_mass_storage.removable=1

g_mass_storage.idVendor=0x066F " \

include/configs/colibri-imx8qxp.h new file +4 -0
+               "g_mass_storage.idProduct=0x37FF " \
+               "g_mass_storage.iSerialNumber=\"\" "\
+               MFG_NAND_PARTITION \
+               "video=imxdpufb5:off video=imxdpufb6:off

video=imxdpufb7:off " \

include/configs/colibri-imx8qxp.h new file +5 -0
+               "clk_ignore_unused "\
+               "\0" \
+       "initrd_addr=0x83800000\0" \
+       "initrd_high=0xffffffff\0" \
+       "bootcmd_mfg=run mfgtool_args;booti ${loadaddr}

${initrd_addr} " \

include/configs/colibri-imx8qxp.h new file +11 -0
+               "${fdt_addr};\0" \
+
+/* Initial environment variables */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+       AHAB_ENV \
+       BOOTENV \
+       CONFIG_MFG_ENV_SETTINGS \
+       M4_BOOT_ENV \
+       MEM_LAYOUT_ENV_SETTINGS \
+       "boot_fdt=try\0" \
+       "bootscript=echo Running bootscript from mmc ...; source\0"

\
+ "console=ttyLP3,115200
earlycon=lpuart32,0x5a090000,115200\0" \

include/configs/colibri-imx8qxp.h new file +8 -0
+       "fdt_addr=0x83000000\0"                 \
+       "fdt_file=fsl-imx8qxp-colibri-eval-v3.dtb\0" \
+       "fdt_high=0xffffffffffffffff\0"         \
+       "finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
+       "image=Image\0" \
+       "initrd_addr=0x83800000\0"              \
+       "initrd_high=0xffffffffffffffff\0" \
+       "loadbootscript=fatload mmc ${mmcdev}:${mmcpart}

${loadaddr} " \

include/configs/colibri-imx8qxp.h new file +2 -0
+               "${script};\0" \
+       "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}

${fdt_file}\0" \
+ "loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}
${image}\0" \

include/configs/colibri-imx8qxp.h new file +6 -0
+       "mmcargs=setenv bootargs console=${console},${baudrate} " \
+               "root=PARTUUID=${uuid} rootwait " \
+       "mmcautodetect=yes\0" \
+       "mmcboot=echo Booting from mmc ...; " \
+               "run finduuid; run mmcargs; " \
+               "if test ${boot_fdt} = yes || test ${boot_fdt} =

try; then " \

include/configs/colibri-imx8qxp.h new file +2 -0
+                       "if run loadfdt; then " \
+                               "booti ${loadaddr} - ${fdt_addr}; "

\

include/configs/colibri-imx8qxp.h new file +9 -0
+                       "else " \
+                               "echo WARN: Cannot load the DT; " \
+                       "fi; " \
+               "else " \
+                       "echo wait for boot; " \
+               "fi;\0" \
+       "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
+       "mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
+       "netargs=setenv bootargs console=${console} root=/dev/nfs

ip=dhcp " \
+ "nfsroot=${serverip}:${nfsroot},v3,tcp
video=imxdpufb5:off " \

include/configs/colibri-imx8qxp.h new file +10 -0
+               "video=imxdpufb6:off video=imxdpufb7:off\0" \
+       "netboot=echo Booting from net ...; " \
+               "run netargs; " \
+               "if test ${ip_dyn} = yes; then " \
+                       "setenv get_cmd dhcp; " \
+               "else " \
+                       "setenv get_cmd tftp; " \
+               "fi; " \
+               "${get_cmd} ${loadaddr} ${image}; " \
+               "if test ${boot_fdt} = yes || test ${boot_fdt} =

try; then " \
+ "if ${get_cmd} ${fdt_addr} ${fdt_file};
then " \
+ "booti ${loadaddr} - ${fdt_addr}; "
\

include/configs/colibri-imx8qxp.h new file +7 -0
+                       "else " \
+                               "echo WARN: Cannot load the DT; " \
+                       "fi; " \
+               "else " \
+                       "booti; " \
+               "fi;\0" \
+       "nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp

${fdt_addr} " \
+ "colibri-imx8qxp/${fdt_file}; booti ${loadaddr} - "
\

include/configs/colibri-imx8qxp.h new file +4 -0
+               "${fdt_addr}\0" \
+       "panel=NULL\0" \
+       "script=boot.scr\0" \
+       "video=imxdpufb5:off video=imxdpufb6:off

video=imxdpufb7:off\0"

include/configs/colibri-imx8qxp.h new file +25 -0
+
+#undef CONFIG_BOOTCOMMAND
+#define CONFIG_BOOTCOMMAND \
+          "mmc dev ${mmcdev}; if mmc rescan; then " \
+                  "if run loadbootscript; then " \
+                          "run bootscript; " \
+                  "else " \
+                          "if run loadimage; then " \
+                                  "run mmcboot; " \
+                          "else run netboot; " \
+                          "fi; " \
+                  "fi; " \
+          "else booti ${loadaddr} - ${fdt_addr}; fi"
+
+/* Link Definitions */
+#define CONFIG_LOADADDR                        0x80280000
+
+#define CONFIG_SYS_LOAD_ADDR           CONFIG_LOADADDR
+
+#define CONFIG_SYS_INIT_SP_ADDR                0x80200000
+
+#define CONFIG_SYS_MEMTEST_START       0x88000000
+#define CONFIG_SYS_MEMTEST_END         0x89000000
+
+/* Environment in eMMC, before config block at the end of 1st
Quoted 2 lines

"boot sector" */
+#define CONFIG_ENV_SIZE (8 * 1024)

(8 * 1024) can be replaced with SZ_8K (from include/linux/sizes.h)

Quoted 16 lines
include/configs/colibri-imx8qxp.h new file +2 -0
+#define CONFIG_ENV_OFFSET              (-CONFIG_ENV_SIZE + \
+                                        CONFIG_TDX_CFG_BLOCK_OFFSE

T)

include/configs/colibri-imx8qxp.h new file +7 -0
+#define CONFIG_SYS_MMC_ENV_DEV         0
+#define CONFIG_SYS_MMC_ENV_PART                1
+
+#define CONFIG_SYS_MMC_IMG_LOAD_PART   1
+
+/* On Colibri iMX8 USDHC1 is eMMC, USDHC2 is 4-bit SD */
+#define CONFIG_SYS_MMC_ENV_DEV         0                /* USDHC1

eMMC */

include/configs/colibri-imx8qxp.h new file +4 -0
+#define CONFIG_SYS_FSL_USDHC_NUM       2
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN          ((CONFIG_ENV_SIZE + (32 *

1024)) * 1024)

include/configs/colibri-imx8qxp.h line 194

Quoted 6 lines
include/configs/colibri-imx8qxp.h new file +6 -0
+
+#define CONFIG_SYS_SDRAM_BASE          0x80000000
+#define CONFIG_NR_DRAM_BANKS           3
+#define PHYS_SDRAM_1                   0x80000000
+#define PHYS_SDRAM_2                   0x880000000
+#define PHYS_SDRAM_1_SIZE              0x80000000      /* 2 GB */

0x80000000 can be replaced with SZ_2G (from include/linux/sizes.h)

include/configs/colibri-imx8qxp.h line 202

Quoted 8 lines
include/configs/colibri-imx8qxp.h new file +8 -0
+#define PHYS_SDRAM_2_SIZE              0x00000000      /* 0 GB */
+
+/* Serial */
+#define CONFIG_BAUDRATE                        115200
+
+/* Monitor Command Prompt */
+#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
+#define CONFIG_SYS_CBSIZE              2048

Same as above

Quoted 11 lines
include/configs/colibri-imx8qxp.h new file +4 -0
+#define CONFIG_SYS_MAXARGS             64
+#define CONFIG_SYS_BARGSIZE            CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_PBSIZE              (CONFIG_SYS_CBSIZE + \
+                                       sizeof(CONFIG_SYS_PROMPT) +

16)

include/configs/colibri-imx8qxp.h new file +6 -0
+
+/* Generic Timer Definitions */
+#define COUNTER_FREQUENCY              8000000 /* 8MHz */
+
+#define BOOTAUX_RESERVED_MEM_BASE 0x88000000
+#define BOOTAUX_RESERVED_MEM_SIZE 0x08000000 /* Reserve from
Quoted 1 line

second 128MB */

Same as above

Quoted 9 lines
include/configs/colibri-imx8qxp.h new file +2 -1
+
+#endif /* __COLIBRI_IMX8QXP_H */
--

2.20.1

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
https://lists.denx.de/listinfo/u-boot

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#13 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Stefano

Quoted 5 lines · Stefano Babic
Quoted 4 lines · Marcel Ziswiler

Hi Igor

Sorry, somehow I missed your comments below (;-p).

Quoted 7 lines
Quoted 3 lines

I will send out a v4 (yes there already was a v3 BTW) shortly including
the SPL resp. without SPL build fix.

Fine - the series (without 5/5) is already applied on u-boot-imx. Please
just send 5/5.

OK, strange. While I thought I just checked on git.denx.de I somehow missed that. Will just send 5/5 plus the SPL fix. Thanks!

Quoted 2 lines

Regards,
Stefano

Cheers

Marcel

#14 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Quoted 12 lines · Marcel Ziswiler

Hi Stefano

Quoted 9 lines · Stefano Babic
Quoted 7 lines · Marcel Ziswiler

Hi Igor

Sorry, somehow I missed your comments below (;-p).

I will send out a v4 (yes there already was a v3 BTW) shortly including
the SPL resp. without SPL build fix.

Quoted 6 lines
Quoted 3 lines

Fine - the series (without 5/5) is already applied on u-boot-imx. Please
just send 5/5.

OK, strange. While I thought I just checked on git.denx.de I somehow missed that.

It does not depend on you, but on my changed work-flow. Because Tom does not accept PR that does not pass Travis' build, I push currently first to my github account (where I rebase often and I fix myself small issues), and I push later to git.denx.de just after build passed. This avoids that my rebasess make people unhappy because history is broken, and tree on git.denx.de is always in a good state.

Quoted 2 lines

Will just send 5/5 plus the SPL fix. Thanks!

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#15 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

In reply to Marcel Ziswiler

Hi Marcel,

Quoted 16 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U-Boot supports either booting from the on-module eMMC or may be used for recovery purpose using the universal update utility (uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 7 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

---

I merged the series and build locally (fine), but Travis complains and stops with error:

+cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No such file or directory
+compilation terminated.

Can you take a look at it ?

Regards,
Stefano

Quoted 1,186 lines

Changes in v2:
- Changed imx-atf git clone command to include initial branch information as suggested by Igor.
- Sorted board file includes alphabetically as suggested by Igor.
- Got rid of SPL configuration in legacy header file as suggested by Igor and the whole use of SPL on i.MX 8X anyway neither works well nor makes any much sense at all.

 arch/arm/dts/Makefile                         |   4 +-
 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  | 112 ++++++
 arch/arm/dts/fsl-imx8qxp-colibri.dts          | 328 ++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   6 +
 board/toradex/colibri-imx8qxp/Kconfig         |  30 ++
 board/toradex/colibri-imx8qxp/MAINTAINERS     |   9 +
 board/toradex/colibri-imx8qxp/Makefile        |   7 +
 board/toradex/colibri-imx8qxp/README          |  66 ++++
 .../toradex/colibri-imx8qxp/colibri-imx8qxp.c | 212 +++++++++++
 board/toradex/colibri-imx8qxp/imximage.cfg    |  24 ++
 configs/colibri-imx8qxp_defconfig             |  53 +++
 include/configs/colibri-imx8qxp.h             | 214 ++++++++++++
 12 files changed, 1064 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri.dts
 create mode 100644 board/toradex/colibri-imx8qxp/Kconfig
 create mode 100644 board/toradex/colibri-imx8qxp/MAINTAINERS
 create mode 100644 board/toradex/colibri-imx8qxp/Makefile
 create mode 100644 board/toradex/colibri-imx8qxp/README
 create mode 100644 board/toradex/colibri-imx8qxp/colibri-imx8qxp.c
 create mode 100644 board/toradex/colibri-imx8qxp/imximage.cfg
 create mode 100644 configs/colibri-imx8qxp_defconfig
 create mode 100644 include/configs/colibri-imx8qxp.h
arch/arm/dts/Makefile +3 -1
index 13d1d67624..2a551d42a4 100644
@@ -559,7 +559,9 @@ dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
-dtb-$(CONFIG_ARCH_IMX8) += fsl-imx8qxp-mek.dtb
+dtb-$(CONFIG_ARCH_IMX8) += \
+	fsl-imx8qxp-colibri.dtb \
+	fsl-imx8qxp-mek.dtb
 
 dtb-$(CONFIG_ARCH_IMX8M) += fsl-imx8mq-evk.dtb
 
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi new file +112 -0
new file mode 100644
index 0000000000..f8686befdf
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+&mu {
+	u-boot,dm-spl;
+};
+
+&clk {
+	u-boot,dm-spl;
+};
+
+&iomuxc {
+	u-boot,dm-spl;
+};
+
+&pd_lsio {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio0 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio1 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio2 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio3 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio4 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio5 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio6 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio7 {
+	u-boot,dm-spl;
+};
+
+&pd_conn {
+	u-boot,dm-spl;
+};
+
+&pd_conn_sdch0 {
+	u-boot,dm-spl;
+};
+
+&pd_conn_sdch1 {
+	u-boot,dm-spl;
+};
+
+&pd_conn_sdch2 {
+	u-boot,dm-spl;
+};
+
+&gpio0 {
+	u-boot,dm-spl;
+};
+
+&gpio1 {
+	u-boot,dm-spl;
+};
+
+&gpio2 {
+	u-boot,dm-spl;
+};
+
+&gpio3 {
+	u-boot,dm-spl;
+};
+
+&gpio4 {
+	u-boot,dm-spl;
+};
+
+&gpio5 {
+	u-boot,dm-spl;
+};
+
+&gpio6 {
+	u-boot,dm-spl;
+};
+
+&gpio7 {
+	u-boot,dm-spl;
+};
+
+&lpuart3 {
+	u-boot,dm-spl;
+};
+
+&usdhc1 {
+	u-boot,dm-spl;
+};
+
+&usdhc2 {
+	u-boot,dm-spl;
+};
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +328 -0
new file mode 100644
index 0000000000..0c20edf2cf
@@ -0,0 +1,328 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+/dts-v1/;
+
+#include "fsl-imx8qxp.dtsi"
+#include "fsl-imx8qxp-colibri-u-boot.dtsi"
+
+/ {
+	model = "Toradex Colibri iMX8QXP";
+	compatible = "toradex,colibri-imx8qxp", "fsl,imx8qxp";
+
+	chosen {
+		bootargs = "console=ttyLP3,115200 earlycon=lpuart32,0x5a090000,115200";
+		stdout-path = &lpuart3;
+	};
+
+	reg_usbh_vbus: regulator-usbh-vbus {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_usbh1_reg>;
+		regulator-name = "usbh_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio4 3 GPIO_ACTIVE_LOW>;
+	};
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog0>, <&pinctrl_hog1>, <&pinctrl_hog2>;
+
+	colibri-imx8qxp {
+		pinctrl_lpuart0: lpuart0grp {
+			fsl,pins = <
+				SC_P_UART0_RX_ADMA_UART0_RX	0x06000020
+				SC_P_UART0_TX_ADMA_UART0_TX	0x06000020
+			>;
+		};
+
+		pinctrl_lpuart3: lpuart3grp {
+			fsl,pins = <
+				SC_P_FLEXCAN2_RX_ADMA_UART3_RX	0x06000020
+				SC_P_FLEXCAN2_TX_ADMA_UART3_TX	0x06000020
+			>;
+		};
+
+		pinctrl_lpuart3_ctrl: lpuart3ctrlgrp {
+			fsl,pins = <
+				SC_P_MIPI_DSI1_GPIO0_01_LSIO_GPIO2_IO00 0x00000020 /* DTR */
+				SC_P_SAI1_RXD_LSIO_GPIO0_IO29		0x00000020 /* CTS */
+				SC_P_SAI1_RXC_LSIO_GPIO0_IO30		0x00000020 /* RTS */
+				SC_P_CSI_RESET_LSIO_GPIO3_IO03		0x00000020 /* DSR */
+				SC_P_USDHC1_CD_B_LSIO_GPIO4_IO22	0x00000020 /* DCD */
+				SC_P_CSI_EN_LSIO_GPIO3_IO02		0x00000020 /* RI */
+			>;
+		};
+
+		pinctrl_fec1: fec1grp {
+			fsl,pins = <
+				SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB0_PAD	0x000014a0 /* Use pads in 3.3V mode */
+				SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB1_PAD	0x000014a0 /* Use pads in 3.3V mode */
+				SC_P_ENET0_MDC_CONN_ENET0_MDC			0x06000020
+				SC_P_ENET0_MDIO_CONN_ENET0_MDIO			0x06000020
+				SC_P_ENET0_RGMII_TX_CTL_CONN_ENET0_RGMII_TX_CTL	0x00000061
+				SC_P_ENET0_RGMII_TXC_CONN_ENET0_RCLK50M_OUT	0x06000061
+				SC_P_ENET0_RGMII_TXD0_CONN_ENET0_RGMII_TXD0	0x00000061
+				SC_P_ENET0_RGMII_TXD1_CONN_ENET0_RGMII_TXD1	0x00000061
+				SC_P_ENET0_RGMII_RX_CTL_CONN_ENET0_RGMII_RX_CTL	0x00000061
+				SC_P_ENET0_RGMII_RXD0_CONN_ENET0_RGMII_RXD0	0x00000061
+				SC_P_ENET0_RGMII_RXD1_CONN_ENET0_RGMII_RXD1	0x00000061
+				SC_P_ENET0_RGMII_RXD2_CONN_ENET0_RMII_RX_ER	0x00000061
+			>;
+		};
+
+		pinctrl_gpio_bl_on: gpio-bl-on {
+			fsl,pins = <
+				SC_P_QSPI0A_DATA3_LSIO_GPIO3_IO12	0x00000040
+			>;
+		};
+
+		pinctrl_hog0: hog0grp {
+			fsl,pins = <
+				SC_P_COMP_CTL_GPIO_1V8_3V3_GPIORHB_PAD	0x000514a0 /* Use pads in 3.3V mode */
+			>;
+		};
+
+		pinctrl_hog1: hog1grp {
+			fsl,pins = <
+				SC_P_QSPI0A_DATA1_LSIO_GPIO3_IO10	0x00000020 /*  45 */
+				SC_P_ENET0_RGMII_TXD3_LSIO_GPIO5_IO02	0x06000020 /*  65 */
+					SC_P_CSI_D07_CI_PI_D09		0x00000061
+				SC_P_QSPI0A_DATA2_LSIO_GPIO3_IO11	0x00000020 /*  69 */
+				SC_P_QSPI0A_DQS_LSIO_GPIO3_IO13		0x00000020 /*  73 */
+				SC_P_SAI0_TXC_LSIO_GPIO0_IO26		0x00000020 /*  79 */
+					SC_P_CSI_D02_CI_PI_D04		0x00000061
+				SC_P_ENET0_RGMII_RXC_LSIO_GPIO5_IO03	0x06000020 /*  85 */
+					SC_P_CSI_D06_CI_PI_D08		0x00000061
+				SC_P_QSPI0B_SCLK_LSIO_GPIO3_IO17	0x00000020 /*  95 */
+				SC_P_SAI0_RXD_LSIO_GPIO0_IO27		0x00000020 /*  97 */
+					SC_P_CSI_D03_CI_PI_D05		0x00000061
+				SC_P_QSPI0B_DATA0_LSIO_GPIO3_IO18	0x00000020 /*  99 */
+				SC_P_SAI0_TXFS_LSIO_GPIO0_IO28		0x00000020 /* 101 */
+					SC_P_CSI_D00_CI_PI_D02		0x00000061
+				SC_P_SAI0_TXD_LSIO_GPIO0_IO25		0x00000020 /* 103 */
+					SC_P_CSI_D01_CI_PI_D03		0x00000061
+				SC_P_QSPI0B_DATA1_LSIO_GPIO3_IO19	0x00000020 /* 105 */
+				SC_P_QSPI0B_DATA2_LSIO_GPIO3_IO20	0x00000020 /* 107 */
+				SC_P_USB_SS3_TC2_LSIO_GPIO4_IO05	0x00000020 /* 127 */
+				SC_P_USB_SS3_TC3_LSIO_GPIO4_IO06	0x00000020 /* 131 */
+				SC_P_USB_SS3_TC1_LSIO_GPIO4_IO04	0x00000020 /* 133 */
+				SC_P_CSI_PCLK_LSIO_GPIO3_IO00		0x00000020 /*  96 */
+				SC_P_QSPI0B_DATA3_LSIO_GPIO3_IO21	0x00000020 /*  98 */
+				SC_P_SAI1_RXFS_LSIO_GPIO0_IO31		0x00000020 /* 100 */
+				SC_P_QSPI0B_DQS_LSIO_GPIO3_IO22		0x00000020 /* 102 */
+				SC_P_QSPI0B_SS0_B_LSIO_GPIO3_IO23	0x00000020 /* 104 */
+				SC_P_QSPI0B_SS1_B_LSIO_GPIO3_IO24	0x00000020 /* 106 */
+			>;
+		};
+
+		pinctrl_hog2: hog2grp {
+			fsl,pins = <
+				SC_P_CSI_MCLK_LSIO_GPIO3_IO01		0x00000020 /*  75 */
+				SC_P_QSPI0A_SS0_B_LSIO_GPIO3_IO14	0x00000020 /*  77 */
+				SC_P_QSPI0A_SS1_B_LSIO_GPIO3_IO15	0x00000020 /*  89 */
+				SC_P_QSPI0A_SCLK_LSIO_GPIO3_IO16	0x00000020 /*  93 */
+			>;
+		};
+
+		/* Off Module I2C */
+		pinctrl_i2c1: i2c1grp {
+			fsl,pins = <
+				SC_P_MIPI_DSI0_GPIO0_00_ADMA_I2C1_SCL	0x06000021
+				SC_P_MIPI_DSI0_GPIO0_01_ADMA_I2C1_SDA	0x06000021
+			>;
+		};
+
+		/*INT*/
+		pinctrl_usb3503a: usb3503a-grp {
+			fsl,pins = <
+				SC_P_MIPI_CSI0_MCLK_OUT_LSIO_GPIO3_IO04 0x00000061
+			>;
+		};
+
+		pinctrl_usbc_det: usbc-det {
+			fsl,pins = <
+				SC_P_ENET0_REFCLK_125M_25M_LSIO_GPIO5_IO09	0x06000040
+			>;
+		};
+
+		pinctrl_usbh1_reg: usbh1-reg {
+			fsl,pins = <
+				SC_P_USB_SS3_TC0_LSIO_GPIO4_IO03	0x06000040
+			>;
+		};
+
+		pinctrl_usdhc1: usdhc1grp {
+			fsl,pins = <
+				SC_P_EMMC0_CLK_CONN_EMMC0_CLK		0x06000041
+				SC_P_EMMC0_CMD_CONN_EMMC0_CMD		0x00000021
+				SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0	0x00000021
+				SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1	0x00000021
+				SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2	0x00000021
+				SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3	0x00000021
+				SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4	0x00000021
+				SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5	0x00000021
+				SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6	0x00000021
+				SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7	0x00000021
+				SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE	0x00000041
+				SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B	0x00000021
+			>;
+		};
+
+		pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
+			fsl,pins = <
+				SC_P_EMMC0_CLK_CONN_EMMC0_CLK		0x06000041
+				SC_P_EMMC0_CMD_CONN_EMMC0_CMD		0x00000021
+				SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0	0x00000021
+				SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1	0x00000021
+				SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2	0x00000021
+				SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3	0x00000021
+				SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4	0x00000021
+				SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5	0x00000021
+				SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6	0x00000021
+				SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7	0x00000021
+				SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE	0x00000041
+				SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B	0x00000021
+			>;
+		};
+
+		pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
+			fsl,pins = <
+				SC_P_EMMC0_CLK_CONN_EMMC0_CLK		0x06000041
+				SC_P_EMMC0_CMD_CONN_EMMC0_CMD		0x00000021
+				SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0	0x00000021
+				SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1	0x00000021
+				SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2	0x00000021
+				SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3	0x00000021
+				SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4	0x00000021
+				SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5	0x00000021
+				SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6	0x00000021
+				SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7	0x00000021
+				SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE	0x00000041
+				SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B	0x00000021
+			>;
+		};
+
+		pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+			fsl,pins = <
+				SC_P_QSPI0A_DATA0_LSIO_GPIO3_IO09	0x06000021
+			>;
+		};
+
+		pinctrl_usdhc2: usdhc2grp {
+			fsl,pins = <
+				SC_P_USDHC1_CLK_CONN_USDHC1_CLK		0x06000041
+				SC_P_USDHC1_CMD_CONN_USDHC1_CMD		0x00000021
+				SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0	0x00000021
+				SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1	0x00000021
+				SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2	0x00000021
+				SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3	0x00000021
+				SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT	0x00000021
+			>;
+		};
+
+		pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
+			fsl,pins = <
+				SC_P_USDHC1_CLK_CONN_USDHC1_CLK		0x06000041
+				SC_P_USDHC1_CMD_CONN_USDHC1_CMD		0x00000021
+				SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0	0x00000021
+				SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1	0x00000021
+				SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2	0x00000021
+				SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3	0x00000021
+				SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT	0x00000021
+			>;
+		};
+
+		pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
+			fsl,pins = <
+				SC_P_USDHC1_CLK_CONN_USDHC1_CLK		0x06000041
+				SC_P_USDHC1_CMD_CONN_USDHC1_CMD		0x00000021
+				SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0	0x00000021
+				SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1	0x00000021
+				SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2	0x00000021
+				SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3	0x00000021
+				SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT	0x00000021
+			>;
+		};
+	};
+};
+
+&lpuart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lpuart0>;
+	status = "okay";
+};
+
+&lpuart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lpuart3>, <&pinctrl_lpuart3_ctrl>;
+	status = "okay";
+};
+
+&gpio0 {
+	status = "okay";
+};
+
+&gpio1 {
+	status = "okay";
+};
+
+&gpio3 {
+	status = "okay";
+};
+
+&gpio4 {
+	status = "okay";
+};
+
+&fec1 {
+	phy-handle = <&ethphy0>;
+	phy-mode = "rmii";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec1>;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy at 2 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			max-speed = <100>;
+			reg = <2>;
+		};
+	};
+};
+
+&i2c1 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+};
+
+&usdhc1 {
+	bus-width = <8>;
+	non-removable;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+	status = "okay";
+};
+
+&usdhc2 {
+	bus-width = <4>;
+	cd-gpios = <&gpio3 9 GPIO_ACTIVE_LOW>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+	status = "okay";
+};
arch/arm/mach-imx/imx8/Kconfig +6 -0
index f76a139684..feea07f135 100644
@@ -22,6 +22,11 @@ choice
 	prompt "i.MX8 board select"
 	optional
 
+config TARGET_COLIBRI_IMX8QXP
+	bool "Support Colibri iMX8QXP module"
+	select BOARD_LATE_INIT
+	select IMX8QXP
+
 config TARGET_IMX8QXP_MEK
 	bool "Support i.MX8QXP MEK board"
 	select BOARD_LATE_INIT
@@ -30,5 +35,6 @@ config TARGET_IMX8QXP_MEK
 endchoice
 
 source "board/freescale/imx8qxp_mek/Kconfig"
+source "board/toradex/colibri-imx8qxp/Kconfig"
 
 endif
board/toradex/colibri-imx8qxp/Kconfig new file +30 -0
new file mode 100644
index 0000000000..340fe72816
@@ -0,0 +1,30 @@
+if TARGET_COLIBRI_IMX8QXP
+
+config SYS_BOARD
+	default "colibri-imx8qxp"
+
+config SYS_VENDOR
+	default "toradex"
+
+config SYS_CONFIG_NAME
+	default "colibri-imx8qxp"
+
+config TDX_CFG_BLOCK
+	default y
+
+config TDX_HAVE_MMC
+	default y
+
+config TDX_CFG_BLOCK_DEV
+	default "0"
+
+config TDX_CFG_BLOCK_PART
+	default "1"
+
+# Toradex config block in eMMC, at the end of 1st "boot sector"
+config TDX_CFG_BLOCK_OFFSET
+	default "-512"
+
+source "board/toradex/common/Kconfig"
+
+endif
board/toradex/colibri-imx8qxp/MAINTAINERS new file +9 -0
new file mode 100644
index 0000000000..39a9eb79b7
@@ -0,0 +1,9 @@
+Colibri iMX8QXP
+M:	Marcel Ziswiler <[email protected]>
+W:	http://developer.toradex.com/software/linux/linux-software
+S:	Maintained
+F:	arch/arm/dts/fsl-imx8qxp-colibri.dts
+F:	arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
+F:	board/toradex/colibri-imx8qxp/
+F:	configs/colibri-imx8qxp_defconfig
+F:	include/configs/colibri-imx8qxp.h
board/toradex/colibri-imx8qxp/Makefile new file +7 -0
new file mode 100644
index 0000000000..f6342e1dca
@@ -0,0 +1,7 @@
+#
+# Copyright 2019 Toradex
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += colibri-imx8qxp.o
board/toradex/colibri-imx8qxp/README new file +66 -0
new file mode 100644
index 0000000000..e68d183fe6
@@ -0,0 +1,66 @@
+U-Boot for the Toradex Colibri iMX8QXP V1.0B module
+
+Quick Start
+===========
+
+- Build the ARM trusted firmware binary
+- Get scfw_tcm.bin and ahab-container.img
+- Build U-Boot
+- Load U-Boot binary using uuu
+- Flash U-Boot binary into the eMMC
+- Boot
+
+Get and Build the ARM Trusted Firmware
+======================================
+
+$ git clone -b imx_4.14.78_1.0.0_ga https://source.codeaurora.org/external/imx/imx-atf
+$ cd imx-atf/
+$ make PLAT=imx8qxp bl31
+
+Get scfw_tcm.bin and ahab-container.img
+=======================================
+
+$ wget https://github.com/toradex/meta-fsl-bsp-release/blob/toradex-sumo-4.14.78-1.0.0_ga-bringup/imx/meta-bsp/recipes-bsp/imx-sc-firmware/files/mx8qx-colibri-scfw-tcm.bin?raw=true
+$ mv mx8qx-colibri-scfw-tcm.bin\?raw\=true mx8qx-colibri-scfw-tcm.bin
+$ wget https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-7.6.bin
+$ chmod +x firmware-imx-7.6.bin
+$ ./firmware-imx-7.6.bin
+
+Copy the following binaries to the U-Boot folder:
+
+$ cp imx-atf/build/imx8qxp/release/bl31.bin .
+$ cp u-boot/u-boot.bin .
+
+Copy the following firmware to the U-Boot folder:
+
+$ cp firmware-imx-7.6/firmware/seco/ahab-container.img .
+
+Build U-Boot
+============
+
+$ make colibri-imx8qxp_defconfig
+$ make u-boot-dtb.imx
+
+Load the U-Boot Binary Using UUU
+================================
+
+Get the latest version of the universal update utility (uuu) aka mfgtools 3.0:
+
+https://community.nxp.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2FNXPmicro%2Fmfgtools%2Freleases
+
+Put the module into USB recovery aka serial downloader mode, connect USB device
+to your host and execute uuu:
+
+sudo ./uuu u-boot/u-boot-dtb.imx
+
+Flash the U-Boot Binary into the eMMC
+=====================================
+
+Burn the u-boot-dtb.imx binary to the primary eMMC hardware boot area partition:
+
+load mmc 1:1 $loadaddr u-boot-dtb.imx
+setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt ${blkcnt} / 0x200
+mmc dev 0 1
+mmc write ${loadaddr} 0x0 ${blkcnt}
+
+Boot
board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +212 -0
new file mode 100644
index 0000000000..9aa0f096d2
@@ -0,0 +1,212 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019 Toradex
+ */
+
+#include <common.h>
+
+#include <asm/arch/clock.h>
+#include <asm/arch/imx8-pins.h>
+#include <asm/arch/iomux.h>
+#include <asm/arch/sci/sci.h>
+#include <asm/arch/sys_proto.h>
+#include <asm/gpio.h>
+#include <asm/io.h>
+#include <asm/mach-imx/video.h>
+#include <dm.h>
+#include <environment.h>
+#include <errno.h>
+#include <fdt_support.h>
+#include <fsl_esdhc.h>
+#include <fsl_ifc.h>
+#include <i2c.h>
+#include <linux/libfdt.h>
+#include <malloc.h>
+#include <netdev.h>
+#include <power-domain.h>
+#include <usb.h>
+
+#include "../common/tdx-cfg-block.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define GPIO_PAD_CTRL	((SC_PAD_CONFIG_NORMAL << PADRING_CONFIG_SHIFT) | \
+			 (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT) | \
+			 (SC_PAD_28FDSOI_DSE_DV_HIGH << PADRING_DSE_SHIFT) | \
+			 (SC_PAD_28FDSOI_PS_PU << PADRING_PULL_SHIFT))
+
+#define UART_PAD_CTRL	((SC_PAD_CONFIG_OUT_IN << PADRING_CONFIG_SHIFT) | \
+			 (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT) | \
+			 (SC_PAD_28FDSOI_DSE_DV_HIGH << PADRING_DSE_SHIFT) | \
+			 (SC_PAD_28FDSOI_PS_PU << PADRING_PULL_SHIFT))
+
+static iomux_cfg_t uart3_pads[] = {
+	SC_P_FLEXCAN2_RX | MUX_MODE_ALT(2) | MUX_PAD_CTRL(UART_PAD_CTRL),
+	SC_P_FLEXCAN2_TX | MUX_MODE_ALT(2) | MUX_PAD_CTRL(UART_PAD_CTRL),
+	/* Transceiver FORCEOFF# signal, mux to use pullup */
+	SC_P_QSPI0B_DQS | MUX_MODE_ALT(4) | MUX_PAD_CTRL(UART_PAD_CTRL),
+};
+
+static void setup_iomux_uart(void)
+{
+	imx8_iomux_setup_multiple_pads(uart3_pads, ARRAY_SIZE(uart3_pads));
+}
+
+int board_early_init_f(void)
+{
+	sc_pm_clock_rate_t rate;
+	sc_err_t err = 0;
+
+	/*
+	 * This works around that having only UART3 up the baudrate is 1.2M
+	 * instead of 115.2k. Set UART0 clock root to 80 MHz
+	 */
+	rate = 80000000;
+	err = sc_pm_set_clock_rate(-1, SC_R_UART_0, SC_PM_CLK_PER, &rate);
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	/* Power up UART3 */
+	err = sc_pm_set_resource_power_mode(-1, SC_R_UART_3, SC_PM_PW_MODE_ON);
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	/* Set UART3 clock root to 80 MHz */
+	rate = 80000000;
+	err = sc_pm_set_clock_rate(-1, SC_R_UART_3, SC_PM_CLK_PER, &rate);
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	/* Enable UART3 clock root */
+	err = sc_pm_clock_enable(-1, SC_R_UART_3, SC_PM_CLK_PER, true, false);
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	setup_iomux_uart();
+
+	return 0;
+}
+
+#undef CONFIG_MXC_GPIO /* TODO */
+#ifdef CONFIG_MXC_GPIO
+#define IOEXP_RESET IMX_GPIO_NR(1, 1)
+
+static iomux_cfg_t board_gpios[] = {
+	SC_P_SPI2_SDO | MUX_MODE_ALT(4) | MUX_PAD_CTRL(GPIO_PAD_CTRL),
+	SC_P_ENET0_REFCLK_125M_25M | MUX_MODE_ALT(4) | \
+		MUX_PAD_CTRL(GPIO_PAD_CTRL),
+};
+
+static void board_gpio_init(void)
+{
+	struct gpio_desc desc;
+	int ret;
+
+	ret = dm_gpio_lookup_name("gpio at 1a_3", &desc);
+	if (ret)
+		return;
+
+	ret = dm_gpio_request(&desc, "bb_per_rst_b");
+	if (ret)
+		return;
+
+	dm_gpio_set_dir_flags(&desc, GPIOD_IS_OUT);
+	dm_gpio_set_value(&desc, 0);
+	udelay(50);
+	dm_gpio_set_value(&desc, 1);
+
+	imx8_iomux_setup_multiple_pads(board_gpios, ARRAY_SIZE(board_gpios));
+
+	/* enable i2c port expander assert reset line */
+	gpio_request(IOEXP_RESET, "ioexp_rst");
+	gpio_direction_output(IOEXP_RESET, 1);
+}
+#else
+static inline void board_gpio_init(void) {}
+#endif
+
+#if IS_ENABLED(CONFIG_FEC_MXC)
+#include <miiphy.h>
+
+int board_phy_config(struct phy_device *phydev)
+{
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
+
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
+
+	if (phydev->drv->config)
+		phydev->drv->config(phydev);
+
+	return 0;
+}
+#endif
+
+void build_info(void)
+{
+	u32 sc_build = 0, sc_commit = 0;
+
+	/* Get SCFW build and commit id */
+	sc_misc_build_info(-1, &sc_build, &sc_commit);
+	if (!sc_build) {
+		printf("SCFW does not support build info\n");
+		sc_commit = 0; /* Display 0 if build info not supported */
+	}
+	printf("Build: SCFW %x\n", sc_commit);
+}
+
+int checkboard(void)
+{
+	puts("Model: Toradex Colibri iMX8X\n");
+
+	build_info();
+	print_bootinfo();
+
+	return 0;
+}
+
+int board_init(void)
+{
+	board_gpio_init();
+
+	return 0;
+}
+
+void detail_board_ddr_info(void)
+{
+	puts("\nDDR    ");
+}
+
+/*
+ * Board specific reset that is system reset.
+ */
+void reset_cpu(ulong addr)
+{
+	/* TODO */
+}
+
+#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
+int ft_board_setup(void *blob, bd_t *bd)
+{
+	return ft_common_board_setup(blob, bd);
+}
+#endif
+
+int board_mmc_get_env_dev(int devno)
+{
+	return devno;
+}
+
+int board_late_init(void)
+{
+#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+/* TODO move to common */
+	env_set("board_name", "Colibri iMX8QXP");
+	env_set("board_rev", "v1.0");
+#endif
+
+	return 0;
+}
board/toradex/colibri-imx8qxp/imximage.cfg new file +24 -0
new file mode 100644
index 0000000000..ce9e66c64d
@@ -0,0 +1,24 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ *
+ * Refer doc/README.imx8image for more details about how-to configure
+ * and create imx8image boot image
+ */
+
+#define __ASSEMBLY__
+
+/* Boot from SD, sector size 0x400 */
+BOOT_FROM EMMC_FASTBOOT 0x400
+/* SoC type IMX8QX */
+SOC_TYPE IMX8QX
+/* Append seco container image */
+APPEND ahab-container.img
+/* Create the 2nd container */
+CONTAINER
+/* Add scfw image with exec attribute */
+IMAGE SCU mx8qx-colibri-scfw-tcm.bin
+/* Add ATF image with exec attribute */
+IMAGE A35 bl31.bin 0x80000000
+/* Add U-Boot image with load attribute */
+DATA A35 u-boot-dtb.bin 0x80020000
configs/colibri-imx8qxp_defconfig new file +53 -0
new file mode 100644
index 0000000000..d697546ed7
@@ -0,0 +1,53 @@
+CONFIG_ARM=y
+CONFIG_ARCH_IMX8=y
+CONFIG_SYS_TEXT_BASE=0x80020000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_TARGET_COLIBRI_IMX8QXP=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=3
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri-imx8qxp/imximage.cfg"
+CONFIG_LOG=y
+CONFIG_VERSION_VARIABLE=y
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_CMD_CPU=y
+# CONFIG_CMD_IMPORTENV is not set
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_DM=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_UUID=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-colibri"
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_CLK_IMX8=y
+CONFIG_CPU=y
+CONFIG_DM_GPIO=y
+CONFIG_MXC_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_IMX_LPI2C=y
+CONFIG_MISC=y
+CONFIG_DM_MMC=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_ADDR_ENABLE=y
+CONFIG_PHY_MICREL=y
+CONFIG_DM_ETH=y
+CONFIG_FEC_MXC_SHARE_MDIO=y
+CONFIG_FEC_MXC_MDIO_BASE=0x5B040000
+CONFIG_FEC_MXC=y
+CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX8=y
+CONFIG_POWER_DOMAIN=y
+CONFIG_IMX8_POWER_DOMAIN=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+CONFIG_FSL_LPUART=y
+CONFIG_DM_THERMAL=y
+# CONFIG_EFI_LOADER is not set
include/configs/colibri-imx8qxp.h new file +214 -0
new file mode 100644
index 0000000000..33cbcb44a9
@@ -0,0 +1,214 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ */
+
+#ifndef __COLIBRI_IMX8QXP_H
+#define __COLIBRI_IMX8QXP_H
+
+#include <asm/arch/imx-regs.h>
+#include <linux/sizes.h>
+
+#define CONFIG_REMAKE_ELF
+
+#define CONFIG_DISPLAY_BOARDINFO_LATE
+
+#undef CONFIG_CMD_EXPORTENV
+#undef CONFIG_CMD_IMPORTENV
+#undef CONFIG_CMD_IMLS
+
+#undef CONFIG_CMD_CRC32
+#undef CONFIG_BOOTM_NETBSD
+
+#define CONFIG_FSL_ESDHC
+#define CONFIG_FSL_USDHC
+#define CONFIG_SYS_FSL_ESDHC_ADDR	0
+#define USDHC1_BASE_ADDR		0x5B010000
+#define USDHC2_BASE_ADDR		0x5B020000
+#define CONFIG_SUPPORT_EMMC_BOOT	/* eMMC specific */
+
+#define CONFIG_ENV_OVERWRITE
+
+#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+
+#define FEC_QUIRK_ENET_MAC
+
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE		4096
+#define CONFIG_TFTP_TSIZE
+
+#define CONFIG_IPADDR			192.168.10.2
+#define CONFIG_NETMASK			255.255.255.0
+#define CONFIG_SERVERIP			192.168.10.1
+
+#define MEM_LAYOUT_ENV_SETTINGS \
+	"fdt_addr_r=0x84000000\0" \
+	"kernel_addr_r=0x82000000\0" \
+	"ramdisk_addr_r=0x84100000\0"
+
+#ifdef CONFIG_AHAB_BOOT
+#define AHAB_ENV "sec_boot=yes\0"
+#else
+#define AHAB_ENV "sec_boot=no\0"
+#endif
+
+/* Boot M4 */
+#define M4_BOOT_ENV \
+	"m4_0_image=m4_0.bin\0" \
+	"loadm4image_0=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} " \
+		"${m4_0_image}\0" \
+	"m4boot_0=run loadm4image_0; dcache flush; bootaux ${loadaddr} 0\0" \
+
+#define MFG_NAND_PARTITION ""
+
+#define BOOT_TARGET_DEVICES(func) \
+	func(MMC, mmc, 0) \
+	func(MMC, mmc, 1) \
+	func(DHCP, dhcp, na)
+#include <config_distro_bootcmd.h>
+#undef BOOTENV_RUN_NET_USB_START
+#define BOOTENV_RUN_NET_USB_START ""
+
+#define CONFIG_MFG_ENV_SETTINGS \
+	"mfgtool_args=setenv bootargs console=${console},${baudrate} " \
+		"rdinit=/linuxrc g_mass_storage.stall=0 " \
+		"g_mass_storage.removable=1 g_mass_storage.idVendor=0x066F " \
+		"g_mass_storage.idProduct=0x37FF " \
+		"g_mass_storage.iSerialNumber=\"\" "\
+		MFG_NAND_PARTITION \
+		"video=imxdpufb5:off video=imxdpufb6:off video=imxdpufb7:off " \
+		"clk_ignore_unused "\
+		"\0" \
+	"initrd_addr=0x83800000\0" \
+	"initrd_high=0xffffffff\0" \
+	"bootcmd_mfg=run mfgtool_args;booti ${loadaddr} ${initrd_addr} " \
+		"${fdt_addr};\0" \
+
+/* Initial environment variables */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	AHAB_ENV \
+	BOOTENV \
+	CONFIG_MFG_ENV_SETTINGS \
+	M4_BOOT_ENV \
+	MEM_LAYOUT_ENV_SETTINGS \
+	"boot_fdt=try\0" \
+	"bootscript=echo Running bootscript from mmc ...; source\0" \
+	"console=ttyLP3,115200 earlycon=lpuart32,0x5a090000,115200\0" \
+	"fdt_addr=0x83000000\0"			\
+	"fdt_file=fsl-imx8qxp-colibri-eval-v3.dtb\0" \
+	"fdt_high=0xffffffffffffffff\0"		\
+	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
+	"image=Image\0" \
+	"initrd_addr=0x83800000\0"		\
+	"initrd_high=0xffffffffffffffff\0" \
+	"loadbootscript=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} " \
+		"${script};\0" \
+	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
+	"mmcargs=setenv bootargs console=${console},${baudrate} " \
+		"root=PARTUUID=${uuid} rootwait " \
+	"mmcautodetect=yes\0" \
+	"mmcboot=echo Booting from mmc ...; " \
+		"run finduuid; run mmcargs; " \
+		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
+			"if run loadfdt; then " \
+				"booti ${loadaddr} - ${fdt_addr}; " \
+			"else " \
+				"echo WARN: Cannot load the DT; " \
+			"fi; " \
+		"else " \
+			"echo wait for boot; " \
+		"fi;\0" \
+	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
+	"mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
+	"netargs=setenv bootargs console=${console} root=/dev/nfs ip=dhcp " \
+		"nfsroot=${serverip}:${nfsroot},v3,tcp video=imxdpufb5:off " \
+		"video=imxdpufb6:off video=imxdpufb7:off\0" \
+	"netboot=echo Booting from net ...; " \
+		"run netargs; " \
+		"if test ${ip_dyn} = yes; then " \
+			"setenv get_cmd dhcp; " \
+		"else " \
+			"setenv get_cmd tftp; " \
+		"fi; " \
+		"${get_cmd} ${loadaddr} ${image}; " \
+		"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
+			"if ${get_cmd} ${fdt_addr} ${fdt_file}; then " \
+				"booti ${loadaddr} - ${fdt_addr}; " \
+			"else " \
+				"echo WARN: Cannot load the DT; " \
+			"fi; " \
+		"else " \
+			"booti; " \
+		"fi;\0" \
+	"nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp ${fdt_addr} " \
+		"colibri-imx8qxp/${fdt_file}; booti ${loadaddr} - " \
+		"${fdt_addr}\0" \
+	"panel=NULL\0" \
+	"script=boot.scr\0" \
+	"video=imxdpufb5:off video=imxdpufb6:off video=imxdpufb7:off\0"
+
+#undef CONFIG_BOOTCOMMAND
+#define CONFIG_BOOTCOMMAND \
+	   "mmc dev ${mmcdev}; if mmc rescan; then " \
+		   "if run loadbootscript; then " \
+			   "run bootscript; " \
+		   "else " \
+			   "if run loadimage; then " \
+				   "run mmcboot; " \
+			   "else run netboot; " \
+			   "fi; " \
+		   "fi; " \
+	   "else booti ${loadaddr} - ${fdt_addr}; fi"
+
+/* Link Definitions */
+#define CONFIG_LOADADDR			0x80280000
+
+#define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
+
+#define CONFIG_SYS_INIT_SP_ADDR		0x80200000
+
+#define CONFIG_SYS_MEMTEST_START	0x88000000
+#define CONFIG_SYS_MEMTEST_END		0x89000000
+
+/* Environment in eMMC, before config block at the end of 1st "boot sector" */
+#define CONFIG_ENV_SIZE			(8 * 1024)
+#define CONFIG_ENV_OFFSET		(-CONFIG_ENV_SIZE + \
+					 CONFIG_TDX_CFG_BLOCK_OFFSET)
+#define CONFIG_SYS_MMC_ENV_DEV		0
+#define CONFIG_SYS_MMC_ENV_PART		1
+
+#define CONFIG_SYS_MMC_IMG_LOAD_PART	1
+
+/* On Colibri iMX8 USDHC1 is eMMC, USDHC2 is 4-bit SD */
+#define CONFIG_SYS_MMC_ENV_DEV		0		 /* USDHC1 eMMC */
+#define CONFIG_SYS_FSL_USDHC_NUM	2
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		((CONFIG_ENV_SIZE + (32 * 1024)) * 1024)
+
+#define CONFIG_SYS_SDRAM_BASE		0x80000000
+#define CONFIG_NR_DRAM_BANKS		3
+#define PHYS_SDRAM_1			0x80000000
+#define PHYS_SDRAM_2			0x880000000
+#define PHYS_SDRAM_1_SIZE		0x80000000	/* 2 GB */
+#define PHYS_SDRAM_2_SIZE		0x00000000	/* 0 GB */
+
+/* Serial */
+#define CONFIG_BAUDRATE			115200
+
+/* Monitor Command Prompt */
+#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "
+#define CONFIG_SYS_CBSIZE		2048
+#define CONFIG_SYS_MAXARGS		64
+#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
+					sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* Generic Timer Definitions */
+#define COUNTER_FREQUENCY		8000000	/* 8MHz */
+
+#define BOOTAUX_RESERVED_MEM_BASE 0x88000000
+#define BOOTAUX_RESERVED_MEM_SIZE 0x08000000 /* Reserve from second 128MB */
+
+#endif /* __COLIBRI_IMX8QXP_H */
Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#16 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Stefano

Quoted 36 lines · Stefano Babic

Hi Marcel,

Quoted 20 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB
IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which
are factory fused to properly boot from their on-module eMMC. U- Boot
supports either booting from the on-module eMMC or may be used for recovery purpose using the universal update utility (uuu) aka mfgtools
3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 8 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of
yet.

---

I merged the series and build locally (fine), but Travis complains and
stops with error:

Quoted 5 lines

+cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No such file or directory
+compilation terminated.

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for i.MX8") takes SPL for granted while my patchset currently avoids it.

BTW: I still don't believe SPL makes much sense on i.MX 8X given all the other proprietary parts involved in booting. Plus currently SPL actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

Quoted 2 lines

Regards,
Stefano

Cheers

Marcel

Quoted 1,361 lines
Quoted 1,361 lines

Changes in v2:
- Changed imx-atf git clone command to include initial branch information as suggested by Igor.
- Sorted board file includes alphabetically as suggested by Igor.
- Got rid of SPL configuration in legacy header file as suggested by
Igor and the whole use of SPL on i.MX 8X anyway neither works
well
nor makes any much sense at all.

 arch/arm/dts/Makefile                         |   4 +-
 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi  | 112 ++++++
 arch/arm/dts/fsl-imx8qxp-colibri.dts          | 328
++++++++++++++++++
 arch/arm/mach-imx/imx8/Kconfig                |   6 +
 board/toradex/colibri-imx8qxp/Kconfig         |  30 ++
 board/toradex/colibri-imx8qxp/MAINTAINERS     |   9 +
 board/toradex/colibri-imx8qxp/Makefile        |   7 +
 board/toradex/colibri-imx8qxp/README          |  66 ++++
 .../toradex/colibri-imx8qxp/colibri-imx8qxp.c | 212 +++++++++++
 board/toradex/colibri-imx8qxp/imximage.cfg    |  24 ++
 configs/colibri-imx8qxp_defconfig             |  53 +++
 include/configs/colibri-imx8qxp.h             | 214 ++++++++++++
 12 files changed, 1064 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
 create mode 100644 arch/arm/dts/fsl-imx8qxp-colibri.dts
 create mode 100644 board/toradex/colibri-imx8qxp/Kconfig
 create mode 100644 board/toradex/colibri-imx8qxp/MAINTAINERS
 create mode 100644 board/toradex/colibri-imx8qxp/Makefile
 create mode 100644 board/toradex/colibri-imx8qxp/README
 create mode 100644 board/toradex/colibri-imx8qxp/colibri-imx8qxp.c
 create mode 100644 board/toradex/colibri-imx8qxp/imximage.cfg
 create mode 100644 configs/colibri-imx8qxp_defconfig
 create mode 100644 include/configs/colibri-imx8qxp.h
arch/arm/dts/Makefile +3 -1
index 13d1d67624..2a551d42a4 100644
@@ -559,7 +559,9 @@ dtb-$(CONFIG_MX7) += imx7d-sdb.dtb \
 
 dtb-$(CONFIG_ARCH_MX7ULP) += imx7ulp-evk.dtb
 
-dtb-$(CONFIG_ARCH_IMX8) += fsl-imx8qxp-mek.dtb
+dtb-$(CONFIG_ARCH_IMX8) += \
+	fsl-imx8qxp-colibri.dtb \
+	fsl-imx8qxp-mek.dtb
 
 dtb-$(CONFIG_ARCH_IMX8M) += fsl-imx8mq-evk.dtb
 
arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi new file +112 -0
new file mode 100644
index 0000000000..f8686befdf
@@ -0,0 +1,112 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+&mu {
+	u-boot,dm-spl;
+};
+
+&clk {
+	u-boot,dm-spl;
+};
+
+&iomuxc {
+	u-boot,dm-spl;
+};
+
+&pd_lsio {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio0 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio1 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio2 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio3 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio4 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio5 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio6 {
+	u-boot,dm-spl;
+};
+
+&pd_lsio_gpio7 {
+	u-boot,dm-spl;
+};
+
+&pd_conn {
+	u-boot,dm-spl;
+};
+
+&pd_conn_sdch0 {
+	u-boot,dm-spl;
+};
+
+&pd_conn_sdch1 {
+	u-boot,dm-spl;
+};
+
+&pd_conn_sdch2 {
+	u-boot,dm-spl;
+};
+
+&gpio0 {
+	u-boot,dm-spl;
+};
+
+&gpio1 {
+	u-boot,dm-spl;
+};
+
+&gpio2 {
+	u-boot,dm-spl;
+};
+
+&gpio3 {
+	u-boot,dm-spl;
+};
+
+&gpio4 {
+	u-boot,dm-spl;
+};
+
+&gpio5 {
+	u-boot,dm-spl;
+};
+
+&gpio6 {
+	u-boot,dm-spl;
+};
+
+&gpio7 {
+	u-boot,dm-spl;
+};
+
+&lpuart3 {
+	u-boot,dm-spl;
+};
+
+&usdhc1 {
+	u-boot,dm-spl;
+};
+
+&usdhc2 {
+	u-boot,dm-spl;
+};
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +16 -0
new file mode 100644
index 0000000000..0c20edf2cf
@@ -0,0 +1,328 @@
+// SPDX-License-Identifier: GPL-2.0+ OR X11
+/*
+ * Copyright 2019 Toradex AG
+ */
+
+/dts-v1/;
+
+#include "fsl-imx8qxp.dtsi"
+#include "fsl-imx8qxp-colibri-u-boot.dtsi"
+
+/ {
+	model = "Toradex Colibri iMX8QXP";
+	compatible = "toradex,colibri-imx8qxp", "fsl,imx8qxp";
+
+	chosen {
+		bootargs = "console=ttyLP3,115200

earlycon=lpuart32,0x5a090000,115200";

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +29 -0
+		stdout-path = &lpuart3;
+	};
+
+	reg_usbh_vbus: regulator-usbh-vbus {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_usbh1_reg>;
+		regulator-name = "usbh_vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		gpio = <&gpio4 3 GPIO_ACTIVE_LOW>;
+	};
+};
+
+&iomuxc {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_hog0>, <&pinctrl_hog1>, <&pinctrl_hog2>;
+
+	colibri-imx8qxp {
+		pinctrl_lpuart0: lpuart0grp {
+			fsl,pins = <
+				SC_P_UART0_RX_ADMA_UART0_RX	0x06000020
+				SC_P_UART0_TX_ADMA_UART0_TX	0x06000020
+			>;
+		};
+
+		pinctrl_lpuart3: lpuart3grp {
+			fsl,pins = <
+				SC_P_FLEXCAN2_RX_ADMA_UART3_RX	0x0

6000020

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_FLEXCAN2_TX_ADMA_UART3_TX	0x0

6000020

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_lpuart3_ctrl: lpuart3ctrlgrp {
+			fsl,pins = <
+				SC_P_MIPI_DSI1_GPIO0_01_LSIO_GPIO2_IO00

0x00000020 /* DTR */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_SAI1_RXD_LSIO_GPIO0_IO29		

0x00000020 /* CTS */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_SAI1_RXC_LSIO_GPIO0_IO30		

0x00000020 /* RTS */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_CSI_RESET_LSIO_GPIO3_IO03		

0x00000020 /* DSR */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_CD_B_LSIO_GPIO4_IO22	0x0

0000020 /* DCD */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_CSI_EN_LSIO_GPIO3_IO02		0x0

0000020 /* RI */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_fec1: fec1grp {
+			fsl,pins = <
+				SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB0_

PAD 0x000014a0 /* Use pads in 3.3V mode */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_COMP_CTL_GPIO_1V8_3V3_ENET_ENETB1_

PAD 0x000014a0 /* Use pads in 3.3V mode */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_MDC_CONN_ENET0_MDC		
	0x06000020
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_MDIO_CONN_ENET0_MDIO		
	0x06000020
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_TX_CTL_CONN_ENET0_RGMI

I_TX_CTL 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_TXC_CONN_ENET0_RCLK50M

_OUT 0x06000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_TXD0_CONN_ENET0_RGMII_

TXD0 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_TXD1_CONN_ENET0_RGMII_

TXD1 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_RX_CTL_CONN_ENET0_RGMI

I_RX_CTL 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_RXD0_CONN_ENET0_RGMII_

RXD0 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_RXD1_CONN_ENET0_RGMII_

RXD1 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_RXD2_CONN_ENET0_RMII_R

X_ER 0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_gpio_bl_on: gpio-bl-on {
+			fsl,pins = <
+				SC_P_QSPI0A_DATA3_LSIO_GPIO3_IO12	0x0

0000040

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_hog0: hog0grp {
+			fsl,pins = <
+				SC_P_COMP_CTL_GPIO_1V8_3V3_GPIORHB_PAD	

0x000514a0 /* Use pads in 3.3V mode */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_hog1: hog1grp {
+			fsl,pins = <
+				SC_P_QSPI0A_DATA1_LSIO_GPIO3_IO10	0x0

0000020 /* 45 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_TXD3_LSIO_GPIO5_IO02	

0x06000020 /* 65 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+					SC_P_CSI_D07_CI_PI_D09		

0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0A_DATA2_LSIO_GPIO3_IO11	0x0

0000020 /* 69 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0A_DQS_LSIO_GPIO3_IO13		

0x00000020 /* 73 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_SAI0_TXC_LSIO_GPIO0_IO26		

0x00000020 /* 79 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+					SC_P_CSI_D02_CI_PI_D04		

0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_ENET0_RGMII_RXC_LSIO_GPIO5_IO03	

0x06000020 /* 85 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+					SC_P_CSI_D06_CI_PI_D08		

0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_SCLK_LSIO_GPIO3_IO17	0x0

0000020 /* 95 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_SAI0_RXD_LSIO_GPIO0_IO27		

0x00000020 /* 97 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+					SC_P_CSI_D03_CI_PI_D05		

0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_DATA0_LSIO_GPIO3_IO18	0x0

0000020 /* 99 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_SAI0_TXFS_LSIO_GPIO0_IO28		

0x00000020 /* 101 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+					SC_P_CSI_D00_CI_PI_D02		

0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_SAI0_TXD_LSIO_GPIO0_IO25		

0x00000020 /* 103 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+					SC_P_CSI_D01_CI_PI_D03		

0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_DATA1_LSIO_GPIO3_IO19	0x0

0000020 /* 105 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_DATA2_LSIO_GPIO3_IO20	0x0

0000020 /* 107 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USB_SS3_TC2_LSIO_GPIO4_IO05	0x0

0000020 /* 127 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USB_SS3_TC3_LSIO_GPIO4_IO06	0x0

0000020 /* 131 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USB_SS3_TC1_LSIO_GPIO4_IO04	0x0

0000020 /* 133 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_CSI_PCLK_LSIO_GPIO3_IO00		

0x00000020 /* 96 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_DATA3_LSIO_GPIO3_IO21	0x0

0000020 /* 98 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_SAI1_RXFS_LSIO_GPIO0_IO31		

0x00000020 /* 100 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_DQS_LSIO_GPIO3_IO22		

0x00000020 /* 102 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_SS0_B_LSIO_GPIO3_IO23	0x0

0000020 /* 104 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0B_SS1_B_LSIO_GPIO3_IO24	0x0

0000020 /* 106 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_hog2: hog2grp {
+			fsl,pins = <
+				SC_P_CSI_MCLK_LSIO_GPIO3_IO01		

0x00000020 /* 75 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0A_SS0_B_LSIO_GPIO3_IO14	0x0

0000020 /* 77 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0A_SS1_B_LSIO_GPIO3_IO15	0x0

0000020 /* 89 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_QSPI0A_SCLK_LSIO_GPIO3_IO16	0x0

0000020 /* 93 */

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +7 -0
+			>;
+		};
+
+		/* Off Module I2C */
+		pinctrl_i2c1: i2c1grp {
+			fsl,pins = <
+				SC_P_MIPI_DSI0_GPIO0_00_ADMA_I2C1_SCL	

0x06000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_MIPI_DSI0_GPIO0_01_ADMA_I2C1_SDA	

0x06000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +7 -0
+			>;
+		};
+
+		/*INT*/
+		pinctrl_usb3503a: usb3503a-grp {
+			fsl,pins = <
+				SC_P_MIPI_CSI0_MCLK_OUT_LSIO_GPIO3_IO04

0x00000061

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usbc_det: usbc-det {
+			fsl,pins = <
+				SC_P_ENET0_REFCLK_125M_25M_LSIO_GPIO5_I

O09 0x06000040

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usbh1_reg: usbh1-reg {
+			fsl,pins = <
+				SC_P_USB_SS3_TC0_LSIO_GPIO4_IO03	0x0

6000040

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usdhc1: usdhc1grp {
+			fsl,pins = <
+				SC_P_EMMC0_CLK_CONN_EMMC0_CLK		

0x06000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_CMD_CONN_EMMC0_CMD		

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE	0x0

0000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B	

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
+			fsl,pins = <
+				SC_P_EMMC0_CLK_CONN_EMMC0_CLK		

0x06000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_CMD_CONN_EMMC0_CMD		

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE	0x0

0000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B	

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
+			fsl,pins = <
+				SC_P_EMMC0_CLK_CONN_EMMC0_CLK		

0x06000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_CMD_CONN_EMMC0_CMD		

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA0_CONN_EMMC0_DATA0	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA1_CONN_EMMC0_DATA1	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA2_CONN_EMMC0_DATA2	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA3_CONN_EMMC0_DATA3	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA4_CONN_EMMC0_DATA4	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA5_CONN_EMMC0_DATA5	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA6_CONN_EMMC0_DATA6	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_DATA7_CONN_EMMC0_DATA7	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_STROBE_CONN_EMMC0_STROBE	0x0

0000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_EMMC0_RESET_B_CONN_EMMC0_RESET_B	

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usdhc2_gpio: usdhc2gpiogrp {
+			fsl,pins = <
+				SC_P_QSPI0A_DATA0_LSIO_GPIO3_IO09	0x0

6000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usdhc2: usdhc2grp {
+			fsl,pins = <
+				SC_P_USDHC1_CLK_CONN_USDHC1_CLK		

0x06000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_CMD_CONN_USDHC1_CMD		

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT
	0x00000021
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usdhc2_100mhz: usdhc2grp100mhz {
+			fsl,pins = <
+				SC_P_USDHC1_CLK_CONN_USDHC1_CLK		

0x06000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_CMD_CONN_USDHC1_CMD		

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT
	0x00000021
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +6 -0
+			>;
+		};
+
+		pinctrl_usdhc2_200mhz: usdhc2grp200mhz {
+			fsl,pins = <
+				SC_P_USDHC1_CLK_CONN_USDHC1_CLK		

0x06000041

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_CMD_CONN_USDHC1_CMD		

0x00000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA0_CONN_USDHC1_DATA0	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA1_CONN_USDHC1_DATA1	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA2_CONN_USDHC1_DATA2	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_DATA3_CONN_USDHC1_DATA3	0x0

0000021

arch/arm/dts/fsl-imx8qxp-colibri.dts new file +1 -0
+				SC_P_USDHC1_VSELECT_CONN_USDHC1_VSELECT
	0x00000021
arch/arm/dts/fsl-imx8qxp-colibri.dts new file +80 -0
+			>;
+		};
+	};
+};
+
+&lpuart0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lpuart0>;
+	status = "okay";
+};
+
+&lpuart3 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lpuart3>, <&pinctrl_lpuart3_ctrl>;
+	status = "okay";
+};
+
+&gpio0 {
+	status = "okay";
+};
+
+&gpio1 {
+	status = "okay";
+};
+
+&gpio3 {
+	status = "okay";
+};
+
+&gpio4 {
+	status = "okay";
+};
+
+&fec1 {
+	phy-handle = <&ethphy0>;
+	phy-mode = "rmii";
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_fec1>;
+	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		ethphy0: ethernet-phy at 2 {
+			compatible = "ethernet-phy-ieee802.3-c22";
+			max-speed = <100>;
+			reg = <2>;
+		};
+	};
+};
+
+&i2c1 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	clock-frequency = <100000>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_i2c1>;
+	status = "okay";
+};
+
+&usdhc1 {
+	bus-width = <8>;
+	non-removable;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc1>;
+	pinctrl-1 = <&pinctrl_usdhc1_100mhz>;
+	pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
+	status = "okay";
+};
+
+&usdhc2 {
+	bus-width = <4>;
+	cd-gpios = <&gpio3 9 GPIO_ACTIVE_LOW>;
+	pinctrl-names = "default", "state_100mhz", "state_200mhz";
+	pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-1 = <&pinctrl_usdhc2_100mhz>, <&pinctrl_usdhc2_gpio>;
+	pinctrl-2 = <&pinctrl_usdhc2_200mhz>, <&pinctrl_usdhc2_gpio>;
+	status = "okay";
+};
arch/arm/mach- renamed from arch/arm/mach-imx/imx8/Kconfig +0 -0

imx/imx8/Kconfig
index f76a139684..feea07f135 100644

arch/arm/mach-imx/imx8/Kconfig +6 -0
@@ -22,6 +22,11 @@ choice
 	prompt "i.MX8 board select"
 	optional
 
+config TARGET_COLIBRI_IMX8QXP
+	bool "Support Colibri iMX8QXP module"
+	select BOARD_LATE_INIT
+	select IMX8QXP
+
 config TARGET_IMX8QXP_MEK
 	bool "Support i.MX8QXP MEK board"
 	select BOARD_LATE_INIT
@@ -30,5 +35,6 @@ config TARGET_IMX8QXP_MEK
 endchoice
 
 source "board/freescale/imx8qxp_mek/Kconfig"
+source "board/toradex/colibri-imx8qxp/Kconfig"
 
 endif
board/toradex/colibri-imx8qxp/Kconfig new file +30 -0
new file mode 100644
index 0000000000..340fe72816
@@ -0,0 +1,30 @@
+if TARGET_COLIBRI_IMX8QXP
+
+config SYS_BOARD
+	default "colibri-imx8qxp"
+
+config SYS_VENDOR
+	default "toradex"
+
+config SYS_CONFIG_NAME
+	default "colibri-imx8qxp"
+
+config TDX_CFG_BLOCK
+	default y
+
+config TDX_HAVE_MMC
+	default y
+
+config TDX_CFG_BLOCK_DEV
+	default "0"
+
+config TDX_CFG_BLOCK_PART
+	default "1"
+
+# Toradex config block in eMMC, at the end of 1st "boot sector"
+config TDX_CFG_BLOCK_OFFSET
+	default "-512"
+
+source "board/toradex/common/Kconfig"
+
+endif
board/toradex/colibri-imx8qxp/MAINTAINERS new file +9 -0
new file mode 100644
index 0000000000..39a9eb79b7
@@ -0,0 +1,9 @@
+Colibri iMX8QXP
+M:	Marcel Ziswiler <[email protected]>
+W:	http://developer.toradex.com/software/linux/linux-software
+S:	Maintained
+F:	arch/arm/dts/fsl-imx8qxp-colibri.dts
+F:	arch/arm/dts/fsl-imx8qxp-colibri-u-boot.dtsi
+F:	board/toradex/colibri-imx8qxp/
+F:	configs/colibri-imx8qxp_defconfig
+F:	include/configs/colibri-imx8qxp.h
board/toradex/colibri-imx8qxp/Makefile new file +7 -0
new file mode 100644
index 0000000000..f6342e1dca
@@ -0,0 +1,7 @@
+#
+# Copyright 2019 Toradex
+#
+# SPDX-License-Identifier:	GPL-2.0+
+#
+
+obj-y += colibri-imx8qxp.o
board/toradex/colibri-imx8qxp/README new file +16 -0
new file mode 100644
index 0000000000..e68d183fe6
@@ -0,0 +1,66 @@
+U-Boot for the Toradex Colibri iMX8QXP V1.0B module
+
+Quick Start
+===========
+
+- Build the ARM trusted firmware binary
+- Get scfw_tcm.bin and ahab-container.img
+- Build U-Boot
+- Load U-Boot binary using uuu
+- Flash U-Boot binary into the eMMC
+- Boot
+
+Get and Build the ARM Trusted Firmware
+======================================
+
+$ git clone -b imx_4.14.78_1.0.0_ga 

https://source.codeaurora.org/external/imx/imx-atf
+$ cd imx-atf/
+$ make PLAT=imx8qxp bl31

board/toradex/colibri-imx8qxp/README new file +5 -0
+
+Get scfw_tcm.bin and ahab-container.img
+=======================================
+
+$ wget 

https://github.com/toradex/meta-fsl-bsp-release/blob/toradex-sumo-4.14.78-1.0.0_ga-bringup/imx/meta-bsp/recipes-bsp/imx-sc-firmware/files/mx8qx-colibri-scfw-tcm.bin?raw=true
+$ mv mx8qx-colibri-scfw-tcm.bin\?raw\=true mx8qx-colibri-scfw- tcm.bin
+$ wget
https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/firmware-imx-7.6.bin
+$ chmod +x firmware-imx-7.6.bin
+$ ./firmware-imx-7.6.bin

board/toradex/colibri-imx8qxp/README new file +20 -0
+
+Copy the following binaries to the U-Boot folder:
+
+$ cp imx-atf/build/imx8qxp/release/bl31.bin .
+$ cp u-boot/u-boot.bin .
+
+Copy the following firmware to the U-Boot folder:
+
+$ cp firmware-imx-7.6/firmware/seco/ahab-container.img .
+
+Build U-Boot
+============
+
+$ make colibri-imx8qxp_defconfig
+$ make u-boot-dtb.imx
+
+Load the U-Boot Binary Using UUU
+================================
+
+Get the latest version of the universal update utility (uuu) aka

mfgtools 3.0:

board/toradex/colibri-imx8qxp/README new file +2 -0
+
+

https://community.nxp.com/external-link.jspa?url=https%3A%2F%2Fgithub.com%2FNXPmicro%2Fmfgtools%2Freleases

board/toradex/colibri-imx8qxp/README new file +2 -0
+
+Put the module into USB recovery aka serial downloader mode,

connect USB device

board/toradex/colibri-imx8qxp/README new file +8 -0
+to your host and execute uuu:
+
+sudo ./uuu u-boot/u-boot-dtb.imx
+
+Flash the U-Boot Binary into the eMMC
+=====================================
+
+Burn the u-boot-dtb.imx binary to the primary eMMC hardware boot

area partition:

board/toradex/colibri-imx8qxp/README new file +3 -0
+
+load mmc 1:1 $loadaddr u-boot-dtb.imx
+setexpr blkcnt ${filesize} + 0x1ff && setexpr blkcnt ${blkcnt} /

0x200

board/toradex/colibri-imx8qxp/README new file +4 -0
+mmc dev 0 1
+mmc write ${loadaddr} 0x0 ${blkcnt}
+
+Boot
board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +33 -0
new file mode 100644
index 0000000000..9aa0f096d2
@@ -0,0 +1,212 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright 2019 Toradex
+ */
+
+#include <common.h>
+
+#include <asm/arch/clock.h>
+#include <asm/arch/imx8-pins.h>
+#include <asm/arch/iomux.h>
+#include <asm/arch/sci/sci.h>
+#include <asm/arch/sys_proto.h>
+#include <asm/gpio.h>
+#include <asm/io.h>
+#include <asm/mach-imx/video.h>
+#include <dm.h>
+#include <environment.h>
+#include <errno.h>
+#include <fdt_support.h>
+#include <fsl_esdhc.h>
+#include <fsl_ifc.h>
+#include <i2c.h>
+#include <linux/libfdt.h>
+#include <malloc.h>
+#include <netdev.h>
+#include <power-domain.h>
+#include <usb.h>
+
+#include "../common/tdx-cfg-block.h"
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define GPIO_PAD_CTRL	((SC_PAD_CONFIG_NORMAL <<

PADRING_CONFIG_SHIFT) | \

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +2 -0
+			 (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT) | \
+			 (SC_PAD_28FDSOI_DSE_DV_HIGH <<

PADRING_DSE_SHIFT) | \

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +3 -0
+			 (SC_PAD_28FDSOI_PS_PU << PADRING_PULL_SHIFT))
+
+#define UART_PAD_CTRL	((SC_PAD_CONFIG_OUT_IN <<

PADRING_CONFIG_SHIFT) | \

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +2 -0
+			 (SC_PAD_ISO_OFF << PADRING_LPCONFIG_SHIFT) | \
+			 (SC_PAD_28FDSOI_DSE_DV_HIGH <<

PADRING_DSE_SHIFT) | \

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +4 -0
+			 (SC_PAD_28FDSOI_PS_PU << PADRING_PULL_SHIFT))
+
+static iomux_cfg_t uart3_pads[] = {
+	SC_P_FLEXCAN2_RX | MUX_MODE_ALT(2) |

MUX_PAD_CTRL(UART_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +1 -0
+	SC_P_FLEXCAN2_TX | MUX_MODE_ALT(2) |

MUX_PAD_CTRL(UART_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +2 -0
+	/* Transceiver FORCEOFF# signal, mux to use pullup */
+	SC_P_QSPI0B_DQS | MUX_MODE_ALT(4) |

MUX_PAD_CTRL(UART_PAD_CTRL),

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+};
+
+static void setup_iomux_uart(void)
+{
+	imx8_iomux_setup_multiple_pads(uart3_pads,

ARRAY_SIZE(uart3_pads));

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +9 -0
+}
+
+int board_early_init_f(void)
+{
+	sc_pm_clock_rate_t rate;
+	sc_err_t err = 0;
+
+	/*
+	 * This works around that having only UART3 up the baudrate is

1.2M

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +4 -0
+	 * instead of 115.2k. Set UART0 clock root to 80 MHz
+	 */
+	rate = 80000000;
+	err = sc_pm_set_clock_rate(-1, SC_R_UART_0, SC_PM_CLK_PER,

&rate);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	/* Power up UART3 */
+	err = sc_pm_set_resource_power_mode(-1, SC_R_UART_3,

SC_PM_PW_MODE_ON);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +6 -0
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	/* Set UART3 clock root to 80 MHz */
+	rate = 80000000;
+	err = sc_pm_set_clock_rate(-1, SC_R_UART_3, SC_PM_CLK_PER,

&rate);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +5 -0
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	/* Enable UART3 clock root */
+	err = sc_pm_clock_enable(-1, SC_R_UART_3, SC_PM_CLK_PER, true,

false);

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +37 -0
+	if (err != SC_ERR_NONE)
+		return 0;
+
+	setup_iomux_uart();
+
+	return 0;
+}
+
+#undef CONFIG_MXC_GPIO /* TODO */
+#ifdef CONFIG_MXC_GPIO
+#define IOEXP_RESET IMX_GPIO_NR(1, 1)
+
+static iomux_cfg_t board_gpios[] = {
+	SC_P_SPI2_SDO | MUX_MODE_ALT(4) | MUX_PAD_CTRL(GPIO_PAD_CTRL),
+	SC_P_ENET0_REFCLK_125M_25M | MUX_MODE_ALT(4) | \
+		MUX_PAD_CTRL(GPIO_PAD_CTRL),
+};
+
+static void board_gpio_init(void)
+{
+	struct gpio_desc desc;
+	int ret;
+
+	ret = dm_gpio_lookup_name("gpio at 1a_3", &desc);
+	if (ret)
+		return;
+
+	ret = dm_gpio_request(&desc, "bb_per_rst_b");
+	if (ret)
+		return;
+
+	dm_gpio_set_dir_flags(&desc, GPIOD_IS_OUT);
+	dm_gpio_set_value(&desc, 0);
+	udelay(50);
+	dm_gpio_set_value(&desc, 1);
+
+	imx8_iomux_setup_multiple_pads(board_gpios,

ARRAY_SIZE(board_gpios));

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +38 -0
+
+	/* enable i2c port expander assert reset line */
+	gpio_request(IOEXP_RESET, "ioexp_rst");
+	gpio_direction_output(IOEXP_RESET, 1);
+}
+#else
+static inline void board_gpio_init(void) {}
+#endif
+
+#if IS_ENABLED(CONFIG_FEC_MXC)
+#include <miiphy.h>
+
+int board_phy_config(struct phy_device *phydev)
+{
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x1f);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x8);
+
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x00);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x82ee);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1d, 0x05);
+	phy_write(phydev, MDIO_DEVAD_NONE, 0x1e, 0x100);
+
+	if (phydev->drv->config)
+		phydev->drv->config(phydev);
+
+	return 0;
+}
+#endif
+
+void build_info(void)
+{
+	u32 sc_build = 0, sc_commit = 0;
+
+	/* Get SCFW build and commit id */
+	sc_misc_build_info(-1, &sc_build, &sc_commit);
+	if (!sc_build) {
+		printf("SCFW does not support build info\n");
+		sc_commit = 0; /* Display 0 if build info not supported

*/

board/toradex/colibri-imx8qxp/colibri-imx8qxp.c new file +56 -0
+	}
+	printf("Build: SCFW %x\n", sc_commit);
+}
+
+int checkboard(void)
+{
+	puts("Model: Toradex Colibri iMX8X\n");
+
+	build_info();
+	print_bootinfo();
+
+	return 0;
+}
+
+int board_init(void)
+{
+	board_gpio_init();
+
+	return 0;
+}
+
+void detail_board_ddr_info(void)
+{
+	puts("\nDDR    ");
+}
+
+/*
+ * Board specific reset that is system reset.
+ */
+void reset_cpu(ulong addr)
+{
+	/* TODO */
+}
+
+#if defined(CONFIG_OF_LIBFDT) && defined(CONFIG_OF_BOARD_SETUP)
+int ft_board_setup(void *blob, bd_t *bd)
+{
+	return ft_common_board_setup(blob, bd);
+}
+#endif
+
+int board_mmc_get_env_dev(int devno)
+{
+	return devno;
+}
+
+int board_late_init(void)
+{
+#ifdef CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+/* TODO move to common */
+	env_set("board_name", "Colibri iMX8QXP");
+	env_set("board_rev", "v1.0");
+#endif
+
+	return 0;
+}
board/toradex/colibri-imx8qxp/imximage.cfg new file +5 -0
new file mode 100644
index 0000000000..ce9e66c64d
@@ -0,0 +1,24 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ *
+ * Refer doc/README.imx8image for more details about how-to

configure
+ * and create imx8image boot image
+ */

board/toradex/colibri-imx8qxp/imximage.cfg new file +17 -0
+
+#define __ASSEMBLY__
+
+/* Boot from SD, sector size 0x400 */
+BOOT_FROM EMMC_FASTBOOT 0x400
+/* SoC type IMX8QX */
+SOC_TYPE IMX8QX
+/* Append seco container image */
+APPEND ahab-container.img
+/* Create the 2nd container */
+CONTAINER
+/* Add scfw image with exec attribute */
+IMAGE SCU mx8qx-colibri-scfw-tcm.bin
+/* Add ATF image with exec attribute */
+IMAGE A35 bl31.bin 0x80000000
+/* Add U-Boot image with load attribute */
+DATA A35 u-boot-dtb.bin 0x80020000
configs/colibri- renamed from configs/colibri-imx8qxp_defconfig +0 -0

imx8qxp_defconfig
new file mode 100644
index 0000000000..d697546ed7

configs/colibri-imx8qxp_defconfig new file +9 -0
@@ -0,0 +1,53 @@
+CONFIG_ARM=y
+CONFIG_ARCH_IMX8=y
+CONFIG_SYS_TEXT_BASE=0x80020000
+CONFIG_SYS_MALLOC_F_LEN=0x2000
+CONFIG_TARGET_COLIBRI_IMX8QXP=y
+CONFIG_DISTRO_DEFAULTS=y
+CONFIG_NR_DRAM_BANKS=3
+CONFIG_FIT=y
+CONFIG_SYS_EXTRA_OPTIONS="IMX_CONFIG=board/toradex/colibri-

imx8qxp/imximage.cfg"

configs/colibri-imx8qxp_defconfig new file +44 -0
+CONFIG_LOG=y
+CONFIG_VERSION_VARIABLE=y
+# CONFIG_DISPLAY_BOARDINFO is not set
+CONFIG_BOARD_EARLY_INIT_F=y
+CONFIG_CMD_CPU=y
+# CONFIG_CMD_IMPORTENV is not set
+CONFIG_CMD_MEMTEST=y
+CONFIG_CMD_CLK=y
+CONFIG_CMD_DM=y
+CONFIG_CMD_GPIO=y
+CONFIG_CMD_I2C=y
+CONFIG_CMD_MMC=y
+CONFIG_CMD_CACHE=y
+CONFIG_CMD_UUID=y
+CONFIG_CMD_EXT4_WRITE=y
+CONFIG_DEFAULT_DEVICE_TREE="fsl-imx8qxp-colibri"
+CONFIG_ENV_IS_IN_MMC=y
+CONFIG_CLK_IMX8=y
+CONFIG_CPU=y
+CONFIG_DM_GPIO=y
+CONFIG_MXC_GPIO=y
+CONFIG_DM_I2C=y
+CONFIG_SYS_I2C_IMX_LPI2C=y
+CONFIG_MISC=y
+CONFIG_DM_MMC=y
+CONFIG_PHYLIB=y
+CONFIG_PHY_ADDR_ENABLE=y
+CONFIG_PHY_MICREL=y
+CONFIG_DM_ETH=y
+CONFIG_FEC_MXC_SHARE_MDIO=y
+CONFIG_FEC_MXC_MDIO_BASE=0x5B040000
+CONFIG_FEC_MXC=y
+CONFIG_MII=y
+CONFIG_PINCTRL=y
+CONFIG_PINCTRL_IMX8=y
+CONFIG_POWER_DOMAIN=y
+CONFIG_IMX8_POWER_DOMAIN=y
+CONFIG_DM_REGULATOR=y
+CONFIG_DM_REGULATOR_FIXED=y
+CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_SERIAL=y
+CONFIG_FSL_LPUART=y
+CONFIG_DM_THERMAL=y
+# CONFIG_EFI_LOADER is not set
include/configs/colibri-imx8qxp.h new file +60 -0
new file mode 100644
index 0000000000..33cbcb44a9
@@ -0,0 +1,214 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright 2019 Toradex
+ */
+
+#ifndef __COLIBRI_IMX8QXP_H
+#define __COLIBRI_IMX8QXP_H
+
+#include <asm/arch/imx-regs.h>
+#include <linux/sizes.h>
+
+#define CONFIG_REMAKE_ELF
+
+#define CONFIG_DISPLAY_BOARDINFO_LATE
+
+#undef CONFIG_CMD_EXPORTENV
+#undef CONFIG_CMD_IMPORTENV
+#undef CONFIG_CMD_IMLS
+
+#undef CONFIG_CMD_CRC32
+#undef CONFIG_BOOTM_NETBSD
+
+#define CONFIG_FSL_ESDHC
+#define CONFIG_FSL_USDHC
+#define CONFIG_SYS_FSL_ESDHC_ADDR	0
+#define USDHC1_BASE_ADDR		0x5B010000
+#define USDHC2_BASE_ADDR		0x5B020000
+#define CONFIG_SUPPORT_EMMC_BOOT	/* eMMC specific */
+
+#define CONFIG_ENV_OVERWRITE
+
+#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+
+#define FEC_QUIRK_ENET_MAC
+
+#define CONFIG_IP_DEFRAG
+#define CONFIG_TFTP_BLOCKSIZE		4096
+#define CONFIG_TFTP_TSIZE
+
+#define CONFIG_IPADDR			192.168.10.2
+#define CONFIG_NETMASK			255.255.255.0
+#define CONFIG_SERVERIP			192.168.10.1
+
+#define MEM_LAYOUT_ENV_SETTINGS \
+	"fdt_addr_r=0x84000000\0" \
+	"kernel_addr_r=0x82000000\0" \
+	"ramdisk_addr_r=0x84100000\0"
+
+#ifdef CONFIG_AHAB_BOOT
+#define AHAB_ENV "sec_boot=yes\0"
+#else
+#define AHAB_ENV "sec_boot=no\0"
+#endif
+
+/* Boot M4 */
+#define M4_BOOT_ENV \
+	"m4_0_image=m4_0.bin\0" \
+	"loadm4image_0=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} " \
+		"${m4_0_image}\0" \
+	"m4boot_0=run loadm4image_0; dcache flush; bootaux ${loadaddr}

0\0" \

include/configs/colibri-imx8qxp.h new file +13 -0
+
+#define MFG_NAND_PARTITION ""
+
+#define BOOT_TARGET_DEVICES(func) \
+	func(MMC, mmc, 0) \
+	func(MMC, mmc, 1) \
+	func(DHCP, dhcp, na)
+#include <config_distro_bootcmd.h>
+#undef BOOTENV_RUN_NET_USB_START
+#define BOOTENV_RUN_NET_USB_START ""
+
+#define CONFIG_MFG_ENV_SETTINGS \
+	"mfgtool_args=setenv bootargs console=${console},${baudrate} "

\

include/configs/colibri-imx8qxp.h new file +2 -0
+		"rdinit=/linuxrc g_mass_storage.stall=0 " \
+		"g_mass_storage.removable=1

g_mass_storage.idVendor=0x066F " \

include/configs/colibri-imx8qxp.h new file +4 -0
+		"g_mass_storage.idProduct=0x37FF " \
+		"g_mass_storage.iSerialNumber=\"\" "\
+		MFG_NAND_PARTITION \
+		"video=imxdpufb5:off video=imxdpufb6:off

video=imxdpufb7:off " \

include/configs/colibri-imx8qxp.h new file +5 -0
+		"clk_ignore_unused "\
+		"\0" \
+	"initrd_addr=0x83800000\0" \
+	"initrd_high=0xffffffff\0" \
+	"bootcmd_mfg=run mfgtool_args;booti ${loadaddr} ${initrd_addr}

" \

include/configs/colibri-imx8qxp.h new file +20 -0
+		"${fdt_addr};\0" \
+
+/* Initial environment variables */
+#define CONFIG_EXTRA_ENV_SETTINGS \
+	AHAB_ENV \
+	BOOTENV \
+	CONFIG_MFG_ENV_SETTINGS \
+	M4_BOOT_ENV \
+	MEM_LAYOUT_ENV_SETTINGS \
+	"boot_fdt=try\0" \
+	"bootscript=echo Running bootscript from mmc ...; source\0" \
+	"console=ttyLP3,115200 earlycon=lpuart32,0x5a090000,115200\0" \
+	"fdt_addr=0x83000000\0"			\
+	"fdt_file=fsl-imx8qxp-colibri-eval-v3.dtb\0" \
+	"fdt_high=0xffffffffffffffff\0"		\
+	"finduuid=part uuid mmc ${mmcdev}:2 uuid\0" \
+	"image=Image\0" \
+	"initrd_addr=0x83800000\0"		\
+	"initrd_high=0xffffffffffffffff\0" \
+	"loadbootscript=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} "

\

include/configs/colibri-imx8qxp.h new file +2 -0
+		"${script};\0" \
+	"loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr}

${fdt_file}\0" \

include/configs/colibri-imx8qxp.h new file +1 -0
+	"loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr}

${image}\0" \

include/configs/colibri-imx8qxp.h new file +6 -0
+	"mmcargs=setenv bootargs console=${console},${baudrate} " \
+		"root=PARTUUID=${uuid} rootwait " \
+	"mmcautodetect=yes\0" \
+	"mmcboot=echo Booting from mmc ...; " \
+		"run finduuid; run mmcargs; " \
+		"if test ${boot_fdt} = yes || test ${boot_fdt} = try;

then " \

include/configs/colibri-imx8qxp.h new file +11 -0
+			"if run loadfdt; then " \
+				"booti ${loadaddr} - ${fdt_addr}; " \
+			"else " \
+				"echo WARN: Cannot load the DT; " \
+			"fi; " \
+		"else " \
+			"echo wait for boot; " \
+		"fi;\0" \
+	"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
+	"mmcpart=" __stringify(CONFIG_SYS_MMC_IMG_LOAD_PART) "\0" \
+	"netargs=setenv bootargs console=${console} root=/dev/nfs

ip=dhcp " \

include/configs/colibri-imx8qxp.h new file +1 -0
+		"nfsroot=${serverip}:${nfsroot},v3,tcp

video=imxdpufb5:off " \

include/configs/colibri-imx8qxp.h new file +10 -0
+		"video=imxdpufb6:off video=imxdpufb7:off\0" \
+	"netboot=echo Booting from net ...; " \
+		"run netargs; " \
+		"if test ${ip_dyn} = yes; then " \
+			"setenv get_cmd dhcp; " \
+		"else " \
+			"setenv get_cmd tftp; " \
+		"fi; " \
+		"${get_cmd} ${loadaddr} ${image}; " \
+		"if test ${boot_fdt} = yes || test ${boot_fdt} = try;

then " \

include/configs/colibri-imx8qxp.h new file +1 -0
+			"if ${get_cmd} ${fdt_addr} ${fdt_file}; then "

\

include/configs/colibri-imx8qxp.h new file +8 -0
+				"booti ${loadaddr} - ${fdt_addr}; " \
+			"else " \
+				"echo WARN: Cannot load the DT; " \
+			"fi; " \
+		"else " \
+			"booti; " \
+		"fi;\0" \
+	"nfsboot=run netargs; dhcp ${loadaddr} ${image}; tftp

${fdt_addr} " \

include/configs/colibri-imx8qxp.h new file +30 -0
+		"colibri-imx8qxp/${fdt_file}; booti ${loadaddr} - " \
+		"${fdt_addr}\0" \
+	"panel=NULL\0" \
+	"script=boot.scr\0" \
+	"video=imxdpufb5:off video=imxdpufb6:off video=imxdpufb7:off\0"
+
+#undef CONFIG_BOOTCOMMAND
+#define CONFIG_BOOTCOMMAND \
+	   "mmc dev ${mmcdev}; if mmc rescan; then " \
+		   "if run loadbootscript; then " \
+			   "run bootscript; " \
+		   "else " \
+			   "if run loadimage; then " \
+				   "run mmcboot; " \
+			   "else run netboot; " \
+			   "fi; " \
+		   "fi; " \
+	   "else booti ${loadaddr} - ${fdt_addr}; fi"
+
+/* Link Definitions */
+#define CONFIG_LOADADDR			0x80280000
+
+#define CONFIG_SYS_LOAD_ADDR		CONFIG_LOADADDR
+
+#define CONFIG_SYS_INIT_SP_ADDR		0x80200000
+
+#define CONFIG_SYS_MEMTEST_START	0x88000000
+#define CONFIG_SYS_MEMTEST_END		0x89000000
+
+/* Environment in eMMC, before config block at the end of 1st

"boot sector" */

include/configs/colibri-imx8qxp.h new file +10 -0
+#define CONFIG_ENV_SIZE			(8 * 1024)
+#define CONFIG_ENV_OFFSET		(-CONFIG_ENV_SIZE + \
+					 CONFIG_TDX_CFG_BLOCK_OFFSET)
+#define CONFIG_SYS_MMC_ENV_DEV		0
+#define CONFIG_SYS_MMC_ENV_PART		1
+
+#define CONFIG_SYS_MMC_IMG_LOAD_PART	1
+
+/* On Colibri iMX8 USDHC1 is eMMC, USDHC2 is 4-bit SD */
+#define CONFIG_SYS_MMC_ENV_DEV		0		 /* USDHC1

eMMC */

include/configs/colibri-imx8qxp.h new file +4 -0
+#define CONFIG_SYS_FSL_USDHC_NUM	2
+
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		((CONFIG_ENV_SIZE + (32

* 1024)) * 1024)

include/configs/colibri-imx8qxp.h new file +24 -0
+
+#define CONFIG_SYS_SDRAM_BASE		0x80000000
+#define CONFIG_NR_DRAM_BANKS		3
+#define PHYS_SDRAM_1			0x80000000
+#define PHYS_SDRAM_2			0x880000000
+#define PHYS_SDRAM_1_SIZE		0x80000000	/* 2 GB */
+#define PHYS_SDRAM_2_SIZE		0x00000000	/* 0 GB */
+
+/* Serial */
+#define CONFIG_BAUDRATE			115200
+
+/* Monitor Command Prompt */
+#define CONFIG_SYS_PROMPT_HUSH_PS2	"> "
+#define CONFIG_SYS_CBSIZE		2048
+#define CONFIG_SYS_MAXARGS		64
+#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
+#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
+					sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* Generic Timer Definitions */
+#define COUNTER_FREQUENCY		8000000	/* 8MHz */
+
+#define BOOTAUX_RESERVED_MEM_BASE 0x88000000
+#define BOOTAUX_RESERVED_MEM_SIZE 0x08000000 /* Reserve from

second 128MB */

include/configs/colibri-imx8qxp.h new file +2 -0
+
+#endif /* __COLIBRI_IMX8QXP_H */
#17 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Quoted 39 lines · Marcel Ziswiler

Hi Stefano

Quoted 36 lines · Stefano Babic

Hi Marcel,

Quoted 20 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB
IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which
are factory fused to properly boot from their on-module eMMC. U- Boot
supports either booting from the on-module eMMC or may be used for recovery purpose using the universal update utility (uuu) aka mfgtools
3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 8 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of
yet.

---

I merged the series and build locally (fine), but Travis complains and
stops with error:

Quoted 8 lines
Quoted 5 lines

+cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No such file or directory
+compilation terminated.

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for i.MX8") takes SPL for granted while my patchset currently avoids it.

It looks so, yes.

Quoted 3 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given all the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW and change the configuration - for i.MX6, this means RAMS detection, which boot device is booting, and so on.

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and most features are lost (or must be provided by proprietary code). I agree that on this platform SPL makes less sense, and i.MX8 should be built independently if CONFIG_SPL is set (this is also for i.MX6 / MX5, there are boards without SPL and using the DCD image to set up the RAM controller).

Quoted 4 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#18 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Stefano,

Quoted 59 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Quoted 13 lines · Marcel Ziswiler

Hi Stefano

Quoted 10 lines · Stefano Babic

Hi Marcel,

Quoted 7 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U- Boot supports either booting from the on-module eMMC or

may

Quoted 20 lines
Quoted 20 lines
Quoted 9 lines

be used for recovery purpose using the universal update utility (uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 7 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

---

I merged the series and build locally (fine), but Travis complains and stops with error:

Quoted 8 lines
Quoted 5 lines

+cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No such file or directory
+compilation terminated.

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for i.MX8") takes SPL for granted while my patchset currently avoids it.

It looks so, yes.

Quoted 3 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given all the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW and change the configuration - for i.MX6, this means RAMS detection, which boot device is booting, and so on.

Quoted 6 lines

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and most features are lost (or must be provided by proprietary code). I agree that on this platform SPL makes less sense, and i.MX8 should be built independently if CONFIG_SPL is set (this is also for
i.MX6 / MX5, there are boards without SPL and using the DCD image to set up the RAM controller).

The reason we move to use SPL on i.MX8 is that we would like to avoid bind ATF/OP-TEE/U-Boot into a flat image with hacked offset in an image.

So the bootflow now is
SPL->ATF->OPTEE->ATF->U-Boot

Without SPL, when generating flash.bin, we have to hack ATF to copy OP-TEE image from flash.bin to the runtime location.

Quoted 4 lines
Quoted 4 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

The usb related function for i.MX8 is not ready now. we are almost run out of ocram with SPL DM, thinking to use OF_PLATDATA now, then move to usb functions.

Thanks,
Peng.

Quoted 13 lines
Quoted 1 line

Regards,
Stefano

--
==============================================================
=======
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
==============================================================
=======

#19 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Peng,

Quoted 69 lines · Peng Fan

Hi Stefano,

Quoted 59 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Quoted 13 lines · Marcel Ziswiler

Hi Stefano

Quoted 10 lines · Stefano Babic

Hi Marcel,

Quoted 7 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U- Boot supports either booting from the on-module eMMC or

may

Quoted 20 lines
Quoted 20 lines
Quoted 9 lines

be used for recovery purpose using the universal update utility (uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 7 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

---

I merged the series and build locally (fine), but Travis complains and stops with error:

Quoted 8 lines
Quoted 5 lines

+cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No such file or directory
+compilation terminated.

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for i.MX8") takes SPL for granted while my patchset currently avoids it.

It looks so, yes.

Quoted 3 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given all the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW and change the configuration - for i.MX6, this means RAMS detection, which boot device is booting, and so on.

Quoted 6 lines

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and most features are lost (or must be provided by proprietary code). I agree that on this platform SPL makes less sense, and i.MX8 should be built independently if CONFIG_SPL is set (this is also for
i.MX6 / MX5, there are boards without SPL and using the DCD image to set up the RAM controller).

Quoted 3 lines

The reason we move to use SPL on i.MX8 is that we would like to avoid bind ATF/OP-TEE/U-Boot into a flat image with hacked offset in an image.

It seemed I have missed some point. Thanks for clarification. This makes sense.

Quoted 5 lines

So the bootflow now is
SPL->ATF->OPTEE->ATF->U-Boot

Without SPL, when generating flash.bin, we have to hack ATF to copy OP-TEE image from flash.bin to the runtime location.

Nevertheless, I understand that it is not strictly required to enable OPTEE to boot the kernel, and in some applications a secure zone is not required. The thing is not that SPL is used here, but to constrain all other users like Marcel to do the same. With i.MX6, even if I strongly suggested to do this to allow run time detection, I let boards without SPL and with just u-boot.imx (with built-in DCD) to flow into mainline - the board maintainer rules as he knows better where the device is used.

So I will prefer that the build assume to have SPL just if SPL is configured and not in any case, letting boards without SPL (like this colibri-mx8) to build.

Quoted 7 lines
Quoted 5 lines
Quoted 5 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

The usb related function for i.MX8 is not ready now.

That is ok - it s WIP, it will be merged when ready. I agree with you, this is *not* a reason to avoid SPL.

Quoted 3 lines

we are almost run out
of ocram with SPL DM, thinking to use OF_PLATDATA now, then move to usb functions.

Understood.

Best regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#20 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Stefano,

Quoted 101 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Peng,

Quoted 21 lines · Peng Fan

Hi Stefano,

Quoted 19 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Quoted 13 lines · Marcel Ziswiler

Hi Stefano

Quoted 10 lines · Stefano Babic

Hi Marcel,

Quoted 7 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U- Boot supports either booting from the

on-module

Quoted 52 lines
Quoted 43 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line

eMMC or

may

Quoted 25 lines
Quoted 25 lines
Quoted 9 lines

be used for recovery purpose using the universal update utility (uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 7 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

---

I merged the series and build locally (fine), but Travis complains and stops with error:

(quoted diff) +2 -0
+cc1: fatal error: opening output file spl/u-boot-spl.cfgout: No
+such

file or directory
+compilation terminated.

Quoted 5 lines
Quoted 1 line

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for
i.MX8") takes SPL for granted while my patchset currently avoids it.

It looks so, yes.

Quoted 3 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given all the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW and change the configuration - for i.MX6, this means RAMS detection, which boot device is booting, and so on.

Quoted 7 lines

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and most features are lost (or must be provided by proprietary code). I agree that on this platform SPL makes less sense, and i.MX8 should be built independently if CONFIG_SPL is set (this is also for
i.MX6 / MX5, there are boards without SPL and using the DCD image to set up the RAM controller).

Quoted 3 lines

The reason we move to use SPL on i.MX8 is that we would like to avoid bind ATF/OP-TEE/U-Boot into a flat image with hacked offset in an image.

It seemed I have missed some point. Thanks for clarification. This makes sense.

Quoted 5 lines

So the bootflow now is
SPL->ATF->OPTEE->ATF->U-Boot

Without SPL, when generating flash.bin, we have to hack ATF to copy OP-TEE image from flash.bin to the runtime location.

Nevertheless, I understand that it is not strictly required to enable OPTEE to boot the kernel, and in some applications a secure zone is not required. The thing is not that SPL is used here, but to constrain all other users like Marcel to do the same. With i.MX6, even if I strongly suggested to do this to allow run time detection, I let boards without SPL and with just u-boot.imx (with built-in DCD) to flow into mainline - the board maintainer rules as he knows better where the device is used.

Quoted 3 lines

So I will prefer that the build assume to have SPL just if SPL is configured and not in any case, letting boards without SPL (like this
colibri-mx8) to build.

ok. Then need to think about how to bind bl31.bin and u-boot.bin,

the binded image will be copied to 0x80000000 by ROM.

Consider bl31 is 128KB now, so uboot entry could be hardcoded to 0x80020000, and u-boot.bin is 128KB offset of the final image.

Could use binman. And then need to generate flash.bin.

Regards,
Peng.

Quoted 29 lines
Quoted 8 lines
Quoted 6 lines
Quoted 6 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

The usb related function for i.MX8 is not ready now.

That is ok - it s WIP, it will be merged when ready. I agree with you, this is *not* a reason to avoid SPL.

Quoted 3 lines

we are almost run out
of ocram with SPL DM, thinking to use OF_PLATDATA now, then move to usb functions.

Understood.

Best regards,
Stefano

--
==============================================================
=======
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
==============================================================
=======

#21 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

In reply to Stefano Babic

Hi Peng and Stefano

Quoted 94 lines · Stefano Babic

Hi Peng,

Quoted 85 lines · Peng Fan

Hi Stefano,

Quoted 73 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it
v1.0b module support

Hi Marcel,

Quoted 17 lines · Marcel Ziswiler

Hi Stefano

Quoted 14 lines · Stefano Babic

Hi Marcel,

Quoted 11 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB
WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from
eFuses which are factory fused to properly boot from their on-module
eMMC. U- Boot supports either booting from the on-module eMMC or

may

Quoted 29 lines
Quoted 29 lines
Quoted 10 lines

be used for recovery purpose using the universal update utility
(uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 9 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of
yet.

Quoted 1 line

---

I merged the series and build locally (fine), but Travis complains
and stops with error:

+cc1: fatal error: opening output file spl/u-boot-spl.cfgout:
No such
file or directory
+compilation terminated.

Quoted 6 lines
Quoted 1 line

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for
i.MX8") takes SPL for granted while my patchset currently avoids it.

It looks so, yes.

Quoted 3 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given all
the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW and
change the configuration - for i.MX6, this means RAMS detection, which boot
device is booting, and so on.

Quoted 9 lines

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and
most features are lost (or must be provided by proprietary code). I agree that
on this platform SPL makes less sense, and i.MX8 should be built independently if CONFIG_SPL is set (this is also for i.MX6 / MX5, there are boards without SPL and using the DCD image to set up
the RAM controller).

Quoted 5 lines

The reason we move to use SPL on i.MX8 is that we would like to avoid
bind ATF/OP-TEE/U-Boot into a flat image with hacked offset in an image.

Quoted 3 lines

It seemed I have missed some point. Thanks for clarification. This makes
sense.

OK, I was also not aware of this.

However, currently I am just happy the current tooling kinda works. Which is we can ship stuff to customers and they may use uuu to recover bricked modules. So far nobody is talking about OP-TEE and such advanced use cases yet.

On the other hand enabling SPL currently does not seem to work at all on our hardware. Neither booting from eMMC nor recovering using uuu. That is really the main reason I decided against it at least for now.

Quoted 7 lines
Quoted 6 lines

So the bootflow now is
SPL->ATF->OPTEE->ATF->U-Boot

Without SPL, when generating flash.bin, we have to hack ATF to copy OP-TEE
image from flash.bin to the runtime location.

Quoted 13 lines

Nevertheless, I understand that it is not strictly required to enable OPTEE to boot the kernel, and in some applications a secure zone is not
required. The thing is not that SPL is used here, but to constrain all
other users like Marcel to do the same. With i.MX6, even if I strongly
suggested to do this to allow run time detection, I let boards without
SPL and with just u-boot.imx (with built-in DCD) to flow into mainline -
the board maintainer rules as he knows better where the device is used.

Thanks!

Quoted 3 lines

So I will prefer that the build assume to have SPL just if SPL is configured and not in any case, letting boards without SPL (like this colibri-mx8

Colibri iMX8X that is while on the Apalis family we have the Apalis iMX8 (e.g. with the i.MX 8QuadMax or i.MX 8QuadPlus) and the new Apalis iMX8X with ECC RAM still in the works. Welcome to the i.MX 8 series with the i.MX 8 and i.MX 8X families and careful with NXP's brilliant naming scheme (;-p).

Quoted 1 line

) to build.

Don't worry. I believe I found a fix for the issue at hand and will send a patch shortly.

Quoted 10 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the
universal update utility (uuu) aka mfgtools 3.0.

The usb related function for i.MX8 is not ready now.

That is ok - it s WIP, it will be merged when ready. I agree with you,
this is *not* a reason to avoid SPL.

Agreed. However, it is kinda painful requiring different U-Boot configuration flavours for regular boot vs. recovery. That said we used to previously do this on Apalis/Colibri iMX6 as well so it is definitely no show stopper.

Quoted 5 lines
Quoted 3 lines

we are almost run out
of ocram with SPL DM, thinking to use OF_PLATDATA now, then move to usb functions.

Understood.

Yeah, I also played with OF_PLATDATA once before however was not entirely happy with the result as of yet. I guess WIP patches welcome (;-p).

Quoted 2 lines

Best regards,
Stefano

Cheers

Marcel

#22 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Quoted 95 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Peng and Stefano

Quoted 78 lines · Stefano Babic

Hi Peng,

Quoted 75 lines · Peng Fan

Hi Stefano,

Quoted 72 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Quoted 14 lines · Marcel Ziswiler

Hi Stefano

Quoted 11 lines · Stefano Babic

Hi Marcel,

Quoted 8 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U- Boot supports either booting from the on-module eMMC or

may

Quoted 27 lines
Quoted 27 lines
Quoted 10 lines

be used for recovery purpose using the universal update utility
(uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 8 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

Quoted 1 line

---

I merged the series and build locally (fine), but Travis complains and stops with error:

+cc1: fatal error: opening output file spl/u-boot-spl.cfgout:
No such
file or directory
+compilation terminated.

Quoted 6 lines
Quoted 1 line

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for
i.MX8") takes SPL for granted while my patchset currently avoids it.

It looks so, yes.

Quoted 2 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given all the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW and change the configuration - for i.MX6, this means RAMS detection, which boot device is booting, and so on.

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and most features are lost (or must be provided by proprietary code).
I agree that
on this platform SPL makes less sense, and i.MX8 should be built independently if CONFIG_SPL is set (this is also for i.MX6 / MX5, there are boards without SPL and using the DCD image to set up the RAM controller).

Quoted 7 lines
Quoted 4 lines

The reason we move to use SPL on i.MX8 is that we would like to avoid bind ATF/OP-TEE/U-Boot into a flat image with hacked offset in an image.

It seemed I have missed some point. Thanks for clarification. This makes sense.

OK, I was also not aware of this.

Quoted 8 lines

However, currently I am just happy the current tooling kinda works. Which is we can ship stuff to customers and they may use uuu to recover bricked modules. So far nobody is talking about OP-TEE and such advanced use cases yet.

On the other hand enabling SPL currently does not seem to work at all on our hardware. Neither booting from eMMC nor recovering using uuu. That is really the main reason I decided against it at least for now.

In vendor tree, we use SPL to load i.MX8 container image.
To UUU, 1st need to enable usb gadget functions in SPL, then enable container for the 2nd image. So with uuu, it not work with upstream U-Boot now.

Quoted 28 lines
Quoted 7 lines
Quoted 6 lines

So the bootflow now is
SPL->ATF->OPTEE->ATF->U-Boot

Without SPL, when generating flash.bin, we have to hack ATF to copy OP-TEE image from flash.bin to the runtime location.

Quoted 8 lines

Nevertheless, I understand that it is not strictly required to enable OPTEE to boot the kernel, and in some applications a secure zone is not required. The thing is not that SPL is used here, but to constrain all other users like Marcel to do the same. With i.MX6, even if I strongly suggested to do this to allow run time detection, I let boards without SPL and with just u-boot.imx (with built-in DCD) to flow into mainline - the board maintainer rules as he knows better where the device is used.

Thanks!

Quoted 3 lines

So I will prefer that the build assume to have SPL just if SPL is configured and not in any case, letting boards without SPL (like this colibri-mx8

Colibri iMX8X that is while on the Apalis family we have the Apalis iMX8 (e.g. with the i.MX 8QuadMax or i.MX 8QuadPlus) and the new Apalis iMX8X with ECC RAM still in the works. Welcome to the i.MX 8 series with the i.MX 8 and i.MX 8X families and careful with NXP's brilliant naming scheme (;-p).

Quoted 4 lines
Quoted 1 line

) to build.

Don't worry. I believe I found a fix for the issue at hand and will send a patch shortly.

ok.

Regards,
Peng.

Quoted 29 lines
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Quoted 4 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

The usb related function for i.MX8 is not ready now.

That is ok - it s WIP, it will be merged when ready. I agree with you, this is *not* a reason to avoid SPL.

Agreed. However, it is kinda painful requiring different U-Boot configuration flavours for regular boot vs. recovery. That said we used to previously do this on Apalis/Colibri iMX6 as well so it is definitely no show stopper.

Quoted 5 lines
Quoted 3 lines

we are almost run out
of ocram with SPL DM, thinking to use OF_PLATDATA now, then move to usb functions.

Understood.

Yeah, I also played with OF_PLATDATA once before however was not entirely happy with the result as of yet. I guess WIP patches welcome (;-p).

Quoted 2 lines

Best regards,
Stefano

Cheers

Marcel

#23 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Quoted 123 lines · Peng Fan
Quoted 117 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it
v1.0b module support

Hi Peng and Stefano

Quoted 97 lines · Stefano Babic

Hi Peng,

Quoted 88 lines · Peng Fan

Hi Stefano,

Quoted 75 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp
2gb wb it v1.0b module support

Hi Marcel,

Quoted 18 lines · Marcel Ziswiler

Hi Stefano

Quoted 15 lines · Stefano Babic

Hi Marcel,

Quoted 12 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri
iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are
now strapped to boot from eFuses which are factory fused to
properly boot from their on-module eMMC. U- Boot supports
either booting from the on-module eMMC or

may

Quoted 30 lines
Quoted 30 lines
Quoted 11 lines

be used for recovery purpose using the universal update utility
(uuu) aka mfgtools 3.0.

Functionality wise the following is known to be
working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 9 lines

Unfortunately, there is no USB functionality for the i.MX
8QXP as of yet.

Signed-off-by: Marcel Ziswiler <
marcel.ziswiler at toradex.com

---

I merged the series and build locally (fine), but Travis complains and stops with error:

+cc1: fatal error: opening output file spl/u-boot- spl.cfgout:
No such
file or directory
+compilation terminated.

Quoted 7 lines
Quoted 1 line

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for
i.MX8") takes SPL for granted while my patchset currently avoids
it.

It looks so, yes.

Quoted 3 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given
all the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW
and change the configuration - for i.MX6, this means RAMS detection, which boot device is booting, and so on.

Quoted 10 lines

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and most features are lost (or must be provided by proprietary code).
I agree that
on this platform SPL makes less sense, and i.MX8 should be built
independently if CONFIG_SPL is set (this is also for i.MX6 / MX5, there are boards without SPL and using the DCD image
to set up the RAM controller).

Quoted 5 lines

The reason we move to use SPL on i.MX8 is that we would like to avoid bind ATF/OP-TEE/U-Boot into a flat image with hacked offset in
an image.

Quoted 3 lines

It seemed I have missed some point. Thanks for clarification. This
makes sense.

OK, I was also not aware of this.

However, currently I am just happy the current tooling kinda works. Which is we can ship stuff to customers and they may use uuu to recover
bricked modules. So far nobody is talking about OP-TEE and such advanced
use cases yet.

Quoted 5 lines

On the other hand enabling SPL currently does not seem to work at all on our
hardware. Neither booting from eMMC nor recovering using uuu. That is really the main reason I decided against it at least for now.

Quoted 4 lines

In vendor tree, we use SPL to load i.MX8 container image. To UUU, 1st need to enable usb gadget functions in SPL, then enable container
for the 2nd image. So with uuu, it not work with upstream U-Boot now.

Strange, for me this works just fine with mainline just not with SPL being enabled e.g. as per board/toradex/colibri-imx8qxp/README:

[user at host uuu]$ sudo ./uuu u-boot/u-boot-dtb.imx
uuu (Universal Update Utility) for nxp imx chips -- libuuu_1.2.66-0- ga1a8e69

Success 1 Failure 0

1:33 2/ 2 [Done ] SDPS: done

U-Boot 2019.04-rc4-00169-g42dd45e2d9-dirty (Apr 26 2019 - 11:30:58 +0200)

CPU: NXP i.MX8QXP RevB A35 at 1200 MHz

DRAM:  2 GiB
MMC:   FSL_SDHC: 0, FSL_SDHC: 1

Loading Environment from MMC... *** Warning - bad CRC, using default environment

In:    serial at 5a090000
Out:   serial at 5a090000
Err:   serial at 5a090000
Model: Toradex Colibri iMX8 QuadXPlus 2GB Wi-Fi / BT IT V1.0B, Serial#
06410651
Net:   eth0: ethernet at 5b040000
Hit any key to stop autoboot:  0 

=>

Quoted 81 lines
Quoted 37 lines
Quoted 7 lines
Quoted 6 lines

So the bootflow now is
SPL->ATF->OPTEE->ATF->U-Boot

Without SPL, when generating flash.bin, we have to hack ATF to copy
OP-TEE image from flash.bin to the runtime location.

Quoted 13 lines

Nevertheless, I understand that it is not strictly required to enable
OPTEE to boot the kernel, and in some applications a secure zone is
not required. The thing is not that SPL is used here, but to constrain
all other users like Marcel to do the same. With i.MX6, even if I strongly suggested to do this to allow run time detection, I let boards without SPL and with just u-boot.imx (with built-in DCD) to
flow into mainline - the board maintainer rules as he knows better
where the device is used.

Thanks!

Quoted 4 lines

So I will prefer that the build assume to have SPL just if SPL is configured and not in any case, letting boards without SPL (like this
colibri-mx8

Colibri iMX8X that is while on the Apalis family we have the Apalis iMX8 (e.g. with the i.MX 8QuadMax or i.MX 8QuadPlus) and the new Apalis
iMX8X with ECC RAM still in the works. Welcome to the i.MX 8 series with the
i.MX 8 and i.MX 8X families and careful with NXP's brilliant naming scheme
(;-p).

Quoted 5 lines
Quoted 1 line

) to build.

Don't worry. I believe I found a fix for the issue at hand and will send a patch
shortly.

ok.

Regards,
Peng.

Quoted 33 lines
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

The usb related function for i.MX8 is not ready now.

That is ok - it s WIP, it will be merged when ready. I agree with you,
this is *not* a reason to avoid SPL.

Agreed. However, it is kinda painful requiring different U-Boot configuration
flavours for regular boot vs. recovery. That said we used to previously do this
on Apalis/Colibri iMX6 as well so it is definitely no show stopper.

Quoted 6 lines
Quoted 4 lines

we are almost run out
of ocram with SPL DM, thinking to use OF_PLATDATA now, then move to
usb functions.

Understood.

Yeah, I also played with OF_PLATDATA once before however was not entirely
happy with the result as of yet. I guess WIP patches welcome (;-p).

Quoted 2 lines

Best regards,
Stefano

Cheers

Marcel

#24 lore raw

PATCH v2 5/5 board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Quoted 123 lines

-----Original Message-----
From: Marcel Ziswiler [mailto:marcel.ziswiler at toradex.com]
Sent: 2019年4月26日 17:38
To: Peng Fan <[email protected]>; u-boot at lists.denx.de; sbabic at denx.de
Cc: siva.durga.paladugu at xilinx.com; marek.vasut+renesas at gmail.com; maxime.ripard at bootlin.com; festevam at gmail.com;
michal.simek at xilinx.com; wens at csie.org; dl-uboot-imx <[email protected]>; yamada.masahiro at socionext.com; sr at denx.de; jagan at amarulasolutions.com; agust at denx.de; albert.u.boot at aribaud.net
Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Quoted 108 lines · Peng Fan
Quoted 107 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Peng and Stefano

Quoted 80 lines · Stefano Babic

Hi Peng,

Quoted 77 lines · Peng Fan

Hi Stefano,

Quoted 74 lines

Subject: Re: [PATCH v2 5/5] board: toradex: add colibri imx8qxp 2gb wb it v1.0b module support

Hi Marcel,

Quoted 14 lines · Marcel Ziswiler

Hi Stefano

Quoted 11 lines · Stefano Babic

Hi Marcel,

Quoted 8 lines · Marcel Ziswiler

From: Marcel Ziswiler <[email protected]>

This commit adds initial support for the Toradex Colibri iMX8QXP 2GB WB IT V1.0B module. Unlike the V1.0A early access samples exclusively booting from SD card, they are now strapped to boot from eFuses which are factory fused to properly boot from their on-module eMMC. U- Boot supports either booting from the on-module eMMC or

may

Quoted 29 lines
Quoted 29 lines
Quoted 11 lines

be used for recovery purpose using the universal update utility
(uuu) aka mfgtools 3.0.

Functionality wise the following is known to be working:
- eMMC and MMC/SD card
- Ethernet
- GPIOs
- I2C

Quoted 8 lines

Unfortunately, there is no USB functionality for the i.MX 8QXP as of yet.

Signed-off-by: Marcel Ziswiler <
marcel.ziswiler at toradex.com

---

I merged the series and build locally (fine), but Travis complains and stops with error:

+cc1: fatal error: opening output file spl/u-boot- spl.cfgout:
No such
file or directory
+compilation terminated.

Quoted 6 lines
Quoted 1 line

Can you take a look at it ?

Sure, looks like Peng's commit caceb739ea07 ("imx: build flash.bin for
i.MX8") takes SPL for granted while my patchset currently avoids it.

It looks so, yes.

Quoted 2 lines

BTW: I still don't believe SPL makes much sense on i.MX 8X given all the other proprietary parts involved in booting.

SPL makes more sense if it is possible to detect at runtime the HW and change the configuration - for i.MX6, this means RAMS detection, which boot device is booting, and so on.

On i.MX8 there is a lot of proprietary parts - we lose the flexibility of SPL, and most features are lost (or must be provided by proprietary code).
I agree that
on this platform SPL makes less sense, and i.MX8 should be built independently if CONFIG_SPL is set (this is also for i.MX6 / MX5, there are boards without SPL and using the DCD image to set up the RAM controller).

Quoted 8 lines
Quoted 4 lines

The reason we move to use SPL on i.MX8 is that we would like to avoid bind ATF/OP-TEE/U-Boot into a flat image with hacked offset in an image.

It seemed I have missed some point. Thanks for clarification. This
makes sense.

OK, I was also not aware of this.

However, currently I am just happy the current tooling kinda works. Which is we can ship stuff to customers and they may use uuu to recover bricked modules. So far nobody is talking about OP-TEE and such advanced use cases yet.

On the other hand enabling SPL currently does not seem to work at all on our hardware. Neither booting from eMMC nor recovering using uuu.
That is really the main reason I decided against it at least for now.

Quoted 6 lines
Quoted 4 lines

In vendor tree, we use SPL to load i.MX8 container image. To UUU, 1st need to enable usb gadget functions in SPL, then enable container for the 2nd image. So with uuu, it not work with upstream U-Boot now.

Strange, for me this works just fine with mainline just not with SPL being

For flash.bin with SPL, UUU will not work for upstream uboot to load 2nd images. For flash.bin without SPL, UUU will able to work. So it works for you.

Regards,
Peng.

Quoted 97 lines

enabled e.g. as per board/toradex/colibri-imx8qxp/README:

[user at host uuu]$ sudo ./uuu u-boot/u-boot-dtb.imx uuu (Universal Update Utility) for nxp imx chips -- libuuu_1.2.66-0-
ga1a8e69

Success 1 Failure 0

1:33 2/ 2 [Done ] SDPS: done

U-Boot 2019.04-rc4-00169-g42dd45e2d9-dirty (Apr 26 2019 - 11:30:58 +0200)

CPU: NXP i.MX8QXP RevB A35 at 1200 MHz

DRAM:  2 GiB
MMC:   FSL_SDHC: 0, FSL_SDHC: 1

Loading Environment from MMC... *** Warning - bad CRC, using default environment

In:    serial at 5a090000
Out:   serial at 5a090000
Err:   serial at 5a090000
Model: Toradex Colibri iMX8 QuadXPlus 2GB Wi-Fi / BT IT V1.0B, Serial#
06410651
Net:   eth0: ethernet at 5b040000
Hit any key to stop autoboot:  0

=>

Quoted 68 lines
Quoted 28 lines
Quoted 6 lines
Quoted 5 lines

So the bootflow now is
SPL->ATF->OPTEE->ATF->U-Boot

Without SPL, when generating flash.bin, we have to hack ATF to copy OP-TEE image from flash.bin to the runtime location.

Quoted 8 lines

Nevertheless, I understand that it is not strictly required to enable OPTEE to boot the kernel, and in some applications a secure zone is not required. The thing is not that SPL is used here, but to constrain all other users like Marcel to do the same. With i.MX6, even if I strongly suggested to do this to allow run time detection, I let boards without SPL and with just u-boot.imx (with built-in DCD) to flow into mainline - the board maintainer rules as he knows better where the device is used.

Thanks!

Quoted 4 lines

So I will prefer that the build assume to have SPL just if SPL is configured and not in any case, letting boards without SPL (like this
colibri-mx8

Colibri iMX8X that is while on the Apalis family we have the Apalis iMX8 (e.g. with the i.MX 8QuadMax or i.MX 8QuadPlus) and the new Apalis iMX8X with ECC RAM still in the works. Welcome to the i.MX 8 series with the i.MX 8 and i.MX 8X families and careful with NXP's brilliant naming scheme (;-p).

Quoted 4 lines
Quoted 1 line

) to build.

Don't worry. I believe I found a fix for the issue at hand and will send a patch shortly.

ok.

Regards,
Peng.

Quoted 30 lines
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines

Plus currently SPL
actually breaks the USB serial downloader aka recovery mode using the universal update utility (uuu) aka mfgtools 3.0.

The usb related function for i.MX8 is not ready now.

That is ok - it s WIP, it will be merged when ready. I agree with you, this is *not* a reason to avoid SPL.

Agreed. However, it is kinda painful requiring different U-Boot configuration flavours for regular boot vs. recovery. That said we used to previously do this on Apalis/Colibri iMX6 as well so it is definitely no show stopper.

Quoted 5 lines
Quoted 3 lines

we are almost run out
of ocram with SPL DM, thinking to use OF_PLATDATA now, then move to usb functions.

Understood.

Yeah, I also played with OF_PLATDATA once before however was not entirely happy with the result as of yet. I guess WIP patches welcome (;-p).

Quoted 2 lines

Best regards,
Stefano

Cheers

Marcel