examples/vm_power_manager: fix string null termination
PATCH 1/1 examples/vm_power_manager: fix string null termination
After the read() the jason_data null termination is missing for the case "indent < 0", for "indent > 0" and "indent == 0" cases null termination is already handled.
So add the missing case "indent < 0" to the existing "indent == 0" case to fix null termination.
Coverity issue: 337680
--- examples/vm_power_manager/channel_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
examples/vm_power_manager/channel_monitor.c +1 -1
@@ -807,7 +807,7 @@ read_json_packet(struct channel_info *chan_info) indent--;if ((indent >0 ) || (idx >0 )) idx++; -if (indent ==0 ) +if (indent <=0 ) json_data[idx] =0 ;if (idx >=MAX_JSON_STRING_LEN -1 )break ;
Signature · 1 line
2.17.1
Quoted 22 lines · Reshma Pattan
After the
read()thejason_datanull termination is missing for the case "indent < 0", for "indent > 0" and "indent == 0" cases null termination is already handled.So add the missing case "indent < 0" to the existing "indent == 0" case to fix null termination.
Coverity issue: 337680
Fixes a63504a90f ("examples/power: add JSON string handling")Signed-off-by Reshma Pattan <[email protected]>--- examples/vm_power_manager/channel_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)examples/vm_power_manager/channel_monitor.c +0
-0
examples/vm_power_manager/channel_monitor.c read_json_packet(struct channel_info *chan_info) · line 813
Quoted 8 lines
examples/vm_power_manager/channel_monitor.c +1
-1@@ -807,7 +807,7 @@ read_json_packet(struct channel_info *chan_info) indent--;if ((indent >0 ) || (idx >0 )) idx++; -if (indent ==0 ) +if (indent <=0 ) json_data[idx] =0 ;if (idx >=MAX_JSON_STRING_LEN -1 )break ;
Thomas Monjalon
Applied15/04/2019 16:50, Hunt, David:
Quoted 8 lines · Reshma Pattan
Quoted 7 lines
After the
read()thejason_datanull termination is missing for the case "indent < 0", for "indent > 0" and "indent == 0" cases null termination is already handled.So add the missing case "indent < 0" to the existing "indent == 0" case to fix null termination.
Quoted 8 lines
Quoted 6 lines
Coverity issue: 337680
Fixes a63504a90f ("examples/power: add JSON string handling")Signed-off-by Reshma Pattan <[email protected]>Acked-by David Hunt <[email protected]>
Applied, thanks