cpufreq: Add sunxi nvmem based CPU scaling driver
Subsystems (4)
v2 cover cpufreq: Add sunxi nvmem based CPU scaling driver
Add sunxi nvmem based CPU scaling driver, refers to qcom-cpufreq-kryo.
Yangtao Li (2):
cpufreq: Add sunxi nvmem based CPU scaling driver
dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
.../bindings/opp/sunxi-nvmem-cpufreq.txt | 166 +++++++++++++ MAINTAINERS | 7 + drivers/cpufreq/Kconfig.arm | 10 + drivers/cpufreq/Makefile | 1 + drivers/cpufreq/cpufreq-dt-platdev.c | 2 + drivers/cpufreq/sunxi-cpufreq-nvmem.c | 234 ++++++++++++++++++ 6 files changed, 420 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt create mode 100644 drivers/cpufreq/sunxi-cpufreq-nvmem.c
---
v2:
-update changelog
-convert to dev_pm_opp_set_prop_name use instead of dev_pm_opp_set_supported_hw -some change in OPP Node
---
2.17.0
PATCH v2 1/2 cpufreq: Add sunxi nvmem based CPU scaling driver
For some SoCs, the CPU frequency subset and voltage value of each OPP varies based on the silicon variant in use. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
--- MAINTAINERS | 7 + drivers/cpufreq/Kconfig.arm | 10 ++ drivers/cpufreq/Makefile | 1 + drivers/cpufreq/cpufreq-dt-platdev.c | 2 + drivers/cpufreq/sunxi-cpufreq-nvmem.c | 234 ++++++++++++++++++++++++++ 5 files changed, 254 insertions(+) create mode 100644 drivers/cpufreq/sunxi-cpufreq-nvmem.c
MAINTAINERS +7 -0
@@ -667,6 +667,13 @@ S: Maintained F: Documentation/i2c/busses/i2c-ali1563 F: drivers/i2c/busses/i2c-ali1563.c +ALLWINNER CPUFREQ DRIVER +M: Yangtao Li <[email protected]> +L: [email protected] +S: Maintained +F: Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt +F: drivers/cpufreq/sunxi-cpufreq-nvmem.c + ALLWINNER SECURITY SYSTEM M: Corentin Labbe <[email protected]> L: [email protected]
drivers/cpufreq/Kconfig.arm +10 -0
@@ -18,6 +18,16 @@ config ACPI_CPPC_CPUFREQ If in doubt, say N. +config ARM_ALLWINNER_CPUFREQ_NVMEM + tristate "Allwinner nvmem based CPUFreq" + depends on ARCH_SUNXI + depends on NVMEM_SUNXI_SID + select PM_OPP + help + This adds the CPUFreq driver for Allwinner nvmem based SoC. + + If in doubt, say N. + config ARM_ARMADA_37XX_CPUFREQ tristate "Armada 37xx CPUFreq support" depends on ARCH_MVEBU && CPUFREQ_DT
drivers/cpufreq/Makefile +1 -0
@@ -78,6 +78,7 @@ obj-$(CONFIG_ARM_SCMI_CPUFREQ) += scmi-cpufreq.o obj-$(CONFIG_ARM_SCPI_CPUFREQ) += scpi-cpufreq.o obj-$(CONFIG_ARM_SPEAR_CPUFREQ) += spear-cpufreq.o obj-$(CONFIG_ARM_STI_CPUFREQ) += sti-cpufreq.o +obj-$(CONFIG_ARM_ALLWINNER_CPUFREQ_NVMEM) += sunxi-cpufreq-nvmem.o obj-$(CONFIG_ARM_TANGO_CPUFREQ) += tango-cpufreq.o obj-$(CONFIG_ARM_TEGRA20_CPUFREQ) += tegra20-cpufreq.o obj-$(CONFIG_ARM_TEGRA124_CPUFREQ) += tegra124-cpufreq.o
drivers/cpufreq/cpufreq-dt-platdev.c +2 -0
@@ -105,6 +105,8 @@ static const struct of_device_id whitelist[] __initconst = {* platforms using "operating-points-v2" property. */ static const struct of_device_id blacklist[]__initconst = { + { .compatible ="allwinner,sun50i-h6" , }, + { .compatible ="calxeda,highbank" , }, { .compatible ="calxeda,ecx-2000" , },
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +234 -0
234 lines not on this page · raw message
Signature · 1 line
2.17.0
Viresh Kumar
maintainerQuoted 13 lines · Yangtao Li
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +13
-0+static const struct sunxi_cpufreq_soc_data sun50i_h6_data = { + .efuse_xlate = sun50i_efuse_xlate, + .nvmem_mask =0x7 , + .nvmem_shift =5 , +}; + +static const struct of_device_id sunxi_cpufreq_match_list[] = { + { .compatible ="allwinner,sun50i-h6" , .data = &sun50i_h6_data }, + {} +}; + +static const struct of_device_id *sunxi_cpufreq_match_node (void ) +{
drivers/cpufreq/sunxi-cpufreq-nvmem.c line 110
Quoted 10 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +10
-0+struct device_node *np; +const struct of_device_id *match; + + np =of_find_node_by_path ("/" ); + match =of_match_node (sunxi_cpufreq_match_list, np); +of_node_put (np); + +return match; +} +
Above code can be placed just above sunxi_cpufreq_init(), if you ...
Quoted 6 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +6
-0+static int sunxi_cpufreq_nvmem_probe (struct platform_device *pdev) +{ +const struct sunxi_cpufreq_soc_data *soc_data; +struct opp_table **opp_tables; +const struct of_device_id *match; +char name[MAX_NAME_LEN ];
drivers/cpufreq/sunxi-cpufreq-nvmem.c line 126
Quoted 10 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +10
-0+unsigned int cpu; +u32 speed =0 ; +int ret; + + opp_tables =kcalloc (num_possible_cpus (),sizeof (*opp_tables), +GFP_KERNEL ); +if (!opp_tables) +return -ENOMEM ; + + match =sunxi_cpufreq_match_node ();
... avoid this and ...
Quoted 80 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +80
-0+ soc_data = match->data; +if (!soc_data) +return -EINVAL ; + + ret =sunxi_cpufreq_get_efuse (soc_data, &speed); +if (ret) +return ret; + +snprintf (name,MAX_NAME_LEN ,"speed%d" , speed); + +for_each_possible_cpu (cpu) { +struct device *cpu_dev =get_cpu_device (cpu); + +if (NULL == cpu_dev) { + ret = -ENODEV ; + goto free_opp; + } + + opp_tables[cpu] =dev_pm_opp_set_prop_name (cpu_dev, name); +if (IS_ERR (opp_tables[cpu])) { + ret =PTR_ERR (opp_tables[cpu]); +pr_err ("Failed to set prop name\n" ); + goto free_opp; + } + } + + cpufreq_dt_pdev =platform_device_register_simple ("cpufreq-dt" ,-1 , +NULL ,0 ); +if (!IS_ERR (cpufreq_dt_pdev)) { +platform_set_drvdata (pdev, opp_tables); +return 0 ; + } + + ret =PTR_ERR (cpufreq_dt_pdev); +pr_err ("Failed to register platform device\n" ); + +free_opp: +for_each_possible_cpu (cpu) { +if (IS_ERR_OR_NULL (opp_tables[cpu])) +break ; +dev_pm_opp_put_prop_name (opp_tables[cpu]); + } +kfree (opp_tables); + +return ret; +} + +static int sunxi_cpufreq_nvmem_remove (struct platform_device *pdev) +{ +struct opp_table **opp_tables =platform_get_drvdata (pdev); +unsigned int cpu; + +platform_device_unregister (cpufreq_dt_pdev); + +for_each_possible_cpu (cpu) +dev_pm_opp_put_prop_name (opp_tables[cpu]); + +kfree (opp_tables); + +return 0 ; +} + +static struct platform_driver sunxi_cpufreq_driver = { + .probe = sunxi_cpufreq_nvmem_probe, + .remove = sunxi_cpufreq_nvmem_remove, + .driver = { + .name ="sunxi-cpufreq-nvmem" , + }, +}; + +/* +* Since the driver depends on nvmem drivers, which may return EPROBE_DEFER, +* all the real activity is done in the probe, which may be defered as well. +* The init here is only registering the driver and the platform device. +*/ +static int __init sunxi_cpufreq_init (void ) +{ +const struct of_device_id *match; +int ret; +
drivers/cpufreq/sunxi-cpufreq-nvmem.c line 216
Quoted 10 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +10
-0+ match =sunxi_cpufreq_match_node (); +if (!match) +return -ENODEV ; + + ret =platform_driver_register (&sunxi_cpufreq_driver); +if (unlikely (ret <0 )) +return ret; + + sunxi_cpufreq_pdev =platform_device_register_simple ( +"sunxi-cpufreq-nvmem" ,-1 ,NULL ,0 );
... pass match->data as platform device's data here..
Quoted 20 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +18
-0+ ret =PTR_ERR_OR_ZERO (sunxi_cpufreq_pdev); +if (0 == ret) +return 0 ; + +platform_driver_unregister (&sunxi_cpufreq_driver); +return ret; +} +module_init (sunxi_cpufreq_init); + +static void __exit sunxi_cpufreq_exit(void) +{ +platform_device_unregister (sunxi_cpufreq_pdev); +platform_driver_unregister (&sunxi_cpufreq_driver); +} +module_exit (sunxi_cpufreq_exit); + +MODULE_DESCRIPTION ("Sunxi cpufreq driver" ); +MODULE_LICENSE ("GPL v2" );Signature · 1 line
2.17.0
Signature · 1 line
viresh
Quoted 131 lines · Viresh Kumar
Quoted 13 lines · Yangtao Li
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +13
-0+static const struct sunxi_cpufreq_soc_data sun50i_h6_data = { + .efuse_xlate = sun50i_efuse_xlate, + .nvmem_mask =0x7 , + .nvmem_shift =5 , +}; + +static const struct of_device_id sunxi_cpufreq_match_list[] = { + { .compatible ="allwinner,sun50i-h6" , .data = &sun50i_h6_data }, + {} +}; + +static const struct of_device_id *sunxi_cpufreq_match_node (void ) +{drivers/cpufreq/sunxi-cpufreq-nvmem.c line 110
Quoted 10 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +10
-0+struct device_node *np; +const struct of_device_id *match; + + np =of_find_node_by_path ("/" ); + match =of_match_node (sunxi_cpufreq_match_list, np); +of_node_put (np); + +return match; +} +Above code can be placed just above
sunxi_cpufreq_init(), if you ...Quoted 6 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +6
-0+static int sunxi_cpufreq_nvmem_probe (struct platform_device *pdev) +{ +const struct sunxi_cpufreq_soc_data *soc_data; +struct opp_table **opp_tables; +const struct of_device_id *match; +char name[MAX_NAME_LEN ];drivers/cpufreq/sunxi-cpufreq-nvmem.c line 126
Quoted 10 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +10
-0+unsigned int cpu; +u32 speed =0 ; +int ret; + + opp_tables =kcalloc (num_possible_cpus (),sizeof (*opp_tables), +GFP_KERNEL ); +if (!opp_tables) +return -ENOMEM ; + + match =sunxi_cpufreq_match_node ();... avoid this and ...
Quoted 84 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +84
-0+ soc_data = match->data; +if (!soc_data) +return -EINVAL ; + + ret =sunxi_cpufreq_get_efuse (soc_data, &speed); +if (ret) +return ret; + +snprintf (name,MAX_NAME_LEN ,"speed%d" , speed); + +for_each_possible_cpu (cpu) { +struct device *cpu_dev =get_cpu_device (cpu); + +if (NULL == cpu_dev) { + ret = -ENODEV ; + goto free_opp; + } + + opp_tables[cpu] =dev_pm_opp_set_prop_name (cpu_dev, name); +if (IS_ERR (opp_tables[cpu])) { + ret =PTR_ERR (opp_tables[cpu]); +pr_err ("Failed to set prop name\n" ); + goto free_opp; + } + } + + cpufreq_dt_pdev =platform_device_register_simple ("cpufreq-dt" ,-1 , +NULL ,0 ); +if (!IS_ERR (cpufreq_dt_pdev)) { +platform_set_drvdata (pdev, opp_tables); +return 0 ; + } + + ret =PTR_ERR (cpufreq_dt_pdev); +pr_err ("Failed to register platform device\n" ); + +free_opp: +for_each_possible_cpu (cpu) { +if (IS_ERR_OR_NULL (opp_tables[cpu])) +break ; +dev_pm_opp_put_prop_name (opp_tables[cpu]); + } +kfree (opp_tables); + +return ret; +} + +static int sunxi_cpufreq_nvmem_remove (struct platform_device *pdev) +{ +struct opp_table **opp_tables =platform_get_drvdata (pdev); +unsigned int cpu; + +platform_device_unregister (cpufreq_dt_pdev); + +for_each_possible_cpu (cpu) +dev_pm_opp_put_prop_name (opp_tables[cpu]); + +kfree (opp_tables); + +return 0 ; +} + +static struct platform_driver sunxi_cpufreq_driver = { + .probe = sunxi_cpufreq_nvmem_probe, + .remove = sunxi_cpufreq_nvmem_remove, + .driver = { + .name ="sunxi-cpufreq-nvmem" , + }, +}; + +/* +* Since the driver depends on nvmem drivers, which may return EPROBE_DEFER, +* all the real activity is done in the probe, which may be defered as well. +* The init here is only registering the driver and the platform device. +*/ +static int __init sunxi_cpufreq_init (void ) +{ +const struct of_device_id *match; +int ret; + + match =sunxi_cpufreq_match_node (); +if (!match) +return -ENODEV ; +
Quoted 8 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c line 216
Quoted 6 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +6
-0+ ret =platform_driver_register (&sunxi_cpufreq_driver); +if (unlikely (ret <0 )) +return ret; + + sunxi_cpufreq_pdev =platform_device_register_simple ( +"sunxi-cpufreq-nvmem" ,-1 ,NULL ,0 );... pass
match->dataas platform device's data here..
Yead, it is.
Thanks,
Yangtao
Quoted 24 lines
Quoted 20 lines
drivers/cpufreq/sunxi-cpufreq-nvmem.c new file +18
-1+ ret =PTR_ERR_OR_ZERO (sunxi_cpufreq_pdev); +if (0 == ret) +return 0 ; + +platform_driver_unregister (&sunxi_cpufreq_driver); +return ret; +} +module_init (sunxi_cpufreq_init); + +static void __exit sunxi_cpufreq_exit(void) +{ +platform_device_unregister (sunxi_cpufreq_pdev); +platform_driver_unregister (&sunxi_cpufreq_driver); +} +module_exit (sunxi_cpufreq_exit); + +MODULE_DESCRIPTION ("Sunxi cpufreq driver" ); +MODULE_LICENSE ("GPL v2" ); --Quoted 1 line
2.17.0
--
viresh
PATCH v2 2/2 dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
In reply to Yangtao LiAllwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.
The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-microvolt-<name>: voltage in micro Volts.
At runtime, the platform can pick a <name> and matching opp-microvolt-<name> property
--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 166 ++++++++++++++++++ 1 file changed, 166 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +166 -0
@@ -0,0 +1,166 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with +required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'. +- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cells + bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-microvolt-<name>: Voltage in micro Volts. + At runtime, the platform can pick a <name> and + matching opp-microvolt-<name> property. + [See: opp.txt] + +Example 1: +--------- + + cpus { + #address-cells = <1>; + #size-cells = <0>; + + cpu0: cpu@0 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <0>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu1: cpu@1 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <1>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu2: cpu@2 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <2>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + + cpu3: cpu@3 { + compatible = "arm,cortex-a53"; + device_type = "cpu"; + reg = <3>; + enable-method = "psci"; + clocks = <&ccu CLK_CPUX>; + clock-latency-ns = <244144>; /* 8 32k periods */ + operating-points-v2 = <&cpu_opp_table>; + #cooling-cells = <2>; + }; + }; + + cpu_opp_table: opp_table { + compatible = "operating-points-v2-sunxi-cpu"; + nvmem-cells = <&speedbin_efuse>; + opp-shared; + + opp@480000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <480000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <800000>; + }; + + opp@720000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <720000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <800000>; + }; + + opp@816000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <816000000>; + + opp-microvolt-speed0 = <880000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <800000>; + }; + + opp@888000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <888000000>; + + opp-microvolt-speed0 = <940000>; + opp-microvolt-speed1 = <820000>; + opp-microvolt-speed2 = <800000>; + }; + + opp@1080000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1080000000>; + + opp-microvolt-speed0 = <1060000>; + opp-microvolt-speed1 = <880000>; + opp-microvolt-speed2 = <840000>; + }; + + opp@1320000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1320000000>; + + opp-microvolt-speed0 = <1160000>; + opp-microvolt-speed1 = <940000>; + opp-microvolt-speed2 = <900000>; + }; + + opp@1488000000 { + clock-latency-ns = <244144>; /* 8 32k periods */ + opp-hz = /bits/ 64 <1488000000>; + + opp-microvolt-speed0 = <1160000>; + opp-microvolt-speed1 = <1000000>; + opp-microvolt-speed2 = <960000>; + }; + }; +.... +soc { +.... + sid: sid@3006000 { + compatible = "allwinner,sun50i-h6-sid"; + reg = <0x03006000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + .... + speedbin_efuse: speed@1c { + reg = <0x1c 4>; + }; + }; +};
Signature · 1 line
2.17.0
Viresh Kumar
maintainerRe: [PATCH v2 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
Quoted 14 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-microvolt-<name>: voltage in micro Volts.
At runtime, the platform can pick a <name> and matching opp-microvolt-<name> property
Quoted 5 lines
Signed-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 166 ++++++++++++++++++ 1 file changed, 166 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt
LGTM.
Signature · 1 line
viresh
Re: [PATCH v2 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
In reply to Yangtao LiQuoted 34 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-microvolt-<name>: voltage in micro Volts.
At runtime, the platform can pick a <name> and matching opp-microvolt-<name> propertySigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 166 ++++++++++++++++++ 1 file changed, 166 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +8
-0@@ -0,0 +1,166 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework with
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 18
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'.
Vendor-specific compatibles should have the vendor mentionned.
Also, even though the H6 is the only SoC so far that has needed this, we can't really assume that it will be the only SoC to use it, or that it will always behave like that.
So having something like allwinner,sun50i-h6-operating-points would be great.
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 31
Quoted 13 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +13
-0+- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltage + value pair. + Please refer the for nvmem-cells + bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-microvolt-<name>: Voltage in micro Volts. + At runtime, the platform can pick a <name> and + matching opp-microvolt-<name> property. + [See: opp.txt]
You need to document the valid names here.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Re: [PATCH v2 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
Quoted 49 lines · Maxime Ripard
Quoted 34 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-microvolt-<name>: voltage in micro Volts.
At runtime, the platform can pick a <name> and matching opp-microvolt-<name> propertySigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 166 ++++++++++++++++++ 1 file changed, 166 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +8
-0@@ -0,0 +1,166 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework withDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 18
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'.Vendor-specific compatibles should have the vendor mentionned.
Quoted 3 lines
Also, even though the H6 is the only SoC so far that has needed this, we can't really assume that it will be the only SoC to use it, or that it will always behave like that.
There is no doubt that many platforms need this.
Quoted 3 lines
So having something like allwinner,sun50i-h6-operating-points would be great.
allwinner,cpu-operating-points-v2 Maybe better?
Quoted 16 lines
Quoted 4 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +3
-0+- nvmem-cells: A phandle pointing to a nvmem-cells node representing the + efuse registers that has information about the + speedbin that is used to select the right frequency/voltageDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 31
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+ value pair. + Please refer the for nvmem-cells + bindings Documentation/devicetree/bindings/nvmem/nvmem.txt + and also examples below. + +In every OPP node: +- opp-microvolt-<name>: Voltage in micro Volts. + At runtime, the platform can pick a <name> and + matching opp-microvolt-<name> property. + [See: opp.txt]You need to document the valid names here.
OK.
Cheers,
Yangtao
Re: [PATCH v2 2/2] dt-bindings: cpufreq: Document operating-points-v2-sunxi-cpu
Quoted 51 lines · Frank Lee
Quoted 49 lines · Maxime Ripard
Quoted 34 lines · Yangtao Li
Allwinner Process Voltage Scaling Tables defines the voltage and frequency value based on the speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver reads the efuse value from the SoC to provide the OPP framework with required information.
This is used to determine the voltage and frequency value for each OPP of operating-points-v2 table when it is parsed by the OPP framework.The "operating-points-v2-sunxi-cpu" DT extends the "operating-points-v2" with following parameters:
- nvmem-cells (NVMEM area containig the speedbin information)
- opp-microvolt-<name>: voltage in micro Volts.
At runtime, the platform can pick a <name> and matching opp-microvolt-<name> propertySigned-off-by Yangtao Li <[email protected]>--- .../bindings/opp/sunxi-nvmem-cpufreq.txt | 166 ++++++++++++++++++ 1 file changed, 166 insertions(+) create mode 100644 Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txtDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +8
-0@@ -0,0 +1,166 @@ +Allwinner Technologies, Inc. NVMEM CPUFreq and OPP bindings +=================================== + +For some SoCs, the CPU frequency subset and voltage value of each OPP +varies based on the silicon variant in use. Allwinner Process Voltage +Scaling Tables defines the voltage and frequency value based on the +speedbin blown in the efuse combination. The sunxi-cpufreq-nvmem driver +reads the efuse value from the SoC to provide the OPP framework withDocumentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt line 18
Quoted 10 lines
Documentation/devicetree/bindings/opp/sunxi-nvmem-cpufreq.txt new file +10
-0+required information. + +Required properties: +-------------------- +In 'cpus' nodes: +- operating-points-v2: Phandle to the operating-points-v2 table to use. + +In 'operating-points-v2' table: +- compatible: Should be + - 'operating-points-v2-sunxi-cpu'.Vendor-specific compatibles should have the vendor mentionned.
Quoted 5 lines
Quoted 3 lines
Also, even though the H6 is the only SoC so far that has needed this, we can't really assume that it will be the only SoC to use it, or that it will always behave like that.
There is no doubt that many platforms need this.
That many platform *may* need this, yeah, sure. We can probably even share the same driver for them.
That all of those theretical platform will have the exact same behaviour, down to how the data is stored in the nvmem, and how many bins you have? I seriously doubt so.
Quoted 3 lines
Quoted 2 lines
So having something like allwinner,sun50i-h6-operating-points would be great.
allwinner,cpu-operating-points-v2 Maybe better?
No. You need to have the SoC name in there, and you can drop the v2. There's never been a v1.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com