Skip to contentSkip to conversation

Add PCIe support to EK874

PATCH New Fabrizio Castro 2 participants 8 messages Mar 29, 2019 – Apr 12, 2019

lore
Share & tools
lore
#0 lore raw

cover Add PCIe support to EK874

Dear All,

This series adds PCIe support to the EK874 board.

Thanks,
Fab

Biju Das (2):
arm64: dts: renesas: r8a774c0-cat874: Add pciec0 support
arm64: dts: renesas: cat875: Enable PCIe support

Fabrizio Castro (2):
dt-bindings: PCI: rcar: Add device tree support for r8a774c0
arm64: dts: renesas: r8a774c0: Add PCIe device node

 Documentation/devicetree/bindings/pci/rcar-pci.txt |  4 +++-
 arch/arm64/boot/dts/renesas/cat875.dtsi            |  4 ++++
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts    |  9 ++++++++
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi          | 27 ++++++++++++++++++++++
 4 files changed, 43 insertions(+), 1 deletion(-)
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/4 dt-bindings: PCI: rcar: Add device tree support for r8a774c0

Add PCIe support for the RZ/G2E (a.k.a. R8A774C0).

(cherry picked from commit 2e2b7615e310994b4d59c98b7d114449a9f019e5)
---
 Documentation/devicetree/bindings/pci/rcar-pci.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/pci/rcar-pci.txt +3 -1
index a5f7fc6..fac07a4 100644
@@ -2,6 +2,7 @@
 
 Required properties:
 compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
+	    "renesas,pcie-r8a774c0" for the R8A774C0 SoC;
 	    "renesas,pcie-r8a7779" for the R8A7779 SoC;
 	    "renesas,pcie-r8a7790" for the R8A7790 SoC;
 	    "renesas,pcie-r8a7791" for the R8A7791 SoC;
@@ -11,7 +12,8 @@ compatible: "renesas,pcie-r8a7743" for the R8A7743 SoC;
 	    "renesas,pcie-r8a77980" for the R8A77980 SoC;
 	    "renesas,pcie-rcar-gen2" for a generic R-Car Gen2 or
 				     RZ/G1 compatible device.
-	    "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 compatible device.
+	    "renesas,pcie-rcar-gen3" for a generic R-Car Gen3 or
+				     RZ/G2 compatible device.
 
 	    When compatible with the generic version, nodes must list the
 	    SoC-specific version corresponding to the platform first
Signature · 1 line
2.7.4
#2 lore raw

PATCH 1/4 dt-bindings: PCI: rcar: Add device tree support for r8a774c0

Quoted 2 lines · Fabrizio Castro

Add PCIe support for the RZ/G2E (a.k.a. R8A774C0).

This does not apply.

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

#3 lore raw

PATCH 1/4 dt-bindings: PCI: rcar: Add device tree support for r8a774c0

Hello Pavel,

Thank you for your feedback.

Quoted 7 lines

-----Original Message-----
From: Pavel Machek <[email protected]>
Sent: 09 April 2019 21:56
To: Fabrizio Castro <[email protected]>
Cc: cip-dev at lists.cip-project.org; Biju Das <[email protected]>
Subject: Re: [cip-dev] [PATCH 4.19.y 1/4] dt-bindings: PCI: rcar: Add device tree support for r8a774c0

Quoted 5 lines
Quoted 2 lines · Fabrizio Castro

Add PCIe support for the RZ/G2E (a.k.a. R8A774C0).

This does not apply.

This applies for me. Perhaps your are trying to apply this to a different branch?
I have just managed to apply this cleanly on top of linux-4.19.y-cip, I am told that specifying 4.19.y in the patch description should suffice in describing where the patch should go, perhaps you have a different understanding?

Thanks,
Fab

Quoted 4 lines

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

#4 lore raw

PATCH 1/4 dt-bindings: PCI: rcar: Add device tree support for r8a774c0

In reply to Fabrizio Castro
Quoted 9 lines · Fabrizio Castro

Add PCIe support for the RZ/G2E (a.k.a. R8A774C0).

(cherry picked from commit 2e2b7615e310994b4d59c98b7d114449a9f019e5)

Thanks, I applied the series.
Pavel

Signature · 9 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20190412/3d606f0a/attachment.sig>
#5 lore raw

PATCH 2/4 arm64: dts: renesas: r8a774c0: Add PCIe device node

In reply to Fabrizio Castro

This patch adds PCI express channel 0 device tree node to the RZ/G2E (a.k.a. R8A774C0) SoC dtsi.

(cherry picked from commit f0c2aa1664a2ea6d05ca58fd35767aa0c22dd97e)
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
arch/arm64/boot/dts/renesas/r8a774c0.dtsi +27 -0
index 96a71e3..398b190 100644
@@ -656,6 +656,33 @@
 			resets = <&cpg 408>;
 		};
 
+		pciec0: pcie at fe000000 {
+			compatible = "renesas,pcie-r8a774c0",
+				     "renesas,pcie-rcar-gen3";
+			reg = <0 0xfe000000 0 0x80000>;
+			#address-cells = <3>;
+			#size-cells = <2>;
+			bus-range = <0x00 0xff>;
+			device_type = "pci";
+			ranges = <0x01000000 0 0x00000000 0 0xfe100000 0 0x00100000
+				  0x02000000 0 0xfe200000 0 0xfe200000 0 0x00200000
+				  0x02000000 0 0x30000000 0 0x30000000 0 0x08000000
+				  0x42000000 0 0x38000000 0 0x38000000 0 0x08000000>;
+			/* Map all possible DDR as inbound ranges */
+			dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x40000000>;
+			interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
+			#interrupt-cells = <1>;
+			interrupt-map-mask = <0 0 0 0>;
+			interrupt-map = <0 0 0 0 &gic GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 319>, <&pcie_bus_clk>;
+			clock-names = "pcie", "pcie_bus";
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 319>;
+			status = "disabled";
+		};
+
 		prr: chipid at fff00044 {
 			compatible = "renesas,prr";
 			reg = <0 0xfff00044 0 4>;
Signature · 1 line
2.7.4
#6 lore raw

PATCH 3/4 arm64: dts: renesas: r8a774c0-cat874: Add pciec0 support

In reply to Fabrizio Castro

From: Biju Das <[email protected]>

Silicon Linux CAT 874 board has 2GB DDR memory. Update the dma-ranges mapping for pciec0 node. Also declare pcie bus clock, since it is generated on the CAT874 main board.

(cherry picked from commit aaf6c75c0458122600a20db9d41a0350f0a8dff8)
---
 arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts | 9 +++++++++
 1 file changed, 9 insertions(+)
arch/arm64/boot/dts/renesas/r8a774c0-cat874.dts +9 -0
index 477a56b..96ee0d2c 100644
@@ -56,6 +56,15 @@
 	clock-frequency = <48000000>;
 };
 
+&pcie_bus_clk {
+	clock-frequency = <100000000>;
+};
+
+&pciec0 {
+	/* Map all possible DDR as inbound ranges */
+	dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x80000000>;
+};
+
 &pfc {
 	scif2_pins: scif2 {
 		groups = "scif2_data_a";
Signature · 1 line
2.7.4
#7 lore raw

PATCH 4/4 arm64: dts: renesas: cat875: Enable PCIe support

In reply to Fabrizio Castro

From: Biju Das <[email protected]>

This patch enables PCIEC0 PCI express controller on the sub board.

(cherry picked from commit ee20aeefb53f6ffabed5b1a3b859294197eeb351)
---
 arch/arm64/boot/dts/renesas/cat875.dtsi | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/renesas/cat875.dtsi +4 -0
index 805ffa7..14db667 100644
@@ -30,6 +30,10 @@
 	};
 };
 
+&pciec0 {
+	status = "okay";
+};
+
 &pfc {
 	avb_pins: avb {
 		mux {
Signature · 1 line
2.7.4