Skip to contentSkip to conversation

package/vdr-plugin-vnsiserver: package needs host-gettext to build correctly

PATCH New Giulio Benetti 2 participants 4 messages Apr 9, 2019 – Apr 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/vdr-plugin-vnsiserver: package needs host-gettext to build correctly

During building msgmerge is used, so at the moment if build environment doesn't provide it, build will fail.

Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES.

---
 package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/vdr-plugin-vnsiserver/vdr-plugin-vnsiserver.mk +1 -1
index 20644d3f6b..86c99c422b 100644
@@ -8,7 +8,7 @@ VDR_PLUGIN_VNSISERVER_VERSION = v1.8.0
 VDR_PLUGIN_VNSISERVER_SITE = $(call github,FernetMenta,vdr-plugin-vnsiserver,$(VDR_PLUGIN_VNSISERVER_VERSION))
 VDR_PLUGIN_VNSISERVER_LICENSE = GPL-2.0+
 VDR_PLUGIN_VNSISERVER_LICENSE_FILES = COPYING
-VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr
+VDR_PLUGIN_VNSISERVER_DEPENDENCIES = vdr host-gettext
 
 VDR_PLUGIN_VNSISERVER_CXXFLAGS = CXXFLAGS="$(TARGET_CXXFLAGS) -std=c++11 -fPIC"
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/vdr-plugin-vnsiserver: package needs host-gettext to build correctly

Hello Giulio,

Quoted 6 lines · On Tue, 9 Apr 2019 19:45:35 +0200 Giulio Benetti…

During building msgmerge is used, so at the moment if build environment doesn't provide it, build will fail.

Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES.

In retrospect, I think http://patchwork.ozlabs.org/patch/1074926/ is better.

In fact, my analysis of Fabrice's patch was wrong. Even if the gettext-tiny issue gets resolved, vdr-plugin-vnsiserver (apparently) still needs msgfmt/msgmerge unconditionally, so we would indeed need a host-gettext dependency.

But Fabrice's patch makes that not necessary, by only installing the i18n files when BR2_SYSTEM_ENABLE_NLS=y.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/vdr-plugin-vnsiserver: package needs host-gettext to build correctly

Il 09/04/2019 23:21, Thomas Petazzoni ha scritto:

Quoted 14 lines

Hello Giulio,

Quoted 6 lines · On Tue, 9 Apr 2019 19:45:35 +0200 Giulio Benetti…

During building msgmerge is used, so at the moment if build environment doesn't provide it, build will fail.

Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES.

In retrospect, I think http://patchwork.ozlabs.org/patch/1074926/ is better.

Quoted 7 lines

In fact, my analysis of Fabrice's patch was wrong. Even if the gettext-tiny issue gets resolved, vdr-plugin-vnsiserver (apparently) still needs msgfmt/msgmerge unconditionally, so we would indeed need a host-gettext dependency.

But Fabrice's patch makes that not necessary, by only installing the i18n files when BR2_SYSTEM_ENABLE_NLS=y.

Ah ok, this is clever, since gettext-tiny maintainers pointed they only provide stubs and not complete gettext support(this is why it's called tiny):
https://github.com/sabotage-linux/gettext-tiny/issues/42#issuecomment-480127106

Thanks for the explanation.
Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#3 lore raw

PATCH 1/1 package/vdr-plugin-vnsiserver: package needs host-gettext to build correctly

Hello Thomas,

Il 10/04/2019 12:05, Giulio Benetti ha scritto:

Quoted 22 lines

Il 09/04/2019 23:21, Thomas Petazzoni ha scritto:

Quoted 21 lines

Hello Giulio,

Quoted 6 lines · On Tue, 9 Apr 2019 19:45:35 +0200 Giulio Benetti…

During building msgmerge is used, so at the moment if build environment doesn't provide it, build will fail.

Add host-gettext to VDR_PLUGIN_VNSISERVER_DEPENDENCIES.

In retrospect, I think http://patchwork.ozlabs.org/patch/1074926/ is better.

In fact, my analysis of Fabrice's patch was wrong. Even if the gettext-tiny issue gets resolved, vdr-plugin-vnsiserver (apparently) still needs msgfmt/msgmerge unconditionally, so we would indeed need a host-gettext dependency.

But Fabrice's patch makes that not necessary, by only installing the i18n files when BR2_SYSTEM_ENABLE_NLS=y.

So you mean we need to avoid build step using msgfmt/msgmerge and need to copy i18n files with something like "cp i18n-files target/i18n-files" ?

Quoted 9 lines

Ah ok, this is clever, since gettext-tiny maintainers pointed they only provide stubs and not complete gettext support(this is why it's called tiny):
https://github.com/sabotage-linux/gettext-tiny/issues/42#issuecomment-480127106

Thanks for the explanation.
Best regards

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642