Skip to contentSkip to conversation

package/civetweb: fix link failure due to missing OpenSSL dependency

PATCH New Giulio Benetti 3 participants 4 messages Apr 9, 2019 – Apr 14, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/civetweb: fix link failure due to missing OpenSSL dependency

During linking one OpenSSL dependecy is missing(-latomic) on linking library list.

- Substitute explicit library list with pkg-config libssl when BR2_PACKAGE_OPENSSL is enabled. In such way all needed libraries will be included in linking list.
- Add also host-pkgconf to CIVETWEB_DEPENDENCIES if BR2_PACKAGE_OPENSSL is enabled to make it available for previous point.

Fixes:
http://autobuild.buildroot.net/results/b2e/b2e210bdefe84f4ec9cfda79a33d81788fb7e66c/

---
 package/civetweb/civetweb.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/civetweb/civetweb.mk +2 -2
index fe1cdd5675..c999ec89be 100644
@@ -32,8 +32,8 @@ endif
 
 ifeq ($(BR2_PACKAGE_OPENSSL),y)
 CIVETWEB_COPT += -DNO_SSL_DL
-CIVETWEB_LIBS += -lssl -lcrypto -lz
-CIVETWEB_DEPENDENCIES += openssl
+CIVETWEB_LIBS += `$(HOST_DIR)/usr/bin/pkg-config --libs libssl`
+CIVETWEB_DEPENDENCIES += openssl host-pkgconf
 else
 CIVETWEB_COPT += -DNO_SSL
 endif
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 package/civetweb: fix link failure due to missing OpenSSL dependency

Quoted 9 lines · On Tue, 9 Apr 2019 23:10:32 +0200 Giulio Benetti…

During linking one OpenSSL dependecy is missing(-latomic) on linking library list.

- Substitute explicit library list with pkg-config libssl when BR2_PACKAGE_OPENSSL is enabled. In such way all needed libraries will be included in linking list.
- Add also host-pkgconf to CIVETWEB_DEPENDENCIES if BR2_PACKAGE_OPENSSL is enabled to make it available for previous point.

Quoted 4 lines

Fixes:
http://autobuild.buildroot.net/results/b2e/b2e210bdefe84f4ec9cfda79a33d81788fb7e66c/

Applied to master, with one small change, see below.

Quoted 1 line

+CIVETWEB_LIBS += $(HOST_DIR)/usr/bin/pkg-config --libs libssl

$(HOST_DIR)/usr no longer really exists, it's a symlink to $(HOST_DIR), so this path should have been just $(HOST_DIR)/bin/pkg-config.

However, pkgconf.mk precisely provides the PKG_CONFIG_HOST_BINARY variable, which contains exactly the path to pkg-config. So I've used that instead.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/civetweb: fix link failure due to missing OpenSSL dependency

Il 09/04/2019 23:28, Thomas Petazzoni ha scritto:> $(HOST_DIR)/usr no longer really exists, it's a symlink to $(HOST_DIR),

Quoted 5 lines

so this path should have been just $(HOST_DIR)/bin/pkg-config.

However, pkgconf.mk precisely provides the PKG_CONFIG_HOST_BINARY variable, which contains exactly the path to pkg-config. So I've used that instead.

Ah I've missed that variable good to know.

Thank you

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#3 lore raw

PATCH 1/1 package/civetweb: fix link failure due to missing OpenSSL dependency

In reply to Giulio Benetti
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

During linking one OpenSSL dependecy is missing(-latomic) on linking library list.

- Substitute explicit library list with pkg-config libssl when BR2_PACKAGE_OPENSSL is enabled. In such way all needed libraries will be included in linking list.
- Add also host-pkgconf to CIVETWEB_DEPENDENCIES if BR2_PACKAGE_OPENSSL is enabled to make it available for previous point.

Quoted 4 lines

Fixes:
http://autobuild.buildroot.net/results/b2e/b2e210bdefe84f4ec9cfda79a33d81788fb7e66c/

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard