armv8: ls1028a: Add NXP LS1028A SoC support
PATCH v3 1/3 armv8: ls1028a: Add NXP LS1028A SoC support
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers, 6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.
---
v3:
-- fix some issues
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280 +++++++++++++++++++++ arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsi
arch/arm/cpu/armv8/fsl-layerscape/Kconfig +38 -1
@@ -20,6 +20,40 @@ config ARCH_LS1012A select SYS_I2C_MXC_I2C2 imply PANIC_HANG +config ARCH_LS1028A + bool + select ARMV8_SET_SMPEN + select FSL_LSCH3 + select NXP_LSCH3_2 + select SYS_FSL_HAS_CCI400 + select SYS_FSL_SRDS_1 + select SYS_HAS_SERDES + select SYS_FSL_DDR + select SYS_FSL_DDR_LE + select SYS_FSL_DDR_VER_50 + select SYS_FSL_HAS_DDR3 + select SYS_FSL_HAS_DDR4 + select SYS_FSL_HAS_SEC + select SYS_FSL_SEC_COMPAT_5 + select SYS_FSL_SEC_LE + select FSL_TZASC_1 + select ARCH_EARLY_INIT_R + select BOARD_EARLY_INIT_F + select SYS_I2C_MXC + select SYS_I2C_MXC_I2C1 + select SYS_I2C_MXC_I2C2 + select SYS_I2C_MXC_I2C3 + select SYS_I2C_MXC_I2C4 + select SYS_I2C_MXC_I2C5 + select SYS_I2C_MXC_I2C6 + select SYS_I2C_MXC_I2C7 + select SYS_I2C_MXC_I2C8 + select SYS_FSL_ERRATUM_A009007 + select SYS_FSL_ERRATUM_A008514 if !TFABOOT + select SYS_FSL_ERRATUM_A009663 if !TFABOOT + select SYS_FSL_ERRATUM_A009942 if !TFABOOT + imply PANIC_HANG + config ARCH_LS1043A bool select ARMV8_SET_SMPEN
@@ -244,6 +278,7 @@ config FSL_PCIE_COMPAT string "PCIe compatible of Kernel DT" depends on PCIE_LAYERSCAPE default "fsl,ls1012a-pcie" if ARCH_LS1012A + default "fsl,ls1028a-pcie" if ARCH_LS1028A default "fsl,ls1043a-pcie" if ARCH_LS1043A default "fsl,ls1046a-pcie" if ARCH_LS1046A default "fsl,ls2080a-pcie" if ARCH_LS2080A
@@ -343,6 +378,7 @@ config SYS_FSL_ERRATUM_A010539 config MAX_CPUS int "Maximum number of CPUs permitted for Layerscape" + default 2 if ARCH_LS1028A default 4 if ARCH_LS1043A default 4 if ARCH_LS1046A default 16 if ARCH_LS2080A
@@ -377,7 +413,7 @@ config QSPI_AHB_INIT config SYS_CCI400_OFFSET hex "Offset for CCI400 base" depends on SYS_FSL_HAS_CCI400 - default 0x3090000 if ARCH_LS1088A + default 0x3090000 if ARCH_LS1088A || ARCH_LS1028A default 0x180000 if FSL_LSCH2 help Offset for CCI400 base
@@ -446,6 +482,7 @@ config CLUSTER_CLK_FREQ config SYS_FSL_PCLK_DIV int "Platform clock divider" + default 1 if ARCH_LS1028A default 1 if ARCH_LS1043A default 1 if ARCH_LS1046A default 1 if ARCH_LS1088A
arch/arm/cpu/armv8/fsl-layerscape/Makefile +4 -0
@@ -48,3 +48,7 @@ endif ifneq ($(CONFIG_ARCH_LS1088A),) obj-$(CONFIG_SYS_HAS_SERDES) += ls1088a_serdes.o endif + +ifneq ($(CONFIG_ARCH_LS1028A),) +obj-$(CONFIG_SYS_HAS_SERDES) += ls1028a_serdes.o +endif
arch/arm/cpu/armv8/fsl-layerscape/cpu.c +3 -0
@@ -58,6 +58,7 @@ static struct cpu_type cpu_type_list[] = {CPU_TYPE_ENTRY (LS1026A ,LS1026A ,2 ),CPU_TYPE_ENTRY (LS2040A ,LS2040A ,4 ),CPU_TYPE_ENTRY (LS1012A ,LS1012A ,1 ), +CPU_TYPE_ENTRY (LS1028A ,LS1028A ,2 ),CPU_TYPE_ENTRY (LS1088A ,LS1088A ,8 ),CPU_TYPE_ENTRY (LS1084A ,LS1084A ,8 ), CPU_TYPE_ENTRY(LS1048A, LS1048A, 4),
@@ -246,11 +247,13 @@ static struct mm_region final_map[] = { PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | PTE_BLOCK_NON_SHARE | PTE_BLOCK_PXN | PTE_BLOCK_UXN }, +#ifdef CONFIG_SYS_PCIE3_PHYS_ADDR { CONFIG_SYS_PCIE3_PHYS_ADDR, CONFIG_SYS_PCIE3_PHYS_ADDR, CONFIG_SYS_PCIE3_PHYS_SIZE, PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | PTE_BLOCK_NON_SHARE | PTE_BLOCK_PXN | PTE_BLOCK_UXN }, +#endif #if defined(CONFIG_ARCH_LS2080A) || defined(CONFIG_ARCH_LX2160A) { CONFIG_SYS_PCIE4_PHYS_ADDR, CONFIG_SYS_PCIE4_PHYS_ADDR, CONFIG_SYS_PCIE4_PHYS_SIZE,
arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc +51 -0
60 lines not on this page · raw message
arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c new file +73 -0
73 lines not on this page · raw message
arch/arm/dts/fsl-ls1028a.dtsi new file +280 -0
280 lines not on this page · raw message
arch/arm/include/asm/arch-fsl-layerscape/config.h +61 -0
67 lines not on this page · raw message
arch/arm/include/asm/arch-fsl-layerscape/immap_lsch3.h +9 -0
@@ -171,6 +171,9 @@#define CONFIG_SYS_PCIE1_PHYS_ADDR 0x2000000000ULL#define CONFIG_SYS_PCIE2_PHYS_ADDR 0x2800000000ULL#define CONFIG_SYS_PCIE3_PHYS_ADDR 0x3000000000ULL +#elif CONFIG_ARCH_LS1028A +#define CONFIG_SYS_PCIE1_PHYS_ADDR 0x8000000000ULL +#define CONFIG_SYS_PCIE2_PHYS_ADDR 0x8800000000ULL#else #define CONFIG_SYS_PCIE1_PHYS_ADDR 0x1000000000ULL#define CONFIG_SYS_PCIE2_PHYS_ADDR 0x1200000000ULL
@@ -375,6 +378,12 @@ struct ccsr_gur {#define FSL_CHASSIS3_SRDS2_PRTCL_SHIFT FSL_CHASSIS3_RCWSR30_SRDS2_PRTCL_SHIFT#define FSL_CHASSIS3_SRDS1_REGSR 29#define FSL_CHASSIS3_SRDS2_REGSR 30 +#elif defined(CONFIG_ARCH_LS1028A ) +#define FSL_CHASSIS3_RCWSR29_SRDS1_PRTCL_MASK 0xFFFF0000 +#define FSL_CHASSIS3_RCWSR29_SRDS1_PRTCL_SHIFT 16 +#define FSL_CHASSIS3_SRDS1_PRTCL_MASK FSL_CHASSIS3_RCWSR29_SRDS1_PRTCL_MASK +#define FSL_CHASSIS3_SRDS1_PRTCL_SHIFT FSL_CHASSIS3_RCWSR29_SRDS1_PRTCL_SHIFT +#define FSL_CHASSIS3_SRDS1_REGSR 29#endif #define RCW_SB_EN_REG_INDEX 9#define RCW_SB_EN_MASK 0x00000400
arch/arm/include/asm/arch-fsl-layerscape/soc.h +1 -0
@@ -83,6 +83,7 @@ enum boot_src get_boot_src(void);/* LS1043A/LS1023A 23x23 package silicon has different value of VAR_PER */ #define SVR_LS1043A_P23 0x879202#define SVR_LS1023A_P23 0x87920A +#define SVR_LS1028A 0x870B00#define SVR_LS1046A 0x870700#define SVR_LS1026A 0x870708#define SVR_LS1048A 0x870320
arch/arm/include/asm/arch-fsl-layerscape/stream_id_lsch3.h +1 -1
@@ -87,7 +87,7 @@#define FSL_PEX_STREAM_ID_NUM (0x100)#endif -#if defined(CONFIG_ARCH_LS2080A ) +#if defined(CONFIG_ARCH_LS2080A ) || defined(CONFIG_ARCH_LS1028A )#define FSL_PEX_STREAM_ID_END 22#elif defined(CONFIG_ARCH_LS1088A )#define FSL_PEX_STREAM_ID_END 18
Signature · 1 line
2.7.4
PATCH v3 2/3 armv8: ls1028ardb: Add support for LS1028ARDB platform
LS1028A is an ARMv8 implementation. LS1028ARDB is an evaluatoin platform that supports the LS1028A family SoCs. This patch add basic support of the platform.
---
v3:
- remove ddr fixed initialization
arch/arm/Kconfig | 12 +++ arch/arm/cpu/armv8/Kconfig | 1 + arch/arm/dts/fsl-ls1028a-rdb.dts | 88 +++++++++++++++ board/freescale/ls1028a/Kconfig | 26 +++++ board/freescale/ls1028a/MAINTAINERS | 10 ++ board/freescale/ls1028a/Makefile | 8 ++ board/freescale/ls1028a/README | 79 ++++++++++++++ board/freescale/ls1028a/ddr.c | 20 ++++ board/freescale/ls1028a/ls1028a.c | 193 +++++++++++++++++++++++++++++++++ configs/ls1028ardb_tfa_defconfig | 61 +++++++++++ include/configs/ls1028a_common.h | 209 ++++++++++++++++++++++++++++++++++++ include/configs/ls1028ardb.h | 77 +++++++++++++ 12 files changed, 784 insertions(+) create mode 100644 arch/arm/dts/fsl-ls1028a-rdb.dts create mode 100644 board/freescale/ls1028a/Kconfig create mode 100644 board/freescale/ls1028a/MAINTAINERS create mode 100644 board/freescale/ls1028a/Makefile create mode 100644 board/freescale/ls1028a/README create mode 100644 board/freescale/ls1028a/ddr.c create mode 100644 board/freescale/ls1028a/ls1028a.c create mode 100644 configs/ls1028ardb_tfa_defconfig create mode 100644 include/configs/ls1028a_common.h create mode 100644 include/configs/ls1028ardb.h
arch/arm/Kconfig +12 -0
@@ -1203,6 +1203,17 @@ config TARGET_LS1012AFRDM development platform that supports the QorIQ LS1012A Layerscape Architecture processor. +config TARGET_LS1028ARDB + bool "Support ls1028ardb" + select ARCH_LS1028A + select ARM64 + select ARMV8_MULTIENTRY + help + Support for Freescale LS1028ARDB platform + The LS1028A Development System (RDB) is a high-performance + development platform that supports the QorIQ LS1028A + Layerscape Architecture processor. + config TARGET_LS1088ARDB bool "Support ls1088ardb" select ARCH_LS1088A
@@ -1585,6 +1596,7 @@ source "board/freescale/ls2080a/Kconfig" source "board/freescale/ls2080aqds/Kconfig" source "board/freescale/ls2080ardb/Kconfig" source "board/freescale/ls1088a/Kconfig" +source "board/freescale/ls1028a/Kconfig" source "board/freescale/ls1021aqds/Kconfig" source "board/freescale/ls1043aqds/Kconfig" source "board/freescale/ls1021atwr/Kconfig"
arch/arm/cpu/armv8/Kconfig +1 -0
@@ -104,6 +104,7 @@ config PSCI_RESET !TARGET_LS1012ARDB && !TARGET_LS1012AFRDM && \ !TARGET_LS1012A2G5RDB && !TARGET_LS1012AQDS && \ !TARGET_LS1012AFRWY && \ + !TARGET_LS1028ARDB && \ !TARGET_LS1043ARDB && !TARGET_LS1043AQDS && \ !TARGET_LS1046ARDB && !TARGET_LS1046AQDS && \ !TARGET_LS2081ARDB && !TARGET_LX2160ARDB && \
arch/arm/dts/fsl-ls1028a-rdb.dts new file +88 -0
88 lines not on this page · raw message
board/freescale/ls1028a/Kconfig new file +26 -0
@@ -0,0 +1,26 @@ +if TARGET_LS1028ARDB + +config SYS_BOARD + default "ls1028a" + +config SYS_VENDOR + default "freescale" + +config SYS_SOC + default "fsl-layerscape" + +config SYS_CONFIG_NAME + default "ls1028ardb" + +config EMMC_BOOT + bool "Support for booting from EMMC" + default n + +config SYS_TEXT_BASE + default 0x96000000 if SD_BOOT || EMMC_BOOT + default 0x82000000 if TFABOOT + default 0x20100000 + +source "board/freescale/common/Kconfig" + +endif
board/freescale/ls1028a/MAINTAINERS new file +10 -0
@@ -0,0 +1,10 @@ +LS1028ARDB BOARD +M: Sudhanshu Gupta <[email protected]> +M: Rai Harninder <[email protected]> +M: Rajesh Bhagat <[email protected]> +M: Tang Yuantian <[email protected]> +S: Maintained +F: board/freescale/ls1028a/ +F: include/configs/ls1028a_common.h +F: include/configs/ls1028ardb.h +F: configs/ls1028ardb_tfa_defconfig
board/freescale/ls1028a/Makefile new file +8 -0
@@ -0,0 +1,8 @@ +# +# Copyright 2019 NXP +# +# SPDX-License-Identifier: GPL-2.0+ +# + +obj-y += ls1028a.o +obj-y += ddr.o
board/freescale/ls1028a/README new file +79 -0
79 lines not on this page · raw message
board/freescale/ls1028a/ddr.c new file +20 -0
@@ -0,0 +1,20 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Copyright 2019 NXP +*/ + +#include <common.h> +#include <fsl_ddr_sdram.h> +#include <fsl_ddr_dimm_params.h> + +DECLARE_GLOBAL_DATA_PTR ; + +int fsl_initdram (void ) +{ + gd->ram_size =tfa_get_dram_size (); + +if (!gd->ram_size) + gd->ram_size =fsl_ddr_sdram_size (); + +return 0 ; +}
board/freescale/ls1028a/ls1028a.c new file +193 -0
193 lines not on this page · raw message
configs/ls1028ardb_tfa_defconfig new file +61 -0
61 lines not on this page · raw message
include/configs/ls1028a_common.h new file +209 -0
209 lines not on this page · raw message
include/configs/ls1028ardb.h new file +77 -0
77 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 3/3 armv8: ls1028aqds: Add support of LS1028AQDS
LS1028AQDS Development System is a high-performance computing, evaluation, and development platform that supports LS1028A QorIQ Architecture processor.
---
v3:
-- fix some issues
arch/arm/Kconfig | 11 +++ arch/arm/cpu/armv8/Kconfig | 2 +- arch/arm/dts/fsl-ls1028a-qds.dts | 88 +++++++++++++++++++ board/freescale/ls1028a/Kconfig | 39 +++++++++ board/freescale/ls1028a/MAINTAINERS | 11 +++ board/freescale/ls1028a/README | 85 ++++++++++++++++++ board/freescale/ls1028a/ls1028a.c | 38 ++++++++ configs/ls1028aqds_tfa_defconfig | 61 +++++++++++++ include/configs/ls1028aqds.h | 167 ++++++++++++++++++++++++++++++++++++ 9 files changed, 501 insertions(+), 1 deletion(-) create mode 100644 arch/arm/dts/fsl-ls1028a-qds.dts create mode 100644 configs/ls1028aqds_tfa_defconfig create mode 100644 include/configs/ls1028aqds.h
arch/arm/Kconfig +11 -0
@@ -1203,6 +1203,17 @@ config TARGET_LS1012AFRDM development platform that supports the QorIQ LS1012A Layerscape Architecture processor. +config TARGET_LS1028AQDS + bool "Support ls1028aqds" + select ARCH_LS1028A + select ARM64 + select ARMV8_MULTIENTRY + help + Support for Freescale LS1028AQDS platform + The LS1028A Development System (QDS) is a high-performance + development platform that supports the QorIQ LS1028A + Layerscape Architecture processor. + config TARGET_LS1028ARDB bool "Support ls1028ardb" select ARCH_LS1028A
arch/arm/cpu/armv8/Kconfig +1 -1
@@ -104,7 +104,7 @@ config PSCI_RESET !TARGET_LS1012ARDB && !TARGET_LS1012AFRDM && \ !TARGET_LS1012A2G5RDB && !TARGET_LS1012AQDS && \ !TARGET_LS1012AFRWY && \ - !TARGET_LS1028ARDB && \ + !TARGET_LS1028ARDB && !TARGET_LS1028AQDS && \ !TARGET_LS1043ARDB && !TARGET_LS1043AQDS && \ !TARGET_LS1046ARDB && !TARGET_LS1046AQDS && \ !TARGET_LS2081ARDB && !TARGET_LX2160ARDB && \
arch/arm/dts/fsl-ls1028a-qds.dts new file +88 -0
88 lines not on this page · raw message
board/freescale/ls1028a/Kconfig +39 -0
@@ -1,3 +1,42 @@ +if TARGET_LS1028AQDS + +config SYS_BOARD + default "ls1028a" + +config SYS_VENDOR + default "freescale" + +config SYS_SOC + default "fsl-layerscape" + +config SYS_CONFIG_NAME + default "ls1028aqds" + +config EMMC_BOOT + bool "Support for booting from EMMC" + default n + +config SYS_TEXT_BASE + default 0x96000000 if SD_BOOT || EMMC_BOOT + default 0x82000000 if TFABOOT + default 0x20100000 + +if FSL_LS_PPA +config SYS_LS_PPA_FW_ADDR + hex "PPA Firmware Addr" + default 0x20400000 if SYS_LS_PPA_FW_IN_XIP && ARCH_LS1028A + default 0x400000 if SYS_LS_PPA_FW_IN_MMC && ARCH_LS1028A +if CHAIN_OF_TRUST +config SYS_LS_PPA_ESBC_ADDR + hex "PPA header Addr" + default 0x20600000 if SYS_LS_PPA_FW_IN_XIP && ARCH_LS1028A +endif +endif + +source "board/freescale/common/Kconfig" + +endif + if TARGET_LS1028ARDB config SYS_BOARD
board/freescale/ls1028a/MAINTAINERS +11 -0
@@ -1,3 +1,14 @@ +LS1028AQDS BOARD +M: Sudhanshu Gupta <[email protected]> +M: Rai Harninder <[email protected]> +M: Rajesh Bhagat <[email protected]> +M: Tang Yuantian <[email protected]> +S: Maintained +F: board/freescale/ls1028a/ +F: include/configs/ls1028a_common.h +F: include/configs/ls1028aqds.h +F: configs/ls1028aqds_tfa_defconfig + LS1028ARDB BOARD M: Sudhanshu Gupta <[email protected]> M: Rai Harninder <[email protected]>
board/freescale/ls1028a/README +85 -0
88 lines not on this page · raw message
board/freescale/ls1028a/ls1028a.c +38 -0
@@ -27,6 +27,35 @@DECLARE_GLOBAL_DATA_PTR ; +int config_board_mux (void ) +{ +#if defined(CONFIG_TARGET_LS1028AQDS ) && defined(CONFIG_FSL_QIXIS ) +u8 reg; + + reg =QIXIS_READ (brdcfg[13 ]); +/* Field| Function +* 7-6 | Controls I2C3 routing (net CFG_MUX_I2C3): +* I2C3 | 10= Routes {SCL, SDA} to CAN1 transceiver as {TX, RX}. +* 5-4 | Controls I2C4 routing (net CFG_MUX_I2C4): +* I2C4 |11= Routes {SCL, SDA} to CAN2 transceiver as {TX, RX}. +*/ + reg &= ~(0xf0 ); + reg |=0xb0 ; +QIXIS_WRITE (brdcfg[13 ], reg); + + reg =QIXIS_READ (brdcfg[15 ]); +/* Field| Function +* 7 | Controls the CAN1 transceiver (net CFG_CAN1_STBY): +* CAN1 | 0= CAN #1 transceiver enabled +* 6 | Controls the CAN2 transceiver (net CFG_CAN2_STBY): +* CAN2 | 0= CAN #2 transceiver enabled +*/ + reg &= ~(0xc0 ); +QIXIS_WRITE (brdcfg[15 ], reg); +#endif +return 0 ; +} +int board_init (void ) {#ifdef CONFIG_ENV_IS_NOWHERE
@@ -54,6 +83,15 @@ int board_eth_init(bd_t *bis)return pci_eth_init (bis); } +#if defined(CONFIG_ARCH_MISC_INIT ) +int arch_misc_init (void ) +{ +config_board_mux (); + +return 0 ; +} +#endif +int board_early_init_f (void ) {#ifdef CONFIG_SYS_I2C_EARLY_INIT
configs/ls1028aqds_tfa_defconfig new file +61 -0
61 lines not on this page · raw message
include/configs/ls1028aqds.h new file +167 -0
167 lines not on this page · raw message
Signature · 1 line
2.7.4
PATCH v3 3/3 armv8: ls1028aqds: Add support of LS1028AQDS
Quoted 15 lines
-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: Wednesday, April 10, 2019 2:14 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: albert.u.boot at aribaud.net; Sudhanshu Gupta <[email protected]>; Harninder Rai <[email protected]>; Rajesh Bhagat <[email protected]>; Bhaskar Upadhaya <[email protected]>; Ran Wang <[email protected]>; u- boot at lists.denx.de; Andy Tang <[email protected]>
Subject: [PATCH 3/3 v3] armv8: ls1028aqds: Add support of LS1028AQDSLS1028AQDS Development System is a high-performance computing, evaluation, and development platform that supports LS1028A QorIQ Architecture processor.
Quoted 8 lines
Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang yuantian <[email protected]>---
v3:
-- fix some issues
Please always put complete revision history in patch.
Re-created defconfig using savedefconfig, removed hdp related env, added dtb in make file and applied to fsl-qoriq master, awaiting upstream
--pk
PATCH v3 2/3 armv8: ls1028ardb: Add support for LS1028ARDB platform
In reply to Yuantian TangQuoted 17 lines
-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: Wednesday, April 10, 2019 2:14 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: albert.u.boot at aribaud.net; Sudhanshu Gupta <[email protected]>; Harninder Rai <[email protected]>; Rajesh Bhagat <[email protected]>; Bhaskar Upadhaya <[email protected]>; Ran Wang <[email protected]>; u- boot at lists.denx.de; Andy Tang <[email protected]>
Subject: [PATCH 2/3 v3] armv8: ls1028ardb: Add support for LS1028ARDB platformLS1028A is an ARMv8 implementation. LS1028ARDB is an evaluatoin platform that supports the LS1028A family SoCs. This patch add basic support of the platform.
Quoted 8 lines
Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
- remove ddr fixed initialization
Please always put complete revision history in patch.
Re-created defconfig using savedefconfig, removed hdp related env, added dtb in make file and applied to fsl-qoriq master, awaiting upstream
--pk
PATCH v3 1/3 armv8: ls1028a: Add NXP LS1028A SoC support
In reply to Yuantian TangHi,
Quoted 15 lines · Yuantian Tang
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers, 6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
-- fix some issues
Quoted 14 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280 +++++++++++++++++++++ arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsi
I really would like to see complete DM driver support on this new platform. Please consider converting appropriate codes to driver model. If there is no proper uclass model, please propose one and discuss it on the list. I see the existing NXP PowerPC support is stuck in such a situation that lots of codes are still non-DM and we are getting close to the DM deadline. I don't want to see such happens again in the NXP ARM support.
Thanks!
Regards,
Bin
Hi Bin,
Quoted 48 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月16日 20:10
To: Andy Tang <[email protected]>; Simon Glass <[email protected]>; Tom Rini <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; Sudhanshu Gupta <[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportHi,
Quoted 15 lines · Yuantian Tang
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN
ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers,
6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
-- fix some issuesQuoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280+++++++++++++++++++++
Quoted 8 lines
arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsi
Quoted 6 lines
I really would like to see complete DM driver support on this new platform. Please consider converting appropriate codes to driver model. If there is no proper uclass model, please propose one and discuss it on the list. I see the existing NXP PowerPC support is stuck in such a situation that lots of codes are still non-DM and we are getting close to the DM deadline. I don't want to see such happens again in the NXP ARM support.
Could you please be more specific which part of code is non-DM based? I checked it and didn't find where is non-DM.
Thanks for your review.
BR,
Andy
Quoted 5 lines
Thanks!
Regards,
Bin
Hi Andy,
Quoted 57 lines · Andy Tang
Hi Bin,
Quoted 48 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月16日 20:10
To: Andy Tang <[email protected]>; Simon Glass <[email protected]>; Tom Rini <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; Sudhanshu Gupta <[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportHi,
Quoted 15 lines · Yuantian Tang
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN
ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers,
6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
-- fix some issuesQuoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280+++++++++++++++++++++
Quoted 8 lines
arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsiQuoted 6 lines
I really would like to see complete DM driver support on this new platform. Please consider converting appropriate codes to driver model. If there is no proper uclass model, please propose one and discuss it on the list. I see the existing NXP PowerPC support is stuck in such a situation that lots of codes are still non-DM and we are getting close to the DM deadline. I don't want to see such happens again in the NXP ARM support.
Quoted 3 lines
Could you please be more specific which part of code is non-DM based? I checked it and didn't find where is non-DM.
Thanks for your review.
For example, the "config ARCH_LS1028A" selects the following I2C components:
+ select SYS_I2C_MXC + select SYS_I2C_MXC_I2C1 + select SYS_I2C_MXC_I2C2 + select SYS_I2C_MXC_I2C3 + select SYS_I2C_MXC_I2C4 + select SYS_I2C_MXC_I2C5 + select SYS_I2C_MXC_I2C6 + select SYS_I2C_MXC_I2C7 + select SYS_I2C_MXC_I2C8
These I2C# macros look to me this is not DM based. For DM such stuff is determined from the DT automatically.
For ls1028a_serdes.c, we probably need create serdes uclass driver for it.
For arch/arm/cpu/armv8/fsl-layerscape/cpu.c, can we create a CPU driver for it? I see lots of CONFIG_XXX_BASE and CONFIG_XXX_SIZE in this file that come from arch/arm/include/asm/arch-fsl-layerscape/cpu.h? Can't we get such in DT?
Regards,
Bin
Hi Bin,
Thanks for your review. Please see my comments below.
Quoted 96 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月17日 14:32
To: Andy Tang <[email protected]>
Cc: Simon Glass <[email protected]>; Tom Rini <[email protected]>; Prabhakar Kushwaha <[email protected]>; Sudhanshu Gupta <[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportCaution: EXT Email
Hi Andy,
Quoted 7 lines · Andy Tang
Hi Bin,
Quoted 4 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月16日 20:10
To: Andy Tang <[email protected]>; Simon GlassQuoted 2 lines
Quoted 2 lines
Tom Rini <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; SudhanshuGupta
Quoted 43 lines
Quoted 43 lines
<[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportHi,
Quoted 16 lines · Yuantian Tang
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN
ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers,
6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
-- fix some issuesQuoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280+++++++++++++++++++++
Quoted 8 lines
arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsiQuoted 1 line
Quoted 1 line
I really would like to see complete DM driver support on this new
platform.
Quoted 5 lines
Quoted 5 lines
Please consider converting appropriate codes to driver model. If there is no proper uclass model, please propose one and discuss it on the list. I see the existing NXP PowerPC support is stuck in such a situation that lots of codes are still non-DM and we are getting close to the DM deadline. I don't want to see such happens again in the
NXP ARM support.
Quoted 3 lines
Could you please be more specific which part of code is non-DM based? I checked it and didn't find where is non-DM.
Thanks for your review.For example, the "config
ARCH_LS1028A" selects the following I2C components:arch/arm/cpu/armv8/fsl-layerscape/Kconfig +9
-0+ select SYS_I2C_MXC + select SYS_I2C_MXC_I2C1 + select SYS_I2C_MXC_I2C2 + select SYS_I2C_MXC_I2C3 + select SYS_I2C_MXC_I2C4 + select SYS_I2C_MXC_I2C5 + select SYS_I2C_MXC_I2C6 + select SYS_I2C_MXC_I2C7 + select SYS_I2C_MXC_I2C8
Quoted 2 lines
These I2C# macros look to me this is not DM based. For DM such stuff is determined from the DT automatically.
Agree. Our I2C IP owner is working on it and will change all I2C driver to DM based.
Quoted 2 lines
For
ls1028a_serdes.c, we probably need create serdes uclass driver for it.
We don't have serdes dts node in both uboot and kernel. So I think we can leave it as it is.
Quoted 5 lines
For
arch/arm/cpu/armv8/fsl-layerscape/cpu.c, can we create a CPU driver for it? I see lots ofCONFIG_XXX_BASEandCONFIG_XXX_SIZEin this file that come fromarch/arm/include/asm/arch-fsl-layerscape/cpu.h? Can't we get such in DT?
Agree. But this affects all our platforms and need big efforts. Many components are involved in it. We will convert it step by step.
BR,
Andy
Quoted 3 lines
Regards,
Bin
Hi Andy,
Quoted 101 lines · Andy Tang
Hi Bin,
Thanks for your review. Please see my comments below.
Quoted 96 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月17日 14:32
To: Andy Tang <[email protected]>
Cc: Simon Glass <[email protected]>; Tom Rini <[email protected]>; Prabhakar Kushwaha <[email protected]>; Sudhanshu Gupta <[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportCaution: EXT Email
Hi Andy,
Quoted 7 lines · Andy Tang
Hi Bin,
Quoted 4 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月16日 20:10
To: Andy Tang <[email protected]>; Simon GlassQuoted 2 lines
Quoted 2 lines
Tom Rini <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>; SudhanshuGupta
Quoted 43 lines
Quoted 43 lines
<[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportHi,
Quoted 16 lines · Yuantian Tang
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN
ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers,
6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
-- fix some issuesQuoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280+++++++++++++++++++++
Quoted 8 lines
arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsiQuoted 1 line
Quoted 1 line
I really would like to see complete DM driver support on this new
platform.
Quoted 5 lines
Quoted 5 lines
Please consider converting appropriate codes to driver model. If there is no proper uclass model, please propose one and discuss it on the list. I see the existing NXP PowerPC support is stuck in such a situation that lots of codes are still non-DM and we are getting close to the DM deadline. I don't want to see such happens again in the
NXP ARM support.
Quoted 3 lines
Could you please be more specific which part of code is non-DM based? I checked it and didn't find where is non-DM.
Thanks for your review.For example, the "config
ARCH_LS1028A" selects the following I2C components:arch/arm/cpu/armv8/fsl-layerscape/Kconfig +9
-0+ select SYS_I2C_MXC + select SYS_I2C_MXC_I2C1 + select SYS_I2C_MXC_I2C2 + select SYS_I2C_MXC_I2C3 + select SYS_I2C_MXC_I2C4 + select SYS_I2C_MXC_I2C5 + select SYS_I2C_MXC_I2C6 + select SYS_I2C_MXC_I2C7 + select SYS_I2C_MXC_I2C8
Quoted 3 lines
Quoted 2 lines
These I2C# macros look to me this is not DM based. For DM such stuff is determined from the DT automatically.
Agree. Our I2C IP owner is working on it and will change all I2C driver to DM based.
Great.
Quoted 4 lines
Quoted 3 lines
For
ls1028a_serdes.c, we probably need create serdes uclass driver for it.We don't have serdes dts node in both uboot and kernel. So I think we can leave it as it is.
I see. Then let's keep it as it is.
Quoted 9 lines
Quoted 6 lines
For
arch/arm/cpu/armv8/fsl-layerscape/cpu.c, can we create a CPU driver for it? I see lots ofCONFIG_XXX_BASEandCONFIG_XXX_SIZEin this file that come fromarch/arm/include/asm/arch-fsl-layerscape/cpu.h? Can't we get such in DT?Agree. But this affects all our platforms and need big efforts. Many components are involved in it. We will convert it step by step.
Sounds you already have a plan, which is good!
Regards,
Bin
Dear Bin,
Quoted 124 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: Tuesday, May 21, 2019 1:45 PM
To: Andy Tang <[email protected]>
Cc: Simon Glass <[email protected]>; Tom Rini <[email protected]>; Prabhakar Kushwaha <[email protected]>; Sudhanshu Gupta <[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportHi Andy,
Quoted 11 lines · Andy Tang
Hi Bin,
Thanks for your review. Please see my comments below.
Quoted 6 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月17日 14:32
To: Andy Tang <[email protected]>
Cc: Simon Glass <[email protected]>; Tom Rini <[email protected]>; Prabhakar Kushwaha <[email protected]>; SudhanshuGupta
Quoted 11 lines
Quoted 11 lines
<[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: Re: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportCaution: EXT Email
Hi Andy,
On Fri, May 17, 2019 at 11:23 AM Andy Tang <[email protected]>
Quoted 10 lines · wrote:
Quoted 10 lines
Quoted 7 lines
Hi Bin,
Quoted 4 lines
-----Original Message-----
From: Bin Meng <[email protected]>
Sent: 2019年5月16日 20:10
To: Andy Tang <[email protected]>; Simon GlassQuoted 2 lines
Quoted 2 lines
Tom Rini <[email protected]>
Cc: Prabhakar Kushwaha <[email protected]>;Sudhanshu
Quoted 3 lines
Quoted 3 lines
Gupta
Quoted 2 lines
Quoted 2 lines
<[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>;
Bhaskar
Quoted 70 lines
Quoted 70 lines
Quoted 43 lines
Quoted 43 lines
Upadhaya <[email protected]>
Subject: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportHi,
Quoted 16 lines · Yuantian Tang
Ls1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU,
TSN ENETC, 2 USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers,
6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
-- fix some issuesQuoted 6 lines
arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 39 ++- arch/arm/cpu/armv8/fsl-layerscape/Makefile | 4 + arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 3 + arch/arm/cpu/armv8/fsl-layerscape/doc/README.soc | 51 ++++ arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c | 73 ++++++ arch/arm/dts/fsl-ls1028a.dtsi | 280+++++++++++++++++++++
Quoted 9 lines
arch/arm/include/asm/arch-fsl-layerscape/config.h | 61 +++++ .../include/asm/arch-fsl-layerscape/immap_lsch3.h | 9 + arch/arm/include/asm/arch-fsl-layerscape/soc.h | 1 + .../asm/arch-fsl-layerscape/stream_id_lsch3.h | 2 +- 10 files changed, 521 insertions(+), 2 deletions(-) create mode 100644 arch/arm/cpu/armv8/fsl-layerscape/ls1028a_serdes.c create mode 100644 arch/arm/dts/fsl-ls1028a.dtsiQuoted 2 lines
Quoted 2 lines
I really would like to see complete DM driver support on this new
platform.
Quoted 6 lines
Quoted 6 lines
Please consider converting appropriate codes to driver model. If there is no proper uclass model, please propose one and discuss it on the list. I see the existing NXP PowerPC support is stuck in such a situation that lots of codes are still non-DM and we are getting close to the DM deadline. I don't want to see such happens again in the
NXP ARM support.
Quoted 3 lines
Could you please be more specific which part of code is non-DM based? I checked it and didn't find where is non-DM.
Thanks for your review.For example, the "config
ARCH_LS1028A" selects the following I2C components:arch/arm/cpu/armv8/fsl-layerscape/Kconfig +9
-0+ select SYS_I2C_MXC + select SYS_I2C_MXC_I2C1 + select SYS_I2C_MXC_I2C2 + select SYS_I2C_MXC_I2C3 + select SYS_I2C_MXC_I2C4 + select SYS_I2C_MXC_I2C5 + select SYS_I2C_MXC_I2C6 + select SYS_I2C_MXC_I2C7 + select SYS_I2C_MXC_I2C8
Quoted 6 lines
Quoted 3 lines
Quoted 2 lines
These I2C# macros look to me this is not DM based. For DM such stuff is determined from the DT automatically.
Agree. Our I2C IP owner is working on it and will change all I2C driver to DM
based.
Great.
Andy: Please make sure our I2C IP owner do change all NXP supported SoCs including LS1028A.
Quoted 15 lines
Quoted 5 lines
Quoted 4 lines
For
ls1028a_serdes.c, we probably need create serdes uclass driver for it.We don't have serdes dts node in both uboot and kernel. So I think we can
leave it as it is.
I see. Then let's keep it as it is.
Quoted 6 lines
Quoted 6 lines
For
arch/arm/cpu/armv8/fsl-layerscape/cpu.c, can we create a CPU driver for it? I see lots ofCONFIG_XXX_BASEandCONFIG_XXX_SIZEin this file that come fromarch/arm/include/asm/arch-fsl-layerscape/cpu.h? Can't we get such in
Quoted 8 lines
DT?
Quoted 1 line
Agree. But this affects all our platforms and need big efforts. Many
components are involved in it.
Quoted 2 lines
We will convert it step by step.
Sounds you already have a plan, which is good!
I will prefer to merge this patch-set for now.
I will keep CPU DM model in my todo. It will require change in many NXP supported devices.
--pk
Hi Prabhakar,
Please see my reply inline.
Quoted 26 lines
-----Original Message-----
From: Prabhakar Kushwaha
Sent: 2019年5月21日 16:23
To: Bin Meng <[email protected]>; Andy Tang <[email protected]>
Cc: Simon Glass <[email protected]>; Tom Rini <[email protected]>; Sudhanshu Gupta <[email protected]>; U-Boot Mailing List <[email protected]>; Ran Wang <[email protected]>; Bhaskar Upadhaya <[email protected]>
Subject: RE: [EXT] Re: [U-Boot] [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportQuoted 15 lines
Quoted 15 lines
Quoted 15 lines
For example, the "config
ARCH_LS1028A" selects the following I2C components:(quoted diff) +9
-0+ select SYS_I2C_MXC + select SYS_I2C_MXC_I2C1 + select SYS_I2C_MXC_I2C2 + select SYS_I2C_MXC_I2C3 + select SYS_I2C_MXC_I2C4 + select SYS_I2C_MXC_I2C5 + select SYS_I2C_MXC_I2C6 + select SYS_I2C_MXC_I2C7 + select SYS_I2C_MXC_I2C8These I2C# macros look to me this is not DM based. For DM such stuff is determined from the DT automatically.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Agree. Our I2C IP owner is working on it and will change all I2C driver to DM
based.
Great.
Andy: Please make sure our I2C IP owner do change all NXP supported SoCs including LS1028A.
Patch for DM-based i2c driver is ready. Will send out this week. Then there are follow up patches to convert all the platforms.
Thanks,
Andy
Quoted 35 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
For
ls1028a_serdes.c, we probably need create serdes uclass driver forit.
Quoted 13 lines
Quoted 2 lines
We don't have serdes dts node in both uboot and kernel. So I think we can
leave it as it is.
I see. Then let's keep it as it is.
Quoted 7 lines
Quoted 7 lines
For
arch/arm/cpu/armv8/fsl-layerscape/cpu.c, can we create a CPU driver for it? I see lots ofCONFIG_XXX_BASEandCONFIG_XXX_SIZEin this file that come fromarch/arm/include/asm/arch-fsl-layerscape/cpu.h? Can't we get such inQuoted 8 lines
DT?
Quoted 1 line
Agree. But this affects all our platforms and need big efforts. Many
components are involved in it.
Quoted 2 lines
We will convert it step by step.
Sounds you already have a plan, which is good!
I will prefer to merge this patch-set for now.
I will keep CPU DM model in my todo. It will require change in many NXP supported devices.
--pk
PATCH v3 1/3 armv8: ls1028a: Add NXP LS1028A SoC support
In reply to Yuantian TangQuoted 18 lines
-----Original Message-----
From: Yuantian Tang <[email protected]>
Sent: Wednesday, April 10, 2019 2:14 PM
To: Prabhakar Kushwaha <[email protected]>
Cc: albert.u.boot at aribaud.net; Sudhanshu Gupta <[email protected]>; Harninder Rai <[email protected]>; Rajesh Bhagat <[email protected]>; Bhaskar Upadhaya <[email protected]>; Ran Wang <[email protected]>; u- boot at lists.denx.de; Andy Tang <[email protected]>
Subject: [PATCH 1/3 v3] armv8: ls1028a: Add NXP LS1028A SoC supportLs1028a Soc is based on Layerscape Chassis Generation 3.2 architecture with features:
2 ARM v8 Cortex-A72 cores, CCI400, SEC, DDR3L/4, LCD, GPU, TSN ENETC, 2
USB 3.0, 2 eSDHC, 2 FlexCAN, 2 SPI, SATA, 8 I2C controllers,
6 LPUARTs, GPIO, SAI, qDMA, eDMA, GIC, TMU etc.
Quoted 8 lines
Signed-off-by Sudhanshu Gupta <[email protected]>Signed-off-by Rai Harninder <[email protected]>Signed-off-by Rajesh Bhagat <[email protected]>Signed-off-by Bhaskar Upadhaya <[email protected]>Signed-off-by Tang Yuantian <[email protected]>---
v3:
-- fix some issues
Please always put complete revision history in patch.
This patch has been applied to fsl-qoriq master, awaiting upstream.
--p