Skip to contentSkip to conversation

staging: fbtft: fix alignment should match open parenthesis

PATCH In review Himadri Pandya 2 participants 3 messages Apr 10, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: fbtft: fix alignment should match open parenthesis

Fix checkpatch warning "Alignment should match open parenthesis".

---
 drivers/staging/fbtft/fb_tinylcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_tinylcd.c +1 -1
index 9469248f2c50..60cda57bcb33 100644
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0xE5, 0x00);
 	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
 	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
-		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
 	write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
 	write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
 	udelay(250);
Signature · 1 line
2.17.1
#1 lore raw
Quoted 12 lines · Himadri Pandya

Fix checkpatch warning "Alignment should match open parenthesis".

---
 drivers/staging/fbtft/fb_tinylcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_tinylcd.c +0 -0
index 9469248f2c50..60cda57bcb33 100644

drivers/staging/fbtft/fb_tinylcd.c static int init_display(struct fbtft_par *par) · line 41

Quoted 5 lines
drivers/staging/fbtft/fb_tinylcd.c +1 -1
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
 	write_reg(par, 0xE5, 0x00);
 	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
 	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
-		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);

The original code was written that way deliberately. I don't know why it's broken up like that but it probably means something to people who have read the hardware spec. I would leave it as-is.

regards,
dan carpenter

#2 lore raw
Quoted 22 lines · Dan Carpenter
Quoted 12 lines · Himadri Pandya

Fix checkpatch warning "Alignment should match open parenthesis".

---
  drivers/staging/fbtft/fb_tinylcd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/fbtft/fb_tinylcd.c +0 -0
index 9469248f2c50..60cda57bcb33 100644

drivers/staging/fbtft/fb_tinylcd.c static int init_display(struct fbtft_par *par) · line 41

Quoted 5 lines
drivers/staging/fbtft/fb_tinylcd.c +1 -1
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
  	write_reg(par, 0xE5, 0x00);
  	write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
  	write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
-		       0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+		  0x00, 0x35, 0x33, 0x00, 0x00, 0x00);

The original code was written that way deliberately. I don't know why it's broken up like that but it probably means something to people who have read the hardware spec. I would leave it as-is.

Quoted 2 lines

regards,
dan carpenter

Okay. Thank you for reviewing it.

- Himadri