Skip to contentSkip to conversation

kni: implement header_ops parse method

PATCH Superseded Igor Ryzhov 4 participants 21 messages Sep 27, 2018 – Apr 19, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kni: implement header_ops parse method

---
 kernel/linux/kni/kni_net.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
kernel/linux/kni/kni_net.c +14 -0
index 7fcfa106c..128a5477c 100644
@@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct net_device *dev,
 	return dev->hard_header_len;
 }
 
+/*
+ *  Extract hardware address from packet
+ */
+static int
+kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
+{
+	const struct ethhdr *eth = eth_hdr(skb);
+
+	memcpy(haddr, eth->h_source, ETH_ALEN);
+
+	return ETH_ALEN;
+}
+
 /*
  * Re-fill the eth header
  */
@@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev, bool new_carrier)
 
 static const struct header_ops kni_net_header_ops = {
 	.create  = kni_net_header,
+	.parse   = kni_net_header_parse,
 #ifdef HAVE_REBUILD_HEADER
 	.rebuild = kni_net_rebuild_header,
 #endif /* < 4.1.0  */
Signature · 1 line
2.19.0
#1 lore raw

kernel/linux/kni/kni_net.c kni_net_header(struct sk_buff *skb, struct net_device *dev, · line 692

Quoted 12 lines · On Thu, 27 Sep 2018 03:02:24 +0300 Igor Ryzhov <[email protected]> wrote:
kernel/linux/kni/kni_net.c +12 -0
+/*
+ *  Extract hardware address from packet
+ */
+static int
+kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
+{
+	const struct ethhdr *eth = eth_hdr(skb);
+
+	memcpy(haddr, eth->h_source, ETH_ALEN);
+
+	return ETH_ALEN;
+}

Kernel has function ether_addr_copy which is marginally faster and commonly used.

#2 lore raw

It's just exact copy of eth_header_parse function from Linux kernel.

No problem, can do that with ether_addr_copy.

Quoted 19 lines · Stephen Hemminger

kernel/linux/kni/kni_net.c kni_net_header(struct sk_buff *skb, struct net_device *dev, · line 692

Quoted 12 lines · On Thu, 27 Sep 2018 03:02:24 +0300 Igor Ryzhov <[email protected]> wrote:
kernel/linux/kni/kni_net.c +12 -0
+/*
+ *  Extract hardware address from packet
+ */
+static int
+kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
+{
+     const struct ethhdr *eth = eth_hdr(skb);
+
+     memcpy(haddr, eth->h_source, ETH_ALEN);
+
+     return ETH_ALEN;
+}

Kernel has function ether_addr_copy which is marginally faster and commonly used.

#3 lore raw

Hello Stephen,

I looked at KNI code again, memcpy is already used everywhere (kni_net_header, kni_net_rebuild_header) for MAC address copy. So I propose to accept the patch as it is.

memcpy can be replaced by ether_addr_copy in all functions at once in separate patch.

Igor

Quoted 27 lines · Igor Ryzhov

It's just exact copy of eth_header_parse function from Linux kernel.

No problem, can do that with ether_addr_copy.

Quoted 19 lines · Stephen Hemminger

kernel/linux/kni/kni_net.c kni_net_header(struct sk_buff *skb, struct net_device *dev, · line 692

Quoted 12 lines · On Thu, 27 Sep 2018 03:02:24 +0300 Igor Ryzhov <[email protected]> wrote:
kernel/linux/kni/kni_net.c +12 -0
+/*
+ *  Extract hardware address from packet
+ */
+static int
+kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
+{
+     const struct ethhdr *eth = eth_hdr(skb);
+
+     memcpy(haddr, eth->h_source, ETH_ALEN);
+
+     return ETH_ALEN;
+}

Kernel has function ether_addr_copy which is marginally faster and commonly used.

#4 lore raw
In reply to Igor Ryzhov
Quoted 1 line · Igor Ryzhov

Hi Igor,

What is the motivation to add this support? What is enabled by this?

Meanwhile, why we are not using eth_header_ops, which is already set by ether_setup().
To disable .cache & .cache_update?

If so why not using relevant eth_header_ops (eth_header, eth_header_parse ..) instead of implementing ours?

Quoted 37 lines
---
 kernel/linux/kni/kni_net.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
kernel/linux/kni/kni_net.c +14 -0
index 7fcfa106c..128a5477c 100644
@@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct net_device *dev,
 	return dev->hard_header_len;
 }
 
+/*
+ *  Extract hardware address from packet
+ */
+static int
+kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
+{
+	const struct ethhdr *eth = eth_hdr(skb);
+
+	memcpy(haddr, eth->h_source, ETH_ALEN);
+
+	return ETH_ALEN;
+}
+
 /*
  * Re-fill the eth header
  */
@@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev, bool new_carrier)
 
 static const struct header_ops kni_net_header_ops = {
 	.create  = kni_net_header,
+	.parse   = kni_net_header_parse,
 #ifdef HAVE_REBUILD_HEADER
 	.rebuild = kni_net_rebuild_header,
 #endif /* < 4.1.0  */
#5 lore raw

Hi Ferruh,

header_ops.parse method is used by raw-sockets to fill sockaddr_ll structure.
It is used, for example, in isisd for frrouting.

Regarding your question about eth_header_ops – I, unfortunately, don't know why .cache and .cache_update are disabled for KNI.
I also think that it will be better to use default eth_header_ops.

Best regards,
Igor

Quoted 57 lines · Ferruh Yigit
Quoted 1 line · Igor Ryzhov

Hi Igor,

What is the motivation to add this support? What is enabled by this?

Meanwhile, why we are not using eth_header_ops, which is already set by ether_setup().
To disable .cache & .cache_update?

If so why not using relevant eth_header_ops (eth_header, eth_header_parse ..)
instead of implementing ours?

kernel/linux/kni/kni_net.c kni_net_header(struct sk_buff *skb, struct

Quoted 9 lines
---
 kernel/linux/kni/kni_net.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
kernel/linux/kni/kni_net.c +0 -0
index 7fcfa106c..128a5477c 100644
@@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct

net_device *dev,

kernel/linux/kni/kni_net.c kni_net_change_carrier(struct net_device *dev, bool

Quoted 20 lines
kernel/linux/kni/kni_net.c +13 -0
      return dev->hard_header_len;
 }
 
+/*
+ *  Extract hardware address from packet
+ */
+static int
+kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
+{
+     const struct ethhdr *eth = eth_hdr(skb);
+
+     memcpy(haddr, eth->h_source, ETH_ALEN);
+
+     return ETH_ALEN;
+}
+
 /*
  * Re-fill the eth header
  */
@@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev, bool

new_carrier)

Quoted 8 lines
kernel/linux/kni/kni_net.c +1 -0
 static const struct header_ops kni_net_header_ops = {
      .create  = kni_net_header,
+     .parse   = kni_net_header_parse,
 #ifdef HAVE_REBUILD_HEADER
      .rebuild = kni_net_rebuild_header,
 #endif /* < 4.1.0  */
 
#6 lore raw

Hi Ferruh,

What about this patch?
Can you merge it as-is, or should I change it to use relevant eth_header_ops functions? Or maybe completely use eth_header_ops?

Best regards,
Igor

Quoted 73 lines · Igor Ryzhov

Hi Ferruh,

header_ops.parse method is used by raw-sockets to fill sockaddr_ll structure.
It is used, for example, in isisd for frrouting.

Regarding your question about eth_header_ops – I, unfortunately, don't know why .cache and .cache_update are disabled for KNI.
I also think that it will be better to use default eth_header_ops.

Best regards,
Igor

Quoted 57 lines · Ferruh Yigit
Quoted 1 line · Igor Ryzhov

Hi Igor,

What is the motivation to add this support? What is enabled by this?

Meanwhile, why we are not using eth_header_ops, which is already set by ether_setup().
To disable .cache & .cache_update?

If so why not using relevant eth_header_ops (eth_header, eth_header_parse ..)
instead of implementing ours?

kernel/linux/kni/kni_net.c kni_net_header(struct sk_buff *skb, struct

Quoted 9 lines
---
 kernel/linux/kni/kni_net.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
kernel/linux/kni/kni_net.c +0 -0
index 7fcfa106c..128a5477c 100644
@@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct

net_device *dev,

kernel/linux/kni/kni_net.c kni_net_change_carrier(struct net_device *dev, bool

Quoted 20 lines
kernel/linux/kni/kni_net.c +13 -0
      return dev->hard_header_len;
 }
 
+/*
+ *  Extract hardware address from packet
+ */
+static int
+kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
+{
+     const struct ethhdr *eth = eth_hdr(skb);
+
+     memcpy(haddr, eth->h_source, ETH_ALEN);
+
+     return ETH_ALEN;
+}
+
 /*
  * Re-fill the eth header
  */
@@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev, bool

new_carrier)

Quoted 8 lines
kernel/linux/kni/kni_net.c +1 -0
 static const struct header_ops kni_net_header_ops = {
      .create  = kni_net_header,
+     .parse   = kni_net_header_parse,
 #ifdef HAVE_REBUILD_HEADER
      .rebuild = kni_net_rebuild_header,
 #endif /* < 4.1.0  */
 
#7 lore raw
Quoted 5 lines · Igor Ryzhov

Hi Ferruh,

What about this patch?
Can you merge it as-is, or should I change it to use relevant eth_header_ops functions? Or maybe completely use eth_header_ops?

Hi Igor,

I am not clear about motivation of the patch, what use case enabled by this patch? What is not working with current code?
I am for rejecting the patch without need justified.

And if the need is justified, still there is a question that why not use 'eth_header_parse()' directly but implement our copy?

And an extended question/investigation about why not use 'eth_header_ops', which seems done intentionally but I am missing the reasoning.

Quoted 79 lines

Best regards,
Igor

On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov <[email protected] <mailto:[email protected]>> wrote:

    Hi Ferruh,

    header_ops.parse method is used by raw-sockets to fill sockaddr_ll structure.
    It is used, for example, in isisd for frrouting.

    Regarding your question about eth_header_ops – I, unfortunately, don't know
    why .cache and .cache_update are disabled for KNI.
    I also think that it will be better to use default eth_header_ops.

    Best regards,
    Igor

    On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit <[email protected]
    <mailto:[email protected]>> wrote:

        On 9/27/2018 1:02 AM, Igor Ryzhov wrote:
        > Signed-off-by: Igor Ryzhov <[email protected]
        <mailto:[email protected]>>

        Hi Igor,

        What is the motivation to add this support? What is enabled by this?


        Meanwhile, why we are not using eth_header_ops, which is already set by
        ether_setup().
        To disable .cache & .cache_update?

        If so why not using relevant eth_header_ops (eth_header,
        eth_header_parse ..)
        instead of implementing ours?

        > ---
        >  kernel/linux/kni/kni_net.c | 14 ++++++++++++++
        >  1 file changed, 14 insertions(+)
        >
        > diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
        > index 7fcfa106c..128a5477c 100644
        > --- a/kernel/linux/kni/kni_net.c
        > +++ b/kernel/linux/kni/kni_net.c
        > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct
        net_device *dev,
        >       return dev->hard_header_len;
        >  }
        > 
        > +/*
        > + *  Extract hardware address from packet
        > + */
        > +static int
        > +kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
        > +{
        > +     const struct ethhdr *eth = eth_hdr(skb);
        > +
        > +     memcpy(haddr, eth->h_source, ETH_ALEN);
        > +
        > +     return ETH_ALEN;
        > +}
        > +
        >  /*
        >   * Re-fill the eth header
        >   */
        > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev,
        bool new_carrier)
        > 
        >  static const struct header_ops kni_net_header_ops = {
        >       .create  = kni_net_header,
        > +     .parse   = kni_net_header_parse,
        >  #ifdef HAVE_REBUILD_HEADER
        >       .rebuild = kni_net_rebuild_header,
        >  #endif /* < 4.1.0  */
        >
#8 lore raw

Hi Ferruh,

I already answered your question in my previous email, header_ops.parse method is used by packet(7) interface for packet parsing and filling sockaddr_ll structure.
Here is the link on the usage –
https://elixir.bootlin.com/linux/latest/source/net/packet/af_packet.c#L2100

Regarding the question about eth_header_ops usage:
Right now both already existing functions, kni_net_header and kni_net_rebuild_header, are implemented as copies, not using eth_header_ops functions.
That's why I think my patch should be accepted as is, and the problem of eth_header_ops usage should be investigated separately, and possibly resolved by a separate patch.

Best regards,
Igor

Quoted 110 lines · Ferruh Yigit
Quoted 4 lines · Igor Ryzhov

Hi Ferruh,

What about this patch?
Can you merge it as-is, or should I change it to use relevant

eth_header_ops

Quoted 1 line

functions? Or maybe completely use eth_header_ops?

Hi Igor,

I am not clear about motivation of the patch, what use case enabled by this patch? What is not working with current code?
I am for rejecting the patch without need justified.

And if the need is justified, still there is a question that why not use 'eth_header_parse()' directly but implement our copy?

And an extended question/investigation about why not use 'eth_header_ops', which
seems done intentionally but I am missing the reasoning.

Quoted 10 lines

Best regards,
Igor

On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov <[email protected] <mailto:[email protected]>> wrote:

Hi Ferruh,

header_ops.parse method is used by raw-sockets to fill sockaddr_ll

structure.

Quoted 3 lines

It is used, for example, in isisd for frrouting.

Regarding your question about eth_header_ops – I, unfortunately,

don't know

Quoted 9 lines

why .cache and .cache_update are disabled for KNI.
I also think that it will be better to use default eth_header_ops.

Best regards,
Igor

On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

Quoted 7 lines

On 9/27/2018 1:02 AM, Igor Ryzhov wrote:
> Signed-off-by: Igor Ryzhov <[email protected] <mailto:[email protected]>>

Hi Igor,

What is the motivation to add this support? What is enabled by

this?

Quoted 3 lines

Meanwhile, why we are not using eth_header_ops, which is already

set by

Quoted 4 lines
        ether_setup().
        To disable .cache & .cache_update?

        If so why not using relevant eth_header_ops (eth_header,
Quoted 8 lines
        eth_header_parse ..)
        instead of implementing ours?

        > ---
        >  kernel/linux/kni/kni_net.c | 14 ++++++++++++++
        >  1 file changed, 14 insertions(+)
        >
        > diff --git a/kernel/linux/kni/kni_net.c

b/kernel/linux/kni/kni_net.c

Quoted 5 lines
        > index 7fcfa106c..128a5477c 100644
        > --- a/kernel/linux/kni/kni_net.c
        > +++ b/kernel/linux/kni/kni_net.c
        > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct
        net_device *dev,
Quoted 8 lines
        >       return dev->hard_header_len;
        >  }
        >
        > +/*
        > + *  Extract hardware address from packet
        > + */
        > +static int
        > +kni_net_header_parse(const struct sk_buff *skb, unsigned char

*haddr)

Quoted 4 lines
        > +{
        > +     const struct ethhdr *eth = eth_hdr(skb);
        > +
        > +     memcpy(haddr, eth->h_source, ETH_ALEN);
Quoted 8 lines
        > +
        > +     return ETH_ALEN;
        > +}
        > +
        >  /*
        >   * Re-fill the eth header
        >   */
        > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device

*dev,

Quoted 10 lines

bool new_carrier)
>
> static const struct header_ops kni_net_header_ops = {
> .create = kni_net_header,
> + .parse = kni_net_header_parse,
> #ifdef HAVE_REBUILD_HEADER
> .rebuild = kni_net_rebuild_header,
> #endif /* < 4.1.0 */
>

#9 lore raw
Quoted 6 lines · Igor Ryzhov

Hi Ferruh,

I already answered your question in my previous email, header_ops.parse method is used by packet(7) interface for packet parsing and filling sockaddr_ll structure. Here is the link on the usage –
https://elixir.bootlin.com/linux/latest/source/net/packet/af_packet.c#L2100

I saw your previous reply. That is why changed the question slightly, from 'what it does' to 'what is the use case'.
Trying to understand do we need it, please help me understand.

Quoted 5 lines

Regarding the question about eth_header_ops usage:
Right now both already existing functions, kni_net_header and kni_net_rebuild_header, are implemented as copies, not using eth_header_ops functions.

OK, I see your reasoning, but if there is an already Linux API that does what we want, I suggest calling it instead of re-implementing it, unless there is a good reason to not do so.

Quoted 3 lines

That's why I think my patch should be accepted as is, and the problem of eth_header_ops usage should be investigated separately, and possibly resolved by a separate patch.

Agreed, eth_header_ops usage should be investigated separately.

Quoted 114 lines

Best regards,
Igor

On Thu, Jan 24, 2019 at 5:10 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

On 1/24/2019 9:18 AM, Igor Ryzhov wrote:
> Hi Ferruh,
>
> What about this patch?
> Can you merge it as-is, or should I change it to use relevant eth_header_ops > functions? Or maybe completely use eth_header_ops?

Hi Igor,

I am not clear about motivation of the patch, what use case enabled by this patch? What is not working with current code?
I am for rejecting the patch without need justified.

And if the need is justified, still there is a question that why not use 'eth_header_parse()' directly but implement our copy?

And an extended question/investigation about why not use 'eth_header_ops', which seems done intentionally but I am missing the reasoning.

>
> Best regards,
> Igor
>
> On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov <[email protected] <mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>> wrote:
>
>     Hi Ferruh,
>
>     header_ops.parse method is used by raw-sockets to fill sockaddr_ll structure.
>     It is used, for example, in isisd for frrouting.
>
>     Regarding your question about eth_header_ops – I, unfortunately, don't know
>     why .cache and .cache_update are disabled for KNI.
>     I also think that it will be better to use default eth_header_ops. >
>     Best regards,
>     Igor
>
>     On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit <[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>>> wrote:
>
>         On 9/27/2018 1:02 AM, Igor Ryzhov wrote:
>         > Signed-off-by: Igor Ryzhov <[email protected] <mailto:[email protected]>
>         <mailto:[email protected] <mailto:[email protected]>>> >
>         Hi Igor,
>
>         What is the motivation to add this support? What is enabled by this? >
>
>         Meanwhile, why we are not using eth_header_ops, which is already set by
>         ether_setup().
>         To disable .cache & .cache_update?
>
>         If so why not using relevant eth_header_ops (eth_header, >         eth_header_parse ..)
>         instead of implementing ours?
>
>         > ---
>         >  kernel/linux/kni/kni_net.c | 14 ++++++++++++++
>         >  1 file changed, 14 insertions(+)
>         >
>         > diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c >         > index 7fcfa106c..128a5477c 100644
>         > --- a/kernel/linux/kni/kni_net.c
>         > +++ b/kernel/linux/kni/kni_net.c
>         > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct >         net_device *dev,
>         >       return dev->hard_header_len;
>         >  }
>         >
>         > +/*
>         > + *  Extract hardware address from packet
>         > + */
>         > +static int
>         > +kni_net_header_parse(const struct sk_buff *skb, unsigned char *haddr)
>         > +{
>         > +     const struct ethhdr *eth = eth_hdr(skb);
>         > +
>         > +     memcpy(haddr, eth->h_source, ETH_ALEN);
>         > +
>         > +     return ETH_ALEN;
>         > +}
>         > +
>         >  /*
>         >   * Re-fill the eth header
>         >   */
>         > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev, >         bool new_carrier)
>         >
>         >  static const struct header_ops kni_net_header_ops = { >         >       .create  = kni_net_header,
>         > +     .parse   = kni_net_header_parse,
>         >  #ifdef HAVE_REBUILD_HEADER
>         >       .rebuild = kni_net_rebuild_header,
>         >  #endif /* < 4.1.0  */
>         >
>

#10 lore raw

Hi Ferruh,

Ok, no problem. Generally, it is needed for all applications using packet(7) interface, running over KNI interfaces.
More specifically, one example of such application is FRRouting, I suppose you are familiar with it.
FRR's ISIS daemon is using AF_PACKET sockets and checking received sockaddr_ll.
Here is the link on one of the usages –
https://github.com/FRRouting/frr/blob/master/isisd/isis_pfpacket.c#L294

When we are good with motivation, I'll send v2 using eth_header_parse.

Best regards,
Igor

Quoted 167 lines · Ferruh Yigit
Quoted 3 lines · Igor Ryzhov

Hi Ferruh,

I already answered your question in my previous email, header_ops.parse

method

Quoted 1 line

is used by packet(7) interface for packet parsing and filling

sockaddr_ll structure.

Quoted 2 lines

Here is the link on the usage –

https://elixir.bootlin.com/linux/latest/source/net/packet/af_packet.c#L2100

I saw your previous reply. That is why changed the question slightly, from 'what
it does' to 'what is the use case'.
Trying to understand do we need it, please help me understand.

Quoted 4 lines

Regarding the question about eth_header_ops usage:
Right now both already existing functions, kni_net_header and kni_net_rebuild_header, are implemented as copies, not using

eth_header_ops

Quoted 1 line

functions.

OK, I see your reasoning, but if there is an already Linux API that does what we
want, I suggest calling it instead of re-implementing it, unless there is a good
reason to not do so.

Quoted 2 lines

That's why I think my patch should be accepted as is, and the problem of eth_header_ops usage should be investigated separately, and possibly

resolved by

Quoted 1 line

a separate patch.

Agreed, eth_header_ops usage should be investigated separately.

Quoted 4 lines

Best regards,
Igor

Quoted 8 lines

On Thu, Jan 24, 2019 at 5:10 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

On 1/24/2019 9:18 AM, Igor Ryzhov wrote:
> Hi Ferruh,
>
> What about this patch?
> Can you merge it as-is, or should I change it to use relevant

eth_header_ops

Quoted 5 lines
Quoted 1 line

functions? Or maybe completely use eth_header_ops?

Hi Igor,

I am not clear about motivation of the patch, what use case enabled

by this

Quoted 4 lines

patch? What is not working with current code? I am for rejecting the patch without need justified.

And if the need is justified, still there is a question that why not

use

Quoted 4 lines

'eth_header_parse()' directly but implement our copy?

And an extended question/investigation about why not use

'eth_header_ops', which

Quoted 6 lines

seems done intentionally but I am missing the reasoning.

>
> Best regards,
> Igor
>

Quoted 7 lines

> On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov <[email protected] <mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>> wrote:
>
> Hi Ferruh,
>
> header_ops.parse method is used by raw-sockets to

fill sockaddr_ll

Quoted 4 lines

structure.
> It is used, for example, in isisd for frrouting.
>
> Regarding your question about eth_header_ops – I,

unfortunately, don't

Quoted 3 lines

know
> why .cache and .cache_update are disabled for KNI.
> I also think that it will be better to use default

eth_header_ops.

Quoted 5 lines
Quoted 5 lines
    Best regards,
    Igor

    On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit <

[email protected]

Quoted 2 lines

<mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>>

Quoted 9 lines · wrote:
Quoted 3 lines · Igor Ryzhov

> Signed-off-by: Igor Ryzhov <[email protected]

<mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>>
>
> Hi Igor,
>
> What is the motivation to add this support? What is

enabled by this?

Quoted 3 lines
Quoted 3 lines

Meanwhile, why we are not using eth_header_ops, which is

already

Quoted 8 lines

set by
> ether_setup().
> To disable .cache & .cache_update?
>
> If so why not using relevant eth_header_ops (eth_header,
> eth_header_parse ..)
> instead of implementing ours?
>

Quoted 5 lines

> > ---
> > kernel/linux/kni/kni_net.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/kernel/linux/kni/kni_net.c

b/kernel/linux/kni/kni_net.c

Quoted 4 lines
Quoted 4 lines
        > index 7fcfa106c..128a5477c 100644
        > --- a/kernel/linux/kni/kni_net.c
        > +++ b/kernel/linux/kni/kni_net.c
        > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb,

struct

Quoted 9 lines
Quoted 9 lines
        net_device *dev,
        >       return dev->hard_header_len;
        >  }
        >
        > +/*
        > + *  Extract hardware address from packet
        > + */
        > +static int
        > +kni_net_header_parse(const struct sk_buff *skb,

unsigned char

Quoted 5 lines
    *haddr)
    >         > +{
    >         > +     const struct ethhdr *eth = eth_hdr(skb);
    >         > +
    >         > +     memcpy(haddr, eth->h_source, ETH_ALEN);
Quoted 8 lines
    >         > +
    >         > +     return ETH_ALEN;
    >         > +}
    >         > +
    >         >  /*
    >         >   * Re-fill the eth header
    >         >   */
    >         > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct

net_device *dev,

Quoted 11 lines
Quoted 10 lines

bool new_carrier)
>
> static const struct header_ops kni_net_header_ops = {
> .create = kni_net_header,
> + .parse = kni_net_header_parse,
> #ifdef HAVE_REBUILD_HEADER
> .rebuild = kni_net_rebuild_header,
> #endif /* < 4.1.0 */
>

#11 lore raw

Hi Ferruh,

Can we proceed with this patch?

Igor

Quoted 186 lines · Igor Ryzhov

Hi Ferruh,

Ok, no problem. Generally, it is needed for all applications using packet(7) interface, running over KNI interfaces.
More specifically, one example of such application is FRRouting, I suppose you are familiar with it.
FRR's ISIS daemon is using AF_PACKET sockets and checking received sockaddr_ll.
Here is the link on one of the usages –
https://github.com/FRRouting/frr/blob/master/isisd/isis_pfpacket.c#L294

When we are good with motivation, I'll send v2 using eth_header_parse.

Best regards,
Igor

Quoted 167 lines · Ferruh Yigit
Quoted 3 lines · Igor Ryzhov

Hi Ferruh,

I already answered your question in my previous email, header_ops.parse

method

Quoted 1 line

is used by packet(7) interface for packet parsing and filling

sockaddr_ll structure.

Quoted 2 lines

Here is the link on the usage –

https://elixir.bootlin.com/linux/latest/source/net/packet/af_packet.c#L2100

I saw your previous reply. That is why changed the question slightly, from 'what
it does' to 'what is the use case'.
Trying to understand do we need it, please help me understand.

Quoted 4 lines

Regarding the question about eth_header_ops usage:
Right now both already existing functions, kni_net_header and kni_net_rebuild_header, are implemented as copies, not using

eth_header_ops

Quoted 1 line

functions.

OK, I see your reasoning, but if there is an already Linux API that does what we
want, I suggest calling it instead of re-implementing it, unless there is a good
reason to not do so.

Quoted 2 lines

That's why I think my patch should be accepted as is, and the problem of eth_header_ops usage should be investigated separately, and possibly

resolved by

Quoted 1 line

a separate patch.

Agreed, eth_header_ops usage should be investigated separately.

Quoted 4 lines

Best regards,
Igor

Quoted 8 lines

On Thu, Jan 24, 2019 at 5:10 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

On 1/24/2019 9:18 AM, Igor Ryzhov wrote:
> Hi Ferruh,
>
> What about this patch?
> Can you merge it as-is, or should I change it to use relevant

eth_header_ops

Quoted 5 lines
Quoted 1 line

functions? Or maybe completely use eth_header_ops?

Hi Igor,

I am not clear about motivation of the patch, what use case enabled

by this

Quoted 4 lines

patch? What is not working with current code? I am for rejecting the patch without need justified.

And if the need is justified, still there is a question that why

not use

Quoted 4 lines

'eth_header_parse()' directly but implement our copy?

And an extended question/investigation about why not use

'eth_header_ops', which

Quoted 6 lines

seems done intentionally but I am missing the reasoning.

>
> Best regards,
> Igor
>

Quoted 7 lines

> On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov <[email protected] <mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>> wrote:
>
> Hi Ferruh,
>
> header_ops.parse method is used by raw-sockets to

fill sockaddr_ll

Quoted 4 lines

structure.
> It is used, for example, in isisd for frrouting.
>
> Regarding your question about eth_header_ops – I,

unfortunately, don't

Quoted 3 lines

know
> why .cache and .cache_update are disabled for KNI.
> I also think that it will be better to use default

eth_header_ops.

Quoted 5 lines
Quoted 5 lines
    Best regards,
    Igor

    On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit <

[email protected]

Quoted 2 lines

<mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>>

Quoted 9 lines · wrote:
Quoted 3 lines · Igor Ryzhov

> Signed-off-by: Igor Ryzhov <[email protected]

<mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>>
>
> Hi Igor,
>
> What is the motivation to add this support? What is

enabled by this?

Quoted 3 lines
Quoted 3 lines

Meanwhile, why we are not using eth_header_ops, which is

already

Quoted 8 lines

set by
> ether_setup().
> To disable .cache & .cache_update?
>
> If so why not using relevant eth_header_ops (eth_header,
> eth_header_parse ..)
> instead of implementing ours?
>

Quoted 5 lines

> > ---
> > kernel/linux/kni/kni_net.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/kernel/linux/kni/kni_net.c

b/kernel/linux/kni/kni_net.c

Quoted 4 lines
Quoted 4 lines
        > index 7fcfa106c..128a5477c 100644
        > --- a/kernel/linux/kni/kni_net.c
        > +++ b/kernel/linux/kni/kni_net.c
        > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff

*skb, struct

Quoted 9 lines
Quoted 9 lines
        net_device *dev,
        >       return dev->hard_header_len;
        >  }
        >
        > +/*
        > + *  Extract hardware address from packet
        > + */
        > +static int
        > +kni_net_header_parse(const struct sk_buff *skb,

unsigned char

Quoted 5 lines
    *haddr)
    >         > +{
    >         > +     const struct ethhdr *eth = eth_hdr(skb);
    >         > +
    >         > +     memcpy(haddr, eth->h_source, ETH_ALEN);
Quoted 8 lines
    >         > +
    >         > +     return ETH_ALEN;
    >         > +}
    >         > +
    >         >  /*
    >         >   * Re-fill the eth header
    >         >   */
    >         > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct

net_device *dev,

Quoted 11 lines
Quoted 10 lines

bool new_carrier)
>
> static const struct header_ops kni_net_header_ops = {
> .create = kni_net_header,
> + .parse = kni_net_header_parse,
> #ifdef HAVE_REBUILD_HEADER
> .rebuild = kni_net_rebuild_header,
> #endif /* < 4.1.0 */
>

#12 lore raw
Quoted 19 lines · Igor Ryzhov

Hi Ferruh,

Can we proceed with this patch?

Igor

On Thu, Jan 24, 2019 at 9:05 PM Igor Ryzhov <[email protected] <mailto:[email protected]>> wrote:

Hi Ferruh,

Ok, no problem. Generally, it is needed for all applications using packet(7) interface, running over KNI interfaces.
More specifically, one example of such application is FRRouting, I suppose you are familiar with it.
FRR's ISIS daemon is using AF_PACKET sockets and checking received sockaddr_ll. Here is the link on one of the usages
– https://github.com/FRRouting/frr/blob/master/isisd/isis_pfpacket.c#L294

Quoted 1 line

When we are good with motivation, I'll send v2 using eth_header_parse.

Hi Igor,

Sorry for the delay, thanks for the clarification on patch. Can you please send v2 with 'eth_header_parse'? And please include above information in commit log.

Thanks,
ferruh

Quoted 179 lines

Best regards,
Igor

On Thu, Jan 24, 2019 at 8:15 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

On 1/24/2019 4:35 PM, Igor Ryzhov wrote:
> Hi Ferruh,
>
> I already answered your question in my previous email, header_ops.parse method
> is used by packet(7) interface for packet parsing and filling sockaddr_ll structure.
> Here is the link on the usage –
>
https://elixir.bootlin.com/linux/latest/source/net/packet/af_packet.c#L2100

I saw your previous reply. That is why changed the question slightly, from 'what
it does' to 'what is the use case'.
Trying to understand do we need it, please help me understand.

>
> Regarding the question about eth_header_ops usage:
> Right now both already existing functions, kni_net_header and > kni_net_rebuild_header, are implemented as copies, not using eth_header_ops
> functions.

OK, I see your reasoning, but if there is an already Linux API that does what we
want, I suggest calling it instead of re-implementing it, unless there is a good
reason to not do so.

> That's why I think my patch should be accepted as is, and the problem of > eth_header_ops usage should be investigated separately, and possibly resolved by
> a separate patch.

Agreed, eth_header_ops usage should be investigated separately.

>
> Best regards,
> Igor
>
> On Thu, Jan 24, 2019 at 5:10 PM Ferruh Yigit <[email protected] <mailto:[email protected]>
> <mailto:[email protected] <mailto:[email protected]>>> wrote:
>
>     On 1/24/2019 9:18 AM, Igor Ryzhov wrote:
>     > Hi Ferruh,
>     >
>     > What about this patch?
>     > Can you merge it as-is, or should I change it to use relevant eth_header_ops
>     > functions? Or maybe completely use eth_header_ops?
>
>     Hi Igor,
>
>     I am not clear about motivation of the patch, what use case enabled by this
>     patch? What is not working with current code?
>     I am for rejecting the patch without need justified.
>
>     And if the need is justified, still there is a question that why not use
>     'eth_header_parse()' directly but implement our copy? >
>
>     And an extended question/investigation about why not use 'eth_header_ops', which
>     seems done intentionally but I am missing the reasoning. >
>     >
>     > Best regards,
>     > Igor
>     >
>     > On Fri, Nov 30, 2018 at 10:07 PM Igor Ryzhov <[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>> >     > <mailto:[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>>> wrote:
>     >
>     >     Hi Ferruh,
>     >
>     >     header_ops.parse method is used by raw-sockets to fill sockaddr_ll
>     structure.
>     >     It is used, for example, in isisd for frrouting. >     >
>     >     Regarding your question about eth_header_ops – I, unfortunately, don't
>     know
>     >     why .cache and .cache_update are disabled for KNI. >     >     I also think that it will be better to use default eth_header_ops.
>     >
>     >     Best regards,
>     >     Igor
>     >
>     >     On Tue, Oct 2, 2018 at 7:58 PM Ferruh Yigit <[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>> >     >     <mailto:[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>>> wrote:
>     >
>     >         On 9/27/2018 1:02 AM, Igor Ryzhov wrote:
>     >         > Signed-off-by: Igor Ryzhov <[email protected] <mailto:[email protected]>
>     <mailto:[email protected] <mailto:[email protected]>> >     >         <mailto:[email protected] <mailto:[email protected]> <mailto:[email protected] <mailto:[email protected]>>>>
>     >
>     >         Hi Igor,
>     >
>     >         What is the motivation to add this support? What is enabled by this?
>     >
>     >
>     >         Meanwhile, why we are not using eth_header_ops, which is already
>     set by
>     >         ether_setup().
>     >         To disable .cache & .cache_update?
>     >
>     >         If so why not using relevant eth_header_ops (eth_header, >     >         eth_header_parse ..)
>     >         instead of implementing ours?
>     >
>     >         > ---
>     >         >  kernel/linux/kni/kni_net.c | 14 ++++++++++++++ >     >         >  1 file changed, 14 insertions(+)
>     >         >
>     >         > diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c
>     >         > index 7fcfa106c..128a5477c 100644
>     >         > --- a/kernel/linux/kni/kni_net.c
>     >         > +++ b/kernel/linux/kni/kni_net.c
>     >         > @@ -678,6 +678,19 @@ kni_net_header(struct sk_buff *skb, struct
>     >         net_device *dev,
>     >         >       return dev->hard_header_len;
>     >         >  }
>     >         >
>     >         > +/*
>     >         > + *  Extract hardware address from packet >     >         > + */
>     >         > +static int
>     >         > +kni_net_header_parse(const struct sk_buff *skb, unsigned char
>     *haddr)
>     >         > +{
>     >         > +     const struct ethhdr *eth = eth_hdr(skb); >     >         > +
>     >         > +     memcpy(haddr, eth->h_source, ETH_ALEN); >     >         > +
>     >         > +     return ETH_ALEN;
>     >         > +}
>     >         > +
>     >         >  /*
>     >         >   * Re-fill the eth header
>     >         >   */
>     >         > @@ -739,6 +752,7 @@ kni_net_change_carrier(struct net_device *dev,
>     >         bool new_carrier)
>     >         >
>     >         >  static const struct header_ops kni_net_header_ops = { >     >         >       .create  = kni_net_header,
>     >         > +     .parse   = kni_net_header_parse,
>     >         >  #ifdef HAVE_REBUILD_HEADER
>     >         >       .rebuild = kni_net_rebuild_header,
>     >         >  #endif /* < 4.1.0  */
>     >         >
>     >
>

#13 lore raw

PATCH v2 1/1 kni: implement header_ops parse method

In reply to Igor Ryzhov

It allows applications running packet sockets over KNI interfaces to get source Ethernet addresses of packets received using recvfrom function.

---
v2:
Use eth_header_parse instead of own implementation.

---
 kernel/linux/kni/kni_net.c | 1 +
 1 file changed, 1 insertion(+)
kernel/linux/kni/kni_net.c +1 -0
index be9e6b0b9..ad8365877 100644
@@ -744,6 +744,7 @@ kni_net_change_carrier(struct net_device *dev, bool new_carrier)
 
 static const struct header_ops kni_net_header_ops = {
 	.create  = kni_net_header,
+	.parse   = eth_header_parse,
 #ifdef HAVE_REBUILD_HEADER
 	.rebuild = kni_net_rebuild_header,
 #endif /* < 4.1.0  */
Signature · 1 line
2.21.0
Acked-by on v2 1/1
#14 lore raw
Quoted 4 lines · Igor Ryzhov

It allows applications running packet sockets over KNI interfaces to get source Ethernet addresses of packets received using recvfrom function.

Hi Igor,

I tested this with a quick application on top of kni interfaces, that reads and prints the 'sll_halen', but the last two bytes of the mac address are always zero, it is quite possible that something is not right in the test app, but before spending any time on it, can you please confirm this is working fine for you?

#15 lore raw
Quoted 6 lines · Ferruh Yigit
Quoted 4 lines · Igor Ryzhov

It allows applications running packet sockets over KNI interfaces to get source Ethernet addresses of packets received using recvfrom function.

Quoted 7 lines

Hi Igor,

I tested this with a quick application on top of kni interfaces, that reads and prints the 'sll_halen', but the last two bytes of the mac address are always

I mean 'sll_addr', 'sll_halen' is right (6).

Quoted 3 lines

zero, it is quite possible that something is not right in the test app, but before spending any time on it, can you please confirm this is working fine for you?

#16 lore raw

Hi Ferruh,

I didn't test it with any special application, but FRR's ISIS works for me after the patch, and it didn't work before.

Igor

Quoted 26 lines · Ferruh Yigit
Quoted 4 lines · Ferruh Yigit
Quoted 3 lines · Igor Ryzhov

It allows applications running packet sockets over KNI interfaces to get source Ethernet addresses of packets received using recvfrom function.

Quoted 8 lines
Quoted 1 line

Hi Igor,

I tested this with a quick application on top of kni interfaces, that

reads and

Quoted 1 line

prints the 'sll_halen', but the last two bytes of the mac address are

always

I mean 'sll_addr', 'sll_halen' is right (6).

Quoted 1 line

zero, it is quite possible that something is not right in the test app,

but

Quoted 1 line

before spending any time on it, can you please confirm this is working

fine for you?

Quoted 1 line
#17 lore raw
Quoted 4 lines · Igor Ryzhov

Hi Ferruh,

I didn't test it with any special application, but FRR's ISIS works for me after the patch, and it didn't work before.

That is good enough, and by work you mean that you are able to get correct value on 'sll_addr', right?

Quoted 30 lines

Igor

On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

On 4/12/2019 3:52 PM, Ferruh Yigit wrote:
> On 4/10/2019 11:30 AM, Igor Ryzhov wrote:
>> It allows applications running packet sockets over KNI interfaces to get >> source Ethernet addresses of packets received using recvfrom function. >>
>> Signed-off-by: Igor Ryzhov <[email protected] <mailto:[email protected]>> >
> Acked-by: Ferruh Yigit <[email protected] <mailto:[email protected]>>
>
>
> Hi Igor,
>
> I tested this with a quick application on top of kni interfaces, that reads and
> prints the 'sll_halen', but the last two bytes of the mac address are always

I mean 'sll_addr', 'sll_halen' is right (6).

> zero, it is quite possible that something is not right in the test app, but > before spending any time on it, can you please confirm this is working fine for you?
>

#18 lore raw

Hi Ferruh,

To be absolutely sure, I performed a test using the test application.

When I send pings from an interface:
3: ens8: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000

    link/ether 52:54:00:c8:79:c6 brd ff:ff:ff:ff:ff:ff

Here is what's in sockaddr_ll:
$2 = {sll_family = 0x11, sll_protocol = 0x8, sll_ifindex = 0x2, sll_hatype

= 0x1, sll_pkttype = 0x0, sll_halen = 0x6, sll_addr = {
    0x52, 0x54, 0x0, 0xc8, 0x79, 0xc6, 0x0, 0x0}}

So everything works as expected – the address in sll_addr is correct. Last two bytes are zero because the length of sll_addr is 8, however, Ethernet length is 6.

Igor

Quoted 50 lines · Ferruh Yigit
Quoted 3 lines · Igor Ryzhov

Hi Ferruh,

I didn't test it with any special application, but FRR's ISIS works for

me after

Quoted 1 line

the patch, and it didn't work before.

That is good enough, and by work you mean that you are able to get correct value
on 'sll_addr', right?

Quoted 9 lines

Igor

On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

    On 4/12/2019 3:52 PM, Ferruh Yigit wrote:
    > On 4/10/2019 11:30 AM, Igor Ryzhov wrote:
    >> It allows applications running packet sockets over KNI interfaces

to get

Quoted 1 line
Quoted 1 line
Quoted 1 line

source Ethernet addresses of packets received using recvfrom

function.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

[email protected]>>

Quoted 8 lines
Quoted 2 lines
    <mailto:[email protected]>>
    >
    >
    > Hi Igor,
    >
    > I tested this with a quick application on top of kni interfaces,

that

Quoted 2 lines

reads and
> prints the 'sll_halen', but the last two bytes of the mac address

are always

Quoted 4 lines

I mean 'sll_addr', 'sll_halen' is right (6).

> zero, it is quite possible that something is not right in the test

app, but

Quoted 1 line
Quoted 1 line

before spending any time on it, can you please confirm this is

working

Quoted 3 lines

fine for you?
>

#19 lore raw
Quoted 9 lines · Igor Ryzhov

Hi Ferruh,

To be absolutely sure, I performed a test using the test application.

When I send pings from an interface:
3: ens8: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc pfifo_fast state UP mode DEFAULT group default qlen 1000

    link/ether 52:54:00:c8:79:c6 brd ff:ff:ff:ff:ff:ff
Quoted 8 lines

Here is what's in sockaddr_ll:
$2 = {sll_family = 0x11, sll_protocol = 0x8, sll_ifindex = 0x2, sll_hatype

= 0x1, sll_pkttype = 0x0, sll_halen = 0x6, sll_addr = {
    0x52, 0x54, 0x0, 0xc8, 0x79, 0xc6, 0x0, 0x0}}

So everything works as expected – the address in sll_addr is correct. Last two bytes are zero because the length of sll_addr is 8, however, Ethernet length is 6.

Perfect, thanks for confirming, I am OK with the patch.

For my case sll_halen = 0x6 but only first 4 byte of the sll_addr was the valid, so it was not the issue of size of sll_addr being 8, anyway it was quick dirty app, something should be wrong, I believe not need to dig it more.

Quoted 55 lines

Igor

Quoted 50 lines · Ferruh Yigit
Quoted 3 lines · Igor Ryzhov

Hi Ferruh,

I didn't test it with any special application, but FRR's ISIS works for

me after

Quoted 1 line

the patch, and it didn't work before.

That is good enough, and by work you mean that you are able to get correct value
on 'sll_addr', right?

Quoted 9 lines

Igor

On Fri, Apr 12, 2019 at 5:53 PM Ferruh Yigit <[email protected] <mailto:[email protected]>> wrote:

    On 4/12/2019 3:52 PM, Ferruh Yigit wrote:
    > On 4/10/2019 11:30 AM, Igor Ryzhov wrote:
    >> It allows applications running packet sockets over KNI interfaces

to get

Quoted 1 line
Quoted 1 line
Quoted 1 line

source Ethernet addresses of packets received using recvfrom

function.

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

[email protected]>>

Quoted 8 lines
Quoted 2 lines
    <mailto:[email protected]>>
    >
    >
    > Hi Igor,
    >
    > I tested this with a quick application on top of kni interfaces,

that

Quoted 2 lines

reads and
> prints the 'sll_halen', but the last two bytes of the mac address

are always

Quoted 4 lines

I mean 'sll_addr', 'sll_halen' is right (6).

> zero, it is quite possible that something is not right in the test

app, but

Quoted 1 line
Quoted 1 line

before spending any time on it, can you please confirm this is

working

Quoted 3 lines

fine for you?
>