Skip to contentSkip to conversation

package/vim: move common configure options to separate variable

PATCH New Vadim Kochan 2 participants 2 messages Apr 7, 2019 – Apr 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/vim: move common configure options to separate variable

Move configure options which are used for host and target to separate variable.

---
 package/vim/vim.mk | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
package/vim/vim.mk +3 -5
index c19d835632..739dde091d 100644
@@ -20,7 +20,8 @@ VIM_CONF_ENV = \
 	ac_cv_sizeof_int=4 \
 	ac_cv_small_wchar_t=no
 # GUI/X11 headers leak from the host so forcibly disable them
-VIM_CONF_OPTS = --with-tlib=ncurses --enable-gui=no --without-x
+VIM_CONF_OPTS_COMMON = --with-tlib=ncurses --enable-gui=no --without-x
+VIM_CONF_OPTS = $(VIM_CONF_OPTS_COMMON)
 VIM_LICENSE = Charityware
 VIM_LICENSE_FILES = README.txt
 
@@ -80,10 +81,7 @@ VIM_POST_INSTALL_TARGET_HOOKS += VIM_REMOVE_DOCS
 endif
 
 HOST_VIM_DEPENDENCIES = host-ncurses
-HOST_VIM_CONF_OPTS = \
-	--with-tlib=ncurses \
-	--enable-gui=no \
-	--without-x \
+HOST_VIM_CONF_OPTS = $(VIM_CONF_OPTS_COMMON) \
 	--disable-acl \
 	--disable-gpm \
 	--disable-selinux
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 package/vim: move common configure options to separate variable

Hello,

Quoted 7 lines · On Sun, 7 Apr 2019 18:04:15 +0300 Vadim Kochan <[email protected]> wrote:

Move configure options which are used for host and target to separate variable.

---
 package/vim/vim.mk | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

I'm afraid we don't typically do that in most packages. We prefer to have a clear and separate set of options for the target and host variants.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com