Skip to contentSkip to conversation

FSCTL write support

PATCH New Ronnie Sahlberg 4 participants 7 messages Apr 11, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover FSCTL write support

Steve,
This patch adds code to allow us to do fsctl passthrough for fsctl types that need to pass data to the server.
This not only needs to pass the blob to the server but also need to decode the access-type part of the fsctl code and change the arguments to the CREATE accordingly.

The values for the access are from wireshark traces of win16 -> win16. For now I only implement the special handling we need for FILE_READ_WRITE_ACCESS.
We can add the others as needed and as we we discover them while adding new functions to smbinfo.

#1 lore raw

PATCH 1/1 cifs: Add support for FSCTL passthrough that write data to the server

Add support to pass a blob to the server in FSCTL passthrough.

---
 fs/cifs/smb2ops.c  | 17 +++++++++++++++--
 fs/cifs/smbfsctl.h | 27 +++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +15 -2
index 83a100dd2497..bb7522b882ea 100644
@@ -1382,6 +1382,18 @@ smb2_ioctl_query_info(const unsigned int xid,
 	oparms.fid = &fid;
 	oparms.reconnect = false;
 
+	/*
+	 * FSCTL codes encode the special access they need in the fsctl code.
+	 */
+	if (qi.flags & PASSTHRU_FSCTL) {
+		switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {
+		case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:
+			oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
+			;
+			break;
+		}
+	}
+
 	rc = SMB2_open_init(tcon, &rqst[0], &oplock, &oparms, path);
 	if (rc)
 		goto iqinf_exit;
@@ -1399,8 +1411,9 @@ smb2_ioctl_query_info(const unsigned int xid,
 
 			rc = SMB2_ioctl_init(tcon, &rqst[1],
 					     COMPOUND_FID, COMPOUND_FID,
-					     qi.info_type, true, NULL,
-					     0, CIFSMaxBufSize);
+					     qi.info_type, true, buffer,
+					     qi.output_buffer_length,
+					     CIFSMaxBufSize);
 		}
 	} else if (qi.flags == PASSTHRU_QUERY_INFO) {
 		memset(&qi_iov, 0, sizeof(qi_iov));
fs/cifs/smbfsctl.h +27 -0
index f996daeea271..9b3459b9a5ce 100644
@@ -35,6 +35,33 @@
  * below). Additional detail on less common ones can be found in MS-FSCC
  * section 2.3.
  */
+
+/*
+ * FSCTL values are 32 bits and are constructed as
+ * <device 16bits> <access 2bits> <function 12bits> <method 2bits>
+ */
+/* Device */
+#define FSCTL_DEVICE_DFS                 (0x0006 << 16)
+#define FSCTL_DEVICE_FILE_SYSTEM         (0x0009 << 16)
+#define FSCTL_DEVICE_NAMED_PIPE          (0x0011 << 16)
+#define FSCTL_DEVICE_NETWORK_FILE_SYSTEM (0x0014 << 16)
+#define FSCTL_DEVICE_MASK                0xffff0000
+/* Access */
+#define FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS        (0x00 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS       (0x01 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS      (0x02 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS (0x03 << 14)
+#define FSCTL_DEVICE_ACCESS_MASK                   0x0000c000
+/* Function */
+#define FSCTL_DEVICE_FUNCTION_MASK       0x00003ffc
+/* Method */
+#define FSCTL_DEVICE_METHOD_BUFFERED   0x00
+#define FSCTL_DEVICE_METHOD_IN_DIRECT  0x01
+#define FSCTL_DEVICE_METHOD_OUT_DIRECT 0x02
+#define FSCTL_DEVICE_METHOD_NEITHER    0x03
+#define FSCTL_DEVICE_METHOD_MASK       0x00000003
+
+
 #define FSCTL_DFS_GET_REFERRALS      0x00060194
 #define FSCTL_DFS_GET_REFERRALS_EX   0x000601B0
 #define FSCTL_REQUEST_OPLOCK_LEVEL_1 0x00090000
Signature · 1 line
2.13.6
#2 lore raw

Re: [PATCH] cifs: Add support for FSCTL passthrough that write data to the server

tentatively merged into cifs-2.6.git for-next

Quoted 85 lines · Ronnie Sahlberg

Add support to pass a blob to the server in FSCTL passthrough.

---
 fs/cifs/smb2ops.c  | 17 +++++++++++++++--
 fs/cifs/smbfsctl.h | 27 +++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +15 -2
index 83a100dd2497..bb7522b882ea 100644
@@ -1382,6 +1382,18 @@ smb2_ioctl_query_info(const unsigned int xid,
        oparms.fid = &fid;
        oparms.reconnect = false;
 
+       /*
+        * FSCTL codes encode the special access they need in the fsctl code.
+        */
+       if (qi.flags & PASSTHRU_FSCTL) {
+               switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {
+               case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:
+                       oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
+                       ;
+                       break;
+               }
+       }
+
        rc = SMB2_open_init(tcon, &rqst[0], &oplock, &oparms, path);
        if (rc)
                goto iqinf_exit;
@@ -1399,8 +1411,9 @@ smb2_ioctl_query_info(const unsigned int xid,
 
                        rc = SMB2_ioctl_init(tcon, &rqst[1],
                                             COMPOUND_FID, COMPOUND_FID,
-                                            qi.info_type, true, NULL,
-                                            0, CIFSMaxBufSize);
+                                            qi.info_type, true, buffer,
+                                            qi.output_buffer_length,
+                                            CIFSMaxBufSize);
                }
        } else if (qi.flags == PASSTHRU_QUERY_INFO) {
                memset(&qi_iov, 0, sizeof(qi_iov));
fs/cifs/smbfsctl.h +27 -1
index f996daeea271..9b3459b9a5ce 100644
@@ -35,6 +35,33 @@
  * below). Additional detail on less common ones can be found in MS-FSCC
  * section 2.3.
  */
+
+/*
+ * FSCTL values are 32 bits and are constructed as
+ * <device 16bits> <access 2bits> <function 12bits> <method 2bits>
+ */
+/* Device */
+#define FSCTL_DEVICE_DFS                 (0x0006 << 16)
+#define FSCTL_DEVICE_FILE_SYSTEM         (0x0009 << 16)
+#define FSCTL_DEVICE_NAMED_PIPE          (0x0011 << 16)
+#define FSCTL_DEVICE_NETWORK_FILE_SYSTEM (0x0014 << 16)
+#define FSCTL_DEVICE_MASK                0xffff0000
+/* Access */
+#define FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS        (0x00 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS       (0x01 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS      (0x02 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS (0x03 << 14)
+#define FSCTL_DEVICE_ACCESS_MASK                   0x0000c000
+/* Function */
+#define FSCTL_DEVICE_FUNCTION_MASK       0x00003ffc
+/* Method */
+#define FSCTL_DEVICE_METHOD_BUFFERED   0x00
+#define FSCTL_DEVICE_METHOD_IN_DIRECT  0x01
+#define FSCTL_DEVICE_METHOD_OUT_DIRECT 0x02
+#define FSCTL_DEVICE_METHOD_NEITHER    0x03
+#define FSCTL_DEVICE_METHOD_MASK       0x00000003
+
+
 #define FSCTL_DFS_GET_REFERRALS      0x00060194
 #define FSCTL_DFS_GET_REFERRALS_EX   0x000601B0
 #define FSCTL_REQUEST_OPLOCK_LEVEL_1 0x00090000
--

2.13.6

Signature · 3 lines
Thanks,

Steve
#3 lore raw

Re: [PATCH] cifs: Add support for FSCTL passthrough that write data to the server

In reply to Ronnie Sahlberg

ср, 10 апр. 2019 г. в 19:21, Ronnie Sahlberg <[email protected]>:

Quoted 15 lines

Add support to pass a blob to the server in FSCTL passthrough.

---
 fs/cifs/smb2ops.c  | 17 +++++++++++++++--
 fs/cifs/smbfsctl.h | 27 +++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +0 -0
index 83a100dd2497..bb7522b882ea 100644
@@ -1382,6 +1382,18 @@ smb2_ioctl_query_info(const unsigned int xid,
        oparms.fid = &fid;

fs/cifs/smb2ops.c smb2_ioctl_query_info(const unsigned int xid, · line 1392

Quoted 10 lines
fs/cifs/smb2ops.c +8 -0
        oparms.reconnect = false;
 
+       /*
+        * FSCTL codes encode the special access they need in the fsctl code.
+        */
+       if (qi.flags & PASSTHRU_FSCTL) {
+               switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {
+               case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:
+                       oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
+                       ;

This extra ":" looks unnecessary. Don't we need to add cases for

+#define FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS        (0x00 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS       (0x01 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS      (0x02 << 14)

?

--
Best regards,
Pavel Shilovsky

#4 lore raw

Re: [PATCH] cifs: Add support for FSCTL passthrough that write data to the server

How about this small followon patch to address this?

Quoted 37 lines · Pavel Shilovsky

ср, 10 апр. 2019 г. в 19:21, Ronnie Sahlberg <[email protected]>:

Quoted 15 lines

Add support to pass a blob to the server in FSCTL passthrough.

---
 fs/cifs/smb2ops.c  | 17 +++++++++++++++--
 fs/cifs/smbfsctl.h | 27 +++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +0 -0
index 83a100dd2497..bb7522b882ea 100644
@@ -1382,6 +1382,18 @@ smb2_ioctl_query_info(const unsigned int xid,
        oparms.fid = &fid;

fs/cifs/smb2ops.c smb2_ioctl_query_info(const unsigned int xid, · line 1392

Quoted 10 lines
fs/cifs/smb2ops.c +8 -0
        oparms.reconnect = false;
 
+       /*
+        * FSCTL codes encode the special access they need in the fsctl code.
+        */
+       if (qi.flags & PASSTHRU_FSCTL) {
+               switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {
+               case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:
+                       oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
+                       ;

This extra ":" looks unnecessary. Don't we need to add cases for

(quoted diff) +3 -0
+#define FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS        (0x00 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS       (0x01 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS      (0x02 << 14)

?

--
Best regards,
Pavel Shilovsky

Signature · 3 lines
Thanks,

Steve

From 2f1490f506b583f1533e7165adc7f21eaa01df22 Mon Sep 17 00:00:00 2001
From: Steve French <[email protected]>
Date: Thu, 11 Apr 2019 13:53:17 -0500
Subject: [PATCH] SMB3: Add handling for different FSCTL access flags

DesiredAccess field in SMB3 open request needs
to be set differently for READ vs. WRITE ioctls
(not just ones that request both).

Originally noticed by Pavel

---
 fs/cifs/smb2ops.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
fs/cifs/smb2ops.c +9 -1
index ed8c2ba9590b..08ff044fbb4b 100644
@@ -1389,7 +1389,15 @@ smb2_ioctl_query_info(const unsigned int xid,
 		switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {
 		case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:
 			oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
-			;
+			break;
+		case FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS:
+			oparms.desired_access = GENERIC_ALL;
+			break;
+		case FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS:
+			oparms.desired_access = GENERIC_READ;
+			break;
+		case FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS:
+			oparms.desired_access = GENERIC_WRITE;
 			break;
 		}
 	}
Signature · 1 line
2.17.1
#5 lore raw

Re: [PATCH] cifs: Add support for FSCTL passthrough that write data to the server

Quoted 2 lines · Steve French

How about this small followon patch to address this?

Looks reasonable.

Reviewed-by me

Quoted 47 lines · Pavel Shilovsky
Quoted 34 lines

ср, 10 апр. 2019 г. в 19:21, Ronnie Sahlberg <[email protected]>:

Quoted 15 lines

Add support to pass a blob to the server in FSCTL passthrough.

---
 fs/cifs/smb2ops.c  | 17 +++++++++++++++--
 fs/cifs/smbfsctl.h | 27 +++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +0 -0
index 83a100dd2497..bb7522b882ea 100644
@@ -1382,6 +1382,18 @@ smb2_ioctl_query_info(const unsigned int xid,
        oparms.fid = &fid;

fs/cifs/smb2ops.c smb2_ioctl_query_info(const unsigned int xid, · line 1392

Quoted 10 lines
fs/cifs/smb2ops.c +8 -0
        oparms.reconnect = false;
 
+       /*
+        * FSCTL codes encode the special access they need in the fsctl code.
+        */
+       if (qi.flags & PASSTHRU_FSCTL) {
+               switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {
+               case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:
+                       oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
+                       ;

This extra ":" looks unnecessary. Don't we need to add cases for

(quoted diff) +3 -0
+#define FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS        (0x00 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS       (0x01 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS      (0x02 << 14)

?

Quoted 3 lines

--
Best regards,
Pavel Shilovsky

--
Thanks,

Steve

#6 lore raw

Re: [PATCH] cifs: Add support for FSCTL passthrough that write data to the server

In reply to Pavel Shilovsky
Quoted 32 lines · Pavel Shilovsky

ср, 10 апр. 2019 г. в 19:21, Ronnie Sahlberg <[email protected]>:

Quoted 15 lines

Add support to pass a blob to the server in FSCTL passthrough.

---
 fs/cifs/smb2ops.c  | 17 +++++++++++++++--
 fs/cifs/smbfsctl.h | 27 +++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +0 -0
index 83a100dd2497..bb7522b882ea 100644
@@ -1382,6 +1382,18 @@ smb2_ioctl_query_info(const unsigned int xid,
        oparms.fid = &fid;

fs/cifs/smb2ops.c smb2_ioctl_query_info(const unsigned int xid, · line 1392

Quoted 10 lines
fs/cifs/smb2ops.c +8 -0
        oparms.reconnect = false;
 
+       /*
+        * FSCTL codes encode the special access they need in the fsctl code.
+        */
+       if (qi.flags & PASSTHRU_FSCTL) {
+               switch (qi.info_type & FSCTL_DEVICE_ACCESS_MASK) {
+               case FSCTL_DEVICE_ACCESS_FILE_READ_WRITE_ACCESS:
+                       oparms.desired_access = FILE_READ_DATA | FILE_WRITE_DATA | FILE_READ_ATTRIBUTES | SYNCHRONIZE;
+                       ;

This extra ":" looks unnecessary. Don't we need to add cases for

fs/cifs/smbfsctl.h +3 -0
+#define FSCTL_DEVICE_ACCESS_FILE_ANY_ACCESS        (0x00 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_READ_ACCESS       (0x01 << 14)
+#define FSCTL_DEVICE_ACCESS_FILE_WRITE_ACCESS      (0x02 << 14)
Quoted 1 line

?

Thanks, yeah that ';' should go.
We should add cases for the other three DEVICE_ACCESS cases but i don't know yet how these are mapped on windows. READ_WRITE was based on what win16 used as desired_access for this.

We can add the others later when we start adding other fsctl types when we compare to what windows uses.

Quoted 4 lines

--
Best regards,
Pavel Shilovsky