kms_content_protection: Disable authentication when failed
PATCH 1/1 kms_content_protection: Disable authentication when failed
When content protection authentication is failed in kernel after all requried retries, before declaring the test failure, set the content protection to UNDESIRED state.
This will avoid the HDCP authentication attempts in subsequent modesets from other tests.
--- tests/kms_content_protection.c | 4 ++++ 1 file changed, 4 insertions(+)
tests/kms_content_protection.c +4 -0
@@ -212,6 +212,10 @@ static void test_cp_enable_with_retry(igt_output_t *output,if (!ret && --retry)igt_debug ("Retry (%d/2) ...\n" ,3 - retry); }while (retry && !ret); + +if (!ret) +test_cp_disable (output, s); +igt_assert_f (ret,"Content Protection not enabled\n" ); }
Signature · 6 lines
2.19.1 _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.BAT: success for kms_content_protection: Disable authentication when failed
== Series Details ==
== Series Details ==
Series: kms_content_protection: Disable authentication when failed
URL : https://patchwork.freedesktop.org/series/59338/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5909 -> IGTPW_2845
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59338/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2845 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-7500u: PASS -> DMESG-WARN [fdo#105128] / [fdo#107139]
* igt@i915_selftest@live_hangcheck:
- fi-skl-iommu: PASS -> INCOMPLETE [fdo#108602] / [fdo#108744]
* igt@runner@aborted:
- fi-skl-iommu: NOTRUN -> FAIL [fdo#104108] / [fdo#108602]
#### Possible fixes ####
* igt@i915_selftest@live_hangcheck:
- fi-bxt-dsi: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] -> PASS
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105128]: https://bugs.freedesktop.org/show_bug.cgi?id=105128
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#108602]: https://bugs.freedesktop.org/show_bug.cgi?id=108602
[fdo#108744]: https://bugs.freedesktop.org/show_bug.cgi?id=108744
Participating hosts (49 -> 45)
------------------------------
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* IGT: IGT_4943 -> IGTPW_2845
CI_DRM_5909: af07fbb536d0728e381cc001cac5bc259c41fe02 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2845: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2845/
IGT_4943: 5941f371b0fe25084d4b1c49882faa8d41d44c9f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2845/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Patchwork
CI[igt-dev] ✓ Fi.CI.IGT: success for kms_content_protection: Disable authentication when failed
In reply to Ramalingam C== Series Details ==
== Series Details ==
Series: kms_content_protection: Disable authentication when failed
URL : https://patchwork.freedesktop.org/series/59338/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5909_full -> IGTPW_2845_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2845_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in IGTPW_2845_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/59338/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2845_full:
### IGT changes ###
#### Warnings ####
* igt@gem_set_tiling_vs_pwrite:
- shard-iclb: PASS -> ( 2 PASS ) +56
Known issues
------------
Here are the changes found in IGTPW_2845_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_bad_reloc@negative-reloc-bsd2:
- shard-iclb: NOTRUN -> SKIP [fdo#109276] +12
* igt@gem_eio@in-flight-suspend:
- shard-kbl: PASS -> DMESG-WARN [fdo#108566] +3
* igt@gem_mocs_settings@mocs-reset-dirty-render:
- shard-iclb: NOTRUN -> SKIP [fdo#110206]
* igt@gem_pread@pagefault-pread:
- shard-iclb: NOTRUN -> SKIP [fdo#109277] +1
* igt@gem_pwrite@huge-cpu-backwards:
- shard-iclb: NOTRUN -> SKIP [fdo#109290]
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP [fdo#109271]
* igt@i915_pm_rpm@i2c:
- shard-iclb: NOTRUN -> DMESG-WARN [fdo#109982]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: NOTRUN -> SKIP [fdo#109308]
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: NOTRUN -> SKIP [fdo#109271] +25
* igt@i915_suspend@debugfs-reader:
- shard-apl: PASS -> DMESG-WARN [fdo#108566] +6
* igt@kms_atomic_transition@6x-modeset-transitions-nonblocking-fencing:
- shard-iclb: NOTRUN -> SKIP [fdo#109278] +3
- shard-glk: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-iclb: NOTRUN -> FAIL [fdo#106641]
* igt@kms_busy@basic-modeset-f:
- shard-apl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +1
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-iclb: NOTRUN -> SKIP [fdo#109284] +1
* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> FAIL [fdo#110321] / [fdo#110336]
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-snb: PASS -> DMESG-WARN [fdo#102365]
* igt@kms_cursor_crc@cursor-512x170-random:
- shard-iclb: NOTRUN -> SKIP [fdo#109279]
* igt@kms_cursor_crc@cursor-64x21-random:
- shard-apl: PASS -> FAIL [fdo#103232]
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-iclb: NOTRUN -> SKIP [fdo#109274] +2
* igt@kms_flip@2x-flip-vs-modeset-vs-hang-interruptible:
- shard-iclb: NOTRUN -> ( 2 SKIP ) [fdo#109274]
* igt@kms_force_connector_basic@force-load-detect:
- shard-iclb: NOTRUN -> SKIP [fdo#109285]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
- shard-iclb: NOTRUN -> SKIP [fdo#109280] +16
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#103167] +3
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-iclb: NOTRUN -> FAIL [fdo#109247] +1
* igt@kms_frontbuffer_tracking@fbcpsr-farfromfence:
- shard-glk: NOTRUN -> SKIP [fdo#109271] +13
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: PASS -> FAIL [fdo#109247] +8
* igt@kms_invalid_dotclock:
- shard-iclb: NOTRUN -> ( 2 SKIP ) [fdo#109310]
* igt@kms_lease@setcrtc_implicit_plane:
- shard-kbl: NOTRUN -> FAIL [fdo#110281]
* igt@kms_pipe_crc_basic@read-crc-pipe-d:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] / [fdo#109278] +6
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: PASS -> FAIL [fdo#103375]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> FAIL [fdo#108145]
* igt@kms_plane_scaling@pipe-a-scaler-with-pixel-format:
- shard-glk: PASS -> SKIP [fdo#109271] / [fdo#109278]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: PASS -> SKIP [fdo#109642]
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: PASS -> SKIP [fdo#109441] +1
* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: NOTRUN -> SKIP [fdo#109441] +1
* igt@perf@unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> SKIP [fdo#109289] +2
* igt@prime_nv_api@i915_nv_double_export:
- shard-iclb: NOTRUN -> SKIP [fdo#109291]
* igt@prime_nv_pcopy@test3_4:
- shard-kbl: NOTRUN -> SKIP [fdo#109271] +36
#### Possible fixes ####
* igt@i915_pm_rpm@fences:
- shard-iclb: INCOMPLETE [fdo#107713] / [fdo#108840] -> PASS
* igt@kms_busy@extended-modeset-hang-oldfb-render-c:
- shard-apl: INCOMPLETE [fdo#103927] -> PASS
* igt@kms_flip@dpms-vs-vblank-race:
- shard-apl: FAIL [fdo#103060] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_flip_tiling@flip-x-tiled:
- shard-iclb: FAIL [fdo#108303] -> PASS
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: FAIL [fdo#103167] -> PASS +6
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-iclb: FAIL [fdo#109247] -> PASS +10
* igt@kms_psr@cursor_blt:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> ( 2 PASS )
* igt@kms_psr@cursor_mmap_gtt:
- shard-iclb: FAIL [fdo#107383] / [fdo#110215] -> PASS +2
* igt@kms_psr@no_drrs:
- shard-iclb: FAIL [fdo#108341] -> PASS
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- shard-glk: FAIL [fdo#110037] -> PASS
- shard-apl: FAIL [fdo#110037] -> PASS
- shard-kbl: FAIL [fdo#110037] -> PASS * igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-apl: DMESG-WARN [fdo#108566] -> PASS +5
#### Warnings ####
* igt@gem_exec_parallel@bsd2-fds:
- shard-iclb: SKIP [fdo#109276] -> ( 2 SKIP ) [fdo#109276] +4
* igt@gem_exec_params@rsvd2-dirt:
- shard-iclb: SKIP [fdo#109283] -> ( 2 SKIP ) [fdo#109283]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: SKIP [fdo#109506] -> ( 2 SKIP ) [fdo#109506]
* igt@kms_chamelium@hdmi-cmp-nv21:
- shard-iclb: SKIP [fdo#109284] -> ( 2 SKIP ) [fdo#109284] +1
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic:
- shard-iclb: SKIP [fdo#109274] -> ( 2 SKIP ) [fdo#109274]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-draw-mmap-wc:
- shard-iclb: SKIP [fdo#109280] -> ( 2 SKIP ) [fdo#109280] +3
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: SKIP [fdo#109441] -> ( 2 SKIP ) [fdo#109441]
* igt@kms_universal_plane@cursor-fb-leak-pipe-e:
- shard-iclb: SKIP [fdo#109278] -> ( 2 SKIP ) [fdo#109278] +1
* igt@prime_nv_api@i915_self_import_to_different_fd:
- shard-iclb: SKIP [fdo#109291] -> ( 2 SKIP ) [fdo#109291]
[fdo#102365]: https://bugs.freedesktop.org/show_bug.cgi?id=102365
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107383]: https://bugs.freedesktop.org/show_bug.cgi?id=107383
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109247]: https://bugs.freedesktop.org/show_bug.cgi?id=109247
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109277]: https://bugs.freedesktop.org/show_bug.cgi?id=109277
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109290]: https://bugs.freedesktop.org/show_bug.cgi?id=109290
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109310]: https://bugs.freedesktop.org/show_bug.cgi?id=109310
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#109982]: https://bugs.freedesktop.org/show_bug.cgi?id=109982
[fdo#110037]: https://bugs.freedesktop.org/show_bug.cgi?id=110037
[fdo#110206]: https://bugs.freedesktop.org/show_bug.cgi?id=110206
[fdo#110215]: https://bugs.freedesktop.org/show_bug.cgi?id=110215
[fdo#110281]: https://bugs.freedesktop.org/show_bug.cgi?id=110281
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[fdo#110336]: https://bugs.freedesktop.org/show_bug.cgi?id=110336
Participating hosts (10 -> 6)
------------------------------
Missing (4): pig-skl-6260u shard-skl pig-hsw-4770r pig-glk-j5005
Build changes
-------------
* IGT: IGT_4943 -> IGTPW_2845
* Piglit: piglit_4509 -> None
CI_DRM_5909: af07fbb536d0728e381cc001cac5bc259c41fe02 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2845: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2845/
IGT_4943: 5941f371b0fe25084d4b1c49882faa8d41d44c9f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2845/
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 8 lines · Ramalingam C
When content protection authentication is failed in kernel after all requried retries, before declaring the test failure, set the content protection to UNDESIRED state.
This will avoid the HDCP authentication attempts in subsequent modesets from other tests.
Signed-off-by Ramalingam C <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110376
Quoted 10 lines
--- tests/kms_content_protection.c | 4 ++++ 1 file changed, 4 insertions(+)tests/kms_content_protection.c +0
-0
tests/kms_content_protection.c static void test_cp_enable_with_retry(igt_output_t *output, · line 221
Quoted 10 lines
tests/kms_content_protection.c +4
-0@@ -212,6 +212,10 @@ static void test_cp_enable_with_retry(igt_output_t *output,if (!ret && --retry)igt_debug ("Retry (%d/2) ...\n" ,3 - retry); }while (retry && !ret); + +if (!ret) +test_cp_disable (output, s); +igt_assert_f (ret,"Content Protection not enabled\n" ); }
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Daniel Vetter
Reviewed-byQuoted 11 lines · Martin Peres
Quoted 8 lines · Ramalingam C
When content protection authentication is failed in kernel after all requried retries, before declaring the test failure, set the content protection to UNDESIRED state.
This will avoid the HDCP authentication attempts in subsequent modesets from other tests.
Signed-off-by Ramalingam C <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110376
exit handler would be another option, but they're also not without issues.
Quoted 24 lines
Quoted 10 lines
--- tests/kms_content_protection.c | 4 ++++ 1 file changed, 4 insertions(+)tests/kms_content_protection.c +0
-0tests/kms_content_protection.c static void test_cp_enable_with_retry(igt_output_t *output, · line 221
Quoted 10 lines
tests/kms_content_protection.c +4
-0@@ -212,6 +212,10 @@ static void test_cp_enable_with_retry(igt_output_t *output,if (!ret && --retry)igt_debug ("Retry (%d/2) ...\n" ,3 - retry); }while (retry && !ret); + +if (!ret) +test_cp_disable (output, s); +igt_assert_f (ret,"Content Protection not enabled\n" ); }_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ igt-dev mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/igt-dev
Quoted 9 lines · Daniel Vetter
Quoted 8 lines · Martin Peres
Quoted 7 lines · Ramalingam C
When content protection authentication is failed in kernel after all requried retries, before declaring the test failure, set the content protection to UNDESIRED state.
This will avoid the HDCP authentication attempts in subsequent modesets from other tests.
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Ramalingam C <[email protected]>Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110376
exit handler would be another option, but they're also not without issues.
Reviewed-by Daniel Vetter <[email protected]>
Martin and Daniel,
Thanks for the review. Change is merged in upstream.
-Ram
Quoted 17 lines
Quoted 17 lines
Quoted 17 lines
--- tests/kms_content_protection.c | 4 ++++ 1 file changed, 4 insertions(+)tests/kms_content_protection.c +4
-0@@ -212,6 +212,10 @@ static void test_cp_enable_with_retry(igt_output_t *output,if (!ret && --retry)igt_debug ("Retry (%d/2) ...\n" ,3 - retry); }while (retry && !ret); + +if (!ret) +test_cp_disable (output, s); +
Quoted 13 lines
Quoted 8 lines
tests/kms_content_protection.c static void test_cp_enable_with_retry(igt_output_t *output, · line 221
Quoted 4 lines
tests/kms_content_protection.c +0
-0igt_assert_f (ret,"Content Protection not enabled\n" ); }_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-devSignature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev