efi_loader: enable HII protocols by default
PATCH 1/1 efi_loader: enable HII protocols by default
As the UEFI shell requires the HII protocols let's enable them by default.
--- lib/efi_loader/Kconfig | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)
lib/efi_loader/Kconfig +2 -5
@@ -38,14 +38,11 @@ config EFI_LOADER_BOUNCE_BUFFER config EFI_LOADER_HII bool "Expose HII protocols to EFI applications" depends on EFI_LOADER - default n + default y help The Human Interface Infrastructure is a complicated framework that allows UEFI applications to draw fancy menus and hook strings using a translation framework. U-Boot implements enough of its features to be able to run the UEFI - Shell, but not more than that. The code is experimental still, so - beware that your system might break with HII enabled. - - If unsure, say n. + Shell, but not more than that.
--
2.20.1
PATCH 1/1 efi_loader: enable HII protocols by default
Quoted 1 line · Heinrich Schuchardt
As the UEFI shell requires the HII protocols let's enable them by default.
Is there still any reason that we have this config option at all?
Quoted 13 lines
Signed-off-by Heinrich Schuchardt <[email protected]>--- lib/efi_loader/Kconfig | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)lib/efi_loader/Kconfig +0
-0@@ -38,14 +38,11 @@ config EFI_LOADER_BOUNCE_BUFFER config EFI_LOADER_HII bool "Expose HII protocols to EFI applications" depends on EFI_LOADER
lib/efi_loader/Kconfig config EFI_LOADER_BOUNCE_BUFFER · line 49
Quoted 10 lines
lib/efi_loader/Kconfig +1
-3- default n + default y help The Human Interface Infrastructure is a complicated framework that allows UEFI applications to draw fancy menus and hook strings using a translation framework. U-Boot implements enough of its features to be able to run the UEFI - Shell, but not more than that. The code is experimental still, so - beware that your system might break with HII enabled.
I don't think it's experimental, but just not fully implemented in terms of UEFI specification. This is also true for other UEFI features on U-Boot.
Since a some kind of bug regarding HII was reported, I haven't seen any bug fix relating to that. (I doubt it was a bug.)
-Takahiro Akashi
Quoted 5 lines
lib/efi_loader/Kconfig +1
-2- If unsure, say n. + Shell, but not more than that. --2.20.1
PATCH 1/1 efi_loader: enable HII protocols by default
Quoted 4 lines · AKASHI Takahiro
Quoted 1 line · Heinrich Schuchardt
As the UEFI shell requires the HII protocols let's enable them by default.
Is there still any reason that we have this config option at all?
I have been thinking about the same when writing the patch. I suggest to remove the config option in v2019.10 if no errors are found in the v2019.07 cycle.
Quoted 21 lines
Quoted 21 lines
Signed-off-by Heinrich Schuchardt <[email protected]>--- lib/efi_loader/Kconfig | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-)lib/efi_loader/Kconfig +1
-1@@ -38,14 +38,11 @@ config EFI_LOADER_BOUNCE_BUFFER config EFI_LOADER_HII bool "Expose HII protocols to EFI applications" depends on EFI_LOADER - default n + default y help The Human Interface Infrastructure is a complicated framework that allows UEFI applications to draw fancy menus and hook strings using a translation framework.
Quoted 7 lines
lib/efi_loader/Kconfig config EFI_LOADER_BOUNCE_BUFFER · line 49
Quoted 3 lines
lib/efi_loader/Kconfig +0
-2U-Boot implements enough of its features to be able to run the UEFI - Shell, but not more than that. The code is experimental still, so - beware that your system might break with HII enabled.I don't think it's experimental, but just not fully implemented in terms of UEFI specification. This is also true for other UEFI features on U-Boot.
That is exactly why I removed those lines.
Best regards
Heinrich
Quoted 11 lines
Since a some kind of bug regarding HII was reported, I haven't seen any bug fix relating to that. (I doubt it was a bug.)
-Takahiro Akashi
Quoted 5 lines
lib/efi_loader/Kconfig +1
-2- If unsure, say n. + Shell, but not more than that. --2.20.1