iommu/vt-d: Flush IOTLB for untrusted device in time
PATCH 1/1 iommu/vt-d: Flush IOTLB for untrusted device in time
By default, for performance consideration, Intel IOMMU driver won't flush IOTLB immediately after a buffer is unmapped. It schedules a thread and flushes IOTLB in a batched mode. This isn't suitable for untrusted device since it still can access the memory even if it isn't supposed to do so.
Cc Ashok Raj <[email protected]>
Cc Jacob Pan <[email protected]>
Signed-off-by Lu Baolu <[email protected]>
Tested-by Xu Pengfei <[email protected]>
Tested-by Mika Westerberg <[email protected]>
--- drivers/iommu/intel-iommu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/iommu/intel-iommu.c +5 -1
@@ -3732,10 +3732,14 @@ static void intel_unmap(struct device *dev, dma_addr_t dev_addr, size_t size)unsigned long iova_pfn;struct intel_iommu *iommu;struct page *freelist; +struct pci_dev *pdev =NULL ;if (iommu_no_mapping (dev))return ; +if (dev_is_pci (dev)) + pdev =to_pci_dev (dev); + domain =find_domain (dev);BUG_ON (!domain);
@@ -3751,7 +3755,7 @@ static void intel_unmap(struct device *dev, dma_addr_t dev_addr, size_t size) freelist =domain_unmap (domain, start_pfn, last_pfn); -if (intel_iommu_strict) { +if (intel_iommu_strict || (pdev && pdev->untrusted)) {iommu_flush_iotlb_psi (iommu, domain, start_pfn, nrpages, !freelist,0 );/* free iova */
Signature · 1 line
2.17.1
Quoted 2 lines · Lu Baolu
drivers/iommu/intel-iommu.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Applied, thanks.